On Wed, Jul 25 2018, Sergio Paracuellos wrote:
> On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote:
>> On Mon, Jul 16 2018, Sergio Paracuellos wrote:
>>
>> > This patch series include an attempt to avoid the use of custom
>> > read and writes in driver code and use PCI subsystem common
Remove multiple blank lines, raise a checkpatch issue. This is purely
a coding style change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 3 ---
1 file changed, 3 deletions(-)
diff --git
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style
change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
This series of patches contain purely simple coding style changes.
I considered renaming the struct cmpk_set_cfg_t as it is never actually
used. Following its definition however it is used in a #define:
#define cmpk_query_cfg_tcmpk_set_cfg_t
So whilst the struct cmpk_set_cfg_t
Rename the bit definition ISR_TxBcnOk to ISR_TX_BCN_OK. This change
clears the checkpatch issue with CamelCase naming. The change is a
coding style change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
Rename the bit definition ISR_TxBcnErr to ISR_TX_BCN_ERR. This change
clears the checkpatch issue with CamelCase naming. The change is purely
a coding style change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
Rename the bit definition ISR_BcnTimerIntr to ISR_BCN_TIMER_INTR. This
change clears the checkpatch issue with CamelCase naming. The change is
purely a style change and should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
Correct the spelling of a number of comments, which caused a checkpatch
issue. This is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++--
1 file changed, 2 insertions(+), 2
Remove the typedef from struct cmpk_set_cfg_t. This change clears the
checkpatch issue with defining new types. The change is purely a coding
style change which should have no impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a
coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git
Remove the typedef of the structure cmpk_txfb_t. This clears the
checkpatch issue with defining new types. This change is purely
a coding style change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8
Remove the typedef of struct cmpk_intr_sta_t. This clears the checkpatch
issue with creating new types in code. The change is purely a coding
style change and should have no impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 6 +++---
> From: Vitaly Kuznetsov
> While you do for_each_present_cpu() in netvsc_get_ethtool_stats(),
> netvsc_get_pcpu_stats() does for_each_possible_cpu(). This looks
> inconsistent.
I made a mistake there. Thanks for catch me.
> The allocation you're doing here is short-lived so I would suggest
On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote:
> On Mon, Jul 16 2018, Sergio Paracuellos wrote:
>
> > This patch series include an attempt to avoid the use of custom
> > read and writes in driver code and use PCI subsystem common ones.
> >
> > In order to do this 'map_bus' callback is
On 07/23/18 at 04:34pm, Michal Hocko wrote:
> On Thu 19-07-18 23:17:53, Baoquan He wrote:
> > Kexec has been a formal feature in our distro, and customers owning
> > those kind of very large machine can make use of this feature to speed
> > up the reboot process. On uefi machine, the kexec_file
On Tue, 2018-07-24 at 09:49 -0700, Kees Cook wrote:
> In preparing to remove all stack VLA usage from the kernel[1], this
> removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of
> the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash
> to direct shash. By removing a
On Wed, Jul 25, 2018 at 01:22:07AM +0300, Georgios Tsotsos wrote:
> Date: Wed, 25 Jul 2018 01:18:58 +0300
> Subject: [PATCH 0/4] Staging: octeon-usb: Fixes and Coding style applied.
>
> Hello,
Somehow your subject here got messed up and put in the bod of the email.
Not a big deal this time,
On Wed, Jul 25, 2018 at 01:22:12AM +0300, Georgios Tsotsos wrote:
> Signed-off-by: Georgios Tsotsos
> ---
> drivers/staging/octeon-usb/octeon-hcd.h | 1 +
> 1 file changed, 1 insertion(+)
Two different 4/4 patches in the same series? How did you create these?
greg k-h
On Wed, Jul 25, 2018 at 01:22:11AM +0300, Georgios Tsotsos wrote:
> Signed-off-by: Georgios Tsotsos
> ---
I can not take patches without any changelog text, sorry :(
___
devel mailing list
de...@linuxdriverproject.org
On Wed, Jul 25, 2018 at 01:22:08AM +0300, Georgios Tsotsos wrote:
> Signed-off-by: Georgios Tsotsos
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 1 +
> 1 file changed, 1 insertion(+)
Again, no changelog :(
Please fix this series up and resend.
thanks,
greg k-h
On Wed, Jul 25, 2018 at 08:21:35AM +1000, NeilBrown wrote:
> On Mon, Jul 16 2018, Sergio Paracuellos wrote:
>
> > This patch series include an attempt to avoid the use of custom
> > read and writes in driver code and use PCI subsystem common ones.
> >
> > In order to do this 'map_bus' callback is
On Wed, Jul 25, 2018 at 01:38:49AM +0300, Georgios Tsotsos wrote:
> Hello,
>
> Previously patches were sent with wrong cover format, please ignore.
>
> I am sending four patches which trying to resolve TODO list requirements
> no 45 about octeon-usb.
> There are SPDX licence additions on c
On Tue, Jul 24, 2018 at 02:53:33PM +0200, Sergio Paracuellos wrote:
> On Tue, Jul 24, 2018 at 01:58:25PM +0200, Greg KH wrote:
> > On Mon, Jul 16, 2018 at 07:32:32PM +0200, Sergio Paracuellos wrote:
> > > This commit adds device tree bindings documentation for PCIEE controller
> > > of MT7621 SoC.
On Wed, Jul 25, 2018 at 10:02:36AM +0200, Greg KH wrote:
> On Tue, Jul 24, 2018 at 02:53:33PM +0200, Sergio Paracuellos wrote:
> > On Tue, Jul 24, 2018 at 01:58:25PM +0200, Greg KH wrote:
> > > On Mon, Jul 16, 2018 at 07:32:32PM +0200, Sergio Paracuellos wrote:
> > > > This commit adds device tree
Johannes Berg writes:
> On Tue, 2018-07-24 at 09:49 -0700, Kees Cook wrote:
>> In preparing to remove all stack VLA usage from the kernel[1], this
>> removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of
>> the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash
>> to
This adds a device-tree binding document that specifies the properties
used by the Cedurs VPU driver, as well as examples.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/cedrus.txt | 54 +++
1 file changed, 54 insertions(+)
This adds nodes for the Video Engine and the associated reserved memory
for sun5i-based platforms. Up to 96 MiB of memory are dedicated to the
CMA pool.
The VPU can only map the first 256 MiB of DRAM, so the reserved memory
pool has to be located in that area. Following Allwinner's decision in
This introduces support for Allwinner's MB32-tiled NV12 format, where
each plane is divided into macroblocks of 32x32 pixels. Hence, the size
of each plane has to be aligned to 32 bytes. The pixels inside each
macroblock are coded as they would be if the macroblock was a single
plane, line after
Stateless video decoding engines require both the MPEG slices and
associated metadata from the video stream in order to decode frames.
This introduces definitions for a new pixel format, describing buffers
with MPEG2 slice data, as well as a control structure for passing the
frame metadata to
This is the sixth iteration of the updated Cedrus driver,
that supports the Video Engine found in most Allwinner SoCs, starting
with the A10. It was tested on the A13, A20, A33 and H3.
The initial version of this driver[0] was originally written and
submitted by Florent Revest using a previous
This adds nodes for the Video Engine and the associated reserved memory
for the H3. Up to 96 MiB of memory are dedicated to the CMA pool.
Signed-off-by: Paul Kocialkowski
---
arch/arm/boot/dts/sun8i-h3.dtsi | 25 +
1 file changed, 25 insertions(+)
diff --git
This adds nodes for the Video Engine and the associated reserved memory
for the A20. Up to 96 MiB of memory are dedicated to the CMA pool.
The VPU can only map the first 256 MiB of DRAM, so the reserved memory
pool has to be located in that area. Following Allwinner's decision in
downstream
This introduces the Cedrus VPU driver that supports the VPU found in
Allwinner SoCs, also known as Video Engine. It is implemented through
a v4l2 m2m decoder device and a media device (used for media requests).
So far, it only supports MPEG2 decoding.
Since this VPU is stateless, synchronization
This adds nodes for the Video Engine and the associated reserved memory
for the A33. Up to 96 MiB of memory are dedicated to the CMA pool.
The VPU can only map the first 256 MiB of DRAM, so the reserved memory
pool has to be located in that area. Following Allwinner's decision in
downstream
On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to
> shash directly and allocating the descriptor in heap memory (which should
> be fine: the tfm has
Error message was referencing wrong function, fix it.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index
On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki wrote:
> On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote:
>> In the quest to remove all stack VLA usage from the kernel[1], this
>> removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to
>> shash directly and allocating the
Apply a coding style change suggested by checkpatch and correct a
comment.
Tim Collier (2):
staging: wlan-ng: remove volatile from reapable field in
hfa384x_usbctlx
staging: wlan-ng: correction to comment in hfa384x_usb
drivers/staging/wlan-ng/hfa384x.h | 2 +-
The comment for hfa384x_docmd incorrectly states that usercb_data
should be NULL for DOASYNC calls; in fact, it should be NULL for
DOWAIT calls (this is consistent with the other similar functions and
the rest of the comment text).
Signed-off-by: Tim Collier
---
Fix checkpatch.pl warning:
"Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rs"
reapable is not used to access h/w directly, so volatile is not
necessary.
>From reading the code, the contexts in which the field may be
updated/accessed across threads are
The function CAM_empty_entry() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 -
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 6 deletions(-)
diff --git
The function rtw_get_oper_choffset() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 -
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 6 deletions(-)
diff --git
The function rtw_get_oper_bw() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 -
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 6 deletions(-)
diff --git
The function ODM_RASupport_Init() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c | 10 --
.../staging/rtl8188eu/include/hal8188e_rate_adaptive.h | 2 --
2 files changed, 12 deletions(-)
44 matches
Mail list logo
