[PATCH] staging: rtl8712: remove unused array iw_operation_mode

2018-08-09 Thread Colin King
From: Colin Ian King Array iw_operation_mode is defined but is never used hence it is redundant and can be removed. This array has been like this since the driver was added back in 2010 Cleans up clang warning: warning: 'iw_operation_mode' defined but not used [-Wunused-const-variable=]

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Dan Carpenter
On Thu, Aug 09, 2018 at 12:13:06PM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > >

[PATCH] staging: gasket: apex: remove unused array cm_mappable_regions

2018-08-09 Thread Colin King
From: Colin Ian King Array cm_mappable_regions is defined but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: 'cm_mappable_regions' defined but not used [-Wunused-const-variable=] Signed-off-by: Colin Ian King --- drivers/staging/gasket/apex_driver.c

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Dan Carpenter
On Thu, Aug 09, 2018 at 01:08:38PM +0300, Dan Carpenter wrote: > On Thu, Aug 09, 2018 at 12:13:06PM +0530, Ajay Singh wrote: > > wilc_dir = debugfs_create_dir("wilc_wifi", NULL); > > - for (i = 0; i < ARRAY_SIZE(debugfs_info); i++) { > > - info = _info[i]; > > -

[PATCH v7 3/8] dt-bindings: media: Document bindings for the Cedrus VPU driver

2018-08-09 Thread Paul Kocialkowski
This adds a device-tree binding document that specifies the properties used by the Cedurs VPU driver, as well as examples. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../devicetree/bindings/media/cedrus.txt | 54 +++ 1 file changed, 54 insertions(+)

[PATCH v7 8/8] ARM: dts: sun8i-h3: Add Video Engine and reserved memory nodes

2018-08-09 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for the H3. Up to 96 MiB of memory are dedicated to the CMA pool. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-h3.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v7 5/8] ARM: dts: sun5i: Add Video Engine and reserved memory nodes

2018-08-09 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for sun5i-based platforms. Up to 96 MiB of memory are dedicated to the CMA pool. The VPU can only map the first 256 MiB of DRAM, so the reserved memory pool has to be located in that area. Following Allwinner's decision in

[PATCH v7 7/8] ARM: dts: sun8i-a33: Add Video Engine and reserved memory nodes

2018-08-09 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for the A33. Up to 96 MiB of memory are dedicated to the CMA pool. The VPU can only map the first 256 MiB of DRAM, so the reserved memory pool has to be located in that area. Following Allwinner's decision in downstream

[PATCH v7 0/8] Cedrus driver for the Allwinner Video Engine, using media requests

2018-08-09 Thread Paul Kocialkowski
This is the seventh iteration of the updated Cedrus driver, that supports the Video Engine found on most Allwinner SoCs, starting with the A10. It was tested on the A13, A20, A33 and H3. The initial version of this driver[0] was originally written and submitted by Florent Revest using a previous

Re: [PATCH v2 01/15] staging:rtl8192u: Remove macro eqMacAddr - Style

2018-08-09 Thread John Whitmore
On Wed, Aug 08, 2018 at 03:14:19PM -0700, Joe Perches wrote: > On Wed, 2018-08-08 at 22:00 +0100, John Whitmore wrote: > > The macro eqMacAddr implements the same functionality as the > > ether_addr_equal function defined in etherdevice.h, as a result the > > macro has been removed from the code,

[PATCH v7 6/8] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-08-09 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for the A20. Up to 96 MiB of memory are dedicated to the CMA pool. The VPU can only map the first 256 MiB of DRAM, so the reserved memory pool has to be located in that area. Following Allwinner's decision in downstream

[PATCH v7 1/8] media: v4l: Add definitions for MPEG2 slice format and metadata

2018-08-09 Thread Paul Kocialkowski
Stateless video decoding engines require both the MPEG slices and associated metadata from the video stream in order to decode frames. This introduces definitions for a new pixel format, describing buffers with MPEG2 slice data, as well as a control structure for passing the frame metadata to

[PATCH v7 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-09 Thread Paul Kocialkowski
This introduces the Cedrus VPU driver that supports the VPU found in Allwinner SoCs, also known as Video Engine. It is implemented through a v4l2 m2m decoder device and a media device (used for media requests). So far, it only supports MPEG2 decoding. Since this VPU is stateless, synchronization

[PATCH v7 2/8] media: v4l: Add definition for the Sunxi tiled NV12 format

2018-08-09 Thread Paul Kocialkowski
This introduces support for the Sunxi tiled NV12 format, where each component of the YUV frame is divided into macroblocks. Hence, the size of each plane requires specific alignment. The pixels inside each macroblock are coded in linear order (line after line from top to bottom). This tiled NV12

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Ajay Singh
Hi Dan, On Thu, 9 Aug 2018 13:08:38 +0300 Dan Carpenter wrote: > On Thu, Aug 09, 2018 at 12:13:06PM +0530, Ajay Singh wrote: > > wilc_debug.o object file is included for both SDIO and SPI module. > > When anyone(either SDIO or SPI) module is compiled as loaded module > > and another as buildin

[PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Ajay Singh
wilc_debug.o object file is included for both SDIO and SPI module. When anyone(either SDIO or SPI) module is compiled as loaded module and another as buildin module then below compilation error occurs. "drivers/staging/wilc1000/wilc_debugfs.o:(.data+0x10): undefined reference to `__this_module'"

Re: [PATCH v2] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Greg KH
On Thu, Aug 09, 2018 at 04:59:39PM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > >

[PATCH v2] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Ajay Singh
wilc_debug.o object file is included for both SDIO and SPI module. When anyone(either SDIO or SPI) module is compiled as loaded module and another as buildin module then below compilation error occurs. "drivers/staging/wilc1000/wilc_debugfs.o:(.data+0x10): undefined reference to `__this_module'"

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Greg KH
On Thu, Aug 09, 2018 at 01:43:58PM +0300, Dan Carpenter wrote: > On Thu, Aug 09, 2018 at 01:08:38PM +0300, Dan Carpenter wrote: > > On Thu, Aug 09, 2018 at 12:13:06PM +0530, Ajay Singh wrote: > > > wilc_dir = debugfs_create_dir("wilc_wifi", NULL); > > > - for (i = 0; i <

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Ajay Singh
On Thu, 9 Aug 2018 13:43:58 +0300 Dan Carpenter wrote: > On Thu, Aug 09, 2018 at 01:08:38PM +0300, Dan Carpenter wrote: > > On Thu, Aug 09, 2018 at 12:13:06PM +0530, Ajay Singh wrote: > > > wilc_dir = debugfs_create_dir("wilc_wifi", NULL); > > > - for (i = 0; i < ARRAY_SIZE(debugfs_info);

Re: [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

2018-08-09 Thread Stefan Wahren
> Greg Gallagher hat am 8. August 2018 um 03:40 > geschrieben: > > > Fix warnings generated by checkpatch.pl for alignment should match open > parenthesis. This is a coding style change only. > > Signed-off-by: Greg Gallagher Acked-by: Stefan Wahren

Re: [PATCH v2 10/15] staging: fbtft: Fixes some defines styles - Style

2018-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 09, 2018 at 06:39:55AM -0300, Leonardo Bras wrote: > On Wed, Aug 08, 2018 at 02:22:19PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Aug 07, 2018 at 09:29:25PM -0300, Leonardo Brás wrote: > > > Fixing some styles as recommended by checkpatch.pl. > > > > > > Signed-off-by: Leonardo Brás

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Dan Carpenter
On Thu, Aug 09, 2018 at 02:13:24PM +0200, Greg KH wrote: > On Thu, Aug 09, 2018 at 01:43:58PM +0300, Dan Carpenter wrote: > > On Thu, Aug 09, 2018 at 01:08:38PM +0300, Dan Carpenter wrote: > > > On Thu, Aug 09, 2018 at 12:13:06PM +0530, Ajay Singh wrote: > > > > wilc_dir =

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

2018-08-09 Thread Greg KH
On Thu, Aug 09, 2018 at 03:51:55PM +0300, Dan Carpenter wrote: > On Thu, Aug 09, 2018 at 02:13:24PM +0200, Greg KH wrote: > > On Thu, Aug 09, 2018 at 01:43:58PM +0300, Dan Carpenter wrote: > > > On Thu, Aug 09, 2018 at 01:08:38PM +0300, Dan Carpenter wrote: > > > > On Thu, Aug 09, 2018 at

[PATCH 1/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_security.c

2018-08-09 Thread Michael Straube
Use is_multicast_ether_addr instead of custom IS_MCAST in core/rtw_security.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_security.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c

[PATCH 2/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_recv.c

2018-08-09 Thread Michael Straube
Use is_multicast_ether_addr instead of custom IS_MCAST in core/rtw_recv.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_recv.c | 35 --- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c

[PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_xmit.c

2018-08-09 Thread Michael Straube
Use is_multicast_ether_addr instead of custom IS_MCAST in core/rtw_xmit.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 35 +++ 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 5/5] staging: rtl8188eu: use phydm_reg.h from rtlwifi

2018-08-09 Thread Michael Straube
Use rtlwifi/phydm/phydm_reg.h instead of odm_reg.h and remove the now unused odm_reg.h. All defines from odm_reg.h are defined with the same values in rtlwifi/phydm/phydm_reg.h. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/include/odm_precomp.h | 2 +-

[PATCH 4/5] staging: rtl8188eu: remove unused IS_MCAST

2018-08-09 Thread Michael Straube
Remove the now unused IS_MCAST. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/wifi.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h index 4a56e54e38f6..0a952edf8a81 100644 ---

Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_xmit.c

2018-08-09 Thread Michael Straube
On 8/9/18 7:13 PM, Joe Perches wrote: On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote: Use is_multicast_ether_addr instead of custom IS_MCAST in core/rtw_xmit.c. Have you verified that all accesses are __aligned(2) ? If so, please state that in the patch description. diff --git

Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_xmit.c

2018-08-09 Thread Michael Straube
On 8/9/18 7:51 PM, Joe Perches wrote: On Thu, 2018-08-09 at 19:42 +0200, Michael Straube wrote: On 8/9/18 7:13 PM, Joe Perches wrote: On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote: Use is_multicast_ether_addr instead of custom IS_MCAST in core/rtw_xmit.c. Have you verified that

RE:INFO

2018-08-09 Thread INFORMATION
Good Day I am Brian, I have a private investment of $3.1 Billion USD I will want us to discuss, please give me your most secure and private email with phone numbers asap for more details. Regards, Brian ___ devel mailing list

RE:INFO

2018-08-09 Thread INFORMATION
Good Day I am Brian, I have a private investment of $3.1 Billion USD I will want us to discuss, please give me your most secure and private email with phone numbers asap for more details. Regards, Brian ___ devel mailing list

[PATCH] Staging: One Laptop Per Child: add function argument names

2018-08-09 Thread Arkadiusz Lis
Add function argument names to pointers to functions in struct dcon_platform_data: init, set_dconload and read_status This commit removes checkpatch.pl warning. Signed-off-by: Arkadiusz Lis --- drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_xmit.c

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote: > Use is_multicast_ether_addr instead of custom IS_MCAST in > core/rtw_xmit.c. Have you verified that all accesses are __aligned(2) ? If so, please state that in the patch description. > diff --git

[PATCH] uio_hv_generic: increase size of receive and send buffers

2018-08-09 Thread Stephen Hemminger
When using DPDK there is significant performance boost by using the largest possible send and receive buffer area. Unfortunately, with UIO model there is not a good way to configure this at run time. But it is okay to have a bigger buffer available even if application only decides to use a

RE:INFO

2018-08-09 Thread INFORMATION
Good Day I am Brian, I have a private investment of $3.1 Billion USD I will want us to discuss, please give me your most secure and private email with phone numbers asap for more details. Regards, Brian ___ devel mailing list

[PATCH] uio_hv_generic: drop #ifdef DEBUG

2018-08-09 Thread Stephen Hemminger
DEBUG is leftover from the development phase, remove it. Signed-off-by: Stephen Hemminger --- drivers/uio/uio_hv_generic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index 9e7d622b4326..a08860260f55 100644 ---

[PATCH 15/16] staging: gasket: interrupt: simplify interrupt init parameters

2018-08-09 Thread Todd Poynor
From: Todd Poynor Pass the gasket driver descriptor to the interrupt init function, rather than exploding out separate parameters from various fields of that structure. This allows us to make more localized changes to the types of interrupts supported (MSIX vs. wire, etc.) without affecting the

[PATCH 07/16] staging: gasket: page table: remove unnecessary NULL check

2018-08-09 Thread Todd Poynor
From: Todd Poynor gasket_alloc_coherent_memory remove unnecessary NULL check for coherent_pages. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gasket/gasket_page_table.c

[PATCH 09/16] staging: gasket: core: switch to relaxed memory-mapped I/O

2018-08-09 Thread Todd Poynor
From: Todd Poynor Use of readl() is deprecated; readl_relaxed() with appropriate memory barriers is preferred. Switch to relaxed reads and writes for better performance as well. Memory barriers required for I/O vs. normal memory access on Apex devices have already been explicitly coded in the

[PATCH 00/16] staging: gasket: return of the son of cleanups

2018-08-09 Thread Todd Poynor
From: Todd Poynor Remove extraneous memory barriers, refactor PCI-specific code in prep for platform devices in the near future, general cleanups, and make de facto maintainership official. Todd Poynor (16): MAINTAINERS: Switch a maintainer for drivers/staging/gasket staging: gasket: core:

[PATCH 10/16] staging: gasket: page table: remove extraneous memory barriers

2018-08-09 Thread Todd Poynor
From: Todd Poynor Some explicit memory barriers in the page table code are not necessary, either because: (a) The barrier follows a non-relaxed MMIO access that already performs a read or write memory barrier. (b) The barrier follows DMA API calls for which the device-visible effects of IOMMU

[PATCH 05/16] staging: gasket: core: remove ftrace-style debug logs

2018-08-09 Thread Todd Poynor
From: Todd Poynor Remove debug logs that only indicate the name of the entered function, in favor of using ftrace for function tracing style logs. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 08/16] staging: gasket: page table: use dma_mapping_error for error detection

2018-08-09 Thread Todd Poynor
From: Todd Poynor gasket_perform_mapping() call dma_mapping_error() to determine if mapping failed. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_page_table.c

[PATCH 03/16] staging: gasket: core: fix line continuation indent in gasket_alloc_dev

2018-08-09 Thread Todd Poynor
From: Todd Poynor Previous cleanups missed a case of multi-line function call with line continuation parameters not aligned per kernel style. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 12/16] staging: gasket: core: factor out generic device remove code from PCI

2018-08-09 Thread Todd Poynor
From: Todd Poynor Separate code for generic parts of gasket device removal sequence from the PCI device removal code, in prep for non-PCI devices later. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[PATCH 11/16] staging: gasket: core: factor out generic device add code from PCI code

2018-08-09 Thread Todd Poynor
From: Todd Poynor Split out generic gasket device add code from the code for adding a PCI gasket device, in prep for other gasket device types in the future. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 76 ++-- 1 file changed, 48

[PATCH 14/16] staging: gasket: interrupt: refactor PCI MSIX-specific handler code

2018-08-09 Thread Todd Poynor
From: Todd Poynor Split interrupt handler into PCI MSIX-specific and generic functions, for adding non-MSIX handlers in the future. Move MSIX init code together,, out of generic init path. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_interrupt.c | 48 ---

[PATCH 13/16] staging: gasket: core: rename lookup_internal_desc to be PCI-specific

2018-08-09 Thread Todd Poynor
From: Todd Poynor Rename lookup_internal_desc() to lookup_pci_internal_desc() to reflect use for PCI devices only, in prep for non-PCI devices in the future. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 16/16] staging: gasket: interrupt: remove unimplemented interrupt types

2018-08-09 Thread Todd Poynor
From: Todd Poynor Interrupt types PCI_MSI and PLATFORM_WIRE are unused and unimplemented. Remove these. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.h | 11 drivers/staging/gasket/gasket_interrupt.c | 34 +-- 2 files changed, 1

[PATCH 2/2] staging: fbtft: Adds space around "/"

2018-08-09 Thread Leonardo Brás
Kernel coding style recommends a space char around "/". Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 798a8fe98e95..25302ffc4000 100644 ---

[PATCH 1/2] staging: fbtft: Moves "; " from macro definition to macro usage.

2018-08-09 Thread Leonardo Brás
This makes the macro usage more like a function declaration. Also, ending a macro definition with ";" is not recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v3 1/3] staging: fbtft: Includes description to mutex and spinlock - Style

2018-08-09 Thread Leonardo Brás
Adds comments explaining what are the spinlock and mutex used for. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index

[PATCH v3 0/3] Style changes

2018-08-09 Thread Leonardo Brás
Some style changes to help readability. Leonardo Brás (3): staging: fbtft: Includes description to mutex and spinlock - Style staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style staging: fbtft: Corrects long index line - Style drivers/staging/fbtft/fbtft-sysfs.c | 5 ++-

[PATCH v3 2/3] staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style

2018-08-09 Thread Leonardo Brás
Use of default macro BIT(n) instead of (1 << n). Helps readability. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h

[PATCH 1/1] staging: fbtft: Removes ";" from very used macro definition.

2018-08-09 Thread Leonardo Brás
All usages of this macro append the ";" at the end of line. It is not recommended nor necessary to append a ";" at the end of this macro definition. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 3/3] staging: fbtft: Corrects long index line - Style

2018-08-09 Thread Leonardo Brás
Reduces the index size to keep the code more readable. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-sysfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index

Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_xmit.c

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 19:42 +0200, Michael Straube wrote: > On 8/9/18 7:13 PM, Joe Perches wrote: > > On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote: > > > Use is_multicast_ether_addr instead of custom IS_MCAST in > > > core/rtw_xmit.c. > > > > Have you verified that all accesses are

Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_xmit.c

2018-08-09 Thread Michael Straube
On 8/9/18 8:03 PM, Michael Straube wrote: On 8/9/18 7:51 PM, Joe Perches wrote: On Thu, 2018-08-09 at 19:42 +0200, Michael Straube wrote: On 8/9/18 7:13 PM, Joe Perches wrote: On Thu, 2018-08-09 at 19:01 +0200, Michael Straube wrote: Use is_multicast_ether_addr instead of custom IS_MCAST in

Re: [PATCH 3/5] staging: rtl8188eu: use is_multicast_ether_addr in rtw_xmit.c

2018-08-09 Thread Dan Carpenter
On Thu, Aug 09, 2018 at 09:44:54PM +0200, Michael Straube wrote: > Is the memory pointed to by sk_buff->data (always) __aligned(2) ? Yes. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

[PATCH 06/16] staging: gasket: remove gasket_exit()

2018-08-09 Thread Todd Poynor
From: Todd Poynor Remove now-empty gasket_exit() function. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 0fe5b86b294c8..aee819f379e9a

[PATCH 02/16] staging: gasket: core: remove debug log that could crash

2018-08-09 Thread Todd Poynor
From: Todd Poynor A debug log in gasket_alloc_dev() is issued regardless of whether the device pointer used returned success or error. The log isn't that useful anyway, remove it. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 01/16] MAINTAINERS: Switch a maintainer for drivers/staging/gasket

2018-08-09 Thread Todd Poynor
From: Todd Poynor Todd Poynor takes over for John Joseph. Signed-off-by: John Joseph Signed-off-by: Todd Poynor --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index af64fe0f0b41f..f3466b5c50482 100644 --- a/MAINTAINERS +++