[PATCH 3/4] staging: rtl8188eu: rename parameter of Hal_GetChnlGroup88E()

Rename function parameter of Hal_GetChnlGroup88E() to avoid CamelCase. pGroup -> group Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 2/4] staging: rtl8188eu: change return type of Hal_GetChnlGroup88E()

After the removal of code valid only for 5 GHz the function Hal_GetChnlGroup88E returns always true. Change the return type to void and remove the variable bIn24G. Remove the tests for the return value and the variable bIn24G from the only user Hal_ReadTxPowerInfo88E(). Signed-off-by: Michael

[PATCH 1/4] staging: rtl8188eu: remove 5 GHz code from Hal_GetChnlGroup88E()

Remove code valid only for 5 GHz from Hal_GetChnlGroup88E(). This addresses the below TODO item. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by: Michael Straube ---

[PATCH 4/4] staging: rtl8188eu: clean function definitions - style

Do not line break function definitions where not needed and move the return type to the same line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

Hi Boris, Boris Brezillon wrote on Mon, 17 Sep 2018 10:29:39 +0200: > On Sat, 15 Sep 2018 19:54:40 +0200 > Miquel Raynal wrote: > > > Hi Boris, > > > > Boris Brezillon wrote on Fri, 7 Sep 2018 > > 00:38:32 +0200: > > > > > Hello, > > > > > > This is the 2nd batch of API cleanup

Re: [PATCH v4 0/3] staging: erofs: option validation for remount and some code cleanups

On 9/19/18 11:22 PM, Gao Xiang wrote: Hi Chengguang, On 2018/9/19 22:53, Chengguang Xu wrote: Hi Greg, Xiang I rebased code on latest erofs-master branch and that branch has already merged the first patch in my previous patchset, so this time I only post rest 3 patches. Great, at the most

Re: [PATCH v4 0/3] staging: erofs: option validation for remount and some code cleanups

On 2018/9/20 7:34, cgxu519 wrote: > On 9/19/18 11:22 PM, Gao Xiang wrote: >> Hi Chengguang, >> >> On 2018/9/19 22:53, Chengguang Xu wrote: >>> Hi Greg, Xiang >>> >>> I rebased code on latest erofs-master branch and that branch >>> has already merged the first patch in my previous patchset, >>> so

Re: [PATCH v2 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

On 2018/9/20 0:06, Gao Xiang wrote: > From: Gao Xiang > > This patch introduces `__should_decompress_synchronously' to > cleanup `z_erofs_vle_normalaccess_readpages'. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, ___ devel mailing

Re: [PATCH 1/6] staging: erofs: remove redundant CONFIG_EROFS_FS_XATTRs

On 2018/9/19 13:49, Gao Xiang wrote: > some CONFIG_EROFS_FS_XATTR conditions were added because of > the historial Linux kernel compatibility, which are unneeded now. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, ___ devel mailing list

Re: [PATCH 2/6] staging: erofs: fold in `__update_workgrp_llen'

On 2018/9/19 13:49, Gao Xiang wrote: > There is the only one user to use `__update_workgrp_llen'. > Fold it in `z_erofs_vle_work_iter_begin' and cleanup related code. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, ___ devel mailing list

Re: [PATCH 3/6] staging: erofs: drop multiref support temporarily

On 2018/9/19 13:49, Gao Xiang wrote: > Multiref support means that a compressed page could have > more than one reference, which is designed for on-disk data > deduplication. However, mkfs doesn't support this mode > at this moment, and the kernel implementation is also broken. > > Let's drop

Re: [PATCH v4 0/3] staging: erofs: option validation for remount and some code cleanups

Hi Chengguang, On 2018/9/19 22:53, Chengguang Xu wrote: > Hi Greg, Xiang > > I rebased code on latest erofs-master branch and that branch > has already merged the first patch in my previous patchset, > so this time I only post rest 3 patches. Great, at the most time Chao's erofs-master is the

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Xiang, On 2018/9/19 13:49, Gao Xiang wrote: > This patch introduces `__should_decompress_synchronously' to > cleanup `z_erofs_vle_normalaccess_readpages'. > > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/internal.h | 11 +++ > drivers/staging/erofs/super.c | 5 +

Re: [PATCH 5/6] staging: erofs: add some comments for xattr subsystem

On 2018/9/19 13:49, Gao Xiang wrote: > As Dan Carpenter pointed out, it is better to document what > return values of these callbacks in `struct xattr_iter_handlers' > mean and why it->ofs is increased regardless of success or > failure in `xattr_foreach'. > > Suggested-by: Dan Carpenter >

Re: [PATCH 6/6] staging: erofs: simplify return value of `xattr_foreach'

On 2018/9/19 13:49, Gao Xiang wrote: > As Dan Carpenter pointed out, there is no need to propagate positive > return values back to its callers. > > Suggested-by: Dan Carpenter > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, ___ devel

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Chao, On 2018/9/19 23:26, Chao Yu wrote: > Hi Xiang, > > On 2018/9/19 13:49, Gao Xiang wrote: >> This patch introduces `__should_decompress_synchronously' to >> cleanup `z_erofs_vle_normalaccess_readpages'. >> >> Signed-off-by: Gao Xiang >> --- >> drivers/staging/erofs/internal.h | 11

Re: [PATCH v3] staging: android: ion: Add per-heap counters

On 09/18/2018 10:50 AM, Greg KH wrote: On Tue, Sep 11, 2018 at 02:29:19PM +0300, Alexey Skidanov wrote: Heap statistics have been removed and currently even basics statistics are missing. This patch creates per heap debugfs directory /sys/kernel/debug/ and adds the following counters: - the

[PATCH v4 0/3] staging: erofs: option validation for remount and some code cleanups

Hi Greg, Xiang I rebased code on latest erofs-master branch and that branch has already merged the first patch in my previous patchset, so this time I only post rest 3 patches. Thanks, -- This patch set mainly does option validation for remount and at the same time does related code cleanups.

[PATCH v4 1/3] staging: erofs: code cleanup for option parsing of fault_injection

Define a dummpy function of erofs_build_fault_attr() when macro CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to check the macro in calling place. Based on above adjustment, do proper code cleanup for option parsing of fault_injection. Signed-off-by: Chengguang Xu Reviewed-by:

[PATCH v4 2/3] staging: erofs: code cleanup for erofs_show_options()

Add new helper erofs_get_fault_rate() to get fault rate instead of directly getting it from sbi, so we can remove the macro check surrounding it. Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Reviewed-by: Gao Xiang --- drivers/staging/erofs/super.c | 14 +++--- 1 file changed, 11

[PATCH v4 3/3] staging: erofs: option validation in remount

Add option validation in remount. After this patch, remount can change recognized options, and for unknown options remount will fail and report error. Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Reviewed-by: Gao Xiang --- drivers/staging/erofs/super.c | 37

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Chao, On 2018/9/19 23:32, Gao Xiang via Linux-erofs wrote: > Hi Chao, > > On 2018/9/19 23:26, Chao Yu wrote: >> Hi Xiang, >> >> On 2018/9/19 13:49, Gao Xiang wrote: >>> This patch introduces `__should_decompress_synchronously' to >>> cleanup `z_erofs_vle_normalaccess_readpages'. >>> >>>

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Xiang, On 2018/9/19 23:32, Gao Xiang wrote: > Hi Chao, > > On 2018/9/19 23:26, Chao Yu wrote: >> Hi Xiang, >> >> On 2018/9/19 13:49, Gao Xiang wrote: >>> This patch introduces `__should_decompress_synchronously' to >>> cleanup `z_erofs_vle_normalaccess_readpages'. >>> >>> Signed-off-by: Gao

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Chao, On 2018/9/19 23:45, Chao Yu wrote: > Hi Xiang, > > On 2018/9/19 23:32, Gao Xiang wrote: >> Hi Chao, >> >> On 2018/9/19 23:26, Chao Yu wrote: >>> Hi Xiang, >>> >>> On 2018/9/19 13:49, Gao Xiang wrote: This patch introduces `__should_decompress_synchronously' to cleanup

RE: [PATCH] x86/hyperv: suppress "PCI: Fatal: No config space access function found"

From: Dexuan Cui Sent: Tuesday, September 18, 2018 3:30 PM > > A Generatin-2 Linux VM on Hyper-V doesn't have the legacy PCI bus, and > users always see the scary warning, which is actually harmless. The patch > is made to suppress the warning. > > Signed-off-by: Dexuan Cui > Cc: K. Y.

RE: [PATCH V2 2/13] KVM/MMU: Add tlb flush with range helper function

From: Tianyu Lan Sent: Monday, September 17, 2018 8:18 PM > > +static void kvm_flush_remote_tlbs_with_range(struct kvm *kvm, > + struct kvm_tlb_range *range) > +{ > + int ret = -ENOTSUPP; > + > + if (range && kvm_x86_ops->tlb_remote_flush_with_range) { > + /* > +

[PATCH v2 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

From: Gao Xiang This patch introduces `__should_decompress_synchronously' to cleanup `z_erofs_vle_normalaccess_readpages'. Signed-off-by: Gao Xiang --- change log v2: - Leave the original threshold "3" for DEFAULT_MAX_SYNC_DECOMPRESS_PAGES and just do the cleanup work.

RE: [PATCH V2 4/13] KVM/MMU: Flush tlb directly in the kvm_handle_hva_range()

From: Tianyu Lan Sent: Monday, September 17, 2018 8:19 PM > + > + if (ret && kvm_available_flush_tlb_with_range()) { > + kvm_flush_remote_tlbs_with_address(kvm, > + gfn_start, > +

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

On Wed, 19 Sep 2018, Rasmus Villemoes wrote: > On 2018-09-19 00:46, Thomas Gleixner wrote: > > On Tue, 18 Sep 2018, Andy Lutomirski wrote: > >>> > >> > >> Do we do better if we use signed arithmetic for the whole calculation? > >> Then a small backwards movement would result in a small backwards

Re: Purchase Order 19-09-2018

Dear Sir/Madam, We are a USA based company interested in your product. I'm writing to you after seeing your catalog. We want to purchase this items like in the attachments. Please quote for us good prices including shipping charges by sea CIF port of New York. Waiting for quote. Thank

[PATCH 08/13] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 ++ drivers/staging/comedi/drivers/ni_stc.h | 6 +- 2 files

[PATCH 12/13] staging: comedi: ni_660x: clean up pfi routing

Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72 ++-- 1

[PATCH 03/13] staging: comedi: add new device-global config interface

Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 18 drivers/staging/comedi/comedi_fops.c

[PATCH 13/13] staging: comedi: ni_660x: add device-global routing

Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 265 +++ 1

[PATCH 10/13] staging: comedi: ni_mio_common: create device-global access to tio

Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH 05/13] staging: comedi: add interface to ni routing table information

Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/Kconfig| 4 + drivers/staging/comedi/drivers/Makefile | 1 +

[PATCH 2/4] staging: comedi: ni_mio_common: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

Adds implementation of the new INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS instruction. This patch also adds data for digital subdevices that are streaming capable (within the ni_mio_* family). Mostly, only the m-series devices are capable of digital streaming. Signed-off-by: Spencer E. Olson ---

[PATCH 3/4] staging: comedi: ni_pcidio: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

Adds implementation of the new INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS instruction. This patch also adds data for this implementation, based on spec sheets from NI. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_pcidio.c | 13 + 1 file changed, 13

[PATCH 1/4] staging: comedi: add facility to directly query subdevice timing constraints

Adds facility to directly query the hardware speed limits of subdevices, in particular for scan_begin and convert signals. This information can be critical for integrating comedi with other hardware modules, and also comedi modules together with software where software requires specific timing

[PATCH v8 1/1] staging: mt7621-mmc: Delete IRQ_MSG() and its users

This patch removes IRQ_MSG() and its users as currently it is a no-op. Signed-off-by: Nishad Kamdar --- Changes in v8: - Remove unnecessary {} for single statement if Changes in v7: - Delete IRQ_MSG() and all its users Changes in v6: - No change Changes in v5: - No change ---

[PATCH 00/13] device-global identifiers and routes introduced

Because this patchset has come so far after my last version, I am submitting it without reference to the older patch set. -- This patchset introduces a new framework for providing and maintaining a consistent namespace to define terminal/signal names for a set of comedi devices. This effort was

[PATCH 02/13] staging: comedi: add abstracted NI signal/terminal named constants

This change adds abstracted constants for National Instruments terminal/signal names. Some background: There have been significant confusions over the past many years for users when trying to understand how to connect to/from signals and terminals on NI hardware using comedi. The major

[PATCH 06/13] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

Use new signal routing capability for all comedi command *_src == TRIG_EXT options. This new interface allows the user specify signals and terminals as TRIG_EXT sources using a very consistent naming convention. Furthermore, the interface allows backwards compatibility to prior behavior of

[PATCH 11/13] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 01/13] staging: comedi: tests: add unittest framework for comedi

Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson

[PATCH 07/13] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

Implement device-global config interface for ni_mio devices. In particular, this patch implements: INSN_DEVICE_CONFIG_TEST_ROUTE, INSN_DEVICE_CONFIG_CONNECT_ROUTE, INSN_DEVICE_CONFIG_DISCONNECT_ROUTE, INSN_DEVICE_CONFIG_GET_ROUTES for the ni mio devices. This means that the new abstracted

[PATCH] staging: comedi: ni_mio_common: protect register write overflow

Fixes two problems introduced as early as commit 03aef4b6dc12 ("Staging: comedi: add ni_mio_common code"): (1) Ensures that the last four bits of NISTC_RTSI_TRIGB_OUT_REG register is not unduly overwritten on e-series devices. On e-series devices, the first three of the last four bits

[PATCH 09/13] staging: comedi: tio: implement global tio/ctr routing

Adds ability to use device-global names in command args, in particular cmd->start_arg (for NI_CtrArmStartTrigger), and cmd->scan_begin_arg or cmd->convert_arg (either is used to specify NI_CtrGate, with preference given to cmd->scan_begin_arg, if it is set). The actual arguments of cmd->start_arg

[PATCH 4/4] staging: comedi: comedi_test: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

Adds implementation of the new INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS instruction. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/comedi_test.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/staging/comedi/drivers/comedi_test.c

[PATCH 0/4] Add facility to directly query subdevice timing

This patchset adds a facility to directly query hardware speed limits of subdevices, in particular for scan_begin and convert signals. This information is generally already stored for many devices, such as analog input devices for NI hardware. This patchset makes this information available.

RE: [PATCH V2 10/13] x86/hyper-v: Add HvFlushGuestAddressList hypercall support

From: Tianyu Lan Sent: Monday, September 17, 2018 8:19 PM > > #include > #include > #include > #include > +#include Hopefully asm/kvm_host.h does not need to be #included, given the new code structure. > > #include > > +/* > + * MAX_FLUSH_PAGES = "additional_pages" + 1. It's

Re: [PATCH v7 1/1] staging: mt7621-mmc: Delete IRQ_MSG() and its users.

On Tue, Sep 18, 2018 at 01:29:01PM +0200, Greg Kroah-Hartman wrote: > On Sat, Sep 15, 2018 at 08:28:03AM +0530, Nishad Kamdar wrote: > > This patch removes IRQ_MSG() and its users as currently it is a no-op. > > > > Signed-off-by: Nishad Kamdar > > --- > > Changes in v7: > > - Delete IRQ_MSG()

[PATCH v8 0/1] staging: mt7621-mmc: Fix debug macros and their usages

This patch fixes the debug macro IRQ_MSG(). It deletes IRQ_MSG() and all its users as currently it is a no-op. Changes in v8: - Remove unnecessary {} for single statement if Changes in v7: - Delete IRQ_MSG() macro and its users. - Patchset reduced to 1 patch as the patches fixing N_MSG()

Re: [PATCH v8 0/4] gpiolib: speed up GPIO array processing

On Thu, Sep 13, 2018 at 2:22 AM Linus Walleij wrote: > On Wed, Sep 5, 2018 at 11:49 PM Janusz Krzysztofik > wrote: > > > The goal is to boost performance of get/set array functions while > > processing GPIO arrays which represent pins of a signle chip in > > hardware order. If resulting

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

On 2018-09-19 00:46, Thomas Gleixner wrote: > On Tue, 18 Sep 2018, Andy Lutomirski wrote: >>> >> >> Do we do better if we use signed arithmetic for the whole calculation? >> Then a small backwards movement would result in a small backwards result. >> Or we could offset everything so that we’d have

Re: [PATCH 29/29] staging: wilc1000: return exact error of register_netdev() from wilc_netdev_init()

I was waiting for you to send this like a spider waits for flies. You fell directly into my trap. Mwuahahahahaha. drivers/staging/wilc1000/linux_wlan.c 1056 int wilc_netdev_init(struct wilc **wilc, struct device *dev, int io_type, 1057 const struct wilc_hif_func

[PATCH 15/29] staging: wilc1000: remove unused wid from cfg struct

Cleanup patch to remove the unused element stored in cfg struct. Removed those wid from the cfg variables whose value is not fetched(GET_CFG) from the code. In case the wid is only set to the firmware then there is need to store them as part of cfg variables, so removed the unused code.

[PATCH 19/29] staging: wilc1000: avoid the use of 'hif_driver_comp' completion variable

Instead of using extra completion variable to handle the sync call now using msg->is_sync flag to handle the sync call. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 23 +++ drivers/staging/wilc1000/host_interface.h | 2 +-

[PATCH 21/29] staging: wilc1000: avoid use of 'g_sdio' static variable

Instead of using static variable 'g_sdio' move it as part of 'wilc' struct. Also allocating the memory in the probe function and free during deinitialization. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1 + drivers/staging/wilc1000/wilc_sdio.c | 54

[PATCH 24/29] staging: wilc1000: remove p2p related static variables to wilc_vif struct

Avoid use of static variable and move them as part of private data(wilc_priv) struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 + drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 60 +++

[PATCH 18/29] staging: wilc1000: rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals'

Rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals' as its more appropriate for structure to store the values of string configuration. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 14 +++--- drivers/staging/wilc1000/wilc_wlan_cfg.h | 4 ++-- 2 files changed,

[PATCH 22/29] staging: wilc1000: avoid use of 'g_spi' static variable

Instead of using static variable 'g_spi' move it as part of 'wilc' struct. Also allocating the memory in the probe function and free is taken care in wilc_netdev_cleanup(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 58 +++-- 1 file

[PATCH 25/29] staging: wilc1000: remove wilc_debugfs.c file as its not used

Deleted wilc_debugfs.c file as it's not used. Earlier discussion link: [1]. https://www.spinics.net/lists/linux-wireless/msg176076.html Suggested-by: Greg KH Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/Makefile | 5 +- drivers/staging/wilc1000/wilc_debugfs.c | 115

[PATCH 17/29] staging: wilc1000: refactor code to avoid static variables for config parameters

Refactor the code in wilc_wlan_cfg.c file to avoid the use of static variables. Move the static variables as part of wilc struct and also dynamically allocating memory for keeping those variables. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 12 +-

[PATCH 26/29] staging: wilc1000: remove unnecessary option used with ccflags-y in Makefile

Cleanup patch to remove -I(src) and -DWILC_ASIC_A0 option used in ccflag-y in Makefile. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/Makefile b/drivers/staging/wilc1000/Makefile index

[PATCH 23/29] staging: wilc1000: remove unnecessary memset in sdio_init() & wilc_spi_init()

Cleanup changes to avoid unnecessary setting 'wilc->bus_data' value to zero as the buffer was allocated using kzalloc(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 4 +--- drivers/staging/wilc1000/wilc_spi.c | 3 --- 2 files changed, 1 insertion(+), 6 deletions(-)

[PATCH 20/29] staging: wilc1000: remove use of unnecessary 'wilc_connected_ssid' variable

'wilc_connected_ssid' actually used to store the BSSID information for connected BSSID. 'wilc_vif' already has 'bssid' variable to store the same information. So refactor code to remove 'wilc_connected_ssid' and instead used 'wilc_vif' struct 'bssid' element. Signed-off-by: Ajay Singh ---

[PATCH 27/29] staging: wilc1000: use usleep_range() in place of udelay()

Changes to avoid the below checkpatch warning: 'usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt;' Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 28/29] staging: wilc1000: avoid spaces preferred around checkpatch issue

Cleanup patch to add extra spaces around the '/' to avoid the below checkpatch warning. 'spaces preferred around that '/' (ctx:VxV)' Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v1 0/6] mm: online/offline_pages called w.o. mem_hotplug_lock

Am 19.09.18 um 03:22 schrieb Balbir Singh: > On Tue, Sep 18, 2018 at 01:48:16PM +0200, David Hildenbrand wrote: >> Reading through the code and studying how mem_hotplug_lock is to be used, >> I noticed that there are two places where we can end up calling >> device_online()/device_offline() -

Re: [PATCH v3 4/4] staging: erofs: option validation in remount

Hi Chengguang, On 2018/9/19 0:58, Gao Xiang wrote: > Hi Chengguang, > > On 2018/9/18 23:10, Chengguang Xu wrote: >> Add option validation in remount. After this patch, remount >> can change recognized options, and for unknown options remount >> will fail and report error. >> >> Signed-off-by:

[PATCH 01/29] staging: wilc1000: change return type to 'void' for wilc_frame_register()

Cleanup patch to use 'void' return type for wilc_frame_register(), as its return value is not used. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 ++ drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH 03/29] staging: wilc1000: change return type to 'void' for lock init & deinit functions

Cleanup patch to use 'void' return type for wlan_deinit_locks() & wlan_init_locks(), as same value is return. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c

[PATCH 06/29] staging: wilc1000: use 'void' return type for host_int_get_assoc_res_info()

Change return type to 'void' for host_int_get_assoc_res_info() as its return value is not used. 'rcvd_assoc_resp_info_len' parameter value is used to know the status. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 11 +-- 1 file changed, 5 insertions(+), 6

[PATCH 00/29] staging: wilc1000: avoid static variables and cleanup changes

This patch series contains changes to avoid the use of static variables. Cleanup changes to fix some checkpatch issues and return void for function if their return value is not used. Also deleted 'wilc_debugfs.c' file as it's not used. Ajay Singh (29): staging: wilc1000: change return type to

[PATCH 16/29] staging: wilc1000: refactor code to remove 'mac_status' from 'wilc_mac_cfg' struct

Refactor the code by removing use of 'mac_status' from 'wilc_mac_cfg' and only have the string type configuration values in 'wilc_mac_cfg' struct. Now fetch the value 'WID_STATUS' configuration from 'g_cfg_byte' array. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c

[PATCH 07/29] staging: wilc1000: use 'void' return for wilc_wlan_txq_add_to_head()

Use 'void' return for wilc_wlan_txq_add_to_head() as its always return '0' value. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH 04/29] staging: wilc1000: change return type to 'void' for wilc_deinit_host_int()

Cleanup patch to use 'void' return type for wilc_deinit_host_int(), as its return value is not used in caller. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +- 2 files changed, 2 insertions(+), 4

[PATCH 02/29] staging: wilc1000: change return type to 'void' for wilc_wlan_set_bssid()

Cleanup patch to use 'void' return type for wilc_wlan_set_bssid(), as its always returns the same value. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 4 +--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-)

[PATCH 05/29] staging: wilc1000: change return type to 'void' for wilc_wfi_deinit_mon_interface()

Use 'void' return type for wilc_wfi_deinit_mon_interface(), as same value always return. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 09/29] staging: wilc1000: use 'void' return for wilc_wlan_txq_filter_dup_tcp_ack()

Use 'void' return for wilc_wlan_txq_filter_dup_tcp_ack() as it always return value '1' and its not used by the caller. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH 08/29] staging: wilc1000: change return type to 'void' tcp ack filter functions

Use 'void' return type for below functions as they always return '0' and their return value is not used by caller. add_tcp_pending_ack() update_tcp_session() add_tcp_pending_ack() Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 15 ++- 1 file changed, 6

[PATCH 14/29] staging: wilc1000: remove unused wid type values

Cleanup patch to remove the wid type not used in the code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_if.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h b/drivers/staging/wilc1000/wilc_wlan_if.h index b81a73b..ce2066b

[PATCH 12/29] staging: wilc1000: set default value of cfg response type in wilc_wlan_cfg_indicate_rx()

Handle the setting of default value for 'wilc_cfg_rsp' type for all cases in wilc_wlan_cfg_indicate_rx() as the caller make use of this value to know the type of the received message. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 3 +-- 1 file changed, 1 insertion(+),

[PATCH 10/29] staging: wilc1000: change return type to 'void' for wilc_wlan_cfg_indicate_rx()

Cleanup patch to use 'void' return type for wilc_wlan_cfg_indicate_rx(), as its return value is not used in caller. The value set in 'rsp' argument is used to get the success status. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 8 ++--

[PATCH 13/29] staging: wilc1000: changes 'val' type to u8 in wilc_cfg_byte struct

Use the correct datatype for storing the byte value in 'wilc_cfg_byte' struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.h

[PATCH 11/29] staging: wilc1000: refactor wilc_wlan_parse_info_frame() function

Return 'void' from wilc_wlan_parse_info_frame() as same constant value is returned always. Also removed the 'size' from input parameter as its not used in the function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 12 1 file changed, 4 insertions(+), 8

Re: [PATCH 29/29] staging: wilc1000: return exact error of register_netdev() from wilc_netdev_init()

Hi Dan, Thanks your reviewing the patch. On Wed, 19 Sep 2018 12:41:32 +0300 Dan Carpenter wrote: > I was waiting for you to send this like a spider waits for flies. You > fell directly into my trap. Mwuahahahahaha. Oops!!! I missed seeing it coming :) > >