On Thu 18-10-18 19:18:25, Andrew Morton wrote:
[...]
> So this patch needs more work, yes?
Yes, I've talked to Arun (he is offline until next week) offlist and he
will play with this some more.
--
Michal Hocko
SUSE Labs
___
devel mailing list
Hi Marcin,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-164230
smatch warnings:
drivers/staging/nrf24/nrf24_if.c:538 nrf24_create_pipe() error: 'p->dev'
On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel wrote:
>
> It's based off the driver from the OLPC kernel sources. Somewhat
> modernized and cleaned up, for better or worse.
>
> Modified to plug into the olpc-ec driver infrastructure (so that battery
> interface and debugfs could be reused) and
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> It doesn't make sense to always have this built-in, e.g. on ARM
> multiplatform kernels. A better way to address the problem the original
> commit aimed to solve is to fix Kconfig.
>
> This reverts commit
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> All OLPC ECs are able to turn the power to the DCON on an off. Use the
> regulator framework to expose the functionality.
> +static int olpc_ec_set_dcon_power(struct olpc_ec_priv *ec, bool state)
> +{
> + unsigned char ec_byte =
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> Also, the header is x86 specific, while there are non-x86 OLPC machines.
Same concern. as per patch 2.
Also, you might want to sort headers in alphabetical order.
>
> Signed-off-by: Lubomir Rintel
> ---
>
On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel wrote:
>
> It is actually plaform independent. Move it to the olpc-ec driver from
> the X86 OLPC platform, so that it could be used by the ARM based laptops
> too.
What is platform independent exactly?
> #define OLPC_F_PRESENT 0x01
>
On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel wrote:
>
> The global variables for private data are not too nice. I'd like some
> more, and that would clutter the global name space even further.
>
Good change!
Reviewed-by: Andy Shevchenko
> Signed-off-by: Lubomir Rintel
> ---
>
On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel wrote:
>
> The battery and the protocol are essentially the same as OLPC XO 1.5,
> but the responses from the EC are LSB first.
>
> Signed-off-by: Lubomir Rintel
> ---
> drivers/power/supply/olpc_battery.c | 23 ++-
> 1 file
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> Avoid using the x86 OLPC platform specific call to get the board
> version. It won't work on FDT-based ARM MMP2 platform.
>
> Signed-off-by: Lubomir Rintel
> ---
> drivers/power/supply/olpc_battery.c | 10 +++---
> 1 file changed, 7
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> According to [1] and [2], the temperature values are in tenths of degree
> Celsius. Exposing the Celsius value makes the battery appear on fire:
>
> $ upower -i /org/freedesktop/UPower/devices/battery_olpc_battery
> ...
>
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> Just return ENODEV, so that whoever attempted to use the EC call can
> defer their work.
>
> Signed-off-by: Lubomir Rintel
> ---
> drivers/platform/olpc/olpc-ec.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> Hi.
>
> This patchset adds support for the Embedded Controller on an OLPC XO
> 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into
> the existing OLPC platform infrastructure, currently used by the x86
> based models.
>
>
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> The XO-1 and XO-1.5 batteries apparently differ in an ability to report
> ambient temperature. Add a different compatible string to the 1.5
> battery.
> +int olpc_dt_compatible_match(phandle node, const char *compat)
> {
> char
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote:
>
> There are ARM OLPC machines that use mostly the same drivers, including
> EC infrastructure, DCON and Battery.
>
> While at that, fix Kconfig to allow building this as a module.
> - depends on MOUSE_PS2 && OLPC
> + depends on
On Fri, Oct 19, 2018 at 09:58:01AM +0300, Dan Carpenter wrote:
> Hi Marcin,
>
> Thank you for the patch! Perhaps something to improve:
>
> url:
> https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-164230
>
> smatch
On Tue, Oct 16, 2018 at 05:03:09AM -0700, Todd Poynor wrote:
> From: Nick Ewalt
>
> This allows for more precise dma_direction in the dma_map_page requests.
> Also leaves room for adding more flags later.
Why are you adding new features to this code? It needs to have stuff
cleaned up and
On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel wrote:
>
> This wouldn't work on the DT-based ARM platform. Let's read the EC version
> directly from the EC driver instead.
>
> This makes the driver no longer x86 specific.
>
> Signed-off-by: Lubomir Rintel
> ---
> drivers/power/supply/Kconfig
18 matches
Mail list logo
