Good Day,

2019-01-31 Thread Rt. Hon. Richard Shepherd
Dear Sir, 1. ACQUIRE OIL LICENSE. 2. EARN COMMISSION WITH THE LICENSE. I greet you with warm regards. I have a mandate from a refining outfit owned by an Angolan Government. I currently reside in the United Kingdom and work as a liaison officer to the Government. On my Desk is a mandate to

Good Day,

2019-01-31 Thread Rt. Hon. Richard Shepherd
Dear Sir, 1. ACQUIRE OIL LICENSE. 2. EARN COMMISSION WITH THE LICENSE. I greet you with warm regards. I have a mandate from a refining outfit owned by an Angolan Government. I currently reside in the United Kingdom and work as a liaison officer to the Government. On my Desk is a mandate to

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-31 Thread shuah
On 1/31/19 8:33 AM, Johan Hovold wrote: On Thu, Jan 31, 2019 at 04:18:33PM +0100, Marcel Holtmann wrote: I agree with Al that this change doesn't make much sense. The WARN_ON is there to catch any bugs leading to the termios being changed for a master side pty. Those should bugs should be

[PATCH 3/3] staging/android: simplify handle_vsoc_cond_wait

2019-01-31 Thread Hugo Lefeuvre
simplify handle_vsoc_cond_wait (drivers/staging/android/vsoc.c) using newly added wait_event_freezable_hrtimeout helper and remove useless includes. Signed-off-by: Hugo Lefeuvre --- drivers/staging/android/vsoc.c | 69 +- 1 file changed, 10 insertions(+), 59

[PATCH 1/3] sched/wait: use freezable_schedule when possible

2019-01-31 Thread Hugo Lefeuvre
Replace schedule(); try_to_freeze() by freezable_schedule(). Tasks calling freezable_schedule() set the PF_FREEZER_SKIP flag before calling schedule(). Unlike tasks calling schedule(); try_to_freeze() tasks calling freezable_schedule() are not awaken by try_to_freeze_tasks(). Instead they call

[PATCH 2/3] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-31 Thread Hugo Lefeuvre
introduce wait_event_freezable_hrtimeout, an interruptible and freezable version of wait_event_hrtimeout. Among others this helper will allow for simplifications in staging/android/vsoc.c. Signed-off-by: Hugo Lefeuvre --- include/linux/wait.h | 25 + 1 file changed, 21

Re: [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-31 Thread Hugo Lefeuvre
Hi, > I agree, it is probably better to use freezable_schedule() for all freeze > related wait APIs, and keep it consistent. Your analysis is convincing. I have submitted a new patchset which migrates the wait api to freezable_schedule() and splits the changes from the previous patch. regards,

[PATCH 0/3] sched/wait, staging/android: simplification and optimization of freeze related code

2019-01-31 Thread Hugo Lefeuvre
This patchset changes the wait api to use freezable_schedule when possible and adds a new wait_event_freezable_hrtimeout method. wait_event_freezable_hrtimeout is then used to greatly simplify handle_vsoc_cond_wait in the android vsoc driver. This reduces the size of the vsoc driver and allows

Re: [PATCH] drivers:staging: Fixed line more than 80 characters.

2019-01-31 Thread Dan Carpenter
The subsystem prefix isn't right. It should be" [PATCH] Staging: wlan-ng: Fixed line more than 80 characters On Wed, Jan 30, 2019 at 05:11:27PM +0100, Sandesh Kenjana Ashok wrote: > Lines over 80 characters are adjusted according to standards > > Signed-off-by: Sandesh Kenjana Ashok > --- >

Re: [PATCH] staging:rtlwifi:base.c Fixed line more than 80 characters

2019-01-31 Thread Dan Carpenter
On Wed, Jan 30, 2019 at 07:42:03PM +0100, SandeshKa07 wrote: > From: Sandesh Kenjana Ashok > Fix your email header so this isn't required. > Lines over 80 characters are adjusted according to standards. > > Signed-off-by: Sandesh Kenjana Ashok > --- > drivers/staging/rtlwifi/base.c | 3 ++-

Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-01-31 Thread Tianyu Lan
On Fri, Feb 1, 2019 at 3:07 PM Dan Carpenter wrote: > > On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1...@gmail.com wrote: > > > > > > This comment needs to be indented one tab or it looks like we're outside > the funciton. > > > +/* > > + * Hyper-V doesn't provide irq remapping for

Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-01-31 Thread Dan Carpenter
On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1...@gmail.com wrote: > > This comment needs to be indented one tab or it looks like we're outside the funciton. > +/* > + * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, > + * set x2apic destination mode to physcial mode

Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

2019-01-31 Thread Chen Feng
Thanks. On 2019/2/1 14:59, Qing Xia wrote: > In the first loop, gfp_flags will be modified to high_order_gfp_flags, > and there will be no chance to change back to low_order_gfp_flags. > > Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer > alloc") > Signed-off-by: Qing

[PATCH] staging: android: ion: fix sys heap pool's gfp_flags

2019-01-31 Thread Qing Xia
In the first loop, gfp_flags will be modified to high_order_gfp_flags, and there will be no chance to change back to low_order_gfp_flags. Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc") Signed-off-by: Qing Xia --- drivers/staging/android/ion/ion_system_heap.c

[PATCH 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode

2019-01-31 Thread lantianyu1986
From: Lan Tianyu On the bare metal, enabling X2APIC mode requires interrupt remapping function which helps to deliver irq to cpu with 32-bit APIC ID. Hyper-V doesn't provide interrupt remapping function so far and Hyper-V MSI protocol already supports to deliver interrupt to the CPU whose

[PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-01-31 Thread lantianyu1986
From: Lan Tianyu Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, set x2apic destination mode to physcial mode when x2apic is available and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs have 8-bit APIC id. Signed-off-by: Lan Tianyu ---

[PATCH] staging: rtl8188eu: cleanup ODM_CmnInfoPtrArrayHook()

2019-01-31 Thread Michael Straube
Convert single case switch to if statement to cleanup and simplify code in ODM_CmnInfoPtrArrayHook(). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c

Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-31 Thread Sakari Ailus
Hi Raj, On Wed, Jan 30, 2019 at 05:17:15PM +, Mani, Rajmohan wrote: > Hi Sakari, > > > -Original Message- > > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > > Sent: Wednesday, January 30, 2019 12:59 AM > > To: Mani, Rajmohan > > Cc: Mauro Carvalho Chehab ; Greg

Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-01-31 Thread Greg KH
On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, > set x2apic destination mode to physcial mode when x2apic is available > and Hyper-V IOMMU driver makes sure cpus assigned with

Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-01-31 Thread Tianyu Lan
Hi Greg: Thanks for your review. On Thu, Jan 31, 2019 at 7:57 PM Greg KH wrote: > > On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1...@gmail.com wrote: > > From: Lan Tianyu > > > > Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, > > set x2apic destination

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-01-31 Thread Sasha Levin
On Tue, Jan 29, 2019 at 07:20:28PM +, Dexuan Cui wrote: From: Kimberly Brown > ... > But as you pointed, at least for sub-channels, channel->ringbuffer_page > can indeed disappear in vmbus_close() -> ... -> vmbus_free_ring(), and > the "attribute->show()" could crash when the race happens.

RE: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-01-31 Thread Michael Kelley
From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM > > I've queued this one for hyper-fixes, thanks all! > Actually, please hold off on queuing this one. In a conversation I had yesterday with Kim, they had identified a deadlock. Kim was going to be looking at some revisions to

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-31 Thread Marcel Holtmann
Hi Johan, >>> On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARMN_ON which can be triggered with a syscall to invoke TIOCGETD __NR_ioctl. > > You meant TIOCSETD here, and in fact its the call which sets the uart > protocol that triggers

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-31 Thread Johan Hovold
On Thu, Jan 31, 2019 at 04:18:33PM +0100, Marcel Holtmann wrote: > > I agree with Al that this change doesn't make much sense. The WARN_ON > > is there to catch any bugs leading to the termios being changed for a > > master side pty. Those should bugs should be fixed, and not worked > > around in

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-01-31 Thread Kimberly Brown
On Thu, Jan 31, 2019 at 04:45:35PM +, Michael Kelley wrote: > From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM > > > > I've queued this one for hyper-fixes, thanks all! > > > > Actually, please hold off on queuing this one. In a conversation I had > yesterday with Kim, they had