To properly follow kernel style replace spaces with tabs in comment
where link status bits are explained.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/mt7621-pc
There are two definitions which are not being used at all.
Remove them.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt7621.c
index ad38
There is still a reset line which is not being handled using reset_control
properly and just being accessing writing registers. Use reset_control
instead for pcie general reset line.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 15 ++-
1 file change
This patch series make some minor cleanups of this driver in order
to prepare it to be promoted from staging. Changes are:
* use general pcie reset line in device tree and use reset_control
to handle it,
* some minor space-tabs issue.
* Some minor removes of not needed stuff.
After this changes, o
There is no need to write IO and memory space window Host PCI bridge
registers before doing anything else. Just use its default values which
should be ok.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/
Add general pci reset line to pcie bindings to use reset_control properly
in driver code.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-dts/mt7621.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi
b/drivers/staging
Mon, Feb 11, 2019 at 10:17:46PM CET, f.faine...@gmail.com wrote:
>Hi all,
>
>AFAICT there is no code that attempts to get the value of the attribute
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with
>switchdev_port_attr_set().
>
>This is effectively no doing anything and it can slow down f
Mon, Feb 11, 2019 at 10:17:47PM CET, f.faine...@gmail.com wrote:
>There is no code that will query the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
>attribute remove support for that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing lis
Mon, Feb 11, 2019 at 10:17:49PM CET, f.faine...@gmail.com wrote:
>There is no code that tries to get the attribute
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS, remove support for doing that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel ma
Mon, Feb 11, 2019 at 10:17:48PM CET, f.faine...@gmail.com wrote:
>There is no code that attempts to get the
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute, remove support for that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel maili
Hi Steve,
On Mon, 2019-02-11 at 17:20 -0800, Steve Longerbeam wrote:
[...]
> > Should we support YUV BT.601 <-> YUV REC.709 conversions? That would
> > require separate encodings for input and output.
>
> How about if we pass the input and output encodings to the init ic task
> functions, but fo
On Thu, Feb 07, 2019 at 08:36:32PM +, Dexuan Cui wrote:
>
> When we unload pci-hyperv, the host doesn't send us a PCI_EJECT message.
> In this case we also need to make sure the sysfs pci slot directory
> is removed, otherwise "cat /sys/bus/pci/slots/2/address" will trigger
> "BUG: unable to h
On Mon, Feb 11, 2019 at 11:09:53AM -0800, Florian Fainelli wrote:
> Update the section about switchdev drivers having to implement a
> switchdev_port_attr_get() function to return
> SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after
> commit bccb30254a4a ("net: Get rid of
> SWITCH
On Tue, Feb 12, 2019 at 12:28 AM Alistair Strachan wrote:
>
> On Mon, Feb 11, 2019 at 9:22 AM Todd Kjos wrote:
> >
> > +Alistair Strachan
> >
> > On Mon, Feb 11, 2019 at 9:11 AM Greg KH wrote:
> > >
> > > On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote:
> > > > On Mon, Feb 11, 2
On Mon, Feb 11, 2019 at 11:09:52AM -0800, Florian Fainelli wrote:
> Hi all,
>
> This patch series finishes by the removal of switchdev_ops. To get there
> we convert the existing switchdev_port_attr_{set,get} switchdev_ops to
> use a blocking notifier, thus making it consistent with how the object
On Mon, Feb 11, 2019 at 01:17:47PM -0800, Florian Fainelli wrote:
> There is no code that will query the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
> attribute remove support for that.
>
> Signed-off-by: Florian Fainelli
Reviewed-by: Ido Schimmel
___
devel m
On Mon, Feb 11, 2019 at 11:09:54AM -0800, Florian Fainelli wrote:
> In preparation for allowing switchdev enabled drivers to veto specific
> attribute settings from within the context of the caller, introduce a
> new switchdev notifier type for port attributes.
>
> Suggested-by: Ido Schimmel
> Ac
Tue, Feb 12, 2019 at 02:14:47PM CET, ido...@mellanox.com wrote:
>On Mon, Feb 11, 2019 at 11:09:52AM -0800, Florian Fainelli wrote:
>> Hi all,
>>
>> This patch series finishes by the removal of switchdev_ops. To get there
>> we convert the existing switchdev_port_attr_{set,get} switchdev_ops to
>>
On Mon, Feb 11, 2019 at 11:09:56AM -0800, Florian Fainelli wrote:
> Following patches will change the way we communicate getting or setting
> a port's attribute and use a blocking notifier to perform those tasks.
>
> Prepare mlxsw to support receiving notifier events targeting
> SWITCHDEV_PORT_ATT
On Mon, Feb 11, 2019 at 11:10:01AM -0800, Florian Fainelli wrote:
> Now that we have converted all possible callers to using a switchdev
> notifier for attributes we do not have a need for implementing
> switchdev_ops anymore, and this can be removed from all drivers the
> net_device structure.
>
On Sun, Feb 10, 2019 at 11:34:14AM -0800, Florian Fainelli wrote:
> Le 2/10/19 à 11:05 AM, Ido Schimmel a écrit :
> > On Sun, Feb 10, 2019 at 09:50:55AM -0800, Florian Fainelli wrote:
> >> Now that all switchdev drivers have been converted to checking the
> >> bridge port flags during the prepare p
On Tue, Feb 05, 2019 at 07:44:31PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 05, 2019 at 08:36:24PM +0530, Nishad Kamdar wrote:
> > This patch corrects the style for SPDX license Identifier in mac.h
> > by using "/* */" in place of "//" as per Linux kernel licensing rules.
> > Issue found by c
On Mon, Jan 28, 2019 at 09:49:32PM -0800, Maya Nakamura wrote:
> On Sun, Jan 27, 2019 at 05:11:48AM +, Michael Kelley wrote:
> > From: Maya Nakamura Sent: Saturday, January
> > 26, 2019 12:52 AM
> > >
> > > Remove a duplicate definition of VP set (hv_vp_set) and use the common
> > > definit
On 2/12/19 3:34 AM, Philipp Zabel wrote:
Hi Steve,
On Mon, 2019-02-11 at 17:20 -0800, Steve Longerbeam wrote:
[...]
Should we support YUV BT.601 <-> YUV REC.709 conversions? That would
require separate encodings for input and output.
How about if we pass the input and output encodings to th
From: Florian Fainelli
Date: Mon, 11 Feb 2019 13:17:46 -0800
> AFAICT there is no code that attempts to get the value of the attribute
> SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with
> switchdev_port_attr_set().
>
> This is effectively no doing anything and it can slow down future wo
On 2/12/19 9:50 AM, David Miller wrote:
> From: Florian Fainelli
> Date: Mon, 11 Feb 2019 13:17:46 -0800
>
>> AFAICT there is no code that attempts to get the value of the attribute
>> SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with
>> switchdev_port_attr_set().
>>
>> This is effectivel
Add missing break statement in order to prevent the code from falling
through to the default case and return -EINVAL every time.
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: 58dd7c0a2a6e ("Staging: comedi: add ni_660x driver")
Cc: sta...@vger.kernel.or
Add missing break statement in order to prevent the code from falling
through to the default case and return -EINVAL every time.
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: aa94f225 ("staging: comedi: ni_660x: tidy up
ni_660x_set_pfi_routing()")
Hi,
Please, drop this.
I've just sent v2 with the right Fixes tag:
https://lore.kernel.org/patchwork/patch/1041301/
Thanks
--
Gustavo
On 2/12/19 12:08 PM, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to the default case and return
Rename function cpMacAddr to copy_mac_addr in order to fix checkpatch
warning: Avoid CamelCase and make the function name more readable,
understandable.
---
Changes in V2:
Properly wrap commit message at 72 columns.
Signed-off-by: Himadri Pandya
---
drivers/staging/rtl8192e/dot11d.h | 4
I guess this patch has not been reviewed yet. Please let me know if it
needs revision.
Thank you.
- Himadri
On 10/02/19 2:13 PM, Himadri Pandya wrote:
Rename following macro arguments to fix checkpatch warning: Avoid
Camelcase and make the arguments more readable, understandable.
__pI
On Wed, Feb 13, 2019 at 01:14:38AM +0530, Himadri Pandya wrote:
> Rename function cpMacAddr to copy_mac_addr in order to fix checkpatch
> warning: Avoid CamelCase and make the function name more readable,
> understandable.
> ---
> Changes in V2:
> Properly wrap commit message at 72 columns.
>
On 13/02/19 1:25 AM, Dan Carpenter wrote:
On Wed, Feb 13, 2019 at 01:14:38AM +0530, Himadri Pandya wrote:
Rename function cpMacAddr to copy_mac_addr in order to fix checkpatch
warning: Avoid CamelCase and make the function name more readable,
understandable.
---
Changes in V2:
Properly
Rename function cpMacAddr to copy_mac_addr in order to fix checkpatch
warning: Avoid CamelCase and make the function name more readable,
understandable.
Signed-off-by: Himadri Pandya
---
Changes in V2:
Properly wrap commit message at 72 columns.
---
drivers/staging/rtl8192e/dot11d.h | 4
On 2/12/19 9:54 AM, Florian Fainelli wrote:
> On 2/12/19 9:50 AM, David Miller wrote:
>> From: Florian Fainelli
>> Date: Mon, 11 Feb 2019 13:17:46 -0800
>>
>>> AFAICT there is no code that attempts to get the value of the attribute
>>> SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with
>>>
> From: Lorenzo Pieralisi
> Sent: Tuesday, February 12, 2019 4:13 AM
> ...
> This patch fixes three bugs:
>
> 1) set hpdev->pci_slot to NULL
> 2) move code destroying the slot inside a locked region in
>hv_eject_device_work()
> 3) Add missing slots removal code in hv_pci_remove()
>
> We nee
On Tue, Feb 12 2019, Sergio Paracuellos wrote:
> This patch series make some minor cleanups of this driver in order
> to prepare it to be promoted from staging. Changes are:
> * use general pcie reset line in device tree and use reset_control
> to handle it,
> * some minor space-tabs issue.
> * So
From: Lorenzo Pieralisi Sent: Tuesday, February
12, 2019 8:35 AM
>
> On Mon, Jan 28, 2019 at 09:49:32PM -0800, Maya Nakamura wrote:
> > On Sun, Jan 27, 2019 at 05:11:48AM +, Michael Kelley wrote:
> > > From: Maya Nakamura Sent: Saturday, January
> > > 26,
> 2019 12:52 AM
> > > >
> > > > R
On 2019/2/12 11:24, Chengguang Xu wrote:
> unlikely has already included in IS_ERR(),
> so just remove redundant likely/unlikely
> annotation.
>
> Signed-off-by: Chengguang Xu
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproj
On 2019/2/12 11:24, Chengguang Xu wrote:
> unlikely has already included in IS_ERR(),
> so just remove it.
>
> Signed-off-by: Chengguang Xu
It looks like we don't need to send two patch to fix two similar
issues, if you can merge them, it will be better.
Reviewed-by: Chao Yu
Thanks,
Hi Neil,
On Wed, Feb 13, 2019 at 1:24 AM NeilBrown wrote:
>
> On Tue, Feb 12 2019, Sergio Paracuellos wrote:
>
> > This patch series make some minor cleanups of this driver in order
> > to prepare it to be promoted from staging. Changes are:
> > * use general pcie reset line in device tree and us
41 matches
Mail list logo
