Re: pidfd design

2019-03-28 Thread Christian Brauner
On Mon, Mar 25, 2019 at 05:24:49PM -0700, Andy Lutomirski wrote: > On Mon, Mar 25, 2019 at 5:12 PM Christian Brauner > wrote: > > > > On Mon, Mar 25, 2019 at 05:00:17PM -0700, Andy Lutomirski wrote: > > > On Mon, Mar 25, 2019 at 4:45 PM Christian Brauner > > > wrote: > > > > > > > > On Mon, Mar

[PATCH v2] staging: pi433: Fix rf69_set_tx_cfg() logic

2019-03-28 Thread Sidong Yang
Moved code to configure sync to where check enable_sync option before. There is no need to check enable_sync twice. Configuring sync should be executed immediately after enabling sync. Signed-off-by: Sidong Yang --- v2: remove obvious comment. reordered size/value/enable sync functions. drivers

Re: [PATCH v2] staging: rtl8723bs: core: fix line over 80 characters warning

2019-03-28 Thread Joe Perches
On Wed, 2019-03-27 at 23:49 +0530, Anirudh Rayabharam wrote: > Checkpatch.pl complains that these lines are over 80 characters. Use the > "psecuritypriv" pointer for consistency, remove unnecessary parantheses > and fix the alignment. > > This patch just cleans up a condition, it doesn't affect ru

[PATCH v2 06/14] staging: most: core: make sysfs attributes read-only

2019-03-28 Thread Christian Gromm
This patch changes the access flags of the channel attributes to read-only. This is needed, because configuration is done via configfs. Signed-off-by: Christian Gromm --- v2: drivers/staging/most/core.c | 122 +++- 1 file changed, 7 insertions(+), 115 del

[PATCH v2 02/14] staging: most: change signature of function probe_channel

2019-03-28 Thread Christian Gromm
This patch adds the param argument to the function parameter of the call-back probe_channel. This parameter is needed to configure the channels of an attached device. Signed-off-by: Christian Gromm --- v2: drivers/staging/most/cdev/cdev.c | 2 +- drivers/staging/most/core.c| 6 --

[PATCH v2 14/14] staging: most: Documentation: update driver documentation

2019-03-28 Thread Christian Gromm
This patch updates the driver documentation files to reflect the latest changes regarding configfs. Signed-off-by: Christian Gromm v2: - changed kernel version to 5.2 --- .../most/Documentation/ABI/configfs-most.txt | 204 + .../staging/most/Documentation/drive

[PATCH v2 05/14] staging: most: enable configfs support

2019-03-28 Thread Christian Gromm
This patch enables the configfs functionality of the driver by registering the configfs subsystems and compiling the configfs part of the sources. Signed-off-by: Christian Gromm --- v2: - remove call to configfs_exit function drivers/staging/most/Makefile | 1 + drivers/staging/mo

[PATCH v2 12/14] staging: most: configfs: add code for link removal

2019-03-28 Thread Christian Gromm
This patch adds code that cleans up established links whenever the destroy attribute is set or if the config_item (directory) is being removed. Signed-off-by: Christian Gromm --- v2: - follow-up adaptions due to changes introduced w/ [PATCH v2 01/14] drivers/staging/most/configfs.c | 38

[PATCH v2 13/14] staging: most: configfs: rename config attributes

2019-03-28 Thread Christian Gromm
This patch introduces attribute names that are more self explaining. Signed-off-by: Christian Gromm --- v2: - follow-up adaptions due to changes introduced w/ [PATCH v2 01/14] drivers/staging/most/configfs.c | 97 + 1 file changed, 49 insertions(+

[PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-28 Thread Christian Gromm
This patch adapts the sound card management to the configfs changes. Signed-off-by: Christian Gromm --- v2: drivers/staging/most/sound/sound.c | 41 +- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/drivers/staging/most/sound/sound.c b/drive

[PATCH v2 03/14] staging: most: core: add configfs interface functions

2019-03-28 Thread Christian Gromm
This patch adds the core's interface to configfs file. Signed-off-by: Christian Gromm --- v2: - remove configfs_exit prototype drivers/staging/most/core.c | 142 drivers/staging/most/core.h | 16 - 2 files changed, 157 insertions(+), 1 d

[PATCH v2 08/14] staging: most: usb: remove prefix from description tag

2019-03-28 Thread Christian Gromm
This patch cuts off the usb_device prefix of the description string. It is not needed, as the interface type is already available with the interface attribute of a channel. Signed-off-by: Christian Gromm --- v2: drivers/staging/most/usb/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v2 07/14] staging: most: core: use device description as name

2019-03-28 Thread Christian Gromm
This patch uses the device description to clearly identity a device attached to the bus. It is needed as the currently useed mdevX notation is not sufficiant in case more than one network interface controller is being used at the same time. Signed-off-by: Christian Gromm --- v2: drivers/staging

[PATCH v2 11/14] staging: most: configfs: make create attributes write-only

2019-03-28 Thread Christian Gromm
Reading the create attribute that triggers the creation of a link to a certain channel is not necessary. Hence, it is being removed. Signed-off-by: Christian Gromm --- v2: drivers/staging/most/configfs.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH v2 00/14] staging: most: switch to configfs

2019-03-28 Thread Christian Gromm
This patch set makes the driver provide its configuration interface via configfs. The configuration interface is being switched to simplify the process of setting up the driver and to introduce the new feature of speculative configuration. v2: Christian Gromm (14): staging: most: add new file c

[PATCH v2 01/14] staging: most: add new file configfs.c

2019-03-28 Thread Christian Gromm
This patch adds the file configfs.c to the driver directory. The file registers the necessary subsystems with configfs in order to move the driver configuration from sysfs to configfs. Signed-off-by: Christian Gromm --- v2: Reported-by: Dan Carpenter - remove unnecessary variable init

[PATCH v2 09/14] staging: most: core: remove attribute add_link

2019-03-28 Thread Christian Gromm
This patch removes the driver attribute add_link. It is not needed, because the link management is now done via configfs. Signed-off-by: Christian Gromm --- v2: drivers/staging/most/core.c | 61 - 1 file changed, 61 deletions(-) diff --git a/drivers/

[PATCH v2 10/14] staging: most: allow speculative configuration

2019-03-28 Thread Christian Gromm
This patch makes the driver accept a link confiiguration eventhough no device is attached to the bus. Instead the configuration is being applied as soon as a device is being registered with the core. Signed-off-by: Christian Gromm --- v2: - follow-up adaptions due to changes introduced w/

Re: [PATCH v2 01/14] staging: most: add new file configfs.c

2019-03-28 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 02:17:29PM +0100, Christian Gromm wrote: > +static ssize_t mdev_link_direction_store(struct config_item *item, > + const char *page, size_t count) > +{ > + struct mdev_link *mdev_link = to_mdev_link(item); > + > + if (sysfs_streq(

Re: [PATCH v2 03/14] staging: most: core: add configfs interface functions

2019-03-28 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 02:17:31PM +0100, Christian Gromm wrote: > +int most_set_cfg_direction(char *mdev, char *mdev_ch, char *buf) > +{ > + struct most_channel *c = get_channel(mdev, mdev_ch); > + > + if (!c) > + return -ENODEV; > + if (!strcmp(buf, "dir_rx\n")) { > +

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-28 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > +static int audio_create_sound_card(void) > +{ > + int ret; > + struct sound_adapter *adpt; > + > + list_for_each_entry(adpt, &adpt_list, list) { > + if (!adpt->registered) > + goto adpt_a

Re: [PATCH v2 10/14] staging: most: allow speculative configuration

2019-03-28 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 02:17:38PM +0100, Christian Gromm wrote: > This patch makes the driver accept a link confiiguration eventhough no > device is attached to the bus. Instead the configuration is being applied > as soon as a device is being registered with the core. > > Signed-off-by: Christia

Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

2019-03-28 Thread Dan Carpenter
On Wed, Mar 27, 2019 at 11:43:20PM +, David Howells wrote: > +static void binderfs_free_fc(struct fs_context *fc) > +{ > + struct binderfs_info *info = fc->s_fs_info; > + > + if (info) { > + struct ipc_namespace *ipc_ns = fc->s_fs_info; > + put_ipc_ns(ipc_ns); I

Re: [PATCH 2/2] dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHY

2019-03-28 Thread Rob Herring
On Thu, Mar 14, 2019 at 02:22:10PM +0100, Sergio Paracuellos wrote: > Add bindings to describe Mediatek MT7621 PCIe PHY. Binding should come before the driver. > > Signed-off-by: Sergio Paracuellos > --- > .../bindings/phy/mediatek,mt7621-pci-phy.txt | 54 +++ > 1 file changed

Re: [PATCH 2/2] dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHY

2019-03-28 Thread Sergio Paracuellos
Hi Rob, Thanks for the review. On Thu, Mar 28, 2019 at 4:42 PM Rob Herring wrote: > > On Thu, Mar 14, 2019 at 02:22:10PM +0100, Sergio Paracuellos wrote: > > Add bindings to describe Mediatek MT7621 PCIe PHY. > > Binding should come before the driver. Do you mean this should be PATCH 1 of the s

kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1a9df9e2 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11fed11f20 kernel config: https://syzkaller.appspot.com/x/.config?x=8dcdce25ea72bedf da

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread Todd Kjos
The fix for this is in Greg KH's char-misc-linus branch. Pointing syzbot at it to verify: #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus On Thu, Mar 28, 2019 at 9:14 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD comm

[PATCH 0/3] staging: mt7621-pci-phy: simplify driver to don't use child nodes in DT

2019-03-28 Thread Sergio Paracuellos
This series change both bindings and driver to don't use child nodes in the device tree. This changes are inspired after Rob's bindings review which can be found here: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-March/133123.html Hope this helps. Best regards, Se

[PATCH 1/3] staging: mt7621-dts: simplify pcie phy bindings

2019-03-28 Thread Sergio Paracuellos
If each phy port doesn't have its own resources, then we don't need child nodes. Handle it using #phy-cells to 1 or 0 conveniently. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --

[PATCH 3/3] staging: mt7621-pci-phy: change driver to don't use child nodes

2019-03-28 Thread Sergio Paracuellos
Device tree has been simplified to don't use child nodes and use the #phy-cells property instead. Change the driver accordly implementing custom 'xlate' function to return the correct phy for each port. Signed-off-by: Sergio Paracuellos --- .../staging/mt7621-pci-phy/pci-mt7621-phy.c | 26

[PATCH 2/3] staging: mt7621-pci-phy: update bindings documentation

2019-03-28 Thread Sergio Paracuellos
Device tree has been simplified to use phy-cells instead of using child nodes. Update documentation accordly. Signed-off-by: Sergio Paracuellos --- .../mediatek,mt7621-pci-phy.txt | 44 --- 1 file changed, 9 insertions(+), 35 deletions(-) diff --git a/drivers/stagi

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
Hello, syzbot tried to test the proposed patch but build/boot failed: patch is already applied Tested on: commit: 0532a1b0 virt: vbox: Implement passing requestor info to t.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus compil

[PATCH] staging: erofs: keep corrupted fs from crashing kernel in erofs_readdir()

2019-03-28 Thread Gao Xiang
From: Gao Xiang After commit 419d6efc50e9, kernel cannot be crashed in the namei path. However, corrupted nameoff can do harm in the process of readdir for scenerios without dm-verity as well. Fix it now. Fixes: 3aa8ec716e52 ("staging: erofs: add directory operations") Cc: # 4.19+ Signed-off-by

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
syzbot has bisected this bug to: commit 1a7c3d9bb7a926e88d5f57643e75ad1abfc55013 Author: Todd Kjos Date: Fri Feb 8 18:35:14 2019 + binder: create userspace-to-binder-buffer copy function bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15b9383f20 start commit: 1a9df

[PATCH] staging: wlan-ng: Shorten excessively long p80211 constants

2019-03-28 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov --- drivers/staging/wlan-ng/cfg80211.c | 48 +++--- drivers/staging/wlan-ng/p80211metadef.h | 278 +--- drivers/staging/wlan-ng/p80211netdev.c | 8 +- drivers/staging/wlan-ng/p80211req.c | 28 ++-- drivers/staging/wlan-ng/p8

[PATCH] staging: rtl8192u: fix incorrect mask for EEPROMTxPowerLevelCCK setting

2019-03-28 Thread Colin King
From: Colin Ian King Currently the lower 8 bits of ret are being masked and left shifted by 8 bits always leaving a result of zero. The mask appears to be incorrect and should probably be 0xff00 instead of 0xff. Fix this. (Note: not tested). Fixes: 16feab644fd1 ("staging: rtl8192u: check retur

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread syzbot
Hello, syzbot tried to test the proposed patch but build/boot failed: timed out Tested on: commit: 0532a1b0 virt: vbox: Implement passing requestor info to t.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus kernel config: h

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-28 Thread Todd Kjos
Sigh. One more try... master with the same patch as an attachment. (the patch is already queued up in gregkh's 'char-misc-linus' branch). #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git master On Thu, Mar 28, 2019 at 5:20 PM syzbot wrote: > > Hello, > > syzbot tr

Re: [PATCH 1/3] staging: mt7621-dts: simplify pcie phy bindings

2019-03-28 Thread NeilBrown
On Thu, Mar 28 2019, Sergio Paracuellos wrote: > If each phy port doesn't have its own resources, then we don't need > child nodes. Handle it using #phy-cells to 1 or 0 conveniently. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/mt7621-dts/mt7621.dtsi | 23 +++

Re: [PATCH 3/3] staging: mt7621-pci-phy: change driver to don't use child nodes

2019-03-28 Thread NeilBrown
On Thu, Mar 28 2019, Sergio Paracuellos wrote: > Device tree has been simplified to don't use child nodes and use > the #phy-cells property instead. Change the driver accordly implementing > custom 'xlate' function to return the correct phy for each port. > > Signed-off-by: Sergio Paracuellos > -

[PATCH v2 2/3] staging: mt7621-pci-phy: update bindings documentation

2019-03-28 Thread Sergio Paracuellos
Device tree has been simplified to use phy-cells instead of using child nodes. Update documentation accordly. Signed-off-by: Sergio Paracuellos --- .../mediatek,mt7621-pci-phy.txt | 44 --- 1 file changed, 9 insertions(+), 35 deletions(-) diff --git a/drivers/stagi

[PATCH v2 3/3] staging: mt7621-pci-phy: change driver to don't use child nodes

2019-03-28 Thread Sergio Paracuellos
Device tree has been simplified to don't use child nodes and use the #phy-cells property instead. Change the driver accordly implementing custom 'xlate' function to return the correct phy for each port. Signed-off-by: Sergio Paracuellos --- .../staging/mt7621-pci-phy/pci-mt7621-phy.c | 26

[PATCH v2 1/3] staging: mt7621-dts: simplify pcie phy bindings

2019-03-28 Thread Sergio Paracuellos
If each phy port doesn't have its own resources, then we don't need child nodes. Handle it using #phy-cells to 1 for both phy's. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git

[PATCH v2 0/3] staging: mt7621-pci-phy: simplify driver to don't use child nodes in DT

2019-03-28 Thread Sergio Paracuellos
This series change both bindings and driver to don't use child nodes in the device tree. This changes are inspired after Rob's bindings review which can be found here: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-March/133123.html Changes in v2: - Use #phy_cells=1

Re: [PATCH 1/3] staging: mt7621-dts: simplify pcie phy bindings

2019-03-28 Thread Sergio Paracuellos
Hi Neil, Thanks for the feedback. On Fri, Mar 29, 2019 at 4:01 AM NeilBrown wrote: > > On Thu, Mar 28 2019, Sergio Paracuellos wrote: > > > If each phy port doesn't have its own resources, then we don't need > > child nodes. Handle it using #phy-cells to 1 or 0 conveniently. > > > > Signed-off-b

Re: [PATCH 3/3] staging: mt7621-pci-phy: change driver to don't use child nodes

2019-03-28 Thread Sergio Paracuellos
On Fri, Mar 29, 2019 at 4:06 AM NeilBrown wrote: > > On Thu, Mar 28 2019, Sergio Paracuellos wrote: > > > Device tree has been simplified to don't use child nodes and use > > the #phy-cells property instead. Change the driver accordly implementing > > custom 'xlate' function to return the correct

Re: [PATCH v2 0/3] staging: mt7621-pci-phy: simplify driver to don't use child nodes in DT

2019-03-28 Thread NeilBrown
On Fri, Mar 29 2019, Sergio Paracuellos wrote: > This series change both bindings and driver to don't use child nodes in the > device tree. > > This changes are inspired after Rob's bindings review which can be found here: > > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019

Re: [PATCH] staging: wlan-ng: Shorten excessively long p80211 constants

2019-03-28 Thread Greg Kroah-Hartman
On Thu, Mar 28, 2019 at 11:53:29PM +, Mikhail Gusarov wrote: > Signed-off-by: Mikhail Gusarov > --- I can not take patches without any changelog text at all, sorry. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverpro

[PATCH v2] staging: wlan-ng: Shorten excessively long p80211 constants

2019-03-28 Thread Mikhail Gusarov
drivers/staging/wlan-ng/p80211metadef.h was generated before submitting to Linux, so it contains long constants and ugly code. - Shorten macro names for DIDMSG_*/DIDMIB_* constants generators - Drop repeating prefixes from DIDMSG_*/DIDMIB_* constants - Use abbreviations where spelling full words i

Re: [PATCH] staging: erofs: keep corrupted fs from crashing kernel in erofs_readdir()

2019-03-28 Thread Chao Yu
On 2019/3/29 4:14, Gao Xiang wrote: > From: Gao Xiang > > After commit 419d6efc50e9, kernel cannot be crashed in the namei > path. However, corrupted nameoff can do harm in the process of > readdir for scenerios without dm-verity as well. Fix it now. > > Fixes: 3aa8ec716e52 ("staging: erofs: add

Re: [PATCH v2] staging: wlan-ng: Shorten excessively long p80211 constants

2019-03-28 Thread Greg Kroah-Hartman
On Fri, Mar 29, 2019 at 06:25:09AM +, Mikhail Gusarov wrote: > drivers/staging/wlan-ng/p80211metadef.h was generated before > submitting to Linux, so it contains long constants and > ugly code. > > - Shorten macro names for DIDMSG_*/DIDMIB_* constants generators > - Drop repeating prefixes fro