Hi Jonathan, Alex,
Thanks for the review. Some comments inline.
Thanks,
Renato
On 05/20, Ardelean, Alexandru wrote:
On Sun, 2019-05-19 at 12:32 +0100, Jonathan Cameron wrote:
[External]
On Sat, 18 May 2019 19:41:12 -0300
Renato Lui Geh wrote:
> This patch adds a YAML binding for the
On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandström wrote:
> Fixes build errors:
>
> ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
> ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
> ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
> ERROR: "__uio_register_device" [kpc2000.ko]
On Sat, May 25, 2019 at 12:26:42PM +0800, Mao Wenan wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/kpc2000/kpc_spi/spi_driver.c: In function
> ‘kp_spi_transfer_one_message’:
> drivers/staging/kpc2000/kpc_spi/spi_driver.c:282:9: warning: variable
> ‘status’ set but not
Fixes two minor typos in kpc2000's Kconfig: s/Kaktronics/Daktronics
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
index
Fixes build errors:
ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
ERROR: "__uio_register_device" [kpc2000.ko] undefined!
Signed-off-by: Simon Sandström
---
Hi,
Here are two patches that fixes issues in kpc2000's Kconfig.
The first one is a typo fix (I'm guessing Kaktronics is a typo...).
The second one is a fix for a dependency issues I met when trying to
build kpc2000 on a default x86_64 config. I'm not familiar with neither
MFD nor UIO, so I'm
This patchset converts the old ad7780 device-tree binding to
the new YAML format, and adds an entry to MAINTAINERS.
Renato Lui Geh (2):
dt-bindings: iio: adc: add adi,ad7780.yaml binding
MAINTAINERS: add entry for ad7780 adc driver
.../bindings/iio/adc/adi,ad7780.txt | 48 --
This patch adds a MAINTAINERS entry for the AD7780 ADC driver.
Signed-off-by: Renato Lui Geh
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 54c8e14fae98..d12685c5b09a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -880,6 +880,15 @@ S:
This patch adds a YAML binding for the Analog Devices AD7780/1 and
AD7170/1 analog-to-digital converters.
Signed-off-by: Renato Lui Geh
---
Changes in v2:
- vref-supply to avdd-supply
- remove avdd-supply from required list
- include adc block in an spi block
Bitte hilf mir, diesen Traum zu verwirklichen.
Ich bin Frau Flora Michael aus Kanada. Ich bin mit Herrn Kellen Michael
verheiratet, der neun Jahre lang mit der kanadischen Botschaft hier in der
Republik Benin gearbeitet hat, bevor er 2015 starb. Wir waren elf Jahre ohne
Kind verheiratet. Er
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/kpc2000/kpc_spi/spi_driver.c: In function
‘kp_spi_transfer_one_message’:
drivers/staging/kpc2000/kpc_spi/spi_driver.c:282:9: warning: variable
‘status’ set but not used [-Wunused-but-set-variable]
int status = 0;
^~
On Thu, May 23, 2019 at 04:30:00PM -0400, Sven Van Asbroeck wrote:
> Add myself as the maintainer of the anybuss bus driver, and its client
> drivers.
>
> Signed-off-by: Sven Van Asbroeck
> ---
> MAINTAINERS | 5 +
> 1 file changed, 5 insertions(+)
What changed from v1?
Always list that
>-Original Message-
>From: devel On Behalf Of Greg
>KH
>On Fri, May 24, 2019 at 01:19:26PM +0100, Jeremy Sowden wrote:
>> kp2000_check_uio_irq contained a pair of nested ifs which each evaluated
>> a bitwise operation. If both operations yielded true, the function
>> returned 1;
Function "rtw_sta_flush" always returns 0 value.
So change return type of rtw_sta_flush from int to void.
Same thing applies for rtw_hostapd_sta_flush
Signed-off-by: Hariprasad Kelam
-
Changes v2 -
change return type of rtw_sta_flush
Changes v3 -
fix indentaion issue
Changes
Add myself as the maintainer of the anybuss bus driver, and its client
drivers.
Signed-off-by: Sven Van Asbroeck
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 50e164041e94..2b9223be10b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@
Add myself as the maintainer of the fieldbus subsystem.
Signed-off-by: Sven Van Asbroeck
---
v3:
resend, no changes, forgot to attach history to patch set
v2:
add Documentation directory to maintainer entry for fieldbus,
suggested by Joe Perches
v1:
On Thu, May 23, 2019 at 05:46:39PM +0200, Tianzheng Li wrote:
> This patch removes unnecessary quoted string splits.
>
> Reported-by: Jie Zhang
> Signed-off-by: Tianzheng Li
> ---
> drivers/staging/gasket/gasket_core.c | 6 ++
> drivers/staging/gasket/gasket_ioctl.c | 3 +--
>
On Fri, May 24, 2019 at 11:22:38AM +0530, Nishka Dasgupta wrote:
> The initial value of return variable ret is never used, so it can be
> removed.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/ks7010/ks_hostif.c | 2 +-
> 1 file changed, 1
On Fri, May 24, 2019 at 12:31:19PM +0530, Nishka Dasgupta wrote:
> On 24/05/19 12:22 PM, Greg KH wrote:
> > On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
> > > As the initial value of the return variable result is never used, it can
> > > be removed.
> > > Issue found with
On Do, 2019-05-23 at 18:53 +0530, Nishka Dasgupta wrote:
> External E-Mail
>
>
> Remove variable frame_size as its multiple usages are all independent
> of
> each other and so can be returned separately.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
Acked-by: Christian
The return variable is used only twice (in two different branches), and
both times it is assigned the same constant value. These can therefore
be merged into the same assignment, placed at the point that both
these branches (and no other) go to. The return variable itself can be
removed.
Issue
The initial value of return variable ret, -1, is never used and hence
can be removed.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/gdm724x/gdm_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_usb.c
On Fri, May 24, 2019 at 03:02:48AM +, Geordan Neukum wrote:
> On Fri, May 24, 2019 at 2:38 AM Geordan Neukum wrote:
> > + depends on MFD_CORE
>
> In order for this to work in menuconfig, this either needs to be a
> select or I need to
> add a prompt to MFD_CORE. I don't have strong
On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote:
>
> This patch adds of_match_table entry in device driver in order to
> enable spi fallback probing.
>
> Signed-off-by: Rodrigo Ribeiro
> Reviewed-by: Marcelo Schmitt
> ---
> drivers/staging/iio/accel/adis16240.c | 1 +
> 1 file changed, 1
On Fri, May 24, 2019 at 11:30:25AM +0530, Nishka Dasgupta wrote:
> The initial value of return variable ret, -1, is never used and hence
> can be removed.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/gdm724x/gdm_usb.c | 2 +-
> 1 file changed, 1
On Fri, May 24, 2019 at 11:30:26AM +0530, Nishka Dasgupta wrote:
> The return variable is used only twice (in two different branches), and
> both times it is assigned the same constant value. These can therefore
> be merged into the same assignment, placed at the point that both
> these branches
On Fri, May 24, 2019 at 11:33:28AM +0530, Nishka Dasgupta wrote:
> The local variable cd, used in multiple functions, is immediately passed
> to another function call, whose result is returned. As that is the only
> use of cd, it can be replaced with its variable.
> Issue found with Coccinelle.
>
On 24/05/19 12:22 PM, Greg KH wrote:
On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
As the initial value of the return variable result is never used, it can
be removed.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/ks7010/ks7010_sdio.c | 2
On Thu, May 23, 2019 at 11:40:09PM +0530, Hariprasad Kelam wrote:
> Function "rtw_sta_flush" always returns 0 value. So change
> return type of rtw_sta_flush from int to void.
Odd line wrapping :(
Also your subject line is missing a trailing '"' character :(
v5?
thanks,
greg k-h
The local variable cd, used in multiple functions, is immediately passed
to another function call, whose result is returned. As that is the only
use of cd, it can be replaced with its variable.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
> As the initial value of the return variable result is never used, it can
> be removed.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 2 +-
> 1 file changed, 1
The initial value of return variable result is never used, so it can be
removed.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
Changes in v2:
- Fixed typo in commit message
- Clarified subject line to include filename
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed,
On Fri, May 24, 2019 at 01:36:22PM +0530, Nishka Dasgupta wrote:
> As the initial value of the return variable result is never used, it can
> be removed.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> Changes in v2:
> - Clarified subject line
Your subject line is an
On Do, 2019-05-23 at 18:51 +0200, Greg KH wrote:
> External E-Mail
>
>
> On Thu, May 23, 2019 at 06:53:34PM +0530, Nishka Dasgupta wrote:
> >
> > Remove variable frame_size as its multiple usages are all
> > independent of
> > each other and so can be returned separately.
> > Issue found with
As the initial value of the return variable result is never used, it can
be removed.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
Changes in v2:
- Clarified subject line
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The function hostif_data_request had two return variables, ret and
result. When ret is assigned a value, in all cases (except one) this
assignment is followed immediately by a goto to the end of the
function. In the last case, the goto takes effect only if ret < 0;
however, if ret >= 0 then this
Hi,
Here is a new version of the H264 decoding support in the cedrus
driver.
As you might already know, the cedrus driver relies on the Request
API, and is a reverse engineered driver for the video decoding engine
found on the Allwinner SoCs.
This work has been possible thanks to the work done
From: Pawel Osciak
Stateless video codecs will require both the H264 metadata and slices in
order to be able to decode frames.
This introduces the definitions for the structures used to pass the
metadata from the userspace to the kernel.
Reviewed-by: Paul Kocialkowski
Reviewed-by: Tomasz Figa
From: Maxime Ripard
The H264_SLICE_RAW format introduced before is meant for stateless
decoders that will need the H264 parsed slice data without the start code.
Let's document it.
Signed-off-by: Maxime Ripard
Signed-off-by: Hans Verkuil
---
.../media/uapi/v4l/pixfmt-compressed.rst |
From: Maxime Ripard
The H264_SLICE_RAW format is meant to hold the parsed slice data without
the start code. This will be needed by stateless decoders.
Signed-off-by: Maxime Ripard
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/media/h264-ctrls.h
This introduces the required definitions for HEVC decoding support with
stateless VPUs. The controls associated to the HEVC slice format provide
the required meta-data for decoding slices extracted from the bitstream.
They are not exported to the public V4L2 API since reworking this API
will be
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
both uni-directional and bi-directional prediction modes supported.
Field-coded (interlaced) pictures, custom quantization matrices and
10-bit output are not supported at this point.
Signed-off-by: Paul Kocialkowski
---
This is early support for HEVC/H.265 stateless decoding in V4L2,
including both definitions and driver support for the Cedrus VPU
driver, which concerns Allwinner devices.
A specific pixel format is introduced for the HEVC slice format and
controls are provided to pass the bitstream metadata to
Document the current state of the HEVC slice pixel format.
The format will need to evolve in the future, which is why it is
not part of the public API.
Signed-off-by: Paul Kocialkowski
---
.../media/uapi/v4l/pixfmt-compressed.rst | 21 +++
1 file changed, 21 insertions(+)
Introduce the V4L2_PIX_FMT_HEVC_SLICE pixel format, which currently
describes an output buffer with enough appended slice data for
producing one decoded frame with a stateless video decoder.
This will need to be reworked (along with the controls and the core) to
allow passing slice data
As the initial value of the return variable result is never used, it can
be removed.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
Changes in v3:
- Edited subject line and commit message
Changes in v2:
- Clarified subject line
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1
From: Maxime Ripard
Introduce some basic H264 decoding support in cedrus. So far, only the
baseline profile videos have been tested, and some more advanced features
used in higher profiles are not even implemented.
Reviewed-by: Jernej Skrabec
Reviewed-by: Paul Kocialkowski
Signed-off-by:
Fixes checkpatch.pl check "spaces preferred around that ".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000/core.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
Fixes checkpatch.pl errors "space required before the open brace '{'"
and "(foo*)" should be "(foo *)".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
Hi,
These patches fixes minor whitespace issues in staging/kpc2000/core.c as
reported by checkpatch.pl.
- Simon
Simon Sandström (4):
staging: kpc2000: add spaces around operators in core.c
staging: kpc2000: remove extra blank line in core.c
staging: kpc2000: add missing spaces in core.c
Fixes checkpatch.pl check "Please don't use multiple blank lines".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
b/drivers/staging/kpc2000/kpc2000/core.c
index
Fixes checkpatch.pl error "foo __init bar" should be "foo __init bar"
and "foo __exit bar" should be "foo __exit bar".
Signed-off-by: Simon Sandström
---
drivers/staging/kpc2000/kpc2000/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
kp2000_check_uio_irq contained a pair of nested ifs which each evaluated
a bitwise operation. If both operations yielded true, the function
returned 1; otherwise it returned 0.
Replaced the whole thing with one return statement that evaluates the
combination of both bitwise operations.
This patch removes unnecessary quoted string splits.
Co-developed-by: Jie Zhang
Signed-off-by: Jie Zhang
Signed-off-by: Tianzheng Li
---
Changes in v2:
- Add Co-developed-by: Jie Zhang
drivers/staging/gasket/gasket_core.c | 6 ++
drivers/staging/gasket/gasket_ioctl.c | 3
Hi Alexandru,
On 05/24, Alexandru Ardelean wrote:
> On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote:
> >
> > This patch adds of_match_table entry in device driver in order to
> > enable spi fallback probing.
> >
> > Signed-off-by: Rodrigo Ribeiro
> > Reviewed-by: Marcelo Schmitt
> > ---
On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote:
> [External]
>
>
> Hi Alexandru,
>
> On 05/24, Alexandru Ardelean wrote:
> > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro
> > wrote:
> > >
> > > This patch adds of_match_table entry in device driver in order to
> > > enable spi
On Fri, May 24, 2019 at 01:19:26PM +0100, Jeremy Sowden wrote:
> kp2000_check_uio_irq contained a pair of nested ifs which each evaluated
> a bitwise operation. If both operations yielded true, the function
> returned 1; otherwise it returned 0.
>
> Replaced the whole thing with one return
57 matches
Mail list logo
