On Sat, 2019-09-07 at 18:58 +, Valentin Vidic wrote:
> Fixes checkpatch.pl warnings:
>
> CHECK: No space is necessary after a cast
Please always try to improve the code rather
than shutup checkpatch warnings.
> diff --git a/drivers/staging/exfat/exfat_core.c
>
Fixed open parenthesis at the end of the line on line 327.
Signed-off-by: Sandro Volery
---
drivers/staging/wlan-ng/cfg80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
b/drivers/staging/wlan-ng/cfg80211.c
index
Use constants and fix checkpatch.pl warnings:
CHECK: No space is necessary after a cast
Signed-off-by: Valentin Vidic
---
v2: Use constants where possible
drivers/staging/exfat/exfat_core.c | 94 ++---
drivers/staging/exfat/exfat_super.c | 66 ++--
2
You need a subject prefix. It should be something like:
[PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c
Generally "Fix" is considered better style than "Fixed". We aren't
going to care about that in staging, but the patch prefix is mandatory
so you will need to redo it
> On 7 Sep 2019, at 16:39, Dan Carpenter wrote:
>
> You need a subject prefix. It should be something like:
>
> [PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c
>
Thanks for the reply! I'll try to do that better for my next patch.
> Generally "Fix" is considered
On Sat, Sep 07, 2019 at 04:48:21PM +0200, Sandro Volery wrote:
> > Joe's comments are, of course, correct as well.
> >
> > regards,
> > dan carpenter
> >
>
> I'll take a look at Joe's suggestions too sometime tonight. I'd feel kinda
> bad tho if I just apply his work and send it in?
Don't
PRO: driverdev-devel@linuxdriverproject.org
Ahoj,
Naposledy jste navštívili Ƿorno stránky s dospívajícími,
stáhli jste a nainstalovali software, který jsem vytvořil.
Můj program zapnul fotoaparát a zaznamenal proces
vaší ʍasturbace.
Můj software také popadl všechny vaše e-mailové seznamy
Using strncpy() does not always terminate the destination string.
stracpy() is a alternative function that does, by using this new
function we will no longer need to insert a null separator.
Signed-off-by: Adam Zerella
---
drivers/staging/android/ion/ion.c | 3 +--
1 file changed, 1
Fixes checkpatch.pl warnings:
CHECK: No space is necessary after a cast
Signed-off-by: Valentin Vidic
---
drivers/staging/exfat/exfat_core.c | 88 ++---
drivers/staging/exfat/exfat_super.c | 66 +++---
2 files changed, 77 insertions(+), 77
Fixes checkpatch.pl warnings:
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '*' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
Signed-off-by: Valentin Vidic
---
10 matches
Mail list logo