Re: [PATCH] staging: greybus: Replace zero-length array with flexible-array member

2020-02-11 Thread Johan Hovold
On Tue, Feb 11, 2020 at 03:12:19PM -0600, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

REPLY

2020-02-11 Thread Warren Buffett Foundation
Warren Buffett Foundation picked you for a $1 500,000 donation. For more details reply ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[driver-core:debugfs_remove_return_value] BUILD SUCCESS 898362bb172007ce38474fd471a4ad32356140b3

2020-02-11 Thread kbuild test robot
-a001-20200211 x86_64 randconfig-a002-20200211 x86_64 randconfig-a003-20200211 i386 randconfig-a001-20200211 i386 randconfig-a002-20200211 i386 randconfig-a003-20200211 alpharandconfig-a001-20200210 m68k

[driver-core:debugfs_cleanup] BUILD SUCCESS 8d3008b80ad7f4048eef7fe2b27215f56a5d11db

2020-02-11 Thread kbuild test robot
randconfig-a001-20200210 h8300randconfig-a001-20200210 nios2randconfig-a001-20200210 microblaze randconfig-a001-20200210 sparc64 randconfig-a001-20200210 c6x randconfig-a001-20200210 c6x randconfig-a001-20200211 h8300

Re: [greybus-dev] [PATCH] staging: greybus: Replace zero-length array with flexible-array member

2020-02-11 Thread Alex Elder
On 2/11/20 4:47 PM, Gustavo A. R. Silva wrote: > > > On 2/11/20 16:15, Alex Elder wrote: >> On 2/11/20 3:12 PM, Gustavo A. R. Silva wrote: >>> The current codebase makes use of the zero-length array language >>> extension to the C90 standard, but the preferred mechanism to declare >>>

Re: [PATCH 07/22] staging: exfat: Rename variable "MilliSecond" to "milli_second"

2020-02-11 Thread Joe Perches
On Mon, 2020-01-27 at 14:55 +0300, Dan Carpenter wrote: > On Mon, Jan 27, 2020 at 03:43:28PM +0530, Pragat Pandya wrote: > > Change all the occurrences of "MilliSecond" to "milli_second" in exfat. > > > > Signed-off-by: Pragat Pandya > > --- > > drivers/staging/exfat/exfat.h | 2 +- > >

[[PATCH staging] 6/7] staging: wfx: use sleeping gpio accessors

2020-02-11 Thread Michał Mirosław
Driver calls GPIO get/set only from non-atomic context and so can use any GPIOs. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 6 +++--- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/main.c| 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff

[[PATCH staging] 2/7] staging: wfx: follow compatible = vendor,chip format

2020-02-11 Thread Michał Mirosław
As for SPI, follow "vendor,chip" format 'compatible' string also for SDIO bus. Signed-off-by: Michał Mirosław --- .../devicetree/bindings/net/wireless/siliabs,wfx.txt | 4 ++-- drivers/staging/wfx/bus_sdio.c| 1 + 2 files changed, 3 insertions(+), 2

[[PATCH staging] 1/7] staging: wfx: add proper "compatible" string

2020-02-11 Thread Michał Mirosław
Add "compatible" string matching "vendor,chip" template and proper GPIO flags handling. Keep support for old name and reset polarity for older devicetrees. Cc: sta...@vger.kernel.org # d3a5bcb4a17f ("gpio: add gpiod_toggle_active_low()") Cc: sta...@vger.kernel.org Signed-off-by: Michał

[[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Michał Mirosław
Move interrupt request and free so to avoid following WARN on probe and possible use-after-free on remove. WARNING: CPU: 0 PID: 827 at drivers/staging/wfx/bus_spi.c:142 wfx_spi_irq_handler+0x5c/0x64 [wfx] race condition in driver init/deinit Cc: sta...@vger.kernel.org Signed-off-by: Michał

[[PATCH staging] 4/7] staging: wfx: annotate nested gc_list vs tx queue locking

2020-02-11 Thread Michał Mirosław
Lockdep is complaining about recursive locking, because it can't make a difference between locked skb_queues. Annotate nested locks and avoid double bh_disable/enable. [...] insmod/815 is trying to acquire lock: cb7d6418 (&(>lock)->rlock){+...}, at: wfx_tx_queues_clear+0xfc/0x198 [wfx] but task

[PATCH staging 0/7] WF200 driver fixes

2020-02-11 Thread Michał Mirosław
A set of fixes for WF200 WiFi module driver. Three are bug fixes, all the rest: cleanups and optimizations. Michał Mirosław (7): staging: wfx: add proper "compatible" string staging: wfx: follow compatible = vendor,chip format staging: wfx: fix init/remove vs IRQ race staging: wfx:

[[PATCH staging] 5/7] staging: wfx: try 16-bit word mode first

2020-02-11 Thread Michał Mirosław
WF200 chip works with 16-bit words over SPI, so use that word size if available. This avoids a bounce buffer usage for little-endian hosts. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bus_spi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[[PATCH staging] 7/7] staging: wfx: use more power-efficient sleep for reset

2020-02-11 Thread Michał Mirosław
Replace udelay() with usleep_range() as all uses are in a sleepable context. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/hwio.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 3/3] staging: wilc1000: refactor p2p action frames handling API's

2020-02-11 Thread Ajay.Kathat
Hi Dan, On 11/02/20 12:21 pm, Dan Carpenter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, Feb 10, 2020 at 06:36:01PM +, ajay.kat...@microchip.com wrote: >> + if (sta_ch == WILC_INVALID_CHANNEL) >> + return;

Re: [[PATCH staging] 6/7] staging: wfx: use sleeping gpio accessors

2020-02-11 Thread Jérôme Pouiller
On Tuesday 11 February 2020 09:46:55 CET Michał Mirosław wrote: > Driver calls GPIO get/set only from non-atomic context and so can use any > GPIOs. > > Signed-off-by: Michał Mirosław > --- > drivers/staging/wfx/bh.c | 6 +++--- > drivers/staging/wfx/bus_spi.c | 4 ++-- >

Re: [[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Michał Mirosław
On Tue, Feb 11, 2020 at 12:23:54PM +0300, Dan Carpenter wrote: > On Tue, Feb 11, 2020 at 09:46:54AM +0100, Michał Mirosław wrote: > > @@ -234,8 +234,8 @@ static void wfx_sdio_remove(struct sdio_func *func) > > struct wfx_sdio_priv *bus = sdio_get_drvdata(func); > > > >

Official Winnings Notification

2020-02-11 Thread SuperEnalotto / EuroMillion/ PowerBall Lotto
Dear : Winner We are pleased to inform you that as a result of our recent DRAWS held on the 8th of February,2020.You have officially Won $1.700.000,00 USD , Kindly Contact Mrs.Maria Lucento ,for claims with the following details 1. Full Name:2.Gender/Age--- 3.Address-:4.Mobile---

[PATCH v2 6/6] staging: wfx: use more power-efficient sleep for reset

2020-02-11 Thread Michał Mirosław
Replace udelay() with usleep_range() as all uses are in a sleepable context. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/hwio.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 5/6] staging: wfx: use sleeping gpio accessors

2020-02-11 Thread Michał Mirosław
Driver calls GPIO get/set only from non-atomic context and so can use any GPIOs. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 6 +++--- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/main.c| 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v2 4/6] staging: wfx: follow compatible = vendor,chip format

2020-02-11 Thread Michał Mirosław
As for SPI, follow "vendor,chip" format 'compatible' string also for SDIO bus. Fixes: 0096214a59a7 ("staging: wfx: add support for I/O access") Signed-off-by: Michał Mirosław --- .../devicetree/bindings/net/wireless/siliabs,wfx.txt | 4 ++-- drivers/staging/wfx/bus_sdio.c

[PATCH v2 3/3] staging: wilc1000: refactor p2p action frames handling API's

2020-02-11 Thread Ajay.Kathat
From: Ajay Singh Refactor handling of P2P specific action frames. Make use of 'struct' to handle the P2P frames instead of manipulating using 'buf' pointer. Signed-off-by: Ajay Singh --- v2: corrected 'while' condition by adding 'struct' size as suggested by Dan.

[PATCH v2 2/3] staging: wilc1000: directly fetch 'priv' handler from 'vif' instance

2020-02-11 Thread Ajay.Kathat
From: Ajay Singh The 'priv' handler is already present in 'vif' struct so directly fetch its value from vif handler in wilc_handle_roc_expired(). Signed-off-by: Ajay Singh --- v2: No change drivers/staging/wilc1000/hif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v2 1/3] staging: wilc1000: remove use of vendor specific IE for p2p handling

2020-02-11 Thread Ajay.Kathat
From: Ajay Singh Remove the use of vendor specific IE parameter to decide p2p_GO/p2p_Client roles between two 'wilc' device. Previously p2p group formation between two 'wilc' device make use of vendor IE for roles decision. The role is decided based on the 'go_intent' value. Signed-off-by: Ajay

Re: [[PATCH staging] 7/7] staging: wfx: use more power-efficient sleep for reset

2020-02-11 Thread Jérôme Pouiller
On Tuesday 11 February 2020 09:46:56 CET Michał Mirosław wrote: > > Replace udelay() with usleep_range() as all uses are in a sleepable context. > > Signed-off-by: Michał Mirosław > --- > drivers/staging/wfx/bh.c | 2 +- > drivers/staging/wfx/bus_spi.c | 4 ++-- >

Re: [PATCH v2 1/6] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Jérôme Pouiller
On Tuesday 11 February 2020 11:35:01 CET Michał Mirosław wrote: > Current code races in init/exit with interrupt handlers. This is noticed > by the warning below. Fix it by using devres for ordering allocations and > IRQ de/registration. > > WARNING: CPU: 0 PID: 827 at

Re: [[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Dan Carpenter
On Tue, Feb 11, 2020 at 09:46:54AM +0100, Michał Mirosław wrote: > @@ -218,9 +218,9 @@ static int wfx_sdio_probe(struct sdio_func *func, > return 0; > > err3: > - wfx_free_common(bus->core); > + wfx_sdio_irq_unsubscribe(bus); > err2: > - wfx_sdio_irq_unsubscribe(bus); > +

[PATCH] staging: qlge: qlge_main.c: fix style issues

2020-02-11 Thread Mohana Datta Yelugoti
This patch fixes "WARNING: Missing a blank line after declarations" generated from checkpatch.pl by adding a blank line after declarations. Signed-off-by: Mohana Datta Yelugoti --- drivers/staging/qlge/qlge_main.c | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH v2 3/6] staging: wfx: add proper "compatible" string

2020-02-11 Thread Michał Mirosław
Add "compatible" string matching "vendor,chip" template and proper GPIO flags handling. Keep support for old name and reset polarity for older devicetrees. Cc: sta...@vger.kernel.org # d3a5bcb4a17f ("gpio: add gpiod_toggle_active_low()") Cc: sta...@vger.kernel.org Fixes: 0096214a59a7

[PATCH v2 0/6] staging: WF200 driver fixes

2020-02-11 Thread Michał Mirosław
A set of fixes for WF200 WiFi module driver. Three are bug fixes, all the rest: cleanups and optimizations. v2: use devres for fixing init/interrupt race, as suggested by Dan Carpenter add Fixes: tags dropped by accident remove 8-bit SPI fall-back patch Michał Mirosław (6): staging: wfx:

Re: [[PATCH staging] 4/7] staging: wfx: annotate nested gc_list vs tx queue locking

2020-02-11 Thread Jérôme Pouiller
On Tuesday 11 February 2020 09:46:55 CET Michał Mirosław wrote: > Lockdep is complaining about recursive locking, because it can't make > a difference between locked skb_queues. Annotate nested locks and avoid > double bh_disable/enable. > > [...] > insmod/815 is trying to acquire lock: >

[PATCH v2 1/6] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Michał Mirosław
Current code races in init/exit with interrupt handlers. This is noticed by the warning below. Fix it by using devres for ordering allocations and IRQ de/registration. WARNING: CPU: 0 PID: 827 at drivers/staging/wfx/bus_spi.c:142 wfx_spi_irq_handler+0x5c/0x64 [wfx] race condition in driver

[PATCH v2 2/6] staging: wfx: annotate nested gc_list vs tx queue locking

2020-02-11 Thread Michał Mirosław
Lockdep is complaining about recursive locking, because it can't make a difference between locked skb_queues. Annotate nested locks and avoid double bh_disable/enable. [...] insmod/815 is trying to acquire lock: cb7d6418 (&(>lock)->rlock){+...}, at: wfx_tx_queues_clear+0xfc/0x198 [wfx] but task

[PATCH RESEND] Staging: remove wusbcore and UWB from the kernel tree.

2020-02-11 Thread Greg Kroah-Hartman
It's been over 6 months, and no one has noticed that these drivers are deleted, probably because no one actually has this hardware. As no one has volunteered to maintain the code, let's drop it for good. Signed-off-by: Greg Kroah-Hartman --- [resending and deleting the actual diffs as the patch

Re: [PATCH v2 1/6] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Michał Mirosław
On Tue, Feb 11, 2020 at 11:19:18AM +, Jérôme Pouiller wrote: > On Tuesday 11 February 2020 11:35:01 CET Michał Mirosław wrote: > > Current code races in init/exit with interrupt handlers. This is noticed > > by the warning below. Fix it by using devres for ordering allocations and > > IRQ

Re: [PATCH 2/6] staging: rtl8723bs: Fix potential security hole

2020-02-11 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.5.2, v5.4.18, v4.19.102, v4.14.170, v4.9.213, v4.4.213. v5.5.2: Build OK!

[PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'

2020-02-11 Thread YueHaibing
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16: warning: variable local_entity_uc set but not used [-Wunused-but-set-variable] commit bd8aa2850f00 ("staging: vc04_services: Get

Re: [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'

2020-02-11 Thread Dan Carpenter
On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function > vchiq_use_internal: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16: > warning: variable local_entity_uc set but not used >

Re: [[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Dan Carpenter
On Tue, Feb 11, 2020 at 11:39:31AM +0100, Michał Mirosław wrote: > On Tue, Feb 11, 2020 at 12:23:54PM +0300, Dan Carpenter wrote: > > On Tue, Feb 11, 2020 at 09:46:54AM +0100, Michał Mirosław wrote: > > > @@ -234,8 +234,8 @@ static void wfx_sdio_remove(struct sdio_func *func) > > > struct

Re: [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'

2020-02-11 Thread Yuehaibing
On 2020/2/11 22:24, Dan Carpenter wrote: > On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote: >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function >> vchiq_use_internal: >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16: >> warning:

Re: [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'

2020-02-11 Thread Jérôme Pouiller
On Tuesday 11 February 2020 16:21:41 CET Jérôme Pouiller wrote: > On Tuesday 11 February 2020 15:03:34 CET YueHaibing wrote: > > drivers/staging/wfx/queue.c: In function wfx_tx_queues_get: > > drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not > > used

Re: [PATCH v2 1/6] staging: wfx: fix init/remove vs IRQ race

2020-02-11 Thread Jérôme Pouiller
On Tuesday 11 February 2020 13:49:22 CET Michał Mirosław wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Tue, Feb 11, 2020 at 11:19:18AM +, Jérôme

Re: [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'

2020-02-11 Thread Jérôme Pouiller
On Tuesday 11 February 2020 15:03:34 CET YueHaibing wrote: > drivers/staging/wfx/queue.c: In function wfx_tx_queues_get: > drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not > used [-Wunused-but-set-variable] > > commit 2e57865e79cf ("staging: wfx: pspoll_mask make no

[PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'

2020-02-11 Thread YueHaibing
drivers/staging/wfx/queue.c: In function wfx_tx_queues_get: drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not used [-Wunused-but-set-variable] commit 2e57865e79cf ("staging: wfx: pspoll_mask make no sense") left behind this unused variable. Reported-by: Hulk Robot

Re: [PATCH v2 00/19] Renaming some identifiers.

2020-02-11 Thread Greg KH
On Tue, Feb 11, 2020 at 12:05:39AM +0530, Pragat Pandya wrote: > This patchset renames following nineteen variables in exfat.h > Fix checkpatch warning: Avoid CamelCase > -Year->year > -Day->day > -Hour->hour > -Minute->minute > -Second->second > -Millisecond->millisecond >

Re: [PATCH v2 3/3] staging: wilc1000: refactor p2p action frames handling API's

2020-02-11 Thread Greg KH
On Tue, Feb 11, 2020 at 09:57:10AM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > Refactor handling of P2P specific action frames. Make use of 'struct' to > handle the P2P frames instead of manipulating using 'buf' pointer. > > Signed-off-by: Ajay Singh > --- > v2: corrected

Re: [greybus-dev] [PATCH] staging: greybus: Replace zero-length array with flexible-array member

2020-02-11 Thread Gustavo A. R. Silva
On 2/11/20 16:15, Alex Elder wrote: > On 2/11/20 3:12 PM, Gustavo A. R. Silva wrote: >> The current codebase makes use of the zero-length array language >> extension to the C90 standard, but the preferred mechanism to declare >> variable-length types such as these ones is a flexible array

[PATCH] staging: greybus: Replace zero-length array with flexible-array member

2020-02-11 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By

[PATCH] staging: unisys: visorinput: Replace zero-length array with flexible-array member

2020-02-11 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By

Re: [greybus-dev] [PATCH] staging: greybus: Replace zero-length array with flexible-array member

2020-02-11 Thread Alex Elder
On 2/11/20 3:12 PM, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct