Re: [PATCH 1/2] staging: gasket: Fix 4 over 80 char warnings

On Wed, Apr 01, 2020 at 10:54:17PM -0700, Joe Perches wrote: > On Wed, 2020-04-01 at 22:36 -0700, John B. Wyatt IV wrote: > > Fix 4 over 80 char warnings by caching long enum values into local > > variables. > > > > All enums are only used once inside each function (and once inside > > the entire

Re: [PATCH 2/2] staging: gasket: Fix comment 75 character limit warning

On Wed, Apr 01, 2020 at 10:36:17PM -0700, John B. Wyatt IV wrote: > Fix 75 character limit warning in comment reported by checkpatch. comments are not allowed to go beyond 75 columns now? Is that something new? The code is fine as-is, sorry. thanks, greg k-h ___

Re: [PATCH] staging: uwb: Fix missing blank space coding style issue

On Mon, Mar 30, 2020 at 01:57:27AM +0300, Iulian Olaru wrote: > This patch adds a blank space before the switch argument parenthesis to > silence checkpatch.pl errors. > > Signed-off-by: Iulian Olaru > --- > drivers/staging/uwb/drp.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-

Re: [PATCH 00/32] staging: wfx: rework the Tx queue

I didn't quite finish reviewing these pathches last night. Looks good. You will need a check on "ssidlen" to prevent memory corruption, as discussed in patch 1, but that's not a bug which was introduced by this patchset. None of my other comments really applied to the patchset itself, just to the

Re: [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment

On Wed, Apr 01, 2020 at 07:33:10PM -0700, John B. Wyatt IV wrote: > Fix 2 parenthesis alignment issues. > > Reported by checkpatch. > > Signed-off-by: John B. Wyatt IV > --- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH 1/2] staging: gasket: Fix 4 over 80 char warnings

On Wed, Apr 01, 2020 at 10:36:16PM -0700, John B. Wyatt IV wrote: > Fix 4 over 80 char warnings by caching long enum values into local > variables. > > All enums are only used once inside each function (and once inside > the entire file). > > Reported by checkpatch. > > Signed-off-by: John B. Wy

{Re:Reply}

Hello, My name is Reem Ebrahim Al-Hashimi, I am the "Minister of state and Petroleum" also "Minister of State for International Cooperation" in UAE. Kindly visit this link for more understanding: https://en.wikipedia.org/wiki/Reem_Al_Hashimi I write to solicit for your partnership in claiming o

Re: [PATCH 01/01] staging: gasket: Fix incongruency in handling of sysfs entries creation

On Thu, Apr 02, 2020 at 03:22:33PM +0100, Luís Mendes wrote: > Hi Dan, > > Ah sorry, ok, I will re-send the patch using git. > Can you please tell me which is the correct mailing list to where this > patch should be submitted? > You had the CC correct, but always CC the person responsible for or

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

On Thu, Apr 02, 2020 at 03:30:34PM +, George Spelvin wrote: > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: > > I don't know how this patch made it through two versions without anyone > > complaining that this paragraph should be done as a separate patch... > > I often fold co

Re: [PATCH v5 1/9] media: adv748x: fix end-of-line terminators in diagnostic statements

Hi Alex, On 02/04/2020 19:34, Alex Riesen wrote: > Signed-off-by: Alexander Riesen > Reviewed-by: Laurent Pinchart I guess we could have also added this directly to the helper macros, but there is indeed already a mixed usage so either way would require fixups to be consistent. So this is a go

Re: [PATCH v5 2/9] media: adv748x: include everything adv748x.h needs into the file

Hi Alex, On 02/04/2020 19:34, Alex Riesen wrote: > To follow the established practice of not depending on others to > pull everything in. While at it, make sure it stays like this. Good call! Small extra trivial comment below... Reviewed-by: Kieran Bingham > Signed-off-by: Alexander Riesen >

Re: [PATCH v5 1/9] media: adv748x: fix end-of-line terminators in diagnostic statements

Kieran Bingham, Fri, Apr 03, 2020 12:43:38 +0200: > Hi Alex, > > On 02/04/2020 19:34, Alex Riesen wrote: > > Signed-off-by: Alexander Riesen > > Reviewed-by: Laurent Pinchart > > I guess we could have also added this directly to the helper macros, but > there is indeed already a mixed usage so

Re: [PATCH v5 2/9] media: adv748x: include everything adv748x.h needs into the file

Hi Kiran, Kieran Bingham, Fri, Apr 03, 2020 12:48:06 +0200: > On 02/04/2020 19:34, Alex Riesen wrote: > > --- a/drivers/media/i2c/adv748x/adv748x-core.c > > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > > @@ -10,6 +10,8 @@ > > * Kieran Bingham > > */ > > > > +#include "adv748x.h" > > + >

KCSAN: data-race in binder_dec_node_nilocked / binder_state_show

Hello, syzbot found the following crash on: HEAD commit:245a4300 Merge branch 'rcu/kcsan' into tip/locking/kcsan git tree: https://github.com/google/ktsan.git kcsan console output: https://syzkaller.appspot.com/x/log.txt?x=106b67f1e0 kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH 1/4] dt-bindings: phy: phy-rockchip-dphy-rx0: move rockchip dphy rx0 bindings out of staging

On 4/2/20 1:17 PM, Ezequiel Garcia wrote: > (+Kishon) > > Hi Helen, > > I was wondering if we couldn't also move the phy driver out of staging. I think we can, let's move it. Regards, Helen > > Thanks, > Ezequiel > > On Wed, 2020-04-01 at 21:02 -0300, Helen Koike wrote: >> Move phy-rockc

[PATCH 01/01] staging: gasket: Fix incongruency in handling of sysfs entries creation

Fix incongruency in handling of sysfs entries creation. This issue could cause invalid memory accesses, by not properly detecting the end of the sysfs attributes array. Fixes: 84c45d5f3bf1 ("staging: gasket: Replace macro __ATTR with __ATTR_NULL") Signed-off-by: Luis Mendes --- gasket_sysfs.c

[PATCH 01/01] staging: gasket: Fix incongruency in handling of sysfs entries creation

Fix incongruency in handling of sysfs entries creation. This issue could cause invalid memory accesses, by not properly detecting the end of the sysfs attributes array. Fixes: 84c45d5f3bf1 ("staging: gasket: Replace macro __ATTR with __ATTR_NULL") Signed-off-by: Luis Mendes --- gasket_sysfs.c

[driver-core:debugfs_remove_return_value] BUILD SUCCESS bbf258a14f332b2432a57ade3d4d2d844aeb5db5

generic-32bit_defconfig pariscgeneric-64bit_defconfig alpharandconfig-a001-20200403 m68k randconfig-a001-20200403 mips randconfig-a001-20200403 nds32randconfig-a001-20200403 parisc randconfig-a001

[staging:staging-testing] BUILD SUCCESS e41d25a3f8a9d3d9a89527a77e687bd308a847a8

64r6el_defconfig mips malta_kvm_defconfig pariscallnoconfig parisc allyesconfig pariscgeneric-32bit_defconfig pariscgeneric-64bit_defconfig x86_64 randconfig-a001-20200403 x86_64

[PATCH v2 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399

Move the bindings out of drivers/staging and place them in Documentation/devicetree/bindings instead. Also, add DT nodes for RK3399 and verify with make ARCH=arm64 dtbs_check and make ARCH=arm64 dt_binding_check. Tested by verifying images streamed from RockPi 4 board with imx219 module. Changes

[PATCH v2 2/9] media: staging: dt-bindings: rkisp1: add required items in i2c example

Add missing required items in Rockchip ISP1 dt-bindings example for a complete i2c node. Suggested-by: Johan Jonker Signed-off-by: Helen Koike --- Changes in v2: - new patch in the series --- .../devicetree/bindings/media/rockchip-isp1.yaml | 5 + 1 file changed, 5 insertions(+

[PATCH v2 5/9] dt-bindings: phy: phy-rockchip-dphy-rx0: move rockchip dphy rx0 bindings out of staging

Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy Verified with: make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml Signed-off-by: Helen Koike --- V2: - no changes .../devicetree/bindings/phy/rockchip-

[PATCH v2 8/9] arm64: dts: rockchip: add rx0 mipi-phy for rk3399

From: Shunqian Zheng Designware MIPI D-PHY, used for ISP0 in rk3399. Verified with: make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen Signed-off-by: Helen Koike --- Changes i

[PATCH v2 4/9] media: staging: dt-bindings: phy-rockchip-dphy-rx0: remove non-used reg property

reg property is not used in Rockchip MIPI DPHY RX0 bindings, thus remove it. Suggested-by: Johan Jonker Signed-off-by: Helen Koike --- Changes in v2: - this is a new patch in the series --- .../devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml| 3 --- 1 file changed, 3 deletions(-)

[PATCH v2 1/9] media: staging: dt-bindings: rkisp1: add missing required nodes

Add missing required nodes in json-schema yaml file for Rockchip ISP1 dt-bindings. Suggested-by: Johan Jonker Signed-off-by: Helen Koike --- Changes in v2: - New patch in the series --- .../devicetree/bindings/media/rockchip-isp1.yaml | 8 1 file changed, 8 insertions(+) dif

[PATCH v2 3/9] media: staging: dt-bindings: rkisp1: re-order properties

Organize properties order in dt-binbings to move it out of staging. On top: compatible, reg and interrupts. Then alphabetical order, then properties starting with '#'. Suggested-by: Johan Jonker Signed-off-by: Helen Koike --- V2: - this is a new patch in the series --- .../bindings/media/rock

[PATCH v2 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging

Move rkisp1 bindings to Documentation/devicetree/bindings/media Verified with: make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml Signed-off-by: Helen Koike --- V2: - no changes .../devicetree/bindings/media/rockchip-isp1.yaml

[PATCH v2 9/9] arm64: dts: rockchip: add isp0 node for rk3399

From: Shunqian Zheng RK3399 has two ISPs, but only ISP0 was tested at present. Add isp0 node in rk3399 dtsi Verified with: make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen Signed-off-

[PATCH v2 7/9] media: MAINTAINERS: rkisp1: add path to dt-bindings

The Rockchip ISP bindings was moved out of staging. Update MAINTAINERS file with the new path. Suggested-by: Johan Jonker Signed-off-by: Helen Koike --- V2: - This is a new patch in the series --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d

Re: [PATCH v5 3/9] media: adv748x: reduce amount of code for bitwise modifications of device registers

Hi Alex, On 02/04/2020 19:34, Alex Riesen wrote: > The regmap provides a convenient utility for this. > The hdmi_* and dpll_* register modification macros added for symmetry > with the existing operations (io_*, sdp_*). Ah yes, perhaps I should have done that when I converted this driver to regm

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

On Fri, Apr 03, 2020 at 12:10:29PM +0300, Dan Carpenter wrote: > On Thu, Apr 02, 2020 at 03:30:34PM +, George Spelvin wrote: > > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: > > > I don't know how this patch made it through two versions without anyone > > > complaining that th