Re: [PATCH] media: ipu3: add a module to probe sensors via ACPI

+Cc: Heikki (swnode expert) On Wed, May 20, 2020 at 2:19 PM Mauro Carvalho Chehab wrote: > Em Wed, 20 May 2020 11:26:08 +0300 > Sakari Ailus escreveu: ... > As I said, the problem is not probing the sensor via ACPI, but, instead, > to be able receive platform-specific data. There is no proble

[PATCH] staging: rtl8192e: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/d

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > Hi, Dan, > > I agree the best solution is to fix __pm_runtime_resume(). But there are also > many cases that assume pm_runtime_get_sync() will change PM usage > counter on error. According to my static analysis results, th

[PATCH 01/10] staging: vt6656: remove ieee80211_hdr from vnt_usb_send_context.

It is only used in one place were it can be pointed to at skb->data. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/device.h | 1 - drivers/staging/vt6656/rxtx.c | 5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/device.h b/drivers/stag

[PATCH 02/10] staging: vt6656: rxtx remove unused need_ack

need_ack is no longer used by driver remove it. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/device.h | 1 - drivers/staging/vt6656/rxtx.c | 5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h i

[PATCH 03/10] staging: vt6656: Move vnt_mic_hdr pointers to vnt_fill_txkey

mic_hdr has three possible locations ieee80211_tx_info can controls these with control.use_cts_prot for rts or cts exchange or otherwise the rts/data position. Removing double pointer. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 37 ++- 1

[PATCH 04/10] staging: vt6656: use ieee80211_tx_info to replace need_mic

Use the info->control.hw_key to replace need mic which is only present when info->control.hw_key->cipher == WLAN_CIPHER_SUITE_CCMP. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 39 +-- 1 file changed, 23 insertions(+), 16 deletions(-) diff

[PATCH 05/10] staging: vt6656: rxtx use ieee80211_tx_info for rts/cts control

Use the control for rts/cts exhanges replacing need_rts and use_cts_prot for packet type PK_TYPE_11GB / PK_TYPE_11GA Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/v

[PATCH 06/10] staging: vt6656: Move key_buffer inside vnt_fill_txkey.

Use vnt_tx_fifo_head to point directly at tx_key removing key_buffer. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index 310d

[PATCH 07/10] staging: vt6656: move tx_body_size/payload_len to skb->len

both variables can be removed and replaced with skb->len. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index 2d7a8fc70d92..b9164142e2

[PATCH 08/10] staging: vt6656: Move tx_key inside vnt_fill_txkey.

tx_key can be got directly from info. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index b9164142e2b5..a0672ca51138 100644 --- a/drivers/

[PATCH 09/10] staging: vt6656: Move calling point of vnt_fill_txkey.

Change vnt_fill_txkey to return true if mic_hdr is needed and change calling point at where it is to be placed. tx_buffer is already in tx_context. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 191 +- 1 file changed, 95 insertions(+), 96 d

[PATCH 10/10] staging: vt6656: move key frag controls to vnt_fill_txkey

vnt_fill_txkey now has access to tx_buffer move cipher frag controls The icv_len is the only thing needed from hw_key in vnt_tx_packet. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a

Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

On Thu, May 21, 2020 at 02:27:45PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu Let's s

Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

We need to make sure if pm_runtime_get_sync() is designed with such behavior before modifying it. I received a response from Rafael when I commited a similar patch: https://lkml.org/lkml/2020/5/20/1100 It seems that this behavior is intentional and needs to be kept. Regards, Dinghao "Dan Carpe

Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote: > We need to make sure if pm_runtime_get_sync() is designed with > such behavior before modifying it. > > I received a response from Rafael when I commited a similar patch: > https://lkml.org/lkml/2020/5/20/1100 > It seems t

Re: Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

Sorry, I misunderstood your idea before. A new function is the best solution for this problem. Regards, Dinghao "Dan Carpenter" 写道： > On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote: > > We need to make sure if pm_runtime_get_sync() is designed wi

[PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string

From: Colin Ian King Currently HSD20_IPS is defined as "true" and will always result in a non-zero result even if it is defined as "false" because it is an array and that will never be zero. Fix this by defining it as an integer 1 rather than a literal string. Addessses-Coverity: ("Array compare

MY DONATION FOR THE LESS PRIVILEGED IN THIS TIME OF PANDEMIC

I write to ask for your consent to carry out humanitarian projects and help the less privileged in this time of pandemic all over the world, I suffer from advanced cancer that prevents me from realizing my dreams. The doctor informed me that my days are numbered due to my degrading health. That

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

On Thu, May 21, 2020 at 11:15 AM Dan Carpenter wrote: > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > > Hi, Dan, > > > > I agree the best solution is to fix __pm_runtime_resume(). But there are > > also > > many cases that assume pm_runtime_get_sync() will change PM

Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

On Wednesday, May 20, 2020 5:02:30 PM CEST Dan Carpenter wrote: > On Wed, May 20, 2020 at 01:15:44PM +0300, Dmitry Osipenko wrote: > > 20.05.2020 12:51, Dinghao Liu пишет: > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > > it returns an error code. Thus a pairing decreme

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter > wrote: > > > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > > > Hi, Dan, > > > > > > I agree the best solution is to fix __pm_runtime_resume(). But th

Contact JP Morgan Chase Bank NY USA to receive your transfer $35.700,000Million USD Deposited this Morning

Dear Friend. Goodnews to you Contact JP Morgan Chase Bank NY USA to receive your transfer $35.700,000Million USD Deposited this Morning, All Service Fees was taking care of by IMF Ny, Contact Bank Director, Dr.James Dinton Email ID: jpmorganchasebankny...@gmail.com Phone(906) 205-3516 TEXT THE OFFI

Contact JP Morgan Chase Bank NY USA to receive your transfer $35.700,000Million USD Deposited this Morning

Dear Friend. Goodnews to you Contact JP Morgan Chase Bank NY USA to receive your transfer $35.700,000Million USD Deposited this Morning, All Service Fees was taking care of by IMF Ny, Contact Bank Director, Dr.James Dinton Email ID: jpmorganchasebankny...@gmail.com Phone(906) 205-3516 TEXT THE OFFI

[PATCH][next] media: atomisp: fix a handful of spelling mistakes

From: Colin Ian King There are several spelling mistakes in various messages and literal strings. Fix these. Signed-off-by: Colin Ian King --- .../staging/media/atomisp/pci/base/refcount/src/refcount.c | 2 +- .../media/atomisp/pci/css_2401_system/host/csi_rx_private.h | 4 ++-- .../atomisp/p