On 26/07/20 2:42 pm, Greg KH wrote:
> On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote:
>> this patch fixes the coding style of block comments.
>>
>> Signed-off-by: Rohit K Bharadwaj
>> ---
>> v3: change patch subject prefix
>> v2: split patch into sequence of patches
>> v1: fix
On Sun, Jul 26, 2020 at 04:23:02PM +0530, Aditya Jain wrote:
> Cleaning messy function declartions and fixing code style
> errors in hal_phy_cfg.h as reported by checkpatch.pl
>
> Signed-off-by: Aditya Jain
> ---
> .../staging/rtl8723bs/include/hal_phy_cfg.h | 118 +-
> 1 file
Remove redundant variable in file fwio.c used for returning value.
Issue was found using Coccinelle:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Sumera Priyadarsini
---
drivers/staging/wfx/fwio.c | 11 +--
1 file changed, 5
this patch fixes style of open brace after functions and if statements
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
.../media/atomisp/pci/sh_css_firmware.c | 29
On 26/07/20 3:12 pm, Mauro Carvalho Chehab wrote:
> Em Sun, 26 Jul 2020 14:35:12 +0530
> Rohit K Bharadwaj escreveu:
>
>> this patch fixes style of open brace after functions and if statements
>>
>> Signed-off-by: Rohit K Bharadwaj
>
>> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw,
Hi all,
The following series of patches fixes code style issues in
the file staging/drivers/rtl8723bs/include/hal_phy_cfg.h
Regards,
Aditya Jain
___
devel mailing list
de...@linuxdriverproject.org
this patch fixes the line length exceeded error from checkpatch.pl
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 ++-
1 file
this patch fixes the error from checkpatch.pl which says that trailing
statements after if keyword to be on next line
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote:
> this patch fixes the coding style of block comments.
>
> Signed-off-by: Rohit K Bharadwaj
> ---
> v3: change patch subject prefix
> v2: split patch into sequence of patches
> v1: fix all coding style issues in single patch
>
Em Sun, 26 Jul 2020 14:35:12 +0530
Rohit K Bharadwaj escreveu:
> this patch fixes style of open brace after functions and if statements
>
> Signed-off-by: Rohit K Bharadwaj
> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct
> ia_css_fw_info *bi,
> blob = (const
rhel-kconfig
powerpc allmodconfig
powerpc allnoconfig
powerpc defconfig
i386 randconfig-a003-20200726
i386 randconfig-a005-20200726
i386 randconfig-a004-20200726
Cleaning up messy multiline function declarations in hal_phy_cfg.h
This patch is a continuation of patch "Clean up function declarations"
Signed-off-by: Aditya Jain
---
.../staging/rtl8723bs/include/hal_phy_cfg.h | 56 ++-
1 file changed, 16 insertions(+), 40 deletions(-)
Adjust spacing in macro definitions to align them and improve
readbility
Signed-off-by: Aditya Jain
---
drivers/staging/rtl8723bs/include/hal_phy_cfg.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
Clean up multiline function declartions in hal_phy_cfg.h
to improve code readablility
Signed-off-by: Aditya Jain
---
.../staging/rtl8723bs/include/hal_phy_cfg.h | 44 ---
1 file changed, 9 insertions(+), 35 deletions(-)
diff --git
Fixing ERROR: "foo *bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
Signed-off-by: Aditya Jain
---
.../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
Cleaning messy function declartions and fixing code style
errors in hal_phy_cfg.h as reported by checkpatch.pl
Signed-off-by: Aditya Jain
---
.../staging/rtl8723bs/include/hal_phy_cfg.h | 118 +-
1 file changed, 33 insertions(+), 85 deletions(-)
diff --git
On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote:
> Cleaning up messy multiline function declarations in hal_phy_cfg.h
>
> This patch is a continuation of patch "Clean up function declarations"
This should be merged with that patch, no reason to make it separate.
>
> Signed-off-by:
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
> Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
> as reported by checkpatch.pl
>
> Signed-off-by: Aditya Jain
> ---
> .../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +-
> 1 file changed, 9
this patch fixes the coding style of block comments.
Signed-off-by: Rohit K Bharadwaj
---
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
.../media/atomisp/pci/sh_css_firmware.c | 28 +--
1 file changed, 19 insertions(+), 9
On 26/07/20 2:18 pm, Rohit K Bharadwaj wrote:
> this patch fixes the coding style of block comments.
>
> Signed-off-by: Rohit K Bharadwaj
> ---
> v2: split patch into sequence of patches
> v1: fix all coding style issues in single patch
>
> .../media/atomisp/pci/sh_css_firmware.c | 28
this patch fixes the coding style of block comments.
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
.../media/atomisp/pci/sh_css_firmware.c | 28 +--
1 file
On Sun, Jul 26, 2020 at 1:56 PM Greg KH wrote:
>
> On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
> > Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
> > as reported by checkpatch.pl
> >
> > Signed-off-by: Aditya Jain
> > ---
> >
The following changes since commit ba47d845d715a010f7b51f6f89bae32845e6acb7:
Linux 5.8-rc6 (2020-07-19 15:41:18 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.8-rc7
for you to fetch changes up to
On Sun, Jul 26, 2020 at 10:45 PM Joe Perches wrote:
>
> On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote:
> > On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote:
> > > Cleaning up messy multiline function declarations in hal_phy_cfg.h
> []
> > > diff --git
On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote:
> On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote:
> > Cleaning up messy multiline function declarations in hal_phy_cfg.h
[]
> > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
> >
The pull request you sent on Sun, 26 Jul 2020 13:12:46 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> tags/staging-5.8-rc7
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f208a76fcb5700a0c5104e5888679acc31d1ce41
Thank you!
--
On Sun, 26 Jul 2020 at 16:16, Jernej Škrabec wrote:
>
> Hi Ezequiel!
>
> Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a):
> > Hi Jernej,
> >
> > As you know, I'm not familiar with this hardware,
> > but I've tried to take a detailed look anyway.
> >
>
> Thanks, any
powerpc allyesconfig
powerpc rhel-kconfig
powerpc allmodconfig
powerpc allnoconfig
x86_64 randconfig-a014-20200726
x86_64 randconfig-a016-20200726
x86_64
On 7/26/20 3:40 AM, Aditya Jain wrote:
On Sun, Jul 26, 2020 at 1:56 PM Greg KH wrote:
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
Signed-off-by: Aditya Jain
---
Hi Ezequiel!
Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a):
> Hi Jernej,
>
> As you know, I'm not familiar with this hardware,
> but I've tried to take a detailed look anyway.
>
Thanks, any review is welcome.
> The driver looks mostly good to me, I just have
> some
rtw_aes_decrypt, rtw_tkip_decrypt, rtw_wep_decrypt, rtw_aes_encrypt,
rtw_tkip_encrypt, rtw_wep_encrypt are takes (u8 *) second argiment and
always uses it as (struct recv_frame *) or (struct xmit_frame *).
This is causes a lot of unnecessary type casts
and complicates refactoring.
Signed-off-by:
On 26/07/20 11:33 pm, Larry Finger wrote:
On 7/26/20 3:40 AM, Aditya Jain wrote:
On Sun, Jul 26, 2020 at 1:56 PM Greg KH
wrote:
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
this patch fixes the warnings and errors generated after running checkpatch.pl
on pci/sh_css_firmware.c
Signed-off-by: Rohit K Bharadwaj
---
.../media/atomisp/pci/sh_css_firmware.c | 62 +++
1 file changed, 36 insertions(+), 26 deletions(-)
diff --git
On Sun, Jul 26, 2020 at 11:55:42AM +0530, Rohit K Bharadwaj wrote:
> this patch fixes the warnings and errors generated after running
> checkpatch.pl on pci/sh_css_firmware.c
>
> Signed-off-by: Rohit K Bharadwaj
> ---
> .../media/atomisp/pci/sh_css_firmware.c | 62 +++
>
Fixing ERROR: "foo *bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
Signed-off-by: Aditya Jain
---
.../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
35 matches
Mail list logo