Re: [PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 2:42 pm, Greg KH wrote: > On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote: >> this patch fixes the coding style of block comments. >> >> Signed-off-by: Rohit K Bharadwaj >> --- >> v3: change patch subject prefix >> v2: split patch into sequence of patches >> v1: fix

Re: [PATCH v2] staging: rtl8723bs: include: Fix coding style issues

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 04:23:02PM +0530, Aditya Jain wrote: > Cleaning messy function declartions and fixing code style > errors in hal_phy_cfg.h as reported by checkpatch.pl > > Signed-off-by: Aditya Jain > --- > .../staging/rtl8723bs/include/hal_phy_cfg.h | 118 +- > 1 file

[PATCH] staging: wfx: Remove unnecessary return variable

2020-07-26 Thread Sumera Priyadarsini
Remove redundant variable in file fwio.c used for returning value. Issue was found using Coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Sumera Priyadarsini --- drivers/staging/wfx/fwio.c | 11 +-- 1 file changed, 5

[PATCH v3 2/4] staging: media: atomisp: fix style of open brace

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes style of open brace after functions and if statements Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 29

Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 3:12 pm, Mauro Carvalho Chehab wrote: > Em Sun, 26 Jul 2020 14:35:12 +0530 > Rohit K Bharadwaj escreveu: > >> this patch fixes style of open brace after functions and if statements >> >> Signed-off-by: Rohit K Bharadwaj > >> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw,

Fix code style issues in staging

2020-07-26 Thread Aditya Jain
Hi all, The following series of patches fixes code style issues in the file staging/drivers/rtl8723bs/include/hal_phy_cfg.h Regards, Aditya Jain ___ devel mailing list de...@linuxdriverproject.org

[PATCH v3 4/4] staging: media: atomisp: fix line length exceeds

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the line length exceeded error from checkpatch.pl Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 ++- 1 file

[PATCH v3 3/4] staging: media: atomisp: fix trailing statement of if

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the error from checkpatch.pl which says that trailing statements after if keyword to be on next line Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch

Re: [PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote: > this patch fixes the coding style of block comments. > > Signed-off-by: Rohit K Bharadwaj > --- > v3: change patch subject prefix > v2: split patch into sequence of patches > v1: fix all coding style issues in single patch >

Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace

2020-07-26 Thread Mauro Carvalho Chehab
Em Sun, 26 Jul 2020 14:35:12 +0530 Rohit K Bharadwaj escreveu: > this patch fixes style of open brace after functions and if statements > > Signed-off-by: Rohit K Bharadwaj > @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct > ia_css_fw_info *bi, > blob = (const

[staging:staging-testing] BUILD SUCCESS 58b1d3f864b1f32521d60642e240face22e9ee68

2020-07-26 Thread kernel test robot
rhel-kconfig powerpc allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a003-20200726 i386 randconfig-a005-20200726 i386 randconfig-a004-20200726

[PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations

2020-07-26 Thread Aditya Jain
Cleaning up messy multiline function declarations in hal_phy_cfg.h This patch is a continuation of patch "Clean up function declarations" Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h | 56 ++- 1 file changed, 16 insertions(+), 40 deletions(-)

[PATCH v3 4/4] staging: rtl8723bs: include: Align macro definitions

2020-07-26 Thread Aditya Jain
Adjust spacing in macro definitions to align them and improve readbility Signed-off-by: Aditya Jain --- drivers/staging/rtl8723bs/include/hal_phy_cfg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h

[PATCH v3 2/4] staging: rtl8723bs: include: Clean up function declations

2020-07-26 Thread Aditya Jain
Clean up multiline function declartions in hal_phy_cfg.h to improve code readablility Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h | 44 --- 1 file changed, 9 insertions(+), 35 deletions(-) diff --git

[PATCH v3 1/4] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Aditya Jain
Fixing ERROR: "foo *bar" should be "foo *bar" in hal_phy_cfg.h as reported by checkpatch.pl Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v2] staging: rtl8723bs: include: Fix coding style issues

2020-07-26 Thread Aditya Jain
Cleaning messy function declartions and fixing code style errors in hal_phy_cfg.h as reported by checkpatch.pl Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h | 118 +- 1 file changed, 33 insertions(+), 85 deletions(-) diff --git

Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > Cleaning up messy multiline function declarations in hal_phy_cfg.h > > This patch is a continuation of patch "Clean up function declarations" This should be merged with that patch, no reason to make it separate. > > Signed-off-by:

Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote: > Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h > as reported by checkpatch.pl > > Signed-off-by: Aditya Jain > --- > .../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +- > 1 file changed, 9

[PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the coding style of block comments. Signed-off-by: Rohit K Bharadwaj --- v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 28 +-- 1 file changed, 19 insertions(+), 9

Re: [PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 2:18 pm, Rohit K Bharadwaj wrote: > this patch fixes the coding style of block comments. > > Signed-off-by: Rohit K Bharadwaj > --- > v2: split patch into sequence of patches > v1: fix all coding style issues in single patch > > .../media/atomisp/pci/sh_css_firmware.c | 28

[PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the coding style of block comments. Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 28 +-- 1 file

Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Aditya Jain
On Sun, Jul 26, 2020 at 1:56 PM Greg KH wrote: > > On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote: > > Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h > > as reported by checkpatch.pl > > > > Signed-off-by: Aditya Jain > > --- > >

[GIT PULL] Staging driver fixes for 5.8-rc7

2020-07-26 Thread Greg KH
The following changes since commit ba47d845d715a010f7b51f6f89bae32845e6acb7: Linux 5.8-rc6 (2020-07-19 15:41:18 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.8-rc7 for you to fetch changes up to

Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations

2020-07-26 Thread Aditya Jain
On Sun, Jul 26, 2020 at 10:45 PM Joe Perches wrote: > > On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote: > > On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > > > Cleaning up messy multiline function declarations in hal_phy_cfg.h > [] > > > diff --git

Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations

2020-07-26 Thread Joe Perches
On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote: > On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > > Cleaning up messy multiline function declarations in hal_phy_cfg.h [] > > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > >

Re: [GIT PULL] Staging driver fixes for 5.8-rc7

2020-07-26 Thread pr-tracker-bot
The pull request you sent on Sun, 26 Jul 2020 13:12:46 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > tags/staging-5.8-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f208a76fcb5700a0c5104e5888679acc31d1ce41 Thank you! --

Re: [PATCH v2] media: cedrus: Add support for VP8 decoding

2020-07-26 Thread Ezequiel Garcia
On Sun, 26 Jul 2020 at 16:16, Jernej Škrabec wrote: > > Hi Ezequiel! > > Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a): > > Hi Jernej, > > > > As you know, I'm not familiar with this hardware, > > but I've tried to take a detailed look anyway. > > > > Thanks, any

[driver-core:driver-core-testing] BUILD SUCCESS 4fb60b158afd3ac9e0fe9975aa476213f5cc0a4d

2020-07-26 Thread kernel test robot
powerpc allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a014-20200726 x86_64 randconfig-a016-20200726 x86_64

Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Larry Finger
On 7/26/20 3:40 AM, Aditya Jain wrote: On Sun, Jul 26, 2020 at 1:56 PM Greg KH wrote: On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote: Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h as reported by checkpatch.pl Signed-off-by: Aditya Jain ---

Re: [PATCH v2] media: cedrus: Add support for VP8 decoding

2020-07-26 Thread Jernej Škrabec
Hi Ezequiel! Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a): > Hi Jernej, > > As you know, I'm not familiar with this hardware, > but I've tried to take a detailed look anyway. > Thanks, any review is welcome. > The driver looks mostly good to me, I just have > some

[PATCH] staging: r8188eu: use proper type for second argiment of rtw_(aes|tkip|wep)_(decrypt|encrypt)

2020-07-26 Thread Ivan Safonov
rtw_aes_decrypt, rtw_tkip_decrypt, rtw_wep_decrypt, rtw_aes_encrypt, rtw_tkip_encrypt, rtw_wep_encrypt are takes (u8 *) second argiment and always uses it as (struct recv_frame *) or (struct xmit_frame *). This is causes a lot of unnecessary type casts and complicates refactoring. Signed-off-by:

Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Aditya Jain
On 26/07/20 11:33 pm, Larry Finger wrote: On 7/26/20 3:40 AM, Aditya Jain wrote: On Sun, Jul 26, 2020 at 1:56 PM Greg KH wrote: On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote: Fixing ERROR: "foo *  bar" should be "foo *bar" in hal_phy_cfg.h as reported by checkpatch.pl

[PATCH] staging: media: atomisp: fix code style issues

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the warnings and errors generated after running checkpatch.pl on pci/sh_css_firmware.c Signed-off-by: Rohit K Bharadwaj --- .../media/atomisp/pci/sh_css_firmware.c | 62 +++ 1 file changed, 36 insertions(+), 26 deletions(-) diff --git

Re: [PATCH] staging: media: atomisp: fix code style issues

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 11:55:42AM +0530, Rohit K Bharadwaj wrote: > this patch fixes the warnings and errors generated after running > checkpatch.pl on pci/sh_css_firmware.c > > Signed-off-by: Rohit K Bharadwaj > --- > .../media/atomisp/pci/sh_css_firmware.c | 62 +++ >

[PATCH] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Aditya Jain
Fixing ERROR: "foo *bar" should be "foo *bar" in hal_phy_cfg.h as reported by checkpatch.pl Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git