Re: [PATCH v5] sched: Provide USF for the portable equipment.

2020-08-05 Thread peterz
On Wed, Aug 05, 2020 at 03:36:21PM +0800, Dongdong Yang wrote: > +config SCHED_USF > + bool "User Sensitive Factors for Scheduler" > + depends on CPU_FREQ_GOV_SCHEDUTIL && FB > + help > + Select this option to enable the adjustment on the cpufreq with > + the user sensitive

[PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread Tomer Samara
Add functions wfx_full_send(), wfx_full_send_no_reply_async(), wfx_full_send_no_reply() and wfx_full_send_no_reply_free() which works as follow: wfx_full_send() - simple wrapper for both wfx_fill_header() and wfx_cmd_send(). wfx_full_send_no_reply_async() - wrapper for both but

Re: [PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread Greg KH
On Wed, Aug 05, 2020 at 11:56:08AM +0300, Tomer Samara wrote: > Add functions wfx_full_send(), wfx_full_send_no_reply_async(), > wfx_full_send_no_reply() and wfx_full_send_no_reply_free() > which works as follow: > wfx_full_send() - simple wrapper for both wfx_fill_header() > and

Re: [PATCH] staging: android: ashmem: used const keyword

2020-08-05 Thread kernel test robot
Hi Dhiraj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Dhiraj-Sharma/staging-android-ashmem-used-const-keyword/20200729-020222 base:

[PATCH v5] sched: Provide USF for the portable equipment.

2020-08-05 Thread Dongdong Yang
From: Dongdong Yang The power consumption and UI response are more cared for by the portable equipment users. USF(User Sensitive Feedback factor) auxiliary cpufreq governor is providing more util adjustment settings to the high level by scenario identification. From the view of portable

[PATCH v5] Provide USF for the portable equipment.

2020-08-05 Thread Dongdong Yang
From: Dongdong Yang This patch provides USF(User Sensitive Feedback factor) auxiliary cpufreq governor to support high level layer sysfs inodes setting for util adjustment purpose from the identified scenario on portable equipment. Because the power consumption and UI response are more cared for

Re: [PATCH v5] sched: Provide USF for the portable equipment.

2020-08-05 Thread Greg KH
On Wed, Aug 05, 2020 at 03:36:21PM +0800, Dongdong Yang wrote: > +#define usf_attr_rw(_name) \ > +static struct device_attribute _name = > \ > +__ATTR_RW(_name) I also asked you to use DEVICE_ATTR_RW() and not use

Re: [PATCH v5] sched: Provide USF for the portable equipment.

2020-08-05 Thread Greg KH
On Wed, Aug 05, 2020 at 03:36:21PM +0800, Dongdong Yang wrote: > --- /dev/null > +++ b/kernel/sched/usf.c > @@ -0,0 +1,314 @@ > +/* > + * Copyright (C) 2020 XiaoMi Inc. > + * Author: Yang Dongdong > + * This program is free software; you can redistribute it and/or modify > + * it under the terms

Re: [PATCH][next] staging: wfx: fix a handful of spelling mistakes

2020-08-05 Thread Randy Dunlap
On 8/5/20 7:23 AM, Colin King wrote: > From: Colin Ian King > > There are various spelling mistakes in comments and error messages. > Fix these. > > Signed-off-by: Colin Ian King > --- > drivers/staging/wfx/data_rx.c | 2 +- > drivers/staging/wfx/data_tx.c | 2 +- >

Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-05 Thread Qais Yousef
On 08/05/20 03:33, Dongdong Yang wrote: > Appreciate Qais for your above comments. I believe the clamp is very good for > terminal devices per pid or cgroup setting. I really hope it works for the > extended scenario, "screen off", although it has a potential side effect on > "screen on" response

[PATCH] staging: ion: fix spelling mistake in function name "detatch" -> "detach"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in the function name ion_dma_buf_detatch. Fix it by removing the extraneous t. Signed-off-by: Colin Ian King --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [greybus-dev] [PATCH] staging: greybus: audio: Uninitialized variable in gbaudio_remove_controls()

2020-08-05 Thread Alex Elder
On 8/4/20 5:16 AM, Dan Carpenter wrote: > The "err" variable is not meaningful so there is no need to print it. > It's uninitialized on the first iteration through the loop. > > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic > audio modules") > Signed-off-by: Dan

Re: issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put

2020-08-05 Thread Alex Elder
On 7/30/20 11:02 AM, Colin Ian King wrote: > Hi, > > Static analysis with Coverity has detected an uninitialized value being > used in a comparison. The error was detected on a recent change to > drivers/staging/greybus/audio_topology.c however the issue actually > dates back to the original

[PATCH][next] staging: wfx: fix a handful of spelling mistakes

2020-08-05 Thread Colin King
From: Colin Ian King There are various spelling mistakes in comments and error messages. Fix these. Signed-off-by: Colin Ian King --- drivers/staging/wfx/data_rx.c | 2 +- drivers/staging/wfx/data_tx.c | 2 +- drivers/staging/wfx/debug.c | 4 ++-- drivers/staging/wfx/hif_rx.c | 2 +-

Re: [PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread kernel test robot
Hi Tomer, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Tomer-Samara/staging-wfx-refactor-to-avoid-duplication-at-hif_tx-c/20200805-165649 base: https://git.kernel.org/pub/scm/linux

Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-05 Thread Qais Yousef
On 08/05/20 19:13, Dongdong Yang wrote: > Appreciate Qais for your clamp implementation. I would like to add traces > for uclamp_rq_util_with and feedback you if I run into any issues. Thanks. FYI, top posting in LKML is frowned upon. Please put your answer underneath the quoted text. > > The

Re: [PATCH v5] sched: Provide USF for the portable equipment.

2020-08-05 Thread Dan Carpenter
On Wed, Aug 05, 2020 at 03:36:21PM +0800, Dongdong Yang wrote: > From: Dongdong Yang > > The power consumption and UI response are more cared for by the portable > equipment users. USF(User Sensitive Feedback factor) auxiliary cpufreq > governor is providing more util adjustment settings to the

[PATCH v2] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread Tomer Samara
Add functions wfx_full_send(), wfx_full_send_no_reply_async(), wfx_full_send_no_reply() and wfx_full_send_no_reply_free() which works as follow: wfx_full_send() - simple wrapper for both wfx_fill_header() and wfx_cmd_send(). wfx_full_send_no_reply_async() - wrapper for both but

Re: [greybus-dev] [PATCH v4 1/7] staging: greybus: audio: Update snd_jack FW usage as per new APIs

2020-08-05 Thread Alex Elder
On 7/9/20 5:27 AM, Vaibhav Agarwal wrote: > snd_soc_jack APIs are modified in recent kernel versions. This patch > updates the codec driver to resolve the compilation errors related to > jack framework. Greg has already accepted this series so I won't review this now. But I still wanted to

Re: [PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread Tomer Samara
On Wed, Aug 05, 2020 at 11:04:25AM +0200, Greg KH wrote: > On Wed, Aug 05, 2020 at 11:56:08AM +0300, Tomer Samara wrote: > > Add functions wfx_full_send(), wfx_full_send_no_reply_async(), > > wfx_full_send_no_reply() and wfx_full_send_no_reply_free() > > which works as follow: > > wfx_full_send()

Re: [PATCH v3] Provide USF for the portable equipment.

2020-08-05 Thread Dan Carpenter
On Tue, Aug 04, 2020 at 11:17:28AM +0530, Viresh Kumar wrote: > Sending updated patchset for this isn't going to help you my friend. You need > people (maintainers) to agree on the idea here first. It doesn't take much work to make the code look nice. Writing pretty code is always a good idea

Re: [greybus-dev] [PATCH v4 1/7] staging: greybus: audio: Update snd_jack FW usage as per new APIs

2020-08-05 Thread Vaibhav Agarwal
On Wed, Aug 5, 2020 at 6:35 PM Alex Elder wrote: > > On 7/9/20 5:27 AM, Vaibhav Agarwal wrote: > > snd_soc_jack APIs are modified in recent kernel versions. This patch > > updates the codec driver to resolve the compilation errors related to > > jack framework. > > Greg has already accepted this

Investment/Donation For Covid19

2020-08-05 Thread Investment/Donation For Covid19
Greetings, My name is Sofia Guang Blaschke. I am the wife of the owner of Luen Yick Mfg Co Ltd Wuhan China.I am in hospital suffering from covid 19 (corona virus).I am in the intensive care unit and the doctor told me that I may not survive.My husband died of covid 19 and his wish before he

The Fund

2020-08-05 Thread Ms. Reem
Hello, My name is Ms. Reem Ebrahim Al-Hashimi, I am the "Minister of state and Petroleum" also "Minister of State for International Cooperation" in UAE. I write to solicit for your partnership in claiming of {us$90=Million} from a Financial Home in Cambodia. The Fund {us$90=Million} is

Reply...

2020-08-05 Thread Ms. Reem
Hello, My name is Ms. Reem Ebrahim Al-Hashimi, I am the "Minister of state and Petroleum" also "Minister of State for International Cooperation" in UAE. I write to you on behalf of my other "three (3) colleagues" who has approved me to solicit for your "partnership in claiming of