Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/staging-rtl8723bs-Replace-the-comparision-method/20201027-061116
base:
From: Izabela Bakollari
Rewrite comparison to NULL by modifying (p != NULL) to (p).
Issue reported by checkpatch.
Signed-off-by: Izabela Bakollari
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 ++---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 +++
From: Izabela Bakollari
Replace the value comparision method by using the logical NOT
operator instead of comparing the value to NULL.
Signed-off-by: Izabela Bakollari
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 18 ++--
drivers/staging/rtl8723bs/core/rtw_cmd.c | 102
From: Jérôme Pouiller
[ Upstream commit ce3653a8d3db096aa163fc80239d8ec1305c81fa ]
The trace below can appear:
[83613.832200] INFO: trying to register non-static key.
[83613.837248] the code is fine but needs lockdep annotation.
[83613.842808] turning off the locking correctness
On Fri, Oct 23, 2020 at 07:45:40PM +0200, Paul Kocialkowski wrote:
> +static int sun6i_mipi_csi2_s_stream(struct v4l2_subdev *subdev, int on)
> +{
> + struct sun6i_mipi_csi2_video *video =
> + sun6i_mipi_csi2_subdev_video(subdev);
> + struct sun6i_mipi_csi2_dev *cdev =
From: Diana Craciun
[ Upstream commit 5026cf605143e764e1785bbf9158559d17f8d260 ]
Before destroying the mc_io, check first that it was
allocated.
Reviewed-by: Laurentiu Tudor
Acked-by: Laurentiu Tudor
Signed-off-by: Diana Craciun
Link:
From: Badhri Jagan Sridharan
[ Upstream commit 6bbe2a90a0bb4af8dd99c3565e907fe9b5e7fd88 ]
The patch addresses the compliance test failures while running
TD.PD.CP.E3, TD.PD.CP.E4, TD.PD.CP.E5 of the "Deterministic PD
Compliance MOI" test plan published in https://www.usb.org/usbc.
For a product
/kernel/git/gregkh/staging.git
9ab476ba001ead1f64430a3a61c9466ac0fa91ed
config: powerpc64-randconfig-r001-20201026 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
f2c25c70791de95d2466e09b5b58fc37f6ccd7a4)
reproduce (this is a W=1 build):
wget
https
From: Diana Craciun
[ Upstream commit 5026cf605143e764e1785bbf9158559d17f8d260 ]
Before destroying the mc_io, check first that it was
allocated.
Reviewed-by: Laurentiu Tudor
Acked-by: Laurentiu Tudor
Signed-off-by: Diana Craciun
Link:
On Sun, Oct 25, 2020 at 10:54:31AM -0700, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v3:
> - use array_size()
struct_size() is more correct than
The vchiq_instance is allocated with vchiq_initialise() but never
freed properly. Fix memory leak for the vchiq_instance.
Reported-by: Jaehoon Chung
Signed-off-by: Seung-Woo Kim
---
.../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 19 +++
1 files changed, 15
Depending on the context, the error return value
here (extra_buffers_size < added_size) should be
negative.
Signed-off-by: Zhang Qilong
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index
On Fri, Oct 23, 2020 at 07:45:44PM +0200, Paul Kocialkowski wrote:
> +static int sun8i_a83t_mipi_csi2_v4l2_setup(struct sun8i_a83t_mipi_csi2_dev
> *cdev)
> +{
> + struct sun8i_a83t_mipi_csi2_video *video = >video;
> + struct v4l2_subdev *subdev = >subdev;
> + struct
On Fri, Oct 23, 2020 at 11:47:05AM -0700, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v2:
> - correct the subject line
> - correct the commit message
>
The 'break' is unnecessary because of previous
'return', discard it.
Signed-off-by: Zhang Qilong
---
drivers/vme/vme.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index b398293980b6..e1a940e43327 100644
--- a/drivers/vme/vme.c
+++
On Tue, Oct 20, 2020 at 02:57:55PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> .../bindings/net/wireless/silabs,wfx.yaml | 133 ++
> 1 file changed, 133 insertions(+)
> create mode 100644
>
On Mon, Oct 26, 2020 at 04:16:52AM +, Matthew Wilcox wrote:
> On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > > - dev_dbg(>pldev->dev, "Handling completed descriptor %p
> > > (acd = %p)\n", cur, cur->acd);
> > > + dev_dbg(>pldev->dev, "Handling completed
Hi Andy, thanks for the review!
On Thu, 2020-10-22 at 21:53 +0300, Andy Shevchenko wrote:
> On Thu, Oct 22, 2020 at 9:05 PM Nicolas Saenz Julienne
> wrote:
> > Adds support to control the PWM bus available in official Raspberry Pi
> > PoE HAT. Only RPi's co-processor has access to it, so
Use pointer notation instead of using array notation as info_element is
a pointer not array.
Warnings from sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211.h:1013:51: warning: array of
flexible structures
drivers/staging/rtl8192u/ieee80211/ieee80211.h:985:51: warning: array of
flexible
On Thu, 2020-10-22 at 17:58 +0200, Nicolas Saenz Julienne wrote:
> Upon unbinding the device make sure we release RPi's firmware interface.
>
> Signed-off-by: Nicolas Saenz Julienne
> ---
> drivers/soc/bcm/raspberrypi-power.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff
Reformat lines that exceed 100 column in length. Issue reported by
checkpatch script.
Signed-off-by: Deepak R Varma
---
Changes since v2:
- Avoid too much line breaks for a single instruction.
- change suggested by Matthew Wilcox.
Changes since v1:
- No change in this patch.
- Patch
Rename show_engine_regs show function to engine_regs_show as per the
convention followed. The show function macro DEVICE_ATTR also replaced
by DEVICE_ATTR_RO. Issue reported by checkpatch script.
Signed-off-by: Deepak R Varma
---
Changes since v2:
- None for this patch.
Changes since v1:
-
allyesconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a002-20201026
i386 randconfig-a003-20201026
i386 randconfig-a005-20201026
i386 randconfig-a001-20201026
On Mon, Oct 26, 2020 at 06:57:17AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > On Wed, Oct 21, 2020 at 01:01:07PM +0530, Deepak R Varma wrote:
> >
> > Hello,
> > Requesting a review / ack of this patch.
>
> As I said in my previous
On Fri, Oct 23, 2020 at 07:45:40PM +0200, Paul Kocialkowski wrote:
> The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 controller
> found on Allwinner SoCs such as the A31 and V3/V3s.
>
> It is a standalone block, connected to the CSI controller on one side
> and to the MIPI D-PHY block on
On Fri, Oct 23, 2020 at 07:45:42PM +0200, Paul Kocialkowski wrote:
> MIPI CSI-2 is supported on the V3s with an A31 controller, which seems
> to be used on all Allwinner chips supporting it, except for the A83T.
> The controller is connected to CSI0 through fwnode endpoints.
> The mipi_csi2_in
On Fri, Oct 23, 2020 at 07:45:43PM +0200, Paul Kocialkowski wrote:
> This introduces YAML bindings documentation for the A83T MIPI CSI-2
> controller.
>
> Signed-off-by: Paul Kocialkowski
What is the difference with the a31/v3s one?
> ---
> .../media/allwinner,sun8i-a83t-mipi-csi2.yaml | 158
On Fri, Oct 23, 2020 at 07:45:46PM +0200, Paul Kocialkowski wrote:
> The A83T MIPI CSI-2 apparently produces interrupts regardless of the mask
> registers, for example when a transmission error occurs.
>
> This generates quite a flood when unsolicited interrupts are received on
> each received
On Fri, Oct 23, 2020 at 07:45:44PM +0200, Paul Kocialkowski wrote:
> The A83T supports MIPI CSI-2 with a composite controller, covering both the
> protocol logic and the D-PHY implementation. This controller seems to be found
> on the A83T only and probably was abandonned since.
>
> This
On Fri, Oct 23, 2020 at 07:45:32PM +0200, Paul Kocialkowski wrote:
> This series introduces support for MIPI CSI-2, with the A31 controller that is
> found on most SoCs (A31, V3s and probably V5) as well as the A83T-specific
> controller. While the former uses the same MIPI D-PHY that is already
On Mon, 2020-10-26 at 15:40 +0100, Bartosz Golaszewski wrote:
> On Thu, Oct 22, 2020 at 5:59 PM Nicolas Saenz Julienne
> wrote:
> > Upon unbinding the device make sure we release RPi's firmware interface.
> >
> > Signed-off-by: Nicolas Saenz Julienne
> > ---
> >
On Thu, Oct 22, 2020 at 5:59 PM Nicolas Saenz Julienne
wrote:
>
> Upon unbinding the device make sure we release RPi's firmware interface.
>
> Signed-off-by: Nicolas Saenz Julienne
> ---
> drivers/gpio/gpio-raspberrypi-exp.c | 14 +-
> 1 file changed, 13 insertions(+), 1 deletion(-)
On Fri, Oct 23, 2020 at 07:45:35PM +0200, Paul Kocialkowski wrote:
> This allows selecting a dedicated CMA memory pool (specified via
> device-tree) instead of the default one.
>
> Signed-off-by: Paul Kocialkowski
Why would that be needed?
> ---
>
On Fri, Oct 23, 2020 at 07:45:37PM +0200, Paul Kocialkowski wrote:
> Bits related to the interface data width do not have any effect when
> the CSI controller is taking input from the MIPI CSI-2 controller.
I guess it would be clearer to mention that the data width is only
applicable for parallel
From: Arnd Bergmann
Move the added check of the 'band' variable after the
initialization. Pointed out by clang with
drivers/staging/wfx/data_tx.c:34:19: warning: variable 'band' is uninitialized
when used here [-Wuninitialized]
if (rate->idx >= band->n_bitrates) {
Fixes: 868fd970e187
i2c? :)
On Fri, Oct 23, 2020 at 07:45:39PM +0200, Paul Kocialkowski wrote:
> This introduces YAML bindings documentation for the A31 MIPI CSI-2
> controller.
>
> Signed-off-by: Paul Kocialkowski
> ---
> .../media/allwinner,sun6i-a31-mipi-csi2.yaml | 168 ++
> 1 file changed,
On Thu, 2020-10-22 at 21:46 +0300, Andy Shevchenko wrote:
> On Thu, Oct 22, 2020 at 9:06 PM Nicolas Saenz Julienne
> wrote:
> > When unbinding the firmware device we need to make sure it has no
> > consumers left. Otherwise we'd leave them with a firmware handle
> > pointing at freed memory.
> >
On Monday 26 October 2020 17:02:22 CET Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> Move the added check of the 'band' variable after the
> initialization. Pointed out by clang with
>
> drivers/staging/wfx/data_tx.c:34:19: warning: variable 'band' is
> uninitialized when used here
On Mon, Oct 26, 2020 at 3:42 PM Nicolas Saenz Julienne
wrote:
>
> On Mon, 2020-10-26 at 15:40 +0100, Bartosz Golaszewski wrote:
> > On Thu, Oct 22, 2020 at 5:59 PM Nicolas Saenz Julienne
> > wrote:
> > > Upon unbinding the device make sure we release RPi's firmware interface.
> > >
> > >
On Fri, Oct 23, 2020 at 07:45:34PM +0200, Paul Kocialkowski wrote:
> The Allwinner A31 D-PHY supports both Rx and Tx modes. While the latter
> is already supported and used for MIPI DSI this adds support for the
> former, to be used with MIPI CSI-2.
>
> This implementation is inspired by the
40 matches
Mail list logo
