[staging:staging-testing] BUILD SUCCESS 138f3e1265488a9163be7f379073297ba8545cca
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: 138f3e1265488a9163be7f379073297ba8545cca Staging: rtl8723bs/core fix brace coding style issues in rtw_ioctl_set.c elapsed time: 723m configs tested: 119 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig arcvdk_hs38_defconfig powerpc cm5200_defconfig arm tango4_defconfig mips decstation_r4k_defconfig powerpc tqm8555_defconfig sh se7721_defconfig arm lpc18xx_defconfig powerpc tqm5200_defconfig shtitan_defconfig mips tb0226_defconfig powerpc ep88xc_defconfig arm bcm2835_defconfig powerpc acadia_defconfig arm assabet_defconfig powerpc skiroot_defconfig powerpc motionpro_defconfig mips jazz_defconfig powerpccell_defconfig ia64 alldefconfig nds32 defconfig nios2alldefconfig powerpc redwood_defconfig powerpc g5_defconfig powerpc wii_defconfig powerpc mpc836x_mds_defconfig arm jornada720_defconfig arm pxa3xx_defconfig openrisc alldefconfig powerpc mgcoge_defconfig arm s3c2410_defconfig openriscor1ksim_defconfig mips maltasmvp_eva_defconfig armtrizeps4_defconfig armspear3xx_defconfig powerpc mpc8272_ads_defconfig sh espt_defconfig arm vf610m4_defconfig armmulti_v5_defconfig arm nhk8815_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig h8300allyesconfig arc defconfig sh allmodconfig xtensa allyesconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201204 x86_64 randconfig-a006-20201204 x86_64 randconfig-a002-20201204 x86_64 randconfig-a001-20201204 x86_64 randconfig-a005-20201204 x86_64 randconfig-a003-20201204 i386 randconfig-a005-20201204 i386 randconfig-a004-20201204 i386 randconfig-a001-20201204 i386 randconfig-a002-20201204 i386 randconfig-a006-20201204 i386 randconfig-a003-20201204 i386 randconfig-a014-20201204 i386 randconfig-a013-20201204 i386 randconfig-a011-20201204 i386 randconfig-a015-20201204 i386 randconfig-a012-20201204 i386 randconfig-a016-20201204 riscvnommu_k210_defconfig riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv
[driver-core:driver-core-testing] BUILD SUCCESS 5812b32e01c6d86ba7a84110702b46d8a8531fe9
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing branch HEAD: 5812b32e01c6d86ba7a84110702b46d8a8531fe9 of: fix linker-section match-table corruption elapsed time: 726m configs tested: 107 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig m68k amiga_defconfig sh r7785rp_defconfig sh microdev_defconfig m68k m5275evb_defconfig arm lpc18xx_defconfig powerpc tqm5200_defconfig shtitan_defconfig mips tb0226_defconfig nios2allyesconfig pariscgeneric-64bit_defconfig powerpc sbc8548_defconfig powerpc skiroot_defconfig sh lboxre2_defconfig powerpc ep88xc_defconfig arm bcm2835_defconfig powerpc acadia_defconfig arm assabet_defconfig mips maltasmvp_eva_defconfig armtrizeps4_defconfig armspear3xx_defconfig powerpcamigaone_defconfig powerpc mpc834x_itxgp_defconfig powerpc mpc8272_ads_defconfig sh espt_defconfig arm vf610m4_defconfig armmulti_v5_defconfig arm nhk8815_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201204 x86_64 randconfig-a006-20201204 x86_64 randconfig-a002-20201204 x86_64 randconfig-a001-20201204 x86_64 randconfig-a005-20201204 x86_64 randconfig-a003-20201204 i386 randconfig-a005-20201204 i386 randconfig-a004-20201204 i386 randconfig-a001-20201204 i386 randconfig-a002-20201204 i386 randconfig-a006-20201204 i386 randconfig-a003-20201204 i386 randconfig-a014-20201204 i386 randconfig-a013-20201204 i386 randconfig-a011-20201204 i386 randconfig-a015-20201204 i386 randconfig-a012-20201204 i386 randconfig-a016-20201204 riscvnommu_k210_defconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallyesconfig riscvallmodconfig x86_64 rhel x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec x86_64 allyesconfig clang tested configs: x86_64 randconfig-a004-20201205 x86_64 randconfig-a006-20201205 x86_64 randconfig-a002-20201205 x86_64 randconfig-a001-20201205 x86_64 randconfig
Re: [PATCH] Staging: rtl8723bs/core fix brace coding style issues in rtw_recv.c
Hi Brother,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Brother-Matthew-De-Angelis/Staging-rtl8723bs-core-fix-brace-coding-style-issues-in-rtw_recv-c/20201205-060156
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
138f3e1265488a9163be7f379073297ba8545cca
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/fca364b8771a74ab2a2dc2079de520f744371298
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Brother-Matthew-De-Angelis/Staging-rtl8723bs-core-fix-brace-coding-style-issues-in-rtw_recv-c/20201205-060156
git checkout fca364b8771a74ab2a2dc2079de520f744371298
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
In file included from drivers/staging/rtl8723bs/include/drv_types.h:25,
from drivers/staging/rtl8723bs/core/rtw_recv.c:9:
drivers/staging/rtl8723bs/include/ieee80211.h:745:1: warning: alignment 1 of
'struct ieee80211_assoc_request_frame' is less than 2 [-Wpacked-not-aligned]
745 | } __attribute__ ((packed));
| ^
drivers/staging/rtl8723bs/include/ieee80211.h:752:1: warning: alignment 1 of
'struct ieee80211_assoc_response_frame' is less than 2 [-Wpacked-not-aligned]
752 | } __attribute__ ((packed));
| ^
drivers/staging/rtl8723bs/core/rtw_recv.c: In function 'ap2sta_data_frame':
>> drivers/staging/rtl8723bs/core/rtw_recv.c:940:4: warning: suggest braces
>> around empty body in an 'if' statement [-Wempty-body]
940 |;
|^
drivers/staging/rtl8723bs/core/rtw_recv.c: In function
'rtw_signal_stat_timer_hdl':
drivers/staging/rtl8723bs/core/rtw_recv.c:2573:6: warning: variable
'num_signal_qual' set but not used [-Wunused-but-set-variable]
2573 | u32 num_signal_qual = 0;
| ^~~
In file included from drivers/staging/rtl8723bs/include/drv_types.h:42,
from drivers/staging/rtl8723bs/core/rtw_recv.c:9:
At top level:
drivers/staging/rtl8723bs/include/rtw_security.h:371:28: warning: 'K'
defined but not used [-Wunused-const-variable=]
371 | static const unsigned long K[64] = {
|^
vim +/if +940 drivers/staging/rtl8723bs/core/rtw_recv.c
860
861 sint ap2sta_data_frame(struct adapter *adapter, union recv_frame
*precv_frame,
862 struct sta_info **psta);
863 sint ap2sta_data_frame(struct adapter *adapter, union recv_frame
*precv_frame,
864 struct sta_info **psta)
865 {
866 u8 *ptr = precv_frame->u.hdr.rx_data;
867 struct rx_pkt_attrib *pattrib = _frame->u.hdr.attrib;
868 sint ret = _SUCCESS;
869 struct sta_priv *pstapriv = >stapriv;
870 struct mlme_priv *pmlmepriv = >mlmepriv;
871 u8 *mybssid = get_bssid(pmlmepriv);
872 u8 *myhwaddr = myid(>eeprompriv);
873 sint bmcast = IS_MCAST(pattrib->dst);
874
875 if ((check_fwstate(pmlmepriv, WIFI_STATION_STATE) == true) &&
876 (check_fwstate(pmlmepriv, _FW_LINKED) == true ||
877 check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
878 ) {
879
880 /* filter packets that SA is myself or multicast or
broadcast */
881 if (!memcmp(myhwaddr, pattrib->src, ETH_ALEN)) {
882 RT_TRACE(_module_rtl871x_recv_c_, _drv_err_, ("
SA ==myself\n"));
883 #ifdef DBG_RX_DROP_FRAME
884 DBG_871X("DBG_RX_DROP_FRAME %s SA =%pM,
myhwaddr =%pM\n",
885 __func__, MAC_ARG(pattrib->src),
MAC_ARG(myhwaddr));
886 #endif
887 ret = _FAIL;
888 goto exit;
889 }
890
891 /* da should be for me */
892 if ((memcmp(myhwaddr, pattrib->dst, ETH_ALEN)) &&
(!bmcast)) {
893 RT_TRACE(_module_rtl871x_recv_c_, _drv_info_,
894 (" ap2sta_data_frame: compare DA fail;
DA =%pM\n", MAC_ARG(pattrib->dst)));
895 #ifdef DBG_RX_DROP_FRAME
896 DBG_871X("DBG_RX_DROP_FRAME %s DA =%pM\n",
__func__,
I am Vice Chairman of Hang Seng Bank, Dr. Raymond Chien Kuo Fung I have Important Matter to Discuss with you concerning my late client. Died without a NEXT OF KIN. Send me your private email for full
infocar...@aim.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:driver-core-next] BUILD SUCCESS 2e37d91cada138f1c41b5706698b68355d0bafe4
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-next branch HEAD: 2e37d91cada138f1c41b5706698b68355d0bafe4 Merge tag 'auxbus-5.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core into driver-core-next elapsed time: 721m configs tested: 112 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig m68k amiga_defconfig sh r7785rp_defconfig sh microdev_defconfig m68k m5275evb_defconfig armshmobile_defconfig um x86_64_defconfig ia64 tiger_defconfig arm mv78xx0_defconfig ia64zx1_defconfig nios2allyesconfig pariscgeneric-64bit_defconfig powerpc sbc8548_defconfig powerpc skiroot_defconfig sh lboxre2_defconfig powerpc ep88xc_defconfig arm bcm2835_defconfig powerpc acadia_defconfig arm assabet_defconfig arm pcm027_defconfig arm u8500_defconfig powerpc ppc6xx_defconfig arm vf610m4_defconfig powerpc motionpro_defconfig mips jazz_defconfig powerpccell_defconfig ia64 alldefconfig arm pxa3xx_defconfig openrisc alldefconfig powerpc mgcoge_defconfig arm s3c2410_defconfig openriscor1ksim_defconfig mips maltasmvp_eva_defconfig armtrizeps4_defconfig armspear3xx_defconfig powerpcamigaone_defconfig powerpc mpc834x_itxgp_defconfig m68kq40_defconfig sparc64 defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201204 x86_64 randconfig-a006-20201204 x86_64 randconfig-a002-20201204 x86_64 randconfig-a001-20201204 x86_64 randconfig-a005-20201204 x86_64 randconfig-a003-20201204 i386 randconfig-a005-20201204 i386 randconfig-a004-20201204 i386 randconfig-a001-20201204 i386 randconfig-a002-20201204 i386 randconfig-a006-20201204 i386 randconfig-a003-20201204 i386 randconfig-a014-20201204 i386 randconfig-a013-20201204 i386 randconfig-a011-20201204 i386 randconfig-a015-20201204 i386 randconfig-a012-20201204 i386 randconfig-a016-20201204 riscvnommu_k210_defconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscv
[driver-core:auxbus] BUILD SUCCESS 0d2bf11a6b3e275a526b8d42d8d4a3a6067cf953
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git auxbus branch HEAD: 0d2bf11a6b3e275a526b8d42d8d4a3a6067cf953 driver core: auxiliary bus: minor coding style tweaks elapsed time: 727m configs tested: 112 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig m68k amiga_defconfig sh r7785rp_defconfig sh microdev_defconfig m68k m5275evb_defconfig armshmobile_defconfig um x86_64_defconfig ia64 tiger_defconfig arm mv78xx0_defconfig ia64zx1_defconfig nios2allyesconfig pariscgeneric-64bit_defconfig powerpc sbc8548_defconfig powerpc skiroot_defconfig sh lboxre2_defconfig powerpc ep88xc_defconfig arm bcm2835_defconfig powerpc acadia_defconfig arm assabet_defconfig arm pcm027_defconfig arm u8500_defconfig powerpc ppc6xx_defconfig arm vf610m4_defconfig powerpc motionpro_defconfig mips jazz_defconfig powerpccell_defconfig ia64 alldefconfig arm pxa3xx_defconfig openrisc alldefconfig powerpc mgcoge_defconfig arm s3c2410_defconfig openriscor1ksim_defconfig mips maltasmvp_eva_defconfig armtrizeps4_defconfig armspear3xx_defconfig powerpcamigaone_defconfig powerpc mpc834x_itxgp_defconfig m68kq40_defconfig sparc64 defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201204 x86_64 randconfig-a006-20201204 x86_64 randconfig-a002-20201204 x86_64 randconfig-a001-20201204 x86_64 randconfig-a005-20201204 x86_64 randconfig-a003-20201204 i386 randconfig-a005-20201204 i386 randconfig-a004-20201204 i386 randconfig-a001-20201204 i386 randconfig-a002-20201204 i386 randconfig-a006-20201204 i386 randconfig-a003-20201204 i386 randconfig-a014-20201204 i386 randconfig-a013-20201204 i386 randconfig-a011-20201204 i386 randconfig-a015-20201204 i386 randconfig-a012-20201204 i386 randconfig-a016-20201204 riscvnommu_k210_defconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallyesconfig riscvallmodconfig x86_64
Re: [PATCH] staging:rkvdec: Fixed "replace comma with semicolon" Warning:
On Fri, 2020-12-04 at 17:37 -0600, Travis Carter wrote: > drivers/staging/media/rkvdec/rkvdec.c You might consider using Julia Lawall's cocci script for all of drivers/staging or subsets of staging like drivers/staging/media/ https://lore.kernel.org/lkml/1601233948-11629-1-git-send-email-julia.law...@inria.fr/ ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:hantro: Fixed "replace comma with semicolon" Warning:
Corrected the following Warning: drivers/staging/media/hantro/hantro_v4l2.c:319: WARNING: Possible comma where semicolon could be used Signed-off-by: Travis Carter --- drivers/staging/media/hantro/hantro_v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/hantro/hantro_v4l2.c b/drivers/staging/media/hantro/hantro_v4l2.c index b668a82d40ad..e1081c16f56a 100644 --- a/drivers/staging/media/hantro/hantro_v4l2.c +++ b/drivers/staging/media/hantro/hantro_v4l2.c @@ -316,7 +316,7 @@ hantro_reset_fmt(struct v4l2_pix_format_mplane *fmt, fmt->pixelformat = vpu_fmt->fourcc; fmt->field = V4L2_FIELD_NONE; - fmt->colorspace = V4L2_COLORSPACE_JPEG, + fmt->colorspace = V4L2_COLORSPACE_JPEG; fmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; fmt->quantization = V4L2_QUANTIZATION_DEFAULT; fmt->xfer_func = V4L2_XFER_FUNC_DEFAULT; -- 2.17.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:rkvdec: Fixed "replace comma with semicolon" Warning:
Corrected the following Warning: drivers/staging/media/rkvdec/rkvdec.c:133: WARNING: Possible comma where semicolon could be used Signed-off-by: Travis Carter --- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c index d25c4a37e2af..66572066e7a0 100644 --- a/drivers/staging/media/rkvdec/rkvdec.c +++ b/drivers/staging/media/rkvdec/rkvdec.c @@ -130,7 +130,7 @@ static void rkvdec_reset_fmt(struct rkvdec_ctx *ctx, struct v4l2_format *f, memset(f, 0, sizeof(*f)); f->fmt.pix_mp.pixelformat = fourcc; f->fmt.pix_mp.field = V4L2_FIELD_NONE; - f->fmt.pix_mp.colorspace = V4L2_COLORSPACE_REC709, + f->fmt.pix_mp.colorspace = V4L2_COLORSPACE_REC709; f->fmt.pix_mp.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; f->fmt.pix_mp.quantization = V4L2_QUANTIZATION_DEFAULT; f->fmt.pix_mp.xfer_func = V4L2_XFER_FUNC_DEFAULT; -- 2.17.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: rtl8723bs/core fix brace coding style issues in rtw_recv.c
Fix all the brace code style warnings found by checkpatch.pl at the
following lines:
748, 940, 1039, 1602, 1922, 1939.
At line 940 add a semi-colon to specify a line that does not execute
anything, as in Kernighan and Ritchie
Signed-off-by: Brother Matthew De Angelis
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 43e67e48d2df..22030fe6e714 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -745,9 +745,8 @@ void count_rx_stats(struct adapter *padapter, union
recv_frame *prframe, struct
padapter->mlmepriv.LinkDetectInfo.NumRxOkInPeriod++;
- if ((!MacAddr_isBcst(pattrib->dst)) && (!IS_MCAST(pattrib->dst))) {
+ if ((!MacAddr_isBcst(pattrib->dst)) && (!IS_MCAST(pattrib->dst)))
padapter->mlmepriv.LinkDetectInfo.NumRxUnicastOkInPeriod++;
- }
if (sta)
psta = sta;
@@ -937,9 +936,8 @@ sint ap2sta_data_frame(struct adapter *adapter, union
recv_frame *precv_frame,
goto exit;
}
- if ((GetFrameSubType(ptr) & WIFI_QOS_DATA_TYPE) ==
WIFI_QOS_DATA_TYPE) {
- }
-
+ if ((GetFrameSubType(ptr) & WIFI_QOS_DATA_TYPE) ==
WIFI_QOS_DATA_TYPE)
+ ;
if (GetFrameSubType(ptr) & BIT(6)) {
/* No data, will not indicate to upper layer, temporily
count it here */
count_rx_stats(adapter, precv_frame, *psta);
@@ -1036,9 +1034,8 @@ sint sta2ap_data_frame(struct adapter *adapter, union
recv_frame *precv_frame,
process_pwrbit_data(adapter, precv_frame);
- if ((GetFrameSubType(ptr) & WIFI_QOS_DATA_TYPE) ==
WIFI_QOS_DATA_TYPE) {
+ if ((GetFrameSubType(ptr) & WIFI_QOS_DATA_TYPE) ==
WIFI_QOS_DATA_TYPE)
process_wmmps_data(adapter, precv_frame);
- }
if (GetFrameSubType(ptr) & BIT(6)) {
/* No data, will not indicate to upper layer, temporily
count it here */
@@ -1599,9 +1596,8 @@ sint wlanhdr_to_ethhdr(union recv_frame *precvframe)
u8 *ptr = get_recvframe_data(precvframe) ; /* point to frame_ctrl
field */
struct rx_pkt_attrib *pattrib = >u.hdr.attrib;
- if (pattrib->encrypt) {
+ if (pattrib->encrypt)
recvframe_pull_tail(precvframe, pattrib->icv_len);
- }
psnap = (struct ieee80211_snap_hdr *)(ptr+pattrib->hdrlen +
pattrib->iv_len);
psnap_type = ptr+pattrib->hdrlen + pattrib->iv_len+SNAP_SIZE;
@@ -1919,9 +1915,8 @@ static int amsdu_to_msdu(struct adapter *padapter, union
recv_frame *prframe)
a_len -= nSubframe_Length;
if (a_len != 0) {
padding_len = 4 - ((nSubframe_Length + ETH_HLEN) &
(4-1));
- if (padding_len == 4) {
+ if (padding_len == 4)
padding_len = 0;
- }
if (a_len < padding_len) {
DBG_871X("ParseSubframe(): a_len < padding_len
!\n");
@@ -1936,9 +1931,8 @@ static int amsdu_to_msdu(struct adapter *padapter, union
recv_frame *prframe)
sub_pkt = subframes[i];
/* Indicate the packets to upper layer */
- if (sub_pkt) {
+ if (sub_pkt)
rtw_os_recv_indicate_pkt(padapter, sub_pkt,
>u.hdr.attrib);
- }
}
prframe->u.hdr.len = 0;
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] greybus: Add TODO item about modernizing the pwm code
drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers should stick to the atomic API instead. --- drivers/staging/greybus/TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO index 31f1f2cb401c..6461e0132fe3 100644 --- a/drivers/staging/greybus/TODO +++ b/drivers/staging/greybus/TODO @@ -1,3 +1,5 @@ * Convert all uses of the old GPIO API from to the GPIO descriptor API in and look up GPIO lines from device tree or ACPI. +* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity, + ::enable and ::disable. -- 2.29.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()
On Fri, Dec 4, 2020 at 2:10 PM Johan Hovold wrote:
>
> On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> > Add the missing unlock before return from function
> > gbaudio_dapm_free_controls() in the error handling case.
> >
> > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic
> > audio module")
> > Reported-by: Hulk Robot
> > Signed-off-by: Wang Hai
> > ---
> > drivers/staging/greybus/audio_helper.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/greybus/audio_helper.c
> > b/drivers/staging/greybus/audio_helper.c
> > index 237531ba60f3..293675dbea10 100644
> > --- a/drivers/staging/greybus/audio_helper.c
> > +++ b/drivers/staging/greybus/audio_helper.c
> > @@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct
> > snd_soc_dapm_context *dapm,
> > if (!w) {
> > dev_err(dapm->dev, "%s: widget not found\n",
> > widget->name);
> > + mutex_unlock(>card->dapm_mutex);
> > return -EINVAL;
> > }
> > widget++;
>
> This superficially looks correct, but there seems to be another bug in
> this function. It can be used free an array of widgets, but if one of
> them isn't found we just leak the rest. Perhaps that return should
> rather be "widget++; continue;".
>
> Vaibhav?
Thanks Wang for sharing the patch. As already pointed by Johan, this
function indeed has another bug as well.
Pls feel free to share the patch as suggested above.
--
vaibhav
>
> Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call
On Thu, Dec 03, 2020 at 01:47:56PM +0100, Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
> For in-kernel drivers, the kernel version matters. The driver received lots
> of changes, but version number has remained the same since it's introducing
> into mainline, seven years ago. So, it doesn't seem to have much practical
> meaning anymore.
>
> Signed-off-by: Enrico Weigelt
> ---
> drivers/staging/goldfish/goldfish_audio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c
> b/drivers/staging/goldfish/goldfish_audio.c
> index 0c65a0121dde..4a23f40e549a 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -24,7 +24,6 @@
> MODULE_AUTHOR("Google, Inc.");
> MODULE_DESCRIPTION("Android QEMU Audio Driver");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0");
>
> struct goldfish_audio {
> char __iomem *reg_base;
This file isn't even in my tree, are you sure you made this patch series
against the correct branch/tree?
Please fix this series up and resend.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: bcm2835: fix vchiq_mmal dependencies
Hi Arnd,
On Fri, Dec 04, 2020 at 01:49:39PM +0100, Arnd Bergmann wrote:
> On Fri, Dec 4, 2020 at 11:44 AM Jacopo Mondi wrote:
> >
> > Hi Arnd,
> >
> > On Thu, Dec 03, 2020 at 11:38:30PM +0100, Arnd Bergmann wrote:
> > > From: Arnd Bergmann
> > >
> > > When the MMAL code is built-in but the vchiq core config is
> > > set to =m, the mmal code never gets built, which in turn can
> > > lead to link errors:
> >
> > My bad, I repetedly ignored the error report received from the 'kernel
> > test robot' about this. Thanks for fixing.
> >
> > For my eduction, why would the vchiq-mmal code not get build if
> > vchiq-core is set to M ? I mean, that configuration is indeed wrong,
> > as vchiq-mmal uses symbols from vchiq-core and I would expect that to
> > fail when building the kernel image, not have the other modules (as
> > bcm2835-camera) fail as a consequence when building modules.
>
>
> drivers/staging/Makefile has this line:
My bad, I only looked into drivers/staging/vc04_services/
>
> obj-$(CONFIG_BCM2835_VCHIQ) += vc04_services/
>
> when CONFIG_BCM2835_VCHIQ=m, the kbuild infrastructure
> only enters the subdirectory while building modules, but a built-in
> mmal driver is not a loadable module, so it does not get built
> at that time. When compiling the built-in code, the subdirectory is
> not entered.
Thanks, all clear now!
>
> > > Fixes: b18ee53ad297 ("staging: bcm2835: Break MMAL support out from
> > > camera")
> > > Signed-off-by: Arnd Bergmann
> >
> > Acked-by: Jacopo Mondi
> >
> > If you noticed this from the same error notification I recevied it
> > might be fair to report:
> > Reported-by: kernel test robot
>
> I had not seen that report but found it during my own testing,
> thanks for adding.
>
> Arnd
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: bcm2835: fix vchiq_mmal dependencies
On Fri, Dec 4, 2020 at 11:44 AM Jacopo Mondi wrote:
>
> Hi Arnd,
>
> On Thu, Dec 03, 2020 at 11:38:30PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > When the MMAL code is built-in but the vchiq core config is
> > set to =m, the mmal code never gets built, which in turn can
> > lead to link errors:
>
> My bad, I repetedly ignored the error report received from the 'kernel
> test robot' about this. Thanks for fixing.
>
> For my eduction, why would the vchiq-mmal code not get build if
> vchiq-core is set to M ? I mean, that configuration is indeed wrong,
> as vchiq-mmal uses symbols from vchiq-core and I would expect that to
> fail when building the kernel image, not have the other modules (as
> bcm2835-camera) fail as a consequence when building modules.
drivers/staging/Makefile has this line:
obj-$(CONFIG_BCM2835_VCHIQ) += vc04_services/
when CONFIG_BCM2835_VCHIQ=m, the kbuild infrastructure
only enters the subdirectory while building modules, but a built-in
mmal driver is not a loadable module, so it does not get built
at that time. When compiling the built-in code, the subdirectory is
not entered.
> > Fixes: b18ee53ad297 ("staging: bcm2835: Break MMAL support out from camera")
> > Signed-off-by: Arnd Bergmann
>
> Acked-by: Jacopo Mondi
>
> If you noticed this from the same error notification I recevied it
> might be fair to report:
> Reported-by: kernel test robot
I had not seen that report but found it during my own testing,
thanks for adding.
Arnd
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: bcm2835: fix vchiq_mmal dependencies
Hi Arnd,
On Thu, Dec 03, 2020 at 11:38:30PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> When the MMAL code is built-in but the vchiq core config is
> set to =m, the mmal code never gets built, which in turn can
> lead to link errors:
My bad, I repetedly ignored the error report received from the 'kernel
test robot' about this. Thanks for fixing.
For my eduction, why would the vchiq-mmal code not get build if
vchiq-core is set to M ? I mean, that configuration is indeed wrong,
as vchiq-mmal uses symbols from vchiq-core and I would expect that to
fail when building the kernel image, not have the other modules (as
bcm2835-camera) fail as a consequence when building modules.
>
> ERROR: modpost: "vchiq_mmal_port_set_format"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_port_disable"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_port_parameter_set"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_component_finalise"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_port_connect_tunnel"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_component_enable"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_finalise"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_component_init"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_component_disable"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "mmal_vchi_buffer_init"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_port_enable"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_version"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_submit_buffer"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_init"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "mmal_vchi_buffer_cleanup"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
> ERROR: modpost: "vchiq_mmal_port_parameter_get"
> [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined!
>
> Change the Kconfig to depend on BCM2835_VCHIQ like the other drivers,
> and remove the now redundant dependencies.
>
> Fixes: b18ee53ad297 ("staging: bcm2835: Break MMAL support out from camera")
> Signed-off-by: Arnd Bergmann
Acked-by: Jacopo Mondi
If you noticed this from the same error notification I recevied it
might be fair to report:
Reported-by: kernel test robot
Thanks
j
> ---
> drivers/staging/vc04_services/vchiq-mmal/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/Kconfig
> b/drivers/staging/vc04_services/vchiq-mmal/Kconfig
> index 500c0d12e4ff..c99525a0bb45 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/Kconfig
> +++ b/drivers/staging/vc04_services/vchiq-mmal/Kconfig
> @@ -1,6 +1,6 @@
> config BCM2835_VCHIQ_MMAL
> tristate "BCM2835 MMAL VCHIQ service"
> - depends on (ARCH_BCM2835 || COMPILE_TEST)
> + depends on BCM2835_VCHIQ
> help
> Enables the MMAL API over VCHIQ interface as used for the
> majority of the multimedia services on VideoCore.
> --
> 2.27.0
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()
On Fri, Dec 04, 2020 at 05:19:25PM +0800, wanghai (M) wrote:
>
> 在 2020/12/4 16:40, Johan Hovold 写道:
> > On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> >> Add the missing unlock before return from function
> >> gbaudio_dapm_free_controls() in the error handling case.
> >>
> >> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic
> >> audio module")
> >> Reported-by: Hulk Robot
> >> Signed-off-by: Wang Hai
> >> ---
> >> drivers/staging/greybus/audio_helper.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/staging/greybus/audio_helper.c
> >> b/drivers/staging/greybus/audio_helper.c
> >> index 237531ba60f3..293675dbea10 100644
> >> --- a/drivers/staging/greybus/audio_helper.c
> >> +++ b/drivers/staging/greybus/audio_helper.c
> >> @@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct
> >> snd_soc_dapm_context *dapm,
> >>if (!w) {
> >>dev_err(dapm->dev, "%s: widget not found\n",
> >>widget->name);
> >> + mutex_unlock(>card->dapm_mutex);
> >>return -EINVAL;
> >>}
> >>widget++;
> > This superficially looks correct, but there seems to be another bug in
> > this function. It can be used free an array of widgets, but if one of
> > them isn't found we just leak the rest. Perhaps that return should
> > rather be "widget++; continue;".
> >
> I think this is a good idea, should I send a v2 patch?
Let's just wait a bit and see what Vaibhav or Mark says first.
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()
在 2020/12/4 16:40, Johan Hovold 写道:
On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
Add the missing unlock before return from function
gbaudio_dapm_free_controls() in the error handling case.
Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio
module")
Reported-by: Hulk Robot
Signed-off-by: Wang Hai
---
drivers/staging/greybus/audio_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/audio_helper.c
b/drivers/staging/greybus/audio_helper.c
index 237531ba60f3..293675dbea10 100644
--- a/drivers/staging/greybus/audio_helper.c
+++ b/drivers/staging/greybus/audio_helper.c
@@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context
*dapm,
if (!w) {
dev_err(dapm->dev, "%s: widget not found\n",
widget->name);
+ mutex_unlock(>card->dapm_mutex);
return -EINVAL;
}
widget++;
This superficially looks correct, but there seems to be another bug in
this function. It can be used free an array of widgets, but if one of
them isn't found we just leak the rest. Perhaps that return should
rather be "widget++; continue;".
I think this is a good idea, should I send a v2 patch?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()
On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> Add the missing unlock before return from function
> gbaudio_dapm_free_controls() in the error handling case.
>
> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic
> audio module")
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
> ---
> drivers/staging/greybus/audio_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/audio_helper.c
> b/drivers/staging/greybus/audio_helper.c
> index 237531ba60f3..293675dbea10 100644
> --- a/drivers/staging/greybus/audio_helper.c
> +++ b/drivers/staging/greybus/audio_helper.c
> @@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct
> snd_soc_dapm_context *dapm,
> if (!w) {
> dev_err(dapm->dev, "%s: widget not found\n",
> widget->name);
> + mutex_unlock(>card->dapm_mutex);
> return -EINVAL;
> }
> widget++;
This superficially looks correct, but there seems to be another bug in
this function. It can be used free an array of widgets, but if one of
them isn't found we just leak the rest. Perhaps that return should
rather be "widget++; continue;".
Vaibhav?
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
