[PATCH] staging: mt7621-pinctrl: stop using the deprecated 'pinctrl_add_gpio_range'

2020-12-06 Thread Sergio Paracuellos
If the gpio DT node has the 'gpio-ranges' property, the range will be added by the gpio core and doesn't need to be added by the pinctrl driver. By having the gpio-ranges property, we can map every pin between gpio node and pinctrl node and we can stop using the deprecated

[PATCH] staging: rtl8712: check register_netdev() return value

2020-12-06 Thread shaojie . dong
From: "shaojie.dong" Function register_netdev() can fail, so we should check it's return value Signed-off-by: shaojie.dong --- drivers/staging/rtl8712/hal_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/hal_init.c

Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-06 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/shaojie-dong-isrc-iscas-ac-cn/staging-rtl8712-check-register_netdev-return-value/20201207-000540 base:

Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-06 Thread Greg KH
On Sun, Dec 06, 2020 at 11:59:07PM +0800, shaojie.d...@isrc.iscas.ac.cn wrote: > From: "shaojie.dong" > > Function register_netdev() can fail, so we should check it's return value You just check it, you are not doing anything with it, which is just the same as not checking this. Please fix

Re: [PATCH] staging:hantro: Fixed "replace comma with semicolon" Warning:

2020-12-06 Thread Philipp Zabel
Hi Travis, On Fri, 2020-12-04 at 17:51 -0600, Travis Carter wrote: > Corrected the following Warning: > drivers/staging/media/hantro/hantro_v4l2.c:319: WARNING: Possible comma where > semicolon could be used > > Signed-off-by: Travis Carter > --- > drivers/staging/media/hantro/hantro_v4l2.c |