On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote:
> On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote:
> > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> > > On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote:
> > > > On 18/02/2021 08:44, Atul
On Thu, Feb 18, 2021 at 08:10:28AM +0100, Greg KH wrote:
> On Thu, Feb 18, 2021 at 11:58:40AM +0530, Atul Gopinathan wrote:
> > Resolve the following sparse warning:
> > drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in
> > argument 1 (different address spaces)
> >
It is wrong to change the endianness of a variable which has just one
byte size.
Sparse warnings fixed:
drivers/staging//wimax/i2400m/control.c:452:17: warning: cast to restricted
__le32
drivers/staging//wimax/i2400m/control.c:452:17: warning: cast to restricted
__le32
On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote:
> > On 18/02/2021 08:44, Atul Gopinathan wrote:
> > > Fix the following warning generated by sparse:
> > >
> > > drivers/staging//comedi/comedi_fops.c:2956:23: warning:
On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote:
> On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> > On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote:
> > > On 18/02/2021 08:44, Atul Gopinathan wrote:
> > > > Fix the following warning generated by sparse:
> > >
On Wed, Feb 17, 2021 at 09:12:55PM +0530, Pritthijit Nath wrote:
> This change fixes a sparse warning "incorrect type in argument 1
> (different address spaces)".
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1
This change fixes a sparse address type mismatch warning "incorrect type
in assignment (different address spaces)".
Signed-off-by: Pritthijit Nath
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote:
> On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote:
> > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> > > On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote:
> > > > On 18/02/2021 08:44, Atul
Fix the following warning generated by sparse:
drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in
assignment (different address spaces)
drivers/staging//comedi/comedi_fops.c:2956:23:expected unsigned int
*chanlist
drivers/staging//comedi/comedi_fops.c:2956:23:got
On Thu, Feb 18, 2021 at 05:58:41AM +0800, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> debugfs_remove_return_value
> head: 5187c2360ee1d023078e4302dad32fda1e895772
> commit: 72f2bf74b31aae983fb200aa7e84a05943bf27fc [2/8] debugfs:
Resolve the following sparse warning:
drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in
argument 1 (different address spaces)
drivers/staging//comedi/comedi_fops.c:2983:41:expected void [noderef]
*uptr
drivers/staging//comedi/comedi_fops.c:2983:41:got unsigned
World Covid-19 Support Program (WCSP).
Covid Award Number: #865443009766COVID
Approval Number: RU/USA/COVID/097666
Batch Number: #8776/20990976/COVID
OFFICIAL NOTIFICATION:
Because of the corona-virus pandemic accelerates, killing thousands of people
everyday, Russian and United States Of
On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote:
> It is wrong to change the endianness of a variable which has just one
> byte size.
>
> Sparse warnings fixed:
> drivers/staging//wimax/i2400m/control.c:452:17: warning: cast to restricted
> __le32
>
On 18/02/2021 08:44, Atul Gopinathan wrote:
Fix the following warning generated by sparse:
drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in
assignment (different address spaces)
drivers/staging//comedi/comedi_fops.c:2956:23:expected unsigned int
*chanlist
On 17/02/2021 14:20, chakravarthikulkarni wrote:
Warning found by checkpatch.pl script.
Signed-off-by: chakravarthikulkarni
---
drivers/staging/comedi/comedi.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/comedi.h
On Thu, Feb 18, 2021 at 02:40:15PM +0530, Pritthijit Nath wrote:
> This change fixes a sparse address type mismatch warning "incorrect type
> in assignment (different address spaces)".
>
> Signed-off-by: Pritthijit Nath
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6
On Thu, 2021-02-18 at 10:40 +0100, Greg KH wrote:
> On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote:
> > It is wrong to change the endianness of a variable which has just one
> > byte size.
> >
> > Sparse warnings fixed:
> > drivers/staging//wimax/i2400m/control.c:452:17:
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: Prakash Dubey
---
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote:
> On 18/02/2021 08:44, Atul Gopinathan wrote:
> > Fix the following warning generated by sparse:
> >
> > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in
> > assignment (different address spaces)
> >
On 17/02/2021 18:26, Greg KH wrote:
On Wed, Feb 17, 2021 at 11:40:00PM +0530, Atul Gopinathan wrote:
On Wed, Feb 17, 2021 at 06:35:15PM +0100, Greg KH wrote:
On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote:
Resolve the following warning generated by sparse:
Fix the subject. Don't mention eudyptula.
[PATCH] Staging: rtl8723bs: put constant on right side of comparison
Add a commit message:
Checkpatch complains that the constant needs to be on the right hand
side of the comparion.
On Thu, Feb 18, 2021 at 03:54:40PM +, Kurt Manucredo wrote:
>
On Thu, Feb 18, 2021 at 06:51:59PM +0300, Dan Carpenter wrote:
> On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote:
> > On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote:
> > > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> > > > On Thu, Feb 18, 2021 at
On Thu, Feb 18, 2021 at 03:54:29PM +, Kurt Manucredo wrote:
>
> Dear linux kernel developers,
>
> for my eudyptula challenge it is required of me to fix a coding style
> issue in the staging area in linux-next. I am aware that it is in
> general frowned upon when submitting these sorts of
On Wed, Feb 10, 2021 at 03:59:52PM +0100, Mairo Paul Rufus wrote:
> Signed-off-by: Mairo Paul Rufus
No commit message. It should say something like:
Checkpatch complained about the accidental repeated words like
"our our" so I fixed it.
> diff --git a/drivers/staging/wlan-ng/prism2sta.c
>
On 18/02/2021 14:31, chakravarthikulkarni wrote:
> Warning found by checkpath.pl script.
>
> Signed-off-by: chakravarthikulkarni
> ---
> drivers/staging/comedi/comedi_fops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c
>
On Thu, Feb 18, 2021 at 10:39 AM Greg KH wrote:
>
> On Thu, Feb 18, 2021 at 02:40:15PM +0530, Pritthijit Nath wrote:
> > This change fixes a sparse address type mismatch warning "incorrect type
> > in assignment (different address spaces)".
> >
> > Signed-off-by: Pritthijit Nath
> > ---
> >
This patch fixes the checkpatch.pl warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments should align the * on each line
Signed-off-by: Suryashankar Das
---
drivers/staging/rtl8188eu/core/rtw_security.c | 82 +--
1 file changed, 41 insertions(+), 41
On Thu, Feb 18, 2021 at 02:46:48PM +0100, Greg KH wrote:
> On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote:
> > On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote:
> > > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote:
> > > > On Thu, Feb 18, 2021 at 10:31:15AM
Warning found by checkpath.pl script.
Signed-off-by: chakravarthikulkarni
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index
Le 17/02/2021 à 21:42, Ezequiel Garcia a écrit :
Hi Benjamin,
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote:
Add helper functions to allocate and free auxiliary buffers.
These buffers aren't for frames but are needed by the hardware
to store scaling matrix, tiles size, border
On Thu, Feb 18, 2021 at 10:41:07PM -0500, Sean Behan wrote:
> Signed-off-by: Sean Behan
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c
> b/drivers/staging/emxx_udc/emxx_udc.c
> index
The subject is too vague.
On Thu, Feb 18, 2021 at 04:33:10PM +, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo
> ---
>
> Checkpatch complains the constant needs to be on the right side of the
> comparison. The preferred way is:
>
The commit message isn't complete and it has to go
Signed-off-by: Sean Behan
---
drivers/staging/emxx_udc/emxx_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index 3536c03ff523..741147a4f0fe 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++
On Fri, Feb 19, 2021 at 06:00:47AM +0530, karthik alapati wrote:
> convert le32 types to host byte-order types before
> comparison
That says what you did, but not _why_ you did it. Please fix up and
resend.
thanks,
greg k-h
___
devel mailing list
On 2/17/21 6:42 PM, pritthijit.nath at icloud.com (Pritthijit Nath) wrote:
This change fixes a sparse warning "incorrect type in argument 1
(different address spaces)".
Signed-off-by: Pritthijit Nath
---
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
1 file changed, 1 insertion(+), 1
No problem. These days I have fibre to my house, but I still remember
trying to clone the kernel when I could only buy 20MB of data at a
time. :P
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
On Thu, Feb 18, 2021 at 07:50:27PM +, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo
> ---
>
> The preferred coding style is:
> if (!StaAddr)
> return;
Above the Signed-off-by line. Also indenting is wrong. And it's hard
to understand what you're saying.
>
> thank you
On Fri, Feb 19, 2021 at 09:55:14AM +0300, Dan Carpenter wrote:
> No problem. These days I have fibre to my house, but I still remember
> trying to clone the kernel when I could only buy 20MB of data at a
> time. :P
Whoaa, that's tough! Respect to you for still trying to contribute
to the
Dear linux kernel developers,
for my eudyptula challenge it is required of me to fix a coding style
issue in the staging area in linux-next. I am aware that it is in
general frowned upon when submitting these sorts of patches. However, to
finish my 10th challenge I was tasked to do exactly
On Thu, Feb 18, 2021 at 07:50:27PM +, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo
> ---
>
> The preferred coding style is:
> if (!StaAddr)
> return;
>
> thank you mr. dan carpenter
>
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1
Signed-off-by: Kurt Manucredo
---
Checkpatch complains the constant needs to be on the right side of the
comparison. The preferred way is:
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Kurt Manucredo
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..089c6ec19373 100644
---
Align function arguments to fix checkpatch.pl CHECK message and rewrap
to match the file's style.
Signed-off-by: Florian Ziegler
---
drivers/staging/vt6656/card.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
convert le32 types to host byte-order types before
comparison
Signed-off-by: karthik alapati
---
i wonder how these could be false-positives
drivers/staging/wimax/i2400m/fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
On Thu, Feb 18, 2021 at 11:28:14PM +0300, Nikolay Kyx wrote:
> kpc2000_i2c.c:
> fix WARNING: line length of 124 exceeds 100 columns
> fix CHECK: Alignment should match open parenthesis
>
> kpc2000_spi.c:
> fix CHECK: Alignment should match open parenthesis
This changelog is a bit odd.
Please
convert le32 types to host byte-order types before
comparison
Signed-off-by: karthik alapati
---
i wonder how these could be false-positives
drivers/staging/wimax/i2400m/fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
Signed-off-by: Kurt Manucredo
---
The preferred coding style is:
if (!StaAddr)
return;
thank you mr. dan carpenter
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
kpc2000_i2c.c:
fix WARNING: line length of 124 exceeds 100 columns
fix CHECK: Alignment should match open parenthesis
kpc2000_spi.c:
fix CHECK: Alignment should match open parenthesis
Signed-off-by: Nikolay Kyx
---
drivers/staging/kpc2000/kpc2000_i2c.c | 6 --
fwserial.c:
fix CHECK: Alignment should match open parenthesis
Signed-off-by: Nikolay Kyx
---
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index
On Thu, Feb 18, 2021 at 04:33:10PM +, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo
> ---
>
> Checkpatch complains the constant needs to be on the right side of the
> comparison. The preferred way is:
>
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1
On Thu, Feb 18, 2021 at 10:50:43PM +0530, Suryashankar Das wrote:
> This patch fixes the checkpatch.pl warnings:
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Suryashankar Das
> ---
>
This patch fixes the checkpatch.pl warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments should align the * on each line
Signed-off-by: Suryashankar Das
---
drivers/staging/rtl8188eu/core/rtw_security.c | 72 ---
1 file changed, 29 insertions(+), 43
Hi,
I wanted to check the status on the following patch.
I wanted the result for eudyptula task 10 submission.
It would be great if i can check if the mail is being
processed or rejected. I appologise for any troubles.
On Mon, Feb 15, 2021 at 6:57 pm, shivang upadhyay
wrote:
Checkpatch
On Thu, Feb 18, 2021 at 10:54 AM Muhammad Usama Anjum
wrote:
>
> On Thu, 2021-02-18 at 10:40 +0100, Greg KH wrote:
> > On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote:
> > > It is wrong to change the endianness of a variable which has just one
> > > byte size.
> > >
> > >
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I
This change fixes a checkpatch error for "Alignment should match
open parenthesis".
Signed-off-by: Rajat Asthana
---
drivers/staging/wfx/sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index
56 matches
Mail list logo
