Re: [PATCH 0/2] fix sparse warnings

On Sun, Feb 21, 2021 at 09:00:48PM +0530, karthik alapati wrote: > the following patches fixes two byte-order issues > and fixes these sparse warnings > > > drivers/staging//wimax/i2400m/op-rfkill.c:89:25: warning: incorrect type in > assignment (different base types) >

[PATCH v10 1/9] staging: clocking-wizard: Fix kernel-doc warning

Fix the clocking wizard main structure kernel documentation. Signed-off-by: Shubhrajyoti Datta --- v10: Updated the description drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v10 0/9] clk: clocking-wizard: driver updates

In the thread [1] Greg suggested that we move the driver to the clk from the staging. Add patches to address the concerns regarding the fractional and set rate support in the TODO. The patch set does the following - Trivial fixes for kernel doc. - Move the driver to the clk folder - Add

[PATCH v10 2/9] staging: clocking-wizard: Rename speed-grade to xlnx, speed-grade

Rename speed-grade to xlnx,speed-grade Signed-off-by: Shubhrajyoti Datta --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c

[PATCH v10 9/9] clk: clock-wizard: Add the clockwizard to clk directory

Add clocking wizard driver to clk. And delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig| 9 +++ drivers/clk/Makefile | 1 + .../clk-xlnx-clock-wizard.c

[PATCH v10 4/9] staging: clocking-wizard: Allow changing of parent rate for single output

If there is only one output then allow changing of the parent rate. Signed-off-by: Shubhrajyoti Datta --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c

[PATCH v10 6/9] staging: clocking-wizard: Add support for fractional support

Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- v7: Remove unnecessary comments use mult_frac use a common divisor function.

Re: [PATCH 0/2] fix sparse warnings

On Wed, Feb 24, 2021 at 08:26:41PM +0530, karthek wrote: > On Sun, Feb 21, 2021 at 09:00:48PM +0530, karthik alapati wrote: > > the following patches fixes two byte-order issues > > and fixes these sparse warnings > > > > > > drivers/staging//wimax/i2400m/op-rfkill.c:89:25: warning: incorrect

[PATCH v10 5/9] staging: clocking-wizard: Add support for dynamic reconfiguration

The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Signed-off-by: Shubhrajyoti Datta Co-developed-by: Chirag Parekh --- v6: Remove the typecast. use min for capping

[PATCH v10 8/9] dt-bindings: add documentation of xilinx clocking wizard

Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v6: Fix a yaml warning v7: Add vendor prefix speed-grade v8: Fix the warnings v10: Add nr-outputs .../bindings/clock/xlnx,clocking-wizard.yaml | 72 ++ 1 file

[PATCH v10 7/9] staging: clocking-wizard: Remove the hardcoding of the clock outputs

The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v10: generate the names runtime.

[PATCH v10 3/9] staging: clocking-wizard: Update the fixed factor divisors

Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[PATCH AUTOSEL 5.10 16/56] staging: bcm2835-audio: Replace unsafe strcpy() with strscpy()

From: Juerg Haefliger [ Upstream commit 4964a4300660d27907ceb655f219ac47e5941534 ] Replace strcpy() with strscpy() in bcm2835-audio/bcm2835.c to prevent the following when loading snd-bcm2835: [ 58.480634] [ cut here ] [ 58.485321] kernel BUG at lib/string.c:1149! [

Re: [PATCH v4 3/3] drm/bridge: anx7625: add MIPI DPI input feature support

On Wed, Feb 24, 2021 at 5:55 PM Hsin-Yi Wang wrote: > > On Thu, Jan 28, 2021 at 11:10 AM Xin Ji wrote: > > > > Add MIPI rx DPI input support > > > > Reported-by: kernel test robot > > Signed-off-by: Xin Ji > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 326 > >

[PATCH AUTOSEL 4.19 01/26] staging: fwserial: Fix error handling in fwserial_create

From: Dinghao Liu [ Upstream commit f31559af97a0eabd467e4719253675b7dccb8a46 ] When fw_core_add_address_handler() fails, we need to destroy the port by tty_port_destroy(). Also we need to unregister the address handler by fw_core_remove_address_handler() on failure. Signed-off-by: Dinghao Liu

[PATCH AUTOSEL 5.4 11/40] staging: bcm2835-audio: Replace unsafe strcpy() with strscpy()

From: Juerg Haefliger [ Upstream commit 4964a4300660d27907ceb655f219ac47e5941534 ] Replace strcpy() with strscpy() in bcm2835-audio/bcm2835.c to prevent the following when loading snd-bcm2835: [ 58.480634] [ cut here ] [ 58.485321] kernel BUG at lib/string.c:1149! [

[PATCH AUTOSEL 5.4 10/40] staging: most: sound: add sanity check for function argument

From: Christian Gromm [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ] This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter Link:

[PATCH AUTOSEL 5.4 01/40] staging: fwserial: Fix error handling in fwserial_create

From: Dinghao Liu [ Upstream commit f31559af97a0eabd467e4719253675b7dccb8a46 ] When fw_core_add_address_handler() fails, we need to destroy the port by tty_port_destroy(). Also we need to unregister the address handler by fw_core_remove_address_handler() on failure. Signed-off-by: Dinghao Liu

[PATCH AUTOSEL 5.10 15/56] staging: most: sound: add sanity check for function argument

From: Christian Gromm [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ] This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter Link:

[PATCH AUTOSEL 5.10 02/56] staging: fwserial: Fix error handling in fwserial_create

From: Dinghao Liu [ Upstream commit f31559af97a0eabd467e4719253675b7dccb8a46 ] When fw_core_add_address_handler() fails, we need to destroy the port by tty_port_destroy(). Also we need to unregister the address handler by fw_core_remove_address_handler() on failure. Signed-off-by: Dinghao Liu

[PATCH AUTOSEL 5.11 20/67] staging: bcm2835-audio: Replace unsafe strcpy() with strscpy()

From: Juerg Haefliger [ Upstream commit 4964a4300660d27907ceb655f219ac47e5941534 ] Replace strcpy() with strscpy() in bcm2835-audio/bcm2835.c to prevent the following when loading snd-bcm2835: [ 58.480634] [ cut here ] [ 58.485321] kernel BUG at lib/string.c:1149! [

[PATCH AUTOSEL 5.11 19/67] staging: most: sound: add sanity check for function argument

From: Christian Gromm [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ] This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter Link:

Re: [PATCH v4 3/3] drm/bridge: anx7625: add MIPI DPI input feature support

On Thu, Jan 28, 2021 at 11:10 AM Xin Ji wrote: > > Add MIPI rx DPI input support > > Reported-by: kernel test robot > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 326 > -- > drivers/gpu/drm/bridge/analogix/anx7625.h | 20 +- > 2 files

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

On 2021/2/10 19:42, Daniel Thompson wrote: > On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote: >> On 2021/2/8 18:47, Greg KH wrote: >>> On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: On 2021/2/5 17:53, Greg KH wrote: > What does this offer in benefit of the

[PATCH AUTOSEL 5.11 03/67] staging: fwserial: Fix error handling in fwserial_create

From: Dinghao Liu [ Upstream commit f31559af97a0eabd467e4719253675b7dccb8a46 ] When fw_core_add_address_handler() fails, we need to destroy the port by tty_port_destroy(). Also we need to unregister the address handler by fw_core_remove_address_handler() on failure. Signed-off-by: Dinghao Liu

[PATCH AUTOSEL 4.4 09/11] staging: most: sound: add sanity check for function argument

From: Christian Gromm [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ] This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter Link:

[PATCH AUTOSEL 4.9 09/12] staging: most: sound: add sanity check for function argument

From: Christian Gromm [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ] This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter Link:

[PATCH AUTOSEL 4.4 01/11] staging: fwserial: Fix error handling in fwserial_create

From: Dinghao Liu [ Upstream commit f31559af97a0eabd467e4719253675b7dccb8a46 ] When fw_core_add_address_handler() fails, we need to destroy the port by tty_port_destroy(). Also we need to unregister the address handler by fw_core_remove_address_handler() on failure. Signed-off-by: Dinghao Liu

[PATCH AUTOSEL 4.9 01/12] staging: fwserial: Fix error handling in fwserial_create

From: Dinghao Liu [ Upstream commit f31559af97a0eabd467e4719253675b7dccb8a46 ] When fw_core_add_address_handler() fails, we need to destroy the port by tty_port_destroy(). Also we need to unregister the address handler by fw_core_remove_address_handler() on failure. Signed-off-by: Dinghao Liu

[PATCH AUTOSEL 4.19 10/26] staging: most: sound: add sanity check for function argument

From: Christian Gromm [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ] This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter Link:

[PATCH AUTOSEL 4.14 01/16] staging: fwserial: Fix error handling in fwserial_create

From: Dinghao Liu [ Upstream commit f31559af97a0eabd467e4719253675b7dccb8a46 ] When fw_core_add_address_handler() fails, we need to destroy the port by tty_port_destroy(). Also we need to unregister the address handler by fw_core_remove_address_handler() on failure. Signed-off-by: Dinghao Liu

[PATCH AUTOSEL 4.14 09/16] staging: most: sound: add sanity check for function argument

From: Christian Gromm [ Upstream commit 45b754ae5b82949dca2b6e74fa680313cefdc813 ] This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter Link:

Re: [PATCH 0/2] fix sparse warnings

On Wed, Feb 24, 2021 at 06:06:48PM +0300, Dan Carpenter wrote: > On Wed, Feb 24, 2021 at 08:26:41PM +0530, karthek wrote: > > On Sun, Feb 21, 2021 at 09:00:48PM +0530, karthik alapati wrote: > > > the following patches fixes two byte-order issues > > > and fixes these sparse warnings > > > > > >

Re: [PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

> All these patches have the same vague commit message. It's okay if the > commit message basically restates the commit one line summary. It > should say something like: > > Fix a checkpatch warning about a blank line after an open curly brace. > > Rename FooBar to foo_bar to silence a

[PATCH v2 09/13] staging: rtl8192e: rename bdRT2RTAggregation to bd_rt2rt_aggregation in bss_ht struct

Rename bdRT2RTAggregation to bd_rt2rt_aggregation to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 6

[PATCH v2 04/13] staging: rtl8192e: rename bdHTCapLen to bd_ht_cap_len in bss_ht struct

Rename bdHTCapLen to bd_ht_cap_len to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 drivers/staging/rtl8192e/rtllib_rx.c | 12 ++--

[PATCH v2 06/13] staging: rtl8192e: rename bdHTInfoLen to bd_ht_info_len in bss_ht struct

Rename bdHTInfoLen to bd_ht_info_len to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 14 +++---

[PATCH v2 05/13] staging: rtl8192e: rename bdHTInfoBuf to bd_ht_info_buf in bss_ht struct

Rename bdHTInfoBuf to bd_ht_info_buf to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- drivers/staging/rtl8192e/rtllib_rx.c | 13 +++--

[PATCH v2 10/13] staging: rtl8192e: rename bdRT2RTLongSlotTime to bd_rt2rt_long_slot_time in bss_ht struct

Rename bdRT2RTLongSlotTime to bd_rt2rt_long_slot_time to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 4

[PATCH v2 08/13] staging: rtl8192e: rename bdBandWidth to bd_bandwidth in bss_ht struct

Rename bdBandWidth to bd_bandwidth to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 07/13] staging: rtl8192e: rename bdHTSpecVer to bd_ht_spec_ver in bss_ht struct

Rename bdHTSpecVer to bd_ht_spec_ver to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 10 +- 3 files

[PATCH v2 11/13] staging: rtl8192e: rename RT2RT_HT_Mode to rt2rt_ht_mode in bss_ht struct

Rename RT2RT_HT_Mode to rt2rt_ht_mode to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 8

[staging:staging-testing] BUILD SUCCESS 281ad9728617c00ad5f76d8307ff7210e0413027

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: 281ad9728617c00ad5f76d8307ff7210e0413027 staging: wimax: fix code style issues elapsed time: 725m configs tested: 120 configs skipped: 2 The following configs have been built

[PATCH v2 00/13] bss_ht struct cleanups

This patchset fixes the checkpatch issues related to the `bss_ht` struct defined in `rtl8192e/rtl819x_HT.h` (avoid camelcase). The first patch removes a blank line and the last patch reformats the struct a bit to be more consistent with the other types defined in the same file. Changes in v2:

[PATCH v2 03/13] staging: rtl8192e: rename bdHTCapBuf to bd_ht_cap_buf in bss_ht struct

Rename bdHTCapBuf to bd_ht_cap_buf to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 17 +

[PATCH v2 02/13] staging: rtl8192e: rename bdSupportHT to bd_support_ht in bss_ht struct

Rename bdSupportHT to bd_support_ht to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 14 +++---

[PATCH v2 01/13] staging: rtl8192e: remove blank line in bss_ht struct

Fix a checkpatch warning about a blank line after an open curly brace. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index

[PATCH v2 13/13] staging: rtl8192e: reformat bss_ht struct

This change uses a space instead of tabs between the type and name of each member of the struct. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH v2 12/13] staging: rtl8192e: rename bdHT1R to bd_ht_1r in bss_ht struct

Rename bdHT1R to bd_ht_1r to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v4 3/3] drm/bridge: anx7625: add MIPI DPI input feature support

Hi Hsin-Yi, thanks for the comment, I'll change it in the next serial. As video-interfaces.yaml not exist in drm-next, I'm waiting for 5.12-rc1 to apply to drm-misc, then I'll upstream patch v5. Thanks, Xin On Wed, Feb 24, 2021 at 05:55:39PM +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at

Re: [PATCH v2 00/13] bss_ht struct cleanups

Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8712: unterminated string leads to read overflow

The memdup_user() function does not necessarily return a NUL terminated string so this can lead to a read overflow. Switch from memdup_user() to strndup_user() to fix this bug. Fixes: c6dc001f2add ("staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes.") Signed-off-by: Dan