[PATCH 02/17] staging: nuc-wmi: detect WMI API detection

There are currently 3 known API releases: - https://www.intel.com/content/www/us/en/support/articles/23426/intel-nuc/intel-nuc-kits.html - https://raw.githubusercontent.com/nomego/intel_nuc_led/master/specs/INTEL_WMI_LED_0.64.pdf -

[PATCH 10/17] staging: nuc-wmi: get rid of an unused variable

drivers/staging/nuc-led/nuc-wmi.c: In function ‘nuc_nmi_cmd’: drivers/staging/nuc-led/nuc-wmi.c:242:6: warning: variable ‘size’ set but not used [-Wunused-but-set-variable] 242 | int size, ret; | ^~~~ Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 03/17] staging: nuc-wmi: add support for changing S0 brightness

Now that the core logic is in place, let's add support to adjust the S0 brightness level. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 79 +++ 1 file changed, 79 insertions(+) diff --git a/drivers/staging/nuc-led/nuc-wmi.c

[PATCH 04/17] staging: nuc-wmi: add all types of brightness

Improve the logic in order to support not only S0 brightness, but also the brightness for other indicators and for all power states. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 369 -- 1 file changed, 249 insertions(+), 120

[PATCH 01/17] staging: add support for NUC WMI LEDs

Some Intel Next Unit of Computing (NUC) machines have software-configured LEDs that can be used to display a variety of events: - Power State - HDD Activity - Ethernet - WiFi - Power Limit They can even be controlled directly via software, without any

[PATCH 14/17] staging: nuc-wmi: fix software blink behavior logic

The is_visible logic for it is plain wrong: 1. it is used only during devnode creation; 2. it was using the wrong field (id, instead of indicator). Fix it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 30 -- 1 file changed, 12

[PATCH 07/17] staging: nuc-wmi: add basic support for NUC6 WMI

The NUC6 and NUCi7 supports an earlier version of the LEDs WMI, as specified at: https://www.intel.com/content/www/us/en/support/articles/23426/intel-nuc/intel-nuc-kits.html Implement the query part of the LED detection for those devices. Weird enough, at least with Skull Canyon

[PATCH 11/17] staging: nuc-wmi: implement blink control for NUC6

The blink control logic for NUC6 API is somewhat messy, as it uses a single register for controlling both the blink type and the frequency, using a random order. Let's use the same API as defined for other versions, splitting this setting on two different properties. Signed-off-by: Mauro

[PATCH 08/17] staging: muc-wmi: add brightness and color for NUC6 API

The NUC6 WMI API is really simple: it has just 2 messages, that retrieves everything for a LED, and it has just 2 LEDs. Add support for retrieving and set brightness and color. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 198 -- 1

[PATCH 17/17] staging: nuc-led: update the TODOs

Now that most functionality were merged at the driver, update its TODO list, and add a "TODO" comment for the two WMI API commands that are currently not implemented. In summary: - on Rev 0.64, command 0x07 (LED_NOTIFICATION) is meant to store all config settings at EEPROM. That doesn't seem

[GIT PULL] Staging/IIO driver fixes for 5.13-rc2

The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.13-rc2 for you to fetch changes up to

[PATCH 13/17] staging: nuc-led: add support for HDD activity default

There are two possible values for HDD activity behavior: - 0 Normally off, ON when active - 1 Normally on, OFF when active Implement a logic to set it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 77 +++ 1 file

[PATCH 16/17] staging: nuc-wmi: add support for changing the power limit scheme

The power limit indicator may have 2 behaviors: 1. Its color gradually changes from green to red; 2. It displays a single color Add support for it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 93 +++ 1 file changed, 93 insertions(+)

[PATCH 05/17] staging: nuc-wmi: allow changing the LED colors

Add routines to allow seeing and changing the LED colors. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 244 -- 1 file changed, 228 insertions(+), 16 deletions(-) diff --git a/drivers/staging/nuc-led/nuc-wmi.c

[PATCH 09/17] staging: nuc-wmi: Add support to blink behavior for NUC8/10

The hardware blink logic works for both Power State and Software controlled LEDs. Just like brightness, there is one different blink behavior per different power state. Due to that, the logic is somewhat more complex than what it would be expected otherwise. Signed-off-by: Mauro Carvalho Chehab

[PATCH 06/17] staging: nuc-wmi: add support for WMI API version 1.0

The control indicators for WMI version 1.0 (used on NUCi10 and above) are on different locations. The main difference is on single color LEDs. Also, the Power State brightness names are defined on a different way, and there are 3 groups instead of 4. As the driver was written with some tables

[PATCH 00/17] Add an experimental driver for Intel NUC leds

Hi Greg, This series add support for the LEDs found at Intel NUCs since NUC version 6. On several NUC models, the function of the LEDs are programmable, which allow them to indicate several different hardware events. They can even be programmed to represent an userspace-driven event. Some

[PATCH 12/17] staging: nuc-wmi: better detect NUC6/NUC7 devices

There's no documented way to detect if the WMI API is valid, as, when it is not valid, it just returns 4 zeros. However, as having a value of 0x00 for the blinking state is not valid, we can check for it at detection time, in order to disable LEDs control on devices that won't support it.

[PATCH 15/17] staging: nuc-wmi: add support for changing the ethernet type indicator

The Ethernet type indicator can be configured to show the status of LAN1, LAN1 or both. Add support for it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/nuc-led/nuc-wmi.c | 89 +++ 1 file changed, 89 insertions(+) diff --git

Re: [PATCH 01/17] staging: add support for NUC WMI LEDs

Hi Mauro, On 5/16/21 3:53 AM, Mauro Carvalho Chehab wrote: > diff --git a/drivers/staging/nuc-led/Kconfig b/drivers/staging/nuc-led/Kconfig > new file mode 100644 > index ..0f870f45bf44 > --- /dev/null > +++ b/drivers/staging/nuc-led/Kconfig > @@ -0,0 +1,11 @@ > +#

Re: [GIT PULL] Staging/IIO driver fixes for 5.13-rc2

The pull request you sent on Sun, 16 May 2021 11:00:19 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > tags/staging-5.13-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6942d81a8faa17d44d1286b63ccb7d920b29d065 Thank you! --

Re: [PATCH 17/17] staging: nuc-led: update the TODOs

Hi! > - Need to validate the uAPI and document it before moving >this driver out of staging. > - Stabilize and document its sysfs interface. Would you mind starting with this one? We should have existing APIs for most of functionality described... We really don't want to merge code

Re: [PATCH v9 03/13] media: hantro: Use syscon instead of 'ctrl' register

Hi Lucas, On Fri, 2021-04-16 at 12:54 +0200, Lucas Stach wrote: > Am Mittwoch, dem 07.04.2021 um 09:35 +0200 schrieb Benjamin Gaignard: > > In order to be able to share the control hardware block between > > VPUs use a syscon instead a ioremap it in the driver. > > To keep the compatibility with

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

Hi Hans, On Thu, 2021-05-06 at 14:50 +0200, Hans Verkuil wrote: > On 05/05/2021 17:20, Benjamin Gaignard wrote: > > > > Le 05/05/2021 à 16:55, Hans Verkuil a écrit : > > > On 20/04/2021 14:10, Benjamin Gaignard wrote: > > > > The HEVC HANTRO driver needs to know the number of bits to skip at > >