[PATCH V2 5/7] Staging: comedi: change pr_err to dev_err in __unioxx5_digital_write

2013-11-21 Thread Conrad Gomes
This is a patch which subsitutes pr_err with the preferred dev_err for device drivers in __unioxx5_digital_write. The function definition of __unioxx5_digital_write has been changed to take the pointer to the struct comedi_subdevice as a parameter instead of the pointer to struct

[PATCH V2 1/7] Staging: comedi: fix line over 80 character warning in unioxx5.c

2013-11-21 Thread Conrad Gomes
This is a patch to unioxx5.c that fixes the line over 80 character warning found by checkpatch.pl by initializing n_subd before the for loop Signed-off-by: Conrad Gomes conrad.s.j.go...@gmail.com --- drivers/staging/comedi/drivers/unioxx5.c |3 ++- 1 file changed, 2 insertions(+), 1

RE: [PATCH] staging: dwc2: add check on dwc2_core_reset return

2013-11-21 Thread Paul Zimmerman
From: Julien DELACOU [mailto:julien.dela...@st.com] Sent: Wednesday, November 20, 2013 8:30 AM If the GRSTCTL_CSFTRST self-clearing bit never comes back to 0 for any reason, the controller is under reset state and cannot be used. It's preferable to abort initialization in such case.

Re: [PATCH v3 1/5] staging: et131x: clean up code

2013-11-21 Thread Mark Einon
On Wed, Nov 20, 2013 at 03:54:29PM +0800, ZHAO Gang wrote: 1. change function name: et1310_phy_power_down - et1310_phy_power_switch change function name to better describe its functionality. 2. as TODO file suggested, do this sort of things to reduce split lines struct fbr_lookup

[PATCH V2 4/7] Staging: comedi: change pr_err to dev_err in __unioxx5_analog_read

2013-11-21 Thread Conrad Gomes
This is a patch which subsitutes pr_err with dev_err in __unioxx5_analog_read as it is the preferred way to log in device drivers Signed-off-by: Conrad Gomes conrad.s.j.go...@gmail.com --- drivers/staging/comedi/drivers/unioxx5.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v3 0/5] staging: et131x: patches for et131x driver

2013-11-21 Thread Mark Einon
On Wed, Nov 20, 2013 at 03:53:50PM +0800, ZHAO Gang wrote: This patch set should apply to current staging-next tree ZHAO Gang (5): staging: et131x: clean up code staging: et131x: drop packet when error occurs in et131x_tx staging: et131x: stop read when hit max delay in

Re: [PATCH -v2 09/10] mfd: staging: Constify struct mfd_cell where possible

2013-11-21 Thread Greg Kroah-Hartman
On Thu, Nov 21, 2013 at 11:02:11AM +, Lee Jones wrote: On Mon, 18 Nov 2013, Geert Uytterhoeven wrote: As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 (mfd: Stop setting refcounting pointers in original mfd_cell arrays), the cell parameter of mfd_add_devices() is const again.

[PATCH V2 0/7] Staging: comedi: fix coding style issues in unioxx5.c

2013-11-21 Thread Conrad Gomes
This series contains various fixes to coding style issues in unioxx5.c found by checkpatch.pl and due to the usage of pr_err instead of the preferred dev_err type functions for device drivers. Conrad Gomes (7): Staging: comedi: fix line over 80 character warning in unioxx5.c Staging: comedi:

Re: [PATCH v3 2/5] staging: et131x: drop packet when error occurs in et131x_tx

2013-11-21 Thread Mark Einon
On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote: As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY when tx failed. et131x_tx calls function et131x_send_packets, I put the work of et131x_send_packets directly into et131x_tx, and made some changes to let the code

Re: [PATCH v3 4/5] staging: et131x: remove spinlock adapter-lock

2013-11-21 Thread Mark Einon
On Wed, Nov 20, 2013 at 03:57:15PM +0800, ZHAO Gang wrote: adapter-lock is only used in et131x_multicast(), which is eventually called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode() is always called by (net_device *)dev-addr_list_lock hold, to protect from concurrent

[PATCH V2 2/7] Staging: comedi: fix line over 80 character warning in unioxx5.c

2013-11-21 Thread Conrad Gomes
This is a patch to fix a line over 80 character warning found by checkpatch.pl in a comment. The comment was reworded to fix the warning Signed-off-by: Conrad Gomes conrad.s.j.go...@gmail.com --- drivers/staging/comedi/drivers/unioxx5.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: new to this mailing list

2013-11-21 Thread Greg KH
On Thu, Nov 21, 2013 at 09:48:50AM +0700, cotobian wrote: Hello developers! I'm new to Linux kernel, haven't really worked on any real kernel projects but willing to do anything possible to help. Please tell me if there is something i could do. drivers/staging/*/TODO

[PATCH v4 1/5] staging: et131x: clean up code

2013-11-21 Thread ZHAO Gang
1. change function name: et1310_phy_power_down - et1310_phy_power_switch change function name to better describe its functionality. 2. as TODO file suggested, do this sort of things to reduce split lines struct fbr_lookup *fbr; fbr = rx_local-fbr[id]; Then replace

[PATCH V2 7/7] Staging: comedi: remove MACRO pr_fmt in unioxx5.c

2013-11-21 Thread Conrad Gomes
This patch removes MACRO definition pr_fmt which was initially required by pr_info and pr_err logging functions. Signed-off-by: Conrad Gomes conrad.s.j.go...@gmail.com --- drivers/staging/comedi/drivers/unioxx5.c |1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v3 5/5] staging: et131x: update TODO list

2013-11-21 Thread ZHAO Gang
On Fri, Nov 22, 2013 at 5:20 AM, Mark Einon mark.ei...@gmail.com wrote: On Wed, Nov 20, 2013 at 03:58:37PM +0800, ZHAO Gang wrote: remove items that have been done Signed-off-by: ZHAO Gang gamer...@gmail.com If the two small issues in patch 1/5 are fixed: Fixed in v4 of patch 1/5 I sent.