The driver was forced to module only following a previous failure to build
into the kernel. The problem was resolved several months ago.
This has been successfully tested with make allyesconfig on x86_64.
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Eli Billauer
On Sat, Dec 07, 2013 at 05:22:57PM +0800, ZHAO Gang wrote:
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
I have a mess of some patches resend in the series and others not.
On Sat, Dec 07, 2013 at 02:49:05AM -0500, Gary Rookard wrote:
This is the third patch of a series.
What series?
Again, this isn't an ok changelog entry, did you read
Documentation/SubmittingPatches for what should be here?
thanks,
greg k-h
___
devel
On Sat, Dec 07, 2013 at 03:46:48AM -0500, Gary Rookard wrote:
This is the eleventh patch of a series.
No it isn't :)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 9272548..5a45465 100644
---
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 48 -
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index d16ac57..9272548 100644
---
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 5dd2170..d16ac57 100644
---
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 89bd8ca..fdb19df 100644
---
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/README | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 8da96a6..3befc45 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/staging/et131x/README
On Mon, Dec 09, 2013 at 04:46:08PM +0800, ZHAO Gang wrote:
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
What happened to all of Mark's Acked-by: lines? You should have put
On Mon, Dec 9, 2013 at 4:53 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Mon, Dec 09, 2013 at 04:46:08PM +0800, ZHAO Gang wrote:
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 24 ++--
1 file changed, 10 insertions(+), 14
On Mon, Dec 09, 2013 at 05:00:01PM +0800, ZHAO Gang wrote:
On Mon, Dec 9, 2013 at 4:53 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Mon, Dec 09, 2013 at 04:46:08PM +0800, ZHAO Gang wrote:
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 24
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
---
From: Ivaylo Dimitrov freemangor...@abv.bg
Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
need to be exported. It can also be made way simpler by using sscanf.
Signed-off-by: Ivaylo Dimitrov freemangor...@abv.bg
---
drivers/staging/tidspbridge/Makefile |
Signed-off-by: ZHAO Gang gamer...@gmail.com
Acked-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 48 -
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c
Signed-off-by: ZHAO Gang gamer...@gmail.com
Acked-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 5a45465..f498eec 100644
---
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/README | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 8da96a6..3befc45 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/staging/et131x/README
Signed-off-by: ZHAO Gang gamer...@gmail.com
Acked-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index f498eec..89bd8ca 100644
Signed-off-by: ZHAO Gang gamer...@gmail.com
Acked-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index
Signed-off-by: ZHAO Gang gamer...@gmail.com
Acked-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index
On Tuesday, December 03, 2013 at 12:44:52 PM, Shawn Guo wrote:
On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
Add DRM flags for the LCD display clock polarity so the pixelclk-active
DT property can be properly handled by drivers using the DRM API.
Signed-off-by: Marek Vasut
On Mon 2013-12-09 12:13:16, Ivaylo DImitrov wrote:
From: Ivaylo Dimitrov freemangor...@abv.bg
Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
need to be exported. It can also be made way simpler by using sscanf.
Signed-off-by: Ivaylo Dimitrov freemangor...@abv.bg
Previously, VME bridge support was treated as any other driver (using
module_init() macro), but if VME bridge and vme_user (staging) drivers
were compiled into the kernel, then vme_user would attempt to register
itself before the VME core support had been loaded. This would result
in a kernel
This patch updates the vme_master and vme_slave structures to use
types with well defined size and to prevent the compiler from
inserting padding (between enable and vme_addr for one).
The original vme_master and vme_slave structs would be different
sizes and have different layouts depending on
As pointed out by the kbuild test robot, and Ian Abbott, the dma = 0 test
is always true because dma is unsigned. This generates a warn message:
drivers/staging/comedi/drivers/ni_at_a2150.c:715 a2150_attach()
warn: always true condition '(dma = 0) = (0-u32max = 0)'
Fix the test as suggested by
On Mon, Dec 09, 2013 at 07:38:27PM +0800, ZHAO Gang wrote:
Signed-off-by: ZHAO Gang gamer...@gmail.com
Acked-by: Mark Einon mark.ei...@gmail.com
___
devel mailing list
de...@linuxdriverproject.org
On Mon, Dec 09, 2013 at 07:38:29PM +0800, ZHAO Gang wrote:
Signed-off-by: ZHAO Gang gamer...@gmail.com
Acked-by: Mark Einon mark.ei...@gmail.com
___
devel mailing list
de...@linuxdriverproject.org
Tidy up the multi-line comments are the beginning of the file to follow
the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 142
The board supported by this driver only has one asic that provides the
two digital i/o subdevices. The first dio subdevice has 24 channels that
support interrupts. The second dio subdevice also has 24 channels but no
interrupt support.
To make the code clearer and easier to maintain, remove the
Currently this function uses the subdevice private data to get the
iobase address needed to update the dio output channel state and
read the current state of the input channels. This subdevice private
data is in the process of being removed.
Use the subdevice 'index' to determine the base 'port'
This driver is actually fairly simple but it's a bit confusing with all
the subdevice private data usage.
Clean the driver up and remove all the cruft.
H Hartley Sweeten (48):
staging: comedi: pcmmio: remove unused {lock,unlock}_port()
staging: comedi: pcmmio: tidy up switch_page()
The paged registers in the asic need to be spinlock protected to
ensure that the page is not changed while writing to the registers.
Introduce a helper function to make sure the spinlock is used.
Use the new helper in pcmmio_reset(). This is one of the places where
the spinlock is not used.
Rename this function so it has namespace associated with the driver.
The board supported by this driver only has one WinSystems WS16C48 asic
on it that handles the digital i/o. Remove the unnecessary for () loop
that would reset multiple asics.
Signed-off-by: H Hartley Sweeten
The board supported by this driver only has one WinSystems WS16C48 asic
on it that handles the digital i/o.
Remove the unnecessary 'asic' parameter that is passed to switch_page().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The comedi core expects the (*attach) functions to return 0 to indicate
an error or = 0 for success. Change the return to '0' as that is more
typical.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
This member of the subdevice private data is not longer used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 7 ---
1 file changed, 7
Currently this function uses the subdevice private data to get the
iobase address needed to update the channel configuration. This
subdevice private data is in the process of being removed.
Use the subdevice 'index' to determine the base 'port' needed to
access the correct digital i/o registers.
This function is only called by the interrupt subdevice so the sanity
check of the 'asic' is not necessary. Remove it.
The 'nports' is always 3 and the 'firstport' is always 0. Remove the
for () loop that clears the registers to disable the interrupts and
just use the pcmmio_dio_write() helper to
These functions are #ifdef'ed out and not needed in the driver.
Just remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 32
Rename this function to have namespace associated with the driver.
Refactor the function to remove the extra write to the command register
between each ADC conversion. We only need to do one dummy conversion in
order to flush the serial ADC. After that each command will return the
result of the
The (*detach) of this driver just calls comedi_legacy_detach(). Use that
directly for the (*detach).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 7
The board supported by this driver only has one WinSystems WS16C48 asic
on it that handles the digital i/o.
Remove the 'asics' struct array in the private data and add members for
the single 'asic_iobase' and the spinlock used by the asic.
Signed-off-by: H Hartley Sweeten
Refactor the function to remove some indent levels.
Use pcmmio_dio_write() to write the polarity and enable paged registers
instead of using the for () loop to write each register in the pages.
The for () loop actually has a bug. It switches the page to the 'enab'
registers for the first port
Redefine the registers used to access the digital i/o so that they
are based on the dev-iobase of the board instead of the 'asic_iobase'
that is stored in the private data.
Remove the then unused 'asic_iobase'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Change the MODULE_DESCRIPTION to something more usefull than the
generic Comedi low-level driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 2 +-
1
Only subdevice[2], the dio interrupt subdevice, uses the subdevice private data.
Move the members from struct pcmmio_subdev_private to struct pcmmio_private and
remove the subdevice private data. This also allows removing the allocation and
freeing of devpriv-sprivs.
Signed-off-by: H Hartley
Rename adc_wait_ready() so it has namespace associated with the
driver.
Fix the function so it returns an errno if the conversion times
out. Propogate this errno if it happens.
Define the analog input status register to remove the magic numbers.
Signed-off-by: H Hartley Sweeten
Fis the last checkpatch.pl warning in this driver:
WARNING: space prohibited between function name and open parenthesis '('
+ comedi_buf_put (s-async, val 16)) {
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Use the helper functions to read/write the PCMMIO_PAGE_INT_ID registers. This
allows removing the need to lock/unlock the spinlock 'pagelock' and removes the
need for the for () loop that did the read/write of the 3 paged registers.
Also, remove the need for the 'got1' local variable by just
Add some whitespace to the analog output subdevice init and reorder the
init to follow the norm in comedi drivers.
Remove the init of len_chanlist. This member is only used for subdevices
the support async commands. The core will default the value correctly.
Signed-off-by: H Hartley Sweeten
Refactor the board attach so that the async commands support is only
hooked up if the irq is actually available.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The 'num_asic_chans' that support interrupts in the interrupt subdevice is
always initialized to '24'. Remove this unneeded information from the subdevice
private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
The 'iobase' is only used to pass the iobase address of the analog output
registers to ao_winsn(). This address is simply dev-iobase + 8.
Use that instead and remove the 'iobase' from the subdevice private data.
This removes a couple more uses of the ugly 'subpriv' macro.
Signed-off-by: H
Fix the types of some of the private data members. The 'enabled_mask' and
'stop_count' should be unsigned int values. The 'active' and 'continuous'
members are flags, change them to unsigned int bit fields.
Remove the 'sprivs' pointer. This should have been removed when the subdevice
private data
There is only one ai subdevice in this driver so there is no reason
to hold the last sample written to each channel in the subdevice
private data. Move the data into the device private data,
This gets some of the data out of the subdevice private data union
and removes some of the uses of the
This macro relies on a local variable having a specific name. Remove
the macro and add a local variable where used.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The for () loop that does the request_irq() in this driver is a bit of
an overkill. The code appears to have been copied from the pcmuio driver
which supports boards with 1 or 2 ASIC devices. The board supported by
this driver only has 1 ASIC.
Simplify the code and store the irq number in the
The SDF_CMD_READ should be one of the s-subdev_flags not part of
the s-type.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi_apci_1032.c | 4 ++--
1 file
This series cleans up all the comedi_lrange tables to make it easier to
spot common code that could be reduced.
The series is just to make it easier to review. If needed I can repost this
as a single patch.
H Hartley Sweeten (31):
staging: comedi: pcl812: tidy up comedi_lrange tables
Tidy up the whitespace in the comedi_lrange tables.
Use the BIP_RANGE and UNI_RANGE macros instead of the more generic
RANGE macro to reduce possible typo errors.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Tidy up the whitespace in the comedi_lrange tables.
Use the BIP_RANGE and UNI_RANGE macros instead of the more generic
RANGE macro to reduce possible typo errors.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 142 +--
1 file changed,
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das16m1.c | 24
1 file changed, 12
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/fl512.c | 19 ++-
1 file changed, 10
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/icp_multi.c | 13 +++--
1 file changed, 7 insertions(+),
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dmm32at.c | 26 --
1 file changed, 12
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci224.c | 44 ---
1 file changed,
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 42 +++-
1 file changed,
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 11 ++-
1 file changed, 6
The comedi_lrange tables are fixed length based on the 'length' value
before the array of comedi_krange 'range' values. For aesthetics, remove
the trailing comma from last 'range' value.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Tidy up the format of the comedi_lrange table.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9111.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 28 ++-
1 file changed,
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_test.c | 9 -
1 file changed, 4 insertions(+), 5
Tidy up the whitespace in the comedi_lrange tables.
Use the BIP_RANGE and UNI_RANGE macros instead of the more generic
RANGE macro to reduce possible typo errors.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adq12b.c | 27 ++-
1 file changed, 14
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 13 ++---
1 file changed, 6
Tidy up the whitespace in the comedi_lrange tables.
Use the BIP_RANGE macro instead of the more generic RANGE macro to
reduce the potential for typos.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Rename wait_dac_ready() so it has namespace associated with the
driver.
Fix the function so it returns an errno if the conversion times
out. Propogate this errno if it happens.
Define the analog output status register to remove the magic numbers.
Signed-off-by: H Hartley Sweeten
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 21 +++--
1 file changed, 11
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/me4000.c | 13 ++---
1 file changed, 6 insertions(+), 7
Tidy up the whitespace in the comedi_lrange tables.
Use the BIP_RANGE and UNI_RANGE macros instead of the more generic
RANGE macro to reduce possible typo errors.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 248 +---
1 file changed,
Tidy up the whitespace in the comedi_lrange tables.
Use the BIP_RANGE and UNI_RANGE macros instead of the more generic
RANGE macro to reduce possible typo errors.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas.c | 55 ++
1 file changed,
There is only one asic on the board so the for () loop in the interrupt
handler to check multiple asics is not needed.
The sanity check of the 'irq' in the interrupt handler is also not needed.
If it _is_ wrong we have bigger problems in the kernel.
Signed-off-by: H Hartley Sweeten
There are two ADC devices on this board. The first one handles ai
channels 0-7 and the second one channels 8-15.
Define the offset that is added to the iobase to access the 2nd
ADC device.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
To use interrupts the IRQ routing must be configured and interrupts
enabled. Currently both steps are being handled in pcmmio_start_intr().
Move the code that sets the IRQ routing into the attach of the board.
At this point interrupts are still disabled. The enable and polarity
bits just need to
Remove the extra indent levels in this function that resulted from
code removed in previous patches.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 182
Add some whitespace to the ai subdevice init and reorder it a bit
to follow the norm in comedi drivers.
Remove the init of s-len_chanlist. This member is only used with
subdevices that support async commands. The core will default the
value correctly..
The ai subdevice only uses the s-private
Tidy up the format of the comedi_lrange table.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
1 file changed, 2 insertions(+), 2
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbduxfast.c | 5 -
1 file changed, 4 insertions(+), 1
The 'pol' and 'enab' members in the private data are never used. The
'num' member is set during the attach but never used. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Tidy up the whitespace in the comedi_lrange tables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_atmio16d.c | 51
1 file changed,
The first 'asic_chan' that supports interrupts in the interrupt subdevice is
always initialized to '0'. Remove this unneeded information from the subdevice
private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
The 'first_chan' that supports interrupts in the interrupt subdevice is always
initialized to '0'. Remove this unneeded information from the subdevice private
data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Rename this function to have namespace associated with the driver.
Refactor the function to remove the extra write to the command register
to set the range before writing the DAC value. Since the range is constant
for the entire comedi_insn it only needs to be set once. All writes to the
DAC
On Thu, Dec 5, 2013 at 4:02 AM, Arve Hjønnevåg a...@android.com wrote:
On Wed, Dec 4, 2013 at 2:02 PM, Greg KH gre...@linuxfoundation.org wrote:
On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote:
On Wed, Dec 4, 2013 at 1:43 PM, Greg KH gre...@linuxfoundation.org wrote:
On Wed, Dec
Hey Greg--I'm working against Linus' latest tree on
https://github.com/torvalds/linux.git ... which tree should I be using
for the updated code?
Thanks!
Preetam
On Sun, Dec 8, 2013 at 5:30 PM, Greg KH gre...@linuxfoundation.org wrote:
On Sat, Dec 07, 2013 at 02:35:52PM -0800, Preetam D'Souza
On Tue, Dec 10, 2013 at 01:07:58PM +0800, Chen Gang wrote:
Hello Maintainers:
The compiler help me find a warning about it, please help check thanks.
The related git commit: b73db54 Staging: dgrp: Refactor the function
dgrp_receive() in drrp_net_ops.c
The related warning (with
1 - 100 of 102 matches
Mail list logo