Re: [PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
On Wed, Jan 8, 2014 at 10:16 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jan 08, 2014 at 10:00:15PM -0800, Insop Song wrote: This module downloads Xilinx FPGA image using gpio pins DESIGN -- * load Xilinx FPGA bitstream format[1] image using kernel firmware * framework,

[PATCH v2 1/2] stagin: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
This module downloads Xilinx FPGA image using gpio pins. It oads Xilinx FPGA bitstream format image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song insop.s...@gainspeed.com --- drivers/staging/Kconfig |2 + drivers/staging/Makefile

[PATCH v2 2/2] stagin: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
Review feedback, add TODO, remove EXPORT_SYMBOL, update README fie format Signed-off-by: Insop Song insop.s...@gainspeed.com --- drivers/staging/gs_fpgaboot/README| 50 +++-- drivers/staging/gs_fpgaboot/TODO | 14

[PATCH v3 0/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
(please ignore v2, v3 updates minor typos) Update based on Greg's feedback Driver for downloading Xilinx FPGA image V2 - Add TODO - remove EXPORT_SYMBOL - update README fie format Insop Song (2): stagin: fpgaboot: Driver for downloading Xilinx FPGA image stagin: fpgaboot: Driver for

[PATCH v3 1/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
This module downloads Xilinx FPGA image using gpio pins. It loads Xilinx FPGA bitstream format image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song insop.s...@gainspeed.com --- drivers/staging/Kconfig |2 + drivers/staging/Makefile

[PATCH 1/1] staging: dgap: Fix build error

2014-01-09 Thread Sachin Kamat
Include the header file for kzalloc to fix the following build error: drivers/staging/dgap/dgap_fep5.c: In function ‘dgap_do_config_load’: drivers/staging/dgap/dgap_fep5.c:78:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration] Signed-off-by: Sachin Kamat

RE: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory in context Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Victor Miasnikov
Hi! Is there no way we could implement file copying in user space? For file copy service user space may be pretty good But I ( and other Hyper-V sysadmin) see non-Ok ( in political correct terminalogy) results with hv: balloon: Online the hot-added memory in user space Best regards,

[PATCH 0/3] Staging: rtl8187se: Sparse fixes

2014-01-09 Thread me
From: Anmol Sarma m...@anmolsarma.in Fix sparse warnings for undeclared symbols not marked static. Anmol Sarma (3): Staging: rtl8187se: r8180_core.c: mark symbols as static Staging: rtl8187se: r8180_wx.c: mark symbols as static Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Olaf Hering
On Wed, Jan 08, K. Y. Srinivasan wrote: +++ b/tools/hv/hv_fcopy_daemon.c + len = pread(fcopy_fd, buffer, (4096 * 2), 0); + + if (len = 0) { + syslog(LOG_ERR, Read error: %s\n, strerror(errno)); + continue; This could flood

[PATCH 1/3] Staging: rtl8187se: r8180_core.c: mark symbols as static

2014-01-09 Thread me
From: Anmol Sarma m...@anmolsarma.in Fixes the following sparse warnings: 390:6: warning: symbol 'buffer_free' was not declared. Should it be static? 1031:5: warning: symbol 'ComputeTxTime' was not declared. Should it be static? 2345:7: warning: symbol 'rtl8180_init' was not declared. Should it

[PATCH 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread me
From: Anmol Sarma m...@anmolsarma.in Fixes the following sparse warnings: 50:14: warning: symbol 'ieee80211_MFIE_rate_len' was not declared. Should it be static? 68:6: warning: symbol 'ieee80211_MFIE_Brate' was not declared. Should it be static? 85:6: warning: symbol 'ieee80211_MFIE_Grate' was

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-01-09 Thread Alexandre Belloni
Hi, Sorry to chime in only now but it seems that this series is breaking the touchscreen calibration on 3.13 (and -rc7 is out so it might be too late). At first, I though I became a terrible clicker ;) but I found some evidences: xinput_calibrator is complaining about misclicks, debug output:

[PATCH 2/3] Staging: rtl8187se: r8180_wx.c: mark symbols as static

2014-01-09 Thread me
From: Anmol Sarma m...@anmolsarma.in Fixes the following sparse warning: 27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static? Signed-off-by: Anmol Sarma m...@anmolsarma.in --- drivers/staging/rtl8187se/r8180_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Greg KH
On Thu, Jan 09, 2014 at 12:21:06AM -0800, Insop Song wrote: On Wed, Jan 8, 2014 at 10:16 PM, Greg KH gre...@linuxfoundation.org wrote: Why is this driver going into the staging directory? We need a TODO file listing the issues that need to be taken care of in order to be able to move this

Re: [PATCH 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread Greg KH
On Thu, Jan 09, 2014 at 04:41:07PM +0530, m...@anmolsarma.in wrote: From: Anmol Sarma m...@anmolsarma.in Fixes the following sparse warnings: 50:14: warning: symbol 'ieee80211_MFIE_rate_len' was not declared. Should it be static? 68:6: warning: symbol 'ieee80211_MFIE_Brate' was not

Re: [PATCH 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread Dan Carpenter
On Thu, Jan 09, 2014 at 04:41:07PM +0530, m...@anmolsarma.in wrote: From: Anmol Sarma m...@anmolsarma.in Fix your email so this is in the email headers themselves. Fixes the following sparse warnings: 50:14: warning: symbol 'ieee80211_MFIE_rate_len' was not declared. Should it be

Re: [PATCH v3 2/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Greg KH
On Thu, Jan 09, 2014 at 01:36:15AM -0800, Insop Song wrote: --- /dev/null +++ b/drivers/staging/gs_fpgaboot/TODO @@ -0,0 +1,14 @@ +TODO: +- get bus width input instead of hardcoded bus width + + - make it easier to config different programming method for + other embedded

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-09 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 11:25:38PM +0800, Shawn Guo wrote: Yea, adding all four into imx-drm crtcs works for imx6q, but it doesn't for imx6dl, because ipu2 is unavailable for imx6dl at all. Here is how I get around it. Thanks, I've rolled your change into this commit now. -- FTTC broadband

Re: [PATCH] staging: usbip: userspace: add support for viewing imported devices

2014-01-09 Thread Greg KH
On Tue, Jan 07, 2014 at 09:05:56PM +0200, Valentina Manea wrote: As of Matt Mooney's major refactoring in 2011, usbip port option was left out. Add support for this option in a manner similar to the old implementation. Sample output: Imported USB devices Port 00:

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
-Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Thursday, January 09, 2014 4:04 AM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com Subject: Re: [PATCH 1/1]

Re: [PATCH]

2014-01-09 Thread Greg KH
On Tue, Dec 24, 2013 at 09:45:03AM -0600, Evan Hosseini wrote: --- Staging: android: fix parenthesis coding style issue in alarm-dev.c What happened to your Subject:? Also, why put the '---' line here? That means that git will delete everything else. This is a patch to the alarm-dev.c file

Re: your mail

2014-01-09 Thread Greg KH
On Mon, Dec 30, 2013 at 05:40:44PM +, Joe Borg wrote: From 6d9f6446434c4021cc9452e31c374ac50e08f0f9 Mon Sep 17 00:00:00 2001 From: Joe Borg r...@josephb.org This isn't matching your from: line on your email, why should I trust it? And doing kernel work as 'root'? That's not a good idea

Re: [PATCH] DAS1800: Fixed typeo.

2014-01-09 Thread Greg KH
On Thu, Jan 02, 2014 at 05:10:00PM +, Joe Borg wrote: Fixed foo * bar should be foo *bar. Fixed by Joe Borg r...@josephb.org That's not a signed-off-by: line, did you run this patch through scripts/checkpatch.pl? Also, your subject line has a typo :) thanks, greg k-h

Re: [PATCH] DAS6042: Fixing typeo.

2014-01-09 Thread Greg KH
On Thu, Jan 02, 2014 at 05:25:20PM +, Joe Borg wrote: Fixing foo * bar should be foo *bar. Fixed by Joe Borg r...@josephb.org Same comments as the last, I can't take this :( ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: rts5139: Fixed style issues

2014-01-09 Thread Greg KH
On Mon, Jan 06, 2014 at 07:05:09AM -0700, Morgan Creekmore wrote: Fixed style issues for lines over 80 chars Signed-off-by: Morgan Creekmore gamingro...@gmail.com --- drivers/staging/rts5139/rts51x_card.c | 10 +- drivers/staging/rts5139/rts51x_card.h | 8 2 files

Re: your mail

2014-01-09 Thread Joe Borġ
Hi Greg, I'll re do them tonight. I didn't do the changes as root, I sent them from my server as it has SMTP out. Thanks Regards, Joseph David Borġ http://www.jdborg.com On 9 January 2014 18:39, Greg KH gre...@linuxfoundation.org wrote: On Mon, Dec 30, 2013 at 05:40:44PM +, Joe Borg

Re: [PATCH v2] Staging: comedi: drivers:

2014-01-09 Thread Greg KH
On Mon, Jan 06, 2014 at 11:08:14PM -0500, Aruna-Hewapathirane wrote: Fixed a coding style issue in ke_counter.c You forgot a valid Subject: line :( ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: comedi: replace printk() calls with dev_dbg() in pcmmio.c

2014-01-09 Thread Greg KH
On Fri, Dec 27, 2013 at 06:07:21PM -0600, Chase Southwood wrote: From: Chase Southwood csou...@illinois.edu Changed several printk() calls to dev_dbg() or dev_err() in pcmmio.c to fix checkpatch.pl warnings. Patched from 3.13-rc5. Please line-wrap your changelog entries. Also, this is

Re: [PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
On Thu, Jan 9, 2014 at 6:32 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 09, 2014 at 12:21:06AM -0800, Insop Song wrote: On Wed, Jan 8, 2014 at 10:16 PM, Greg KH gre...@linuxfoundation.org wrote: Why is this driver going into the staging directory? We need a TODO file listing

status of sm7xfb staging driver?

2014-01-09 Thread Greg KH
Hi Teddy, It's been pointed out to me that there hasn't been any forward development on the sm7xxfb in over a year now. Is development dead, and I should delete it, or are you planning on doing more work on it soon so that it can be merged out of the staging tree? thanks, greg k-h

[PATCH v2 0/3] Staging: rtl8187se: Sparse fixes

2014-01-09 Thread Anmol Sarma
Fix sparse warnings for undeclared symbols not marked static. Anmol Sarma (3): Staging: rtl8187se: r8180_core.c: mark symbols as static Staging: rtl8187se: r8180_wx.c: make 'rtl8180_rates' static Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

[PATCH v2 1/3] Staging: rtl8187se: r8180_core.c: mark symbols as static

2014-01-09 Thread Anmol Sarma
Fix sparse warnings for undeclared symbols not marked static like: 390:6: warning: symbol 'buffer_free' was not declared. Should it be static? 1031:5: warning: symbol 'ComputeTxTime' was not declared. Should it be static? Signed-off-by: Anmol Sarma m...@anmolsarma.in ---

[PATCH v2 2/3] Staging: rtl8187se: r8180_wx.c: make 'rtl8180_rates' static

2014-01-09 Thread Anmol Sarma
Fixes the following sparse warning: 27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static? Signed-off-by: Anmol Sarma m...@anmolsarma.in --- drivers/staging/rtl8187se/r8180_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Dan Carpenter
We've had this discussion before where you urge me to trust the host... Problem: This code is racy. Solution: The host will only send one message at a time. Now I have to audit the user space code on the host and I don't feel like doing that so you win. I wish we had a better way to do IPC.

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread gre...@linuxfoundation.org
On Thu, Jan 09, 2014 at 11:09:21PM +0300, Dan Carpenter wrote: We've had this discussion before where you urge me to trust the host... Problem: This code is racy. Solution: The host will only send one message at a time. Now I have to audit the user space code on the host and I don't feel

[PATCH v4 0/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-09 Thread Insop Song
Xilinx FPGA firmware download driver v4 - update based on feedback - merge change into one patch Insop Song (1): staging: fpgaboot: Xilinx FPGA firmware download driver drivers/staging/Kconfig |2 + drivers/staging/Makefile |1 +

[PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-09 Thread Insop Song
This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream format firmware image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song insop.s...@gainspeed.com --- drivers/staging/Kconfig |2 +

[PATCH 1/2] Staging: rtl8188eu: Fixed required spaces after ',' and around '=' and '=='

2014-01-09 Thread Tim Jester-Pfadt
This patch fixes all spaces required after ',' and around '=' aswell as '==' checkpatch.pl errors for rtl8188eu. Signed-off-by: Tim Jester-Pfadt t...@gmx.de --- drivers/staging/rtl8188eu/include/Hal8188EPwrSeq.h | 2 +- drivers/staging/rtl8188eu/include/odm.h| 2 +-

[PATCH 0/2] Staging: rtl8188eu: checkpatch.pl error cleanups

2014-01-09 Thread Tim Jester-Pfadt
This patchset fixes all occurrences of the space required after ',' space required around '=' aswell as foo * bar related checkpatch.pl errors in rtl8188eu. The patchset does not fix the remaining 80 character limit warnings, since this might require more substantial code modifiction. Tim

[PATCH 2/2] Staging: rtl8188eu: Fixed foo * bar related coding style issues

2014-01-09 Thread Tim Jester-Pfadt
This patch fixes all foo * bar, foo*bar, foo* bar checkpatch.pl errors for rtl8188eu. Signed-off-by: Tim Jester-Pfadt t...@gmx.de --- drivers/staging/rtl8188eu/include/osdep_service.h | 4 +-- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2 +-

[PATCH v2 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread Anmol Sarma
Fix sparse warnings for undeclared symbols not marked static like: 148:6: warning: symbol 'enqueue_mgmt' was not declared. Should it be static? 166:16: warning: symbol 'dequeue_mgmt' was not declared. Should it be static? Signed-off-by: Anmol Sarma m...@anmolsarma.in ---

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Thursday, January 09, 2014 12:09 PM To: KY Srinivasan Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; linux- ker...@vger.kernel.org; a...@canonical.com; de...@linuxdriverproject.org

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
-Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Thursday, January 09, 2014 12:15 PM To: Dan Carpenter Cc: KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux- ker...@vger.kernel.org; a...@canonical.com;

[PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-09 Thread Haiyang Zhang
This will allow us to use bigger receive buffer, and prevent allocation failure due to fragmented memory. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com --- drivers/hv/channel.c| 14 --

Re: status of echo staging driver?

2014-01-09 Thread David Rowe
Hi Greg, Development as been completed, and AFAIK it works just fine for many people. Is there anything that needs to be done from your side to get it merged into the kernel? Apologies if I'm missing something in the development process. Cheers, David On Thu, 2014-01-09 at 11:13 -0800, Greg

[PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-09 Thread Rostislav Lisovy
This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/ The driver was tested with both cards. Everything seems to work properly.

Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-09 Thread Rostislav Lisovy
On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote: On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote: This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the

[PATCH v3] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-09 Thread Rostislav Lisovy
Changes since v2: * Removed one unused constant * Corrected commit message Changes since v1: * Implemented all the small and big remarks pointed out by Hartley Sweeten, Dan Carpenter and Ian Abbott Rostislav Lisovy (1): comedi: Humusoft MF634 and MF624 DAQ cards driver

[PATCH] Staging: comedi: amcc_s5933: no space before tabs coding style fixes.

2014-01-09 Thread Michal Kwiatkowski
Fixed a coding style issues. Signed-off-by: Michal Kwiatkowski michaelflower...@geekingspree.com --- drivers/staging/comedi/drivers/amcc_s5933.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/amcc_s5933.h

Re: status of echo staging driver?

2014-01-09 Thread Steve Underwood
Hi Greg, As David said, the echo cancellation module is widely used, and gives good service. We have had no reason to touch the code for a long time. The last thing I remember doing was to make a minor correction to filter gain, which avoided a distortion issue some people saw. That was in

Re: status of echo staging driver?

2014-01-09 Thread Greg KH
On Fri, Jan 10, 2014 at 10:45:42AM +0800, Steve Underwood wrote: Hi Greg, As David said, the echo cancellation module is widely used, and gives good service. We have had no reason to touch the code for a long time. The last thing I remember doing was to make a minor correction to filter

Re: [PATCH 1/1] staging: dgap: Fix build error

2014-01-09 Thread Sachin Kamat
system. I got this while building today's linux-next (20140109) for ARM on x86 machine. Regards, Sachin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: status of echo staging driver?

2014-01-09 Thread Greg KH
On Fri, Jan 10, 2014 at 11:26:52AM +0800, Steve Underwood wrote: Hi Greg, On 01/10/2014 11:09 AM, Greg KH wrote: On Fri, Jan 10, 2014 at 10:45:42AM +0800, Steve Underwood wrote: Hi Greg, As David said, the echo cancellation module is widely used, and gives good service. We have had

[PATCH] Staging: comedi: fix spacing coding style issue in 8255.c.

2014-01-09 Thread Chase Southwood
This patch for 8255.c fixes a spacing warning found by checkpatch.pl. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- drivers/staging/comedi/drivers/8255.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/8255.c

Re: 答复: status of sm7xfb staging driver?

2014-01-09 Thread Greg KH
On Fri, Jan 10, 2014 at 12:12:19PM +0800, Teddy.Wang 王力强 wrote: Hello Greg, SM712/SM722 chip is phase out. So, should I just delete the driver if you aren't going to be able to do any future work on it? But we plan to merge our new chip SM750 driver codes to the linux tree? How can I do

Re: [PATCH 1/1] staging: dgap: Fix build error

2014-01-09 Thread Sachin Kamat
on x86, and I have not gotten any build failure reports from the build system. I got this while building today's linux-next (20140109) for ARM on x86 machine. This issue seems to have been fixed in 20140110 linux-next tree by a patch from Vincent (staging: dgap: fix missing header inclusion

答复: status of sm7xfb staging driver?

2014-01-09 Thread Teddy . Wang 王力强
Hello Greg, SM712/SM722 chip is phase out. But we plan to merge our new chip SM750 driver codes to the linux tree? How can I do it? Thanks. Best Regards, Teddy Wang -邮件原件- 发件人: Greg KH [mailto:gre...@linuxfoundation.org] 发送时间: 2014年1月10日 3:13 收件人: Teddy.Wang 王力强 抄送: