Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c

2014-01-14 Thread Xiong, Jinshan
On Jan 13, 2014, at 11:56 PM, Dilger, Andreas andreas.dil...@intel.com wrote: Begin forwarded message: From: Greg KH gre...@linuxfoundation.org Subject: Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c Date: January 11,

Re: [PATCH 3/3] memstick: Add realtek USB memstick host driver

2014-01-14 Thread Dan Carpenter
On Tue, Jan 14, 2014 at 03:47:36PM +0800, rogera...@realtek.com wrote: +static int ms_pull_ctl_disable(struct rtsx_ucr *ucr) +{ + rtsx_usb_init_cmd(ucr); + + if (CHECK_PKG(ucr, LQFP48)) { + rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, +

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-14 Thread Insop Song
On Mon, Jan 13, 2014 at 10:44 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: On Sat, Jan 11, 2014 at 4:10 PM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11, 2014 at 03:56:48PM -0800, Insop Song wrote: On Sat, Jan 11, 2014

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-14 Thread Insop Song
On Tue, Jan 14, 2014 at 1:18 AM, Insop Song insop.s...@gmail.com wrote: On Mon, Jan 13, 2014 at 10:44 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: On Sat, Jan 11, 2014 at 4:10 PM, Greg KH gre...@linuxfoundation.org wrote: On Sat,

Re: vme_tsi148 question

2014-01-14 Thread Martyn Welch
On 14/01/14 04:07, Michael Kenney wrote: Unfortunately, the results are the same. I'm running this from home so I'll have to confirm with the logic-analyzer tomorrow but the bridge driver error messages suggest the same D8 writes (which for some reason our A/D board does not like). The

Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c

2014-01-14 Thread Monam Agarwal
On Tue, Jan 14, 2014 at 1:31 PM, Xiong, Jinshan jinshan.xi...@intel.com wrote: On Jan 13, 2014, at 11:56 PM, Dilger, Andreas andreas.dil...@intel.com wrote: Begin forwarded message: From: Greg KH gre...@linuxfoundation.org Subject: Re: [PATCH v3 1/2] Staging: lustre: Refactor the

Re: [PATCH] Staging: comedi: move trailing statement to next line in ni_mio_common.c

2014-01-14 Thread Ian Abbott
On 2014-01-14 07:23, Dan Carpenter wrote: On Mon, Jan 13, 2014 at 07:16:14PM -0800, Joe Perches wrote: On Mon, 2014-01-13 at 21:13 -0600, Chase Southwood wrote: This patch for ni_mio_common.c silences a checkpatch error due to a trailing statement. [] diff --git

Re: [PATCH] Staging: comedi: remove unnecessary braces in pcl711.c

2014-01-14 Thread Ian Abbott
On 2014-01-14 03:13, Chase Southwood wrote: This patch for pcl711.c removes braces causing a checkpatch.pl warning. It also removes an empty else arm of an if-else statement. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- I removed the else arm of this statement because it was

[PATCH 1/2] Staging: media: Fix quoted string split across line in as102_fe.c

2014-01-14 Thread Monam Agarwal
This patch fixes the following checkpatch.pl issues in as102/as102_fe.c WARNING: quoted string split across lines Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/media/as102/as102_fe.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] Staging: media: Fix line length exceeding 80 characters in as102_fe.c

2014-01-14 Thread Monam Agarwal
This patch fixes the following checkpatch.pl issues in as102/as102_fe.c WARNING: line over 80 characters Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/media/as102/as102_fe.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-14 Thread Lee Jones
From: Roger Tseng rogera...@realtek.com Realtek USB card reader provides a channel to transfer command or data to flash memory cards. This driver exports host instances for mmc and memstick subsystems and handles basic works. Signed-off-by: Roger Tseng rogera...@realtek.com ---

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-14 Thread Dan Carpenter
[ Sorry, I am coming down with the flu today so I'm doing dorky things like reviewing review comments. I'm not sure how coherent I am. ] On Tue, Jan 14, 2014 at 01:04:09PM +, Lee Jones wrote: +static void rtsx_usb_sg_timed_out(unsigned long data) +{ + struct rtsx_ucr *ucr =

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-14 Thread Dan Carpenter
On Tue, Jan 14, 2014 at 04:46:34PM +0300, Dan Carpenter wrote: [ Sorry, I am coming down with the flu today so I'm doing dorky things like reviewing review comments. I'm not sure how coherent I am. ] On Tue, Jan 14, 2014 at 01:04:09PM +, Lee Jones wrote: +static void

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-14 Thread Lee Jones
[ Sorry, I am coming down with the flu today so I'm doing dorky things like reviewing review comments. I'm not sure how coherent I am. ] Always welcome. NB: I did this review in double-quick time, which may account for some of the weird thought processes (or lack there of). +static

[PATCH] Staging: media: Fix line length exceeding 80 characters in as102_drv.c

2014-01-14 Thread Monam Agarwal
This patch fixes the following checkpatch.pl warning in as102/as102_drv.c WARNING: line over 80 characters in the file Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/media/as102/as102_drv.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-14 Thread Greg Kroah-Hartman
On Tue, Jan 14, 2014 at 03:47:34PM +0800, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com Realtek USB card reader provides a channel to transfer command or data to flash memory cards. This driver exports host instances for mmc and memstick subsystems and handles

[PATCH 5/8] staging: dgap: Fix trailing whitespace in dgap_downld.h

2014-01-14 Thread Masanari Iida
This patch fixed trailing whitespace found by checkpatch.pl in staging/dgap/dgap_downld.h Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/dgap/dgap_downld.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap_downld.h

[PATCH 7/8] staging: dgap: Fix trailing whitespace in dgap_sysfs.h

2014-01-14 Thread Masanari Iida
This patch fixed trailing whitespace found by checkpatch.pl in staging/dgap/dgap_sysfs.h Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/dgap/dgap_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgap/dgap_sysfs.h

[PATCH 8/8] staging: dgap: Fix trailing whitespace in dgap_fep5.h

2014-01-14 Thread Masanari Iida
This patch fixed trailing whitespace found by checkpatch.pl in staging/dgap/dgap_fep5.h Signed-off-by: Masanari Iida standby2...@gmail.com # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message

[PATCH 4/8] staging: dgap: Fix trailing whitespace in dgap_driver.c

2014-01-14 Thread Masanari Iida
This patch fixed trailing whitespace found by checkpatch.pl in staging/dgap/dgap_driver.c Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/dgap/dgap_driver.c | 40 +++--- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git

[PATCH 6/8] staging: dgap: Fix trailing whitespace in dgap_driver.h

2014-01-14 Thread Masanari Iida
This patch fixed trailing whitespace found by checkpatch.pl in staging/dgap/dgap_driver.h Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/dgap/dgap_driver.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH 2/8] staging: dgap: Fix trailing whitespace in dgap_sysfs.c

2014-01-14 Thread Masanari Iida
This patch fixed trailing whitespace found by checkpatch.pl in dgap/dgap_sysfs.c Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/dgap/dgap_sysfs.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgap/dgap_sysfs.c

[PATCH 1/8] staging: dgap: Fix trailing whitespace in digi.h

2014-01-14 Thread Masanari Iida
This patch fixed trailing whitespace error found by checkpatch.pl in dgap/digi.h Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/dgap/digi.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/dgap/digi.h

[PATCH 3/7] staging,spear_adc: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/staging/iio/adc/spear_adc.c: In function ‘spear_adc_probe’: drivers/staging/iio/adc/spear_adc.c:393:2: error: implicit declaration of function ‘iounmap’

[PATCH 4/7] phy,exynos: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `exynos_mipi_video_phy_probe': drivers/phy/phy-exynos-mipi-video.c:130: undefined reference to `devm_ioremap_resource' Signed-off-by: Richard

[PATCH 1/7] ptp_pch: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/ptp/ptp_pch.c: In function ‘pch_remove’: drivers/ptp/ptp_pch.c:571:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

[PATCH 2/7] staging,dgap: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/staging/dgap/dgap_driver.c: In function ‘dgap_cleanup_board’: drivers/staging/dgap/dgap_driver.c:457:3: error: implicit declaration of function ‘iounmap’

[PATCH 5/7] net,marvell: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `orion_mdio_probe': drivers/net/ethernet/marvell/mvmdio.c:228: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger rich...@nod.at

[PATCH 3/8] staging: dgap: Fix trailing whitespace in dgap_parse.c

2014-01-14 Thread Masanari Iida
Thsi patch fixed trailing whitespace found by checkpatch.pl in dgap/dgap_parse.c Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/dgap/dgap_parse.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/dgap/dgap_parse.c

[PATCH 6/7] power,goldfish: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `goldfish_battery_probe': drivers/power/goldfish_battery.c:181: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger rich...@nod.at

[PATCH 7/7] staging,lpc32xx_adc: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `lpc32xx_adc_probe': drivers/staging/iio/adc/lpc32xx_adc.c:149: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger rich...@nod.at

Re: vme_tsi148 question

2014-01-14 Thread Michael Kenney
On Tue, Jan 14, 2014 at 1:39 AM, Martyn Welch martyn.we...@ge.com wrote: On 14/01/14 04:07, Michael Kenney wrote: Unfortunately, the results are the same. I'm running this from home so I'll have to confirm with the logic-analyzer tomorrow but the bridge driver error messages suggest the same

Re: your mail

2014-01-14 Thread Steven Rostedt
On Thu, Jan 09, 2014 at 06:49:39PM +, Joe Bor?? wrote: I didn't do the changes as root, I sent them from my server as it has SMTP out. Hmm, this gives me an idea. There's nothing, I believe, that makes the root user have to have the name root except for the passwd file. Maybe I'll just

Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c

2014-01-14 Thread Xiong, Jinshan
On Jan 14, 2014, at 3:09 AM, Monam Agarwal monamagarwal...@gmail.commailto:monamagarwal...@gmail.com wrote: On Tue, Jan 14, 2014 at 1:31 PM, Xiong, Jinshan jinshan.xi...@intel.commailto:jinshan.xi...@intel.com wrote: On Jan 13, 2014, at 11:56 PM, Dilger, Andreas

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: On Tue, Jan 14, 2014 at 1:18 AM, Insop Song insop.s...@gmail.com wrote: On Mon, Jan 13, 2014 at 10:44 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: On Sat, Jan 11, 2014

[PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-14 Thread K. Y. Srinivasan
Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of guest integration services supported on the Windows platform. Here is a link that provides additional details on this functionality:

[PATCH v2] Staging: comedi: convert while loop to timeout in ni_mio_common.c.

2014-01-14 Thread Chase Southwood
This patch to ni_mio_common.c changes a while loop to a timeout for loop, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- I know Mr. Abbott mentioned that he wouldn't expect clean-up patches to have to deal with this sort of thing, but I thought I'd at least

Re: [PATCH v2] Staging: comedi: convert while loop to timeout in ni_mio_common.c.

2014-01-14 Thread Joe Perches
On Tue, 2014-01-14 at 13:38 -0600, Chase Southwood wrote: This patch to ni_mio_common.c changes a while loop to a timeout for loop, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- I know Mr. Abbott mentioned that he wouldn't expect clean-up patches to have

Re: [PATCH v2] Staging: comedi: convert while loop to timeout in ni_mio_common.c.

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 01:38:46PM -0600, Chase Southwood wrote: This patch to ni_mio_common.c changes a while loop to a timeout for loop, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- I know Mr. Abbott mentioned that he wouldn't expect clean-up patches

Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

2014-01-14 Thread Levente Kurusa
Hello, 2014/1/14 Michał Kwiatkowski michaelflower...@geekingspree.com: From: Michal Kwiatkowski michaelflower...@geekingspree.com This is a patch to the alarm-dev.c file that removes parentheses which should not appear in return statement. This error was found by the checkpatch.pl tool.

Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

2014-01-14 Thread Greg Kroah-Hartman
On Tue, Jan 14, 2014 at 10:43:04PM +0100, Levente Kurusa wrote: Hello, 2014/1/14 Michał Kwiatkowski michaelflower...@geekingspree.com: From: Michal Kwiatkowski michaelflower...@geekingspree.com This is a patch to the alarm-dev.c file that removes parentheses which should not appear in

Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-14 Thread Olaf Hering
On Tue, Jan 14, K. Y. Srinivasan wrote: +static ssize_t fcopy_write(struct file *file, const char __user *buf, + size_t count, loff_t *ppos) +{ + int error = 0; + + if (count != sizeof(int)) + return 0; + + if (copy_from_user(error, buf,

Re: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-14 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Thu, 9 Jan 2014 14:24:47 -0800 This will allow us to use bigger receive buffer, and prevent allocation failure due to fragmented memory. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com

Re: [PATCH v3] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 03:31:01PM -0600, Chase Southwood wrote: This patch to ni_mio_common.c changes a simple while loop to a timeout, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- I removed the extra counter variable this time. Greg, you mentioned

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-14 Thread KY Srinivasan
-Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Tuesday, January 14, 2014 2:13 PM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com Subject: Re: [PATCH V2 1/1]

[PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-14 Thread Chase Southwood
This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- OK, here's another go at it. Hopefully everything looks more correct this time. Greg, I've followed the pattern you gave me, and I really

Re: [PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 06:23:05PM -0600, Chase Southwood wrote: This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- OK, here's another go at it. Hopefully everything looks more correct

[PATCH v5] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-14 Thread Chase Southwood
This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- All right, I think this guy's ready to go now! Thanks for all the help! Chase 2: Changed from simple clean-up to swapping a timeout in for a