We allocate bdev and then krealloc the devs pointer in order to add bdev
at the end of the devpriv->devs array list. But if for some reason this
krealloc fails, we need to free bdev before returning an error otherwise
this memory is leaked.
Signed-off-by: Chase Southwood
---
drivers/staging/com
Whitespace between #define keyword and BINDER_* constants are space in
some point and tab in some point. Using space or tab is just writer's
choice. But, let's use them more consistently.
Signed-off-by: SeongJae Park
---
drivers/staging/android/binder.h | 10 +-
1 file changed, 5 inserti
Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
anywhere.
Signed-off-by: SeongJae Park
---
drivers/staging/android/binder.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
index c4
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled "staging: r8188eu:
Remove wrappers around vmalloc and vzalloc" and
commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled "staging: r8188eu:
Remove wrappers around vfree" failed to add the header file needed
to provide vzalloc and vfree.
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, February 07, 2014 3:21 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com
> Subject: Re: [PATCH V2 1/
On Fri, Feb 07, 2014 at 06:59:11PM +, Russell King - ARM Linux wrote:
> Sorry. Deferred probe does work, it's been tested with imx-drm, not
> only from the master component but also the sub-components. There's
> no problem here.
Here's the proof that it also works with the Cubox, and armada
On 02/07/2014 06:04 PM, Greg KH wrote:
On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote:
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled "staging: r8188eu:
Remove wrappers around vmalloc and vzalloc" and
commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled "staging: r81
On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote:
> Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled "staging: r8188eu:
> Remove wrappers around vmalloc and vzalloc" and
> commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled "staging: r8188eu:
> Remove wrappers around vfree
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled "staging: r8188eu:
Remove wrappers around vmalloc and vzalloc" and
commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled "staging: r8188eu:
Remove wrappers around vfree" failed to add the header file needed
to provide vzalloc and vfree.
On Wed, Jan 29, 2014 at 06:14:39PM -0800, K. Y. Srinivasan wrote:
> On Gen2 firmware, Hyper-V does not emulate the PCI bus. However, the MMIO
> information is packaged up in DSDT. Extract this information and export it
> for use by the synthetic framebuffer driver. This is the only driver that
> ne
On Tue, Jan 21, 2014 at 05:43:53PM -0800, K. Y. Srinivasan wrote:
> +/*
> + * Create a char device that can support read/write for passing
> + * the payload.
> + */
> +static struct cdev fcopy_cdev;
> +static struct class *cl;
> +static struct device *sysfs_dev;
Why not just be a misc device, you
On Thu, Feb 06, 2014 at 10:35:04PM +0800, rogera...@realtek.com wrote:
> From: Roger Tseng
>
> This patchset adds modules to support Realtek USB vendor specific class flash
> card reader: one base module in MFD subsystem and two host modules in both mmc
> and memstick subsystems. The architecture
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote:
> This patch series tries to simplify the code of simple devices in case
> they are part of componentised subsystems, are declared in a DT, and
> are not using the component bin/unbind functions.
Here's my changes to the TDA998x
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, February 07, 2014 11:12 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com
> Subject: Re: Drivers/hv
On Fri, Feb 07, 2014 at 07:06:00PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Wednesday, January 29, 2014 1:16 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Wednesday, January 29, 2014 1:16 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com
> Subject: Re: Drivers/hv
On Fri, Feb 07, 2014 at 07:42:04PM +0100, Jean-Francois Moine wrote:
> On Fri, 7 Feb 2014 17:33:26 +
> Russell King - ARM Linux wrote:
>
> > On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote:
> > > This patch series tries to simplify the code of simple devices in case
> > >
On Thu, Jan 30, 2014 at 07:14:02PM +0530, Avinash kumar wrote:
> drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported
> warnings
>
> sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file
> drivers/staging/dgnc/dpacompat.h
> drivers/staging/dgnc/dpacompat.h:109:
On Fri, 7 Feb 2014 17:33:26 +
Russell King - ARM Linux wrote:
> On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote:
> > This patch series tries to simplify the code of simple devices in case
> > they are part of componentised subsystems, are declared in a DT, and
> > are not
On Thu, Feb 06, 2014 at 12:10:36AM +0800, Zhao, Gang wrote:
> fix make W=1 warning:
> drivers/staging/et131x/et131x.c: In function
> ‘et1310_setup_device_for_multicast’:
> drivers/staging/et131x/et131x.c:1052:6: warning: variable ‘pm_csr’ set but
> not used [-Wunused-but-set-variable]
> u32 pm_
On Wed, Jan 15, 2014 at 10:37:13PM +0100, Pol Eyschen wrote:
> Fixed checkpatch.pl issues and removed redundant comment in ced_ioc.cs
>
> Signed-off-by: Pol Eyschen
> ---
> drivers/staging/ced1401/ced_ioc.c | 483
> +
> 1 file changed, 271 insertions(+), 212
On Fri, Feb 07, 2014 at 05:53:27PM +0100, Jean-Francois Moine wrote:
> At system startup time, some devices depends on the availability of
> some other devices before starting. The infrastructure for componentised
> subsystems permits to handle this dependence, each driver defining
> its own role.
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote:
> This patch series tries to simplify the code of simple devices in case
> they are part of componentised subsystems, are declared in a DT, and
> are not using the component bin/unbind functions.
I wonder - I said earlier today t
On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote:
> Some simple components don't need to do any specific action on
> bind to / unbind from a master component.
>
> This patch permits such components to omit the bind/unbind
> operations.
>
> Signed-off-by: Jean-Francois Moine
>
On Fri, Feb 07, 2014 at 06:09:46PM +0100, Jean-Francois Moine wrote:
> *** BLURB HERE ***
Subject and BLURB forgotten?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
*** BLURB HERE ***
Jean-Francois Moine (2):
drivers/base: permit base components to omit the bind/unbind ops
drivers/base: declare phandle DT nodes as components
drivers/base/component.c | 21 +++--
drivers/base/core.c | 18 ++
include/linux/of.h |
At system startup time, some devices depends on the availability of
some other devices before starting. The infrastructure for componentised
subsystems permits to handle this dependence, each driver defining
its own role.
This patch does an automatic creation of the lowest components in
case of DT
Some simple components don't need to do any specific action on
bind to / unbind from a master component.
This patch permits such components to omit the bind/unbind
operations.
Signed-off-by: Jean-Francois Moine
---
drivers/base/component.c | 9 +++--
1 file changed, 7 insertions(+), 2 delet
This patch series tries to simplify the code of simple devices in case
they are part of componentised subsystems, are declared in a DT, and
are not using the component bin/unbind functions.
Jean-Francois Moine (2):
drivers/base: permit base components to omit the bind/unbind ops
drivers/base:
At system startup time, some devices depends on the availability of
some other devices before starting. The infrastructure for componentised
subsystems permits to handle this dependence, each driver defining
its own role.
This patch does an automatic creation of the lowest components in
case of DT
Some simple components don't need to do any specific action on
bind to / unbind from a master component.
This patch permits such components to omit the bind/unbind
operations.
Signed-off-by: Jean-Francois Moine
---
drivers/base/component.c | 9 +++--
1 file changed, 7 insertions(+), 2 delet
On Fri, Feb 07, 2014 at 07:12:50PM +0800, Zhao, Gang wrote:
> Mark, could you look at this patch? It has not been acked.
1 day after sending this you are asking for review? Please realize that
people are busy and have other things to do. If after a week or so
there is no response, is it ok to as
On Friday, February 07, 2014 7:52 AM, Ian Abbott wrote:
> On 2014-02-06 23:48, H Hartley Sweeten wrote:
>> Introduce a comedi core helper function to handle the boilerplate
>> needed by the drivers to wait for a condition to occur. Typically
>> this condition is the analog input/output end-of-conve
On Fri, Feb 07, 2014 at 04:14:01PM +, Hartley Sweeten wrote:
> On Friday, February 07, 2014 8:34 AM, Ian Abbott wrote:
> > On 2014-02-06 23:49, H Hartley Sweeten wrote:
> >> Use comedi_timeout() to wait for the analog input end-of-conversion.
> >>
> >> Combine the logic for the pcl812 and acl81
On Friday, February 07, 2014 8:34 AM, Ian Abbott wrote:
> On 2014-02-06 23:49, H Hartley Sweeten wrote:
>> Use comedi_timeout() to wait for the analog input end-of-conversion.
>>
>> Combine the logic for the pcl812 and acl812 end-of-conversion in the
>> helper function to simplify the driver.
>>
>>
On 2014-02-06 23:49, H Hartley Sweeten wrote:
All the comedi drivers that now use comedi_timeout() return a standard
errno when a timeout occurs. Remove all the private debug messages and
have the core output the dev_dbg() message.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah
On 2014-02-06 23:49, H Hartley Sweeten wrote:
Use comedi_timeout() to wait for the analog input end-of-conversion.
The interrupt routine also uses the timeout check to make sure data
is actually available. Using NULL here for the 'insn' is safe since
nothing uses it.
Interrupt routine, arrrgh!
On 2014-02-06 23:49, H Hartley Sweeten wrote:
Use comedi_timeout() to wait for the analog input end-of-conversion.
Combine the logic for the pcl812 and acl812 end-of-conversion in the
helper function to simplify the driver.
The interrupt routine also uses the timeout check to make sure data
is
On 2014-02-06 23:49, H Hartley Sweeten wrote:
Use comedi_timeout() to wait for the analog input end-of-conversion.
The interrupt routine also uses the timeout check to make sure data
is actually available. Using NULL here for the 'insn' is safe since
nothing uses it.
No good in interrupt routi
This patch fixed spelling typos in sec.c
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/ptlrpc/sec.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c
b/drivers/staging/lustre/lustre/ptlrpc/sec.c
index 9
This patch fixed spelling typo found in client.c
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
b/drivers/staging/lustr
This patch fixed spelling typo in lustre/ptlrpc.
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/ptlrpc/events.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/import.c | 4 ++--
drivers/staging/lustre/lustre/ptlrpc/layout.c | 2 +-
drivers/staging/lustre/lustre/pt
This patch fixed spelling typo in comments within
lustre/ptlrpc/gss.
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/ptlrpc/gss/gss_cli_upcall.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/gss/gss_keyring.c| 2 +-
drivers/staging/lustre/lustre/ptlrpc/gss/gss_pipefs.c | 4
This patch fixed spelling typo in comments wihtin sec_gss.c
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/ptlrpc/gss/sec_gss.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/gss/sec_gss.c
b/drivers/staging/l
On 2014-02-06 23:49, H Hartley Sweeten wrote:
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt2814.c | 44 +++--
1 file changed, 26 i
This patch fixed spelling typo founx in service.c
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/ptlrpc/service.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c
b/drivers/staging/lustre/lustre/ptlrpc/
On 2014-02-06 23:49, H Hartley Sweeten wrote:
Use comedi_timeout() to wait for the analog input end-of-conversion.
Use break to exit the loop so that the common path can be used to unlock
the spinlock.
I don't think you can rely on jiffies being updated while holding the
spin-lock with interr
On 2014-02-06 23:48, H Hartley Sweeten wrote:
Introduce a comedi core helper function to handle the boilerplate
needed by the drivers to wait for a condition to occur. Typically
this condition is the analog input/output end-of-conversion used
with the comedi (*insn_read) and (*insn_write) operati
On Fri, Feb 07, 2014 at 12:57:21PM +0100, Jean-Francois Moine wrote:
> I started to use your code (which works fine, thanks), and it avoids a
> lot of problems, especially, about probe_defer in a DT context.
>
> I was wondering if your componentised mechanism could be extended to the
> devices def
On Fri, 7 Feb 2014 09:46:56 +
Russell King - ARM Linux wrote:
> On Fri, Feb 07, 2014 at 10:04:30AM +0100, Daniel Vetter wrote:
> > I've chatted a bit with Hans Verkuil about this topic at fosdem and
> > apparently both v4l and alsa have something like this already in their
> > helper librarie
On Fri, Feb 07, 2014 at 07:12:50PM +0800, Zhao, Gang wrote:
> Mark, could you look at this patch? It has not been acked.
Sure, in time, I'm making my way through them. Unfortunately kernel
programming is not my day job, and gets done in my spare time (which
is a bit limited at present).
I aim to
On Fri, Feb 07, 2014 at 11:46:26AM +0100, walter harms wrote:
>
>
> Am 03.02.2014 23:38, schrieb Dan Carpenter:
> > The go_devadd_str[] array is two characters too small to hold the
> > address so we corrupt memory.
> >
> > I've changed the user space API slightly and I don't have a way to test
Mark, could you look at this patch? It has not been acked.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Am 03.02.2014 23:38, schrieb Dan Carpenter:
> The go_devadd_str[] array is two characters too small to hold the
> address so we corrupt memory.
>
> I've changed the user space API slightly and I don't have a way to test
> if this breaks anything. In the original code we truncated away the
> las
On Fri, Feb 07, 2014 at 10:04:30AM +0100, Daniel Vetter wrote:
> I've chatted a bit with Hans Verkuil about this topic at fosdem and
> apparently both v4l and alsa have something like this already in their
> helper libraries. Adding more people as fyi in case they want to
> switch to the new driver
I've chatted a bit with Hans Verkuil about this topic at fosdem and
apparently both v4l and alsa have something like this already in their
helper libraries. Adding more people as fyi in case they want to
switch to the new driver core stuff from Russell.
-Daniel
On Thu, Jan 2, 2014 at 10:27 PM, Rus
On Wed, Feb 05, 2014 at 09:56:41PM +0800, Zhao, Gang wrote:
> > @@ -2124,7 +2124,11 @@ static int et131x_rx_dma_memory_alloc(struct
> > et131x_adapter *adapter)
> >
> > /* Alloc memory for the lookup table */
> > rx_ring->fbr[0] = kmalloc(sizeof(struct fbr_lookup), GFP_KERNEL);
> > + i
57 matches
Mail list logo
