Re: [PATCH] Staging: comedi: clean up conditional statement in addi_apci_3xxx.c

2014-02-13 Thread Ian Abbott
On 2014-02-13 03:29, Chase Southwood wrote: In this if-else conditional statement, if (chan 16), but (data[0] == INSN_CONFIG_DIO_QUERY), the function does not return early, but the else-branch does not get executed either. As a result, mask would be used uninitialized in the next line. What

RE: [PATCH net,v3] hyperv: Fix the carrier status setting

2014-02-13 Thread Haiyang Zhang
-Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Wednesday, February 12, 2014 10:52 PM To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org Cc: KY Srinivasan; o...@aepfle.de; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org

RE: [PATCH] Staging: comedi: clean up conditional statement in addi_apci_3xxx.c

2014-02-13 Thread Hartley Sweeten
On Wednesday, February 12, 2014 8:29 PM, Chase Southwood wrote: In this if-else conditional statement, if (chan 16), but (data[0] == INSN_CONFIG_DIO_QUERY), the function does not return early, but the else-branch does not get executed either. As a result, mask would be used uninitialized in

Re: [PATCH] staging: r8188eu: default to y in Kconfig

2014-02-13 Thread Paul Bolle
On Tue, 2014-02-11 at 16:17 +0300, Dan Carpenter wrote: On Tue, Feb 11, 2014 at 02:01:08PM +0100, Paul Bolle wrote: I would have done, if I hadn't bothered to check Documentation/SubmittingPatches first. It contains: Please note that this tag should not be added without the reporter's

[PATCH 1/1] Drivers: hv: Ballon: Make pressure posting thread sleep interruptibly

2014-02-13 Thread K. Y. Srinivasan
The non-interruptible sleep of the memory pressure posting thread results in higher reported load average. Make this sleep interruptible. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/hv/hv_balloon.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH v2] Staging: comedi: clean up conditional statement in addi_apci_3xxx.c

2014-02-13 Thread Chase Southwood
In this conditional statement, if (chan 16), but the instruction passed in data[0] is INSN_CONFIG_DIO_QUERY, the function does not return early, but the else-branch does not get executed either. As a result, mask would be used uninitialized in the next line. We want comedi_dio_insn_config() to

Re: [PATCH net,v3] hyperv: Fix the carrier status setting

2014-02-13 Thread Jason Wang
On 02/13/2014 11:04 PM, Haiyang Zhang wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Wednesday, February 12, 2014 10:52 PM To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org Cc: KY Srinivasan; o...@aepfle.de; linux-ker...@vger.kernel.org;

Re: [PATCH net,v3] hyperv: Fix the carrier status setting

2014-02-13 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Wed, 12 Feb 2014 16:54:27 -0800 Without this patch, the cat /sys/class/net/ethN/operstate shows unknown, and ethtool ethN shows Link detected: yes, when VM boots up with or without vNIC connected. This patch fixed the problem.