You are right. remove whole thing and send it again.
Thanks.
Daeseok Youn
2014-04-02 18:13 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote:
coccicheck says:
drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21:
ERROR: ir is
ir is already checked before calling unregister_from_lirc().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/media/lirc/lirc_igorplugusb.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c
Please drop this patch.
I made a patch as Dan's comment and sent it.
Thanks.
Daeseok Youn.
2014-04-02 18:41 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
You are right. remove whole thing and send it again.
Thanks.
Daeseok Youn
2014-04-02 18:13 GMT+09:00 Dan Carpenter
On Wed, Apr 02, 2014 at 02:49:03AM -0700, Daeseok Youn wrote:
ir is already checked before calling unregister_from_lirc().
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
___
devel mailing list
From: Micky Ching micky_ch...@realsil.com.cn
The patch fa590c222fba: staging: rts5208: add support for rts5208
and rts5288 from Nov 12, 2013, leads to the following static checker
warning:
drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
warn: add curly braces?
This
On Tue, Apr 1, 2014 at 12:48 PM, Greg KH gre...@linuxfoundation.org wrote:
The following changes since commit dcb99fd9b08cfe1afe426af4d8d3cbc429190f15:
Linux 3.14-rc7 (2014-03-16 18:51:24 -0700)
are available in the git repository at:
On Tue, 01 Apr 2014, Andrew Morton wrote:
On Tue, 1 Apr 2014 11:20:32 +0800 Roger rogera...@realtek.com wrote:
On 03/25/2014 06:44 PM, rogera...@realtek.com wrote:
From: Roger Tseng rogera...@realtek.com
Realtek USB memstick host driver provides memstick host support based on
Miscellaneous style fixes for the vt6655 driver. Should not affect
functionality at all. Also remove dead code and some stale comments.
Shrink driver size by 1100 lines.
Guido Martínez (4):
staging: vt6655: fix DBG_PRT and PRINT_K macros
staging: vt6655: remove mention of nonexistent function
Comments mention a function CARDbSetBasicRate, but it never existed in
the source tree. Remove all mention of it.
Signed-off-by: Guido Martínez gu...@vanguardiasur.com.ar
---
drivers/staging/vt6655/card.c | 14 --
1 file changed, 14 deletions(-)
diff --git
Looks ok to me.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Apr 02, 2014 at 07:06:00AM -0600, Shuah Khan wrote:
On Tue, Apr 1, 2014 at 12:48 PM, Greg KH gre...@linuxfoundation.org wrote:
The following changes since commit dcb99fd9b08cfe1afe426af4d8d3cbc429190f15:
Linux 3.14-rc7 (2014-03-16 18:51:24 -0700)
are available in the git
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, April 02, 2014 1:04 PM, Greg KH wrote:
On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote:
On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote:
Staging driver pull request for 3.15-rc1
Here's the huge drivers/staging/ update for 3.15-rc1.
Loads of cleanup fixes, a
The checkpatch.pl complains about missing blank line after declaration.
This patch silence the warning.
Signed-off-by: Bojan Prtvar prtva...@gmail.com
---
This patch is for Eudyptula Challenge task 10
drivers/staging/vme/devices/vme_user.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Fixed coding style rule Breaking long lines and strings for hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin shehabaldin.she...@gmail.com
---
drivers/staging/wlan-ng/hfa384x_usb.c | 52 -
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
On Wed, Apr 02, 2014 at 08:52:18PM +, Insop Song wrote:
On Wed, April 02, 2014 1:04 PM, Greg KH wrote:
On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote:
On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote:
Staging driver pull request for 3.15-rc1
Here's the huge
Fixed coding style rule Breaking long lines and strings for hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin shehabaldin.she...@gmail.com
---
drivers/staging/wlan-ng/hfa384x_usb.c | 52 -
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
On Thu, 2014-04-03 at 01:37 +0200, Sherif wrote:
BTW regarding Alignment should match open parenthesis rule, It's
missing from Documentation/CodingStyle
It's maintainer's preference in at least
net/, drivers/net and drivers/staging.
Maybe it's true for drivers/usb too.
Greg?
Hi Guido,
On 2 April 2014 14:53, Guido Martínez gu...@vanguardiasur.com.ar wrote:
Miscellaneous style fixes for the vt6655 driver. Should not affect
functionality at all. Also remove dead code and some stale comments.
Shrink driver size by 1100 lines.
Just a suggestion for future patches.
Removed unnecessary typedefs from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin shehabaldin.she...@gmail.com
---
drivers/staging/wlan-ng/hfa384x_usb.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
Removed unnecessary typedefs from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin shehabaldin.she...@gmail.com
---
drivers/staging/wlan-ng/hfa384x_usb.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
21 matches
Mail list logo