[PATCH] staging: bcm: use kzalloc instead of kmalloc/memset

2014-05-07 Thread Daeseok Youn
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/bcm/InterfaceDld.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/InterfaceDld.c b/drivers/staging/bcm/InterfaceDld.c index 005e460..e1925bd 100644 ---

[PATCH 1/2] staging: lustre: fix sparse warning should it be static

2014-05-07 Thread Toby Smith
Fix the following warning in lib-eq.c warning: symbol 'lnet_eq_dequeue_event' was not declared. Should it be static? Signed-off-by: Toby Smith t...@tismith.id.au --- drivers/staging/lustre/lnet/lnet/lib-eq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] staging: lustre: fix sparse warning unexpected unlock

2014-05-07 Thread Toby Smith
Fix the following warning in lib-eq.c warning: context imbalance in 'lnet_eq_wait_locked' - unexpected unlock Signed-off-by: Toby Smith t...@tismith.id.au --- drivers/staging/lustre/lnet/lnet/lib-eq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lnet/lnet/lib-eq.c

[PATCH 0/2] staging: lustre: fix sparse warnings in lib-eq.c

2014-05-07 Thread Toby Smith
Fix warnings from sparse in lib-eq.c Toby Smith (2): staging: lustre: fix sparse warning should it be static staging: lustre: fix sparse warning unexpected unlock drivers/staging/lustre/lnet/lnet/lib-eq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.9.1

[PATCH 1/2] staging: comedi: addi_apci_1564: remove check for timer subdevice

2014-05-07 Thread Chase Southwood
The only board served by this driver always has a timer, so we can init the timer subdevice without checking first. The boardinfo about the timer can also be removed and the data used directly. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H

[PATCH 2/2] staging: comedi: addi_apci_1564: remove boardinfo

2014-05-07 Thread Chase Southwood
This driver only supports a single board type. Remove the boardinfo and its use in the driver. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- drivers/staging/comedi/drivers/addi_apci_1564.c | 13

Re: [PATCH] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()

2014-05-07 Thread Andy Shevchenko
On Thu, 2014-05-01 at 11:45 +0200, Christian Engelmayer wrote: Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the requested algorithm is not supported by the driver, the function returns without freeing the already allocated 'param' struct. Move the input

Re: [PATCH] Staging: android: fix coding style issue in timed_gpio.c

2014-05-07 Thread Dan Carpenter
On Wed, May 07, 2014 at 07:23:33AM +0100, John Church wrote: This patch fixes a coding style issue. It modifies a single line that was over 80 characters long. Thanks, John Signed-off-by: John Church j.chu...@ymail.com This patch isn't sent in the correct way. Use git send-email or read

Re: [PATCH] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()

2014-05-07 Thread Dan Carpenter
On Wed, May 07, 2014 at 09:55:47AM +0300, Andy Shevchenko wrote: @@ -1824,6 +1817,15 @@ static int r871x_wx_set_enc_ext(struct net_device *dev, default: return -EINVAL; } + + param_len = sizeof(struct ieee_param) + pext-key_len; + param = (struct ieee_param

Re: [PATCH 0/2] staging: comedi: addi_apci_1564: remove boardinfo

2014-05-07 Thread Ian Abbott
On 2014/05/07 08:02 AM, Chase Southwood wrote: This patchset removes the last dependency on this driver's boardinfo (the timer subdevice init), and then removes the boardinfo from the driver. To be applied on top of my prior patchset staging: comedi: addi_apci_1564: further cleanups Chase

Re: [PATCH] staging: comedi: pcl730: add support for Diamond Systems PC/104 modules

2014-05-07 Thread Ian Abbott
On 2014/05/07 12:08 AM, H Hartley Sweeten wrote: The Diamond Systems OPMM-1616-XT board is a PC/104 module with 16 optoisolated inputs and 16 relay outputs. The PEARL-MM-P board is a PC/104 module with 16 relay outputs. Both of these boards can be supported by the pcl730 driver.

[PATCH]: Staging: gdm72xx Fix minor coding style problems

2014-05-07 Thread Adithya
Hi All, This is patch for fixing of minor coding style problems. This is part of Eudyptula Challenge. Thanks, Adithya.K diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index 50d43ad..5ed32b9 100644 --- a/drivers/staging/gdm72xx/gdm_qos.c +++

Re: [PATCH]: Staging: gdm72xx Fix minor coding style problems

2014-05-07 Thread Greg KH
On Wed, May 07, 2014 at 04:05:27PM +0530, Adithya wrote: Hi All, This is patch for fixing of minor coding style problems. This is part of Eudyptula Challenge. Thanks, Adithya.K Can you please read the Documentation/SubmittingPatches file and then resend this in a format I can apply it

[patch] Documentation/email-clients.txt: add a section about git

2014-05-07 Thread Dan Carpenter
These days most people don't use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index 4e30eba..9004a5fd 100644 --- a/Documentation/email-clients.txt +++

Re: [PATCH]: Staging: gdm72xx Fix minor coding style problems

2014-05-07 Thread Dan Carpenter
On Wed, May 07, 2014 at 04:05:27PM +0530, Adithya wrote: Hi All, This is patch for fixing of minor coding style problems. This is part of Eudyptula Challenge. Write what you fixed. Thanks, Adithya.K Not in the correct format. Use git send-email or read

[PATCH] Staging: dgnc: Fix smatch warning for redundant null check in dgnc_driver.c

2014-05-07 Thread Ebru Akagunduz
Fix smatch warning dgnc_cleanup_board() info: redundant null check on brd-flipbuf calling kfree() in dgnc_driver.c Signed-off-by: Ebru Akagunduz ebru.akagun...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] staging : android: Fixes a coding style issue in timed_gpio.c

2014-05-07 Thread John Church
This patch fixes a coding style issue for a line that was over 80 characters long. Signed-off-by: John Church sleeverol...@gmail.com --- drivers/staging/android/timed_gpio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/timed_gpio.c

Re: [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c

2014-05-07 Thread John Church
On Wed, May 07, 2014 at 03:39:15PM +0300, Dan Carpenter wrote: I wonder if there is some kind of tutorial which teaches people to choose the least specific subject possible? We should find which tutorial it is and update it. John, can you give us a hint here which tutorial you are using?

[PATCH] staging: wlags49_h2: fix sparse warning should it be static

2014-05-07 Thread Luis Ortega
Fixes the following warning: drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static? Signed-off-by: Luis Ortega luior...@gmail.com --- drivers/staging/wlags49_h2/sta_h2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [PATCH 0/2] staging: comedi: addi_apci_1564: remove boardinfo

2014-05-07 Thread Hartley Sweeten
On Wednesday, May 07, 2014 12:03 AM, Chase Southwood wrote: This patchset removes the last dependency on this driver's boardinfo (the timer subdevice init), and then removes the boardinfo from the driver. To be applied on top of my prior patchset staging: comedi: addi_apci_1564: further

[PATCH] staging: silicom: add blank line after declarations

2014-05-07 Thread fernando . apesteguia
From: Fernando Apesteguia fernando.apesteg...@gmail.com Add blank line after declarations and delete extra blank line at the beginning of the function Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com --- drivers/staging/silicom/bpctl_mod.c |2 +- 1 file changed, 1

Re: [patch] Documentation/email-clients.txt: add a section about git

2014-05-07 Thread Laura Abbott
On 5/7/2014 4:17 AM, Dan Carpenter wrote: These days most people don't use git to send patches so I have added a section about that. Do you mean most people *do* use git to send patches? Or most people don't use e-mail clients? Laura -- Qualcomm Innovation Center, Inc. is a member of Code

Re: [patch] Documentation/email-clients.txt: add a section about git

2014-05-07 Thread Dan Carpenter
On Wed, May 07, 2014 at 09:06:54AM -0700, Laura Abbott wrote: On 5/7/2014 4:17 AM, Dan Carpenter wrote: These days most people don't use git to send patches so I have added a section about that. Do you mean most people *do* use git to send patches? Or most people don't use e-mail

Re: [PATCH] staging: silicom: add blank line after declarations

2014-05-07 Thread Dan Carpenter
On Wed, May 07, 2014 at 06:02:44PM +0200, fernando.apesteg...@gmail.com wrote: From: Fernando Apesteguia fernando.apesteg...@gmail.com Add blank line after declarations and delete extra blank line at the beginning of the function Signed-off-by: Fernando Apesteguia

[PATCH v2] staging: rtl8723au: Remove unused pointer in rtw_wdev_free()

2014-05-07 Thread Christian Engelmayer
Pointer 'pwdev_priv' in function rtw_wdev_free() is unused - thus remove it. Signed-off-by: Christian Engelmayer cenge...@gmx.at --- v2: Resend after v1 failed to apply * rebased against staging-next - commit 09c3fbba (staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf) *

[PATCH v2 3/5] staging: rtl8188eu: fix potential leak in rtw_mp_QueryDrv()

2014-05-07 Thread Christian Engelmayer
Function rtw_mp_QueryDrv() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077713. Signed-off-by: Christian Engelmayer cenge...@gmx.at ---

[PATCH v2 0/5] staging: rtl8188eu: fix Coverity defects in os_dep/ioctl_linux.c

2014-05-07 Thread Christian Engelmayer
This is a cleanup of staging/rtl8188eu/os_dep/ioctl_linux.c regarding Coverity resource leak findings. The changes leave the current implementation intact and just attack the problems in the error paths, however, it seems that we could get easily rid of some of the mallocs altogether. char

[PATCH v2 5/5] staging: rtl8188eu: fix potential leak in rtw_mp_pwrtrk()

2014-05-07 Thread Christian Engelmayer
Function rtw_mp_pwrtrk() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - 1077715. Signed-off-by: Christian Engelmayer cenge...@gmx.at ---

[PATCH v2] staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach()

2014-05-07 Thread Christian Engelmayer
This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. The -2a version has 32 on-board DIO channels. In case this variant is detected, local variable 'has_dio' is set accordingly. Otherwise it is left uninitialized and the following subdevice instantiation depends on the stack.

[PATCH v2 4/5] staging: rtl8188eu: fix potential leak in rtw_mp_SetRFPath()

2014-05-07 Thread Christian Engelmayer
Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077714. Signed-off-by: Christian Engelmayer cenge...@gmx.at ---

[PATCH v2] staging: rtl8712: fix potential leaks in r8712_set_key()

2014-05-07 Thread Christian Engelmayer
Fix potential leaks in the error paths of r8712_set_key(). In case the algorithm specific checks fail, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed correctly. Detected by

[PATCH v2] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()

2014-05-07 Thread Christian Engelmayer
Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the requested algorithm is not supported by the driver, the function returns without freeing the already allocated 'param' struct. Move the input verification to the beginning of the function so that the direct return is

[PATCH v3] staging: rtl8188eu: fix potential leak in rtw_set_key()

2014-05-07 Thread Christian Engelmayer
Fix a potential leak in the error path of rtw_set_key(). In case the requested algorithm is not supported by the driver, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed

[PATCH v2] staging: binder: fix usage of uninit scalar in binder_transaction()

2014-05-07 Thread Christian Engelmayer
Fix the error path when a cookie mismatch is detected. In that case the function jumps to the exit label without setting the uninitialized, local variable 'return_error'. Detected by Coverity - CID 201453. Signed-off-by: Christian Engelmayer cenge...@gmx.at --- v2: Resend after v1 failed to apply

[PATCH v2] staging: vt6656: fix potential leak in vt6656_hostap_ioctl()

2014-05-07 Thread Christian Engelmayer
Commit fb841d67 (staging: vt6656: don't leak 'param' in vt6656_hostap_ioctl() when returning -EOPNOTSUPP) cleaned up direct returns in the ioctl switch statement that leaked already allocated memory. Fix the same issue for VIAWGET_HOSTAPD_SCAN_REQ and VIAWGET_HOSTAPD_MLME that are not supported by

[PATCH v2 2/5] staging: rtl8188eu: fix potential leak in rtw_wx_set_enc_ext()

2014-05-07 Thread Christian Engelmayer
Function rtw_wx_set_enc_ext() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077712. Signed-off-by: Christian Engelmayer cenge...@gmx.at ---

[PATCH v3] staging: rtl8188eu: fix potential leak in update_bcn_wps_ie()

2014-05-07 Thread Christian Engelmayer
Fix a potential leak in the error path of function update_bcn_wps_ie(). Move the affected input verification to the beginning of the function so that it may return directly without leaking already allocated memory. Detected by Coverity - CID 1077718. Signed-off-by: Christian Engelmayer

[PATCH v3] staging: silicom: Remove unused pointer in bypass_init_module()

2014-05-07 Thread Christian Engelmayer
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove it. With the last variable declaration gone, there is no more need for an own block. Remove it and adapt the indenting accordingly. Signed-off-by: Christian Engelmayer cenge...@gmx.at --- v3: Resend after v2 failed to

[PATCH v2 1/5] staging: rtl8188eu: fix potential leak in rtw_wx_read32()

2014-05-07 Thread Christian Engelmayer
Function rtw_wx_read32() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077711. Signed-off-by: Christian Engelmayer cenge...@gmx.at ---

Re: [PATCH v2 4/5] staging: rtl8188eu: fix potential leak in rtw_mp_SetRFPath()

2014-05-07 Thread Dan Carpenter
On Wed, May 07, 2014 at 09:33:20PM +0200, Christian Engelmayer wrote: Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077714.

RE: randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

2014-05-07 Thread Haiyang Zhang
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Friday, May 2, 2014 3:19 PM To: Haiyang Zhang Cc: jim.ep...@gmail.com; s...@canb.auug.org.au; linux-n...@vger.kernel.org; linux-ker...@vger.kernel.org; KY Srinivasan; de...@linuxdriverproject.org;

Re: [PATCH 1/2] mmc: rtsx: Revert mmc: rtsx: modify error handleandremove smatch warnings

2014-05-07 Thread micky
Hi Lee It seems Chris is too busy to responding, so would you help to pick this patch for 3.15 fix. Best Regards. micky. On 04/29/2014 03:30 PM, Ulf Hansson wrote: On 29 April 2014 03:54,micky_ch...@realsil.com.cn wrote: From: Micky Chingmicky_ch...@realsil.com.cn This reverts commit

Re: [PATCH 2/2] mmc: rtsx: Revert mmc: rtsx: add support for pre_reqandpost_req

2014-05-07 Thread micky
Hi Lee Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert mmc: rtsx: add support for pre_reqand post_req if need for 3.15 fix. Best Regards. micky. On 04/29/2014 03:36 PM, Ulf Hansson wrote: On 29 April 2014 03:54,micky_ch...@realsil.com.cn wrote: From: Micky