[PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

This should fix a few sparse warnings like the following: CHECK drivers/staging/rtl8723au/core/rtw_ap.c drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:expected int [signed] gfp

[PATCH] staging: wlan-ng: use netdev_() instead of printk()

Replaced all uses of printk() in wlan-ng with netdev_err / _warn where a netdev exists. If a few cases where a netdev does not yet exist, dev_ or pr_ was used. Checkpatch complains about lines over 80 chars or split string constants - the messages are just too long, keeping it completely happy

[PATCH 5/5] staging: xgifb: Update TODO

There's no more printk abuse, it's been sorted out in 448810662ac3 (Staging: xgifb: Remove printk usage.) Extra ifdefs have been fixed too, mostly in 800d67cf9f77 (staging: xgifb: eliminate #ifdef Tap4), c39aada6926c (staging: xgifb: eliminate #ifdef XGIFB_PAN), fa4c212f2b81 (staging: xgifb:

[PATCH 4/5] staging: xgifb: Drop some more useless defines

SetLCDStdMode is not supported as of 34c13ee2b690 (staging: xgifb: drop code for legacy VGA modes). DisableLCD24bpp defined to zero was never realy useful and went away with aa56b2790a8b (staging: xgifb: vb_table: delete XGI21_LCDCapList). Signed-off-by: Lubomir Rintel lkund...@v3.sk ---

[PATCH 2/5] staging: xgifb: Drop pr_fmt

It is neither used nor useful. Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/XGI_main_26.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index a62d4dd..d61e03f 100644 ---

[PATCH 1/5] staging: xgifb: Eliminate useless ifndefs

XGI_VB_CHIP_TYPE, PCI_DEVICE_ID_XGI_42 and PCI_DEVICE_ID_XGI_27 are never defined. Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/XGI_main.h | 4 drivers/staging/xgifb/vgatypes.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main.h

[PATCH 3/5] staging: xgifb: Initialize Part0Port

It was left uninitialized, likely overseen, in this commit: 56810a92c689c6 (staging: xgifb: use XGIRegInit() Avoid copy-paste and use XGIRegInit() to initialize registers addresses.) Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/XGI_main_26.c | 1 + 1 file changed, 1

staging: xgifb: A couple of minor tidyups

Hi, I've cleaned up some small issues in xgifb driver as part of a solution to an Eudyptula Challenge [1] task. The patches are chained to this message. [1] http://eudyptula-challenge.org/ Lubo ___ devel mailing list de...@linuxdriverproject.org

[PATCH 00/28] staging: rtl8188eu: Remove unnecessary functions.

Following patches remove functions which are unused or have empty definition. navin patidar (28): staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError(). staging: rtl8188eu: Remove function with empty definition _InitOperationMode() staging: rtl8188eu:

[PATCH 01/28] staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError().

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 617e4c6..9ce6173 100644 ---

[PATCH 03/28] staging: rtl8188eu: Remove function with empty definition _ps_open_RF()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c

[PATCH 02/28] staging: rtl8188eu: Remove function with empty definition _InitOperationMode()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9ce6173..2e7b81ce 100644 ---

[PATCH 04/28] staging: rtl8188eu: Remove unused function _ps_close_RF()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 2fe1135..1a83d31 100644 ---

[PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 1a83d31..4c3f8c8 100644 ---

[PATCH 07/28] staging: rtl8188eu: Remove unused function rtl8188e_PHY_ConfigRFWithParaFile()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index

[PATCH 08/28] staging: rtl8188eu: Remove unused function rtl8192c_PHY_GetHWRegOriginalValue()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index

[PATCH 09/28] staging: rtl8188eu: Remove unused function PHY_UpdateTxPowerDbm8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 37 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |1 - 2 files changed, 38 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c

[PATCH 10/28] staging:rtl8188eu: Remove unused function phy_DbmToTxPwrIdx()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 44 --- 1 file changed, 44 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index

[PATCH 11/28] staging: rtl8188eu: Remove unused funtion PHY_GetTxPowerLevel8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 46 --- 1 file changed, 46 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index

[PATCH 12/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 34 --- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index a7872c8..941ff74 100644

[PATCH 15/28] staging: rtl8188eu: Remove unused function rtl8188e_RF_ChangeTxPath()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c index

[PATCH 16/28] staging: rtl8188eu: Remove unused function odm_DIGbyRSSI_LPS()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 45 --- 1 file changed, 45 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 89a26e3..d8482ab 100644 ---

[PATCH 17/28] staging: rtl8188eu: Remove function odm_DynamicBBPowerSaving()

odm_DynamicBBPowerSaving() has empty defination. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index

[PATCH 18/28] staging: rtl8188eu: Remove unused function odm_DynamicBBPowerSavingInit()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 2e105b4..e8ad880 100644 ---

[PATCH 19/28] staging:rtl8188eu: Remove unused function iodm_1R_CCA()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index e8ad880..7319b3e 100644 ---

[PATCH 20/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskMP()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 7319b3e..01946cc 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 21/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskAPADSL()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 01946cc..cc73188 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 22/28] staging: rtl8188eu: Remove unused funtion odm_DynamicTxPowerNIC()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index cc73188..8dd5f7e 100644 ---

[PATCH 23/28] staging: rtl8188eu: Remove unused function odm_SwAntDivChkAntSwitchCallback()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 8dd5f7e..4442181 100644 ---

[PATCH 24/28] staging: rtl8188eu: Remove unused function ConvertTo_dB()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 4442181..425c50a4 100644 ---

[PATCH 25/28] staging: rtl8188eu: Remove function with empty defination ODM_CheckPowerStatus()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c index 056052d..7c22658

[PATCH 26/28] staging: rtl8188eu: Remove unused function DM_DIG_LowerBound_88E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 323eb93..7c1043c 100644 ---

[PATCH 27/28] staging: rtl8188eu: Remove unused function ODM_DynamicPrimaryCCA_DupRTS()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 7c1043c..a90b2c5 100644 ---

[PATCH 28/28] staging: rtl8188eu:Remove function with empty defination odm_DynamicPrimaryCCA()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |1 - drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |5 - drivers/staging/rtl8188eu/include/odm_RTL8188E.h |2 -- 3 files changed, 8 deletions(-) diff --git

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index a7872c8..941ff74 100644

Re: [PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Subject line of this patch isn't correct, so please ignore it. I've submitted new patch with [PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E() subject line. regards, navin patidar On Sun, May 18, 2014 at 8:49 PM, navin patidar navin.pati...@gmail.com wrote:

Re: [PATCH] Fix for possible null pointer dereference in node.c

Hi When I run cppcheck find the about 5,000 errors, of these, I selected the 100 most serious and has made patches. But my ability to immerse myself in each failure has been limited unfortunately. Okay, I send it through the scripts instead. Best regards Rickard Strandqvist 2014-05-17 20:56

[PATCH] staging: tidspbridge: rmgr: node.c: Fix for possible null pointer dereference

Removde unnecessary check for null pointer. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/tidspbridge/rmgr/node.c |2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH] Fix for possible null pointer dereference in node.c

On Sun, May 18, 2014 at 05:49:52PM +0200, Rickard Strandqvist wrote: Hi When I run cppcheck find the about 5,000 errors, of these, I selected the 100 most serious and has made patches. But my ability to immerse myself in each failure has been limited unfortunately. I am familiar with that

Re: [PATCH 2/5] staging: xgifb: Drop pr_fmt

On Sun, May 18, 2014 at 12:55:13PM +0200, Lubomir Rintel wrote: It is neither used nor useful. Not true at all. Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/XGI_main_26.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c

Re: [PATCH 5/5] staging: xgifb: Update TODO

On Sun, May 18, 2014 at 12:55:16PM +0200, Lubomir Rintel wrote: There's no more printk abuse, it's been sorted out in 448810662ac3 (Staging: xgifb: Remove printk usage.) Yes, but there are still lots of pr_* calls that should be switched to dev_* calls instead. Or just removed entirely. I'll

Re: [PATCH] Fix for possible null pointer dereference in node.c

Hi The approximately 5,000 errors were not only null pointers, but uninitialized variables, etc. also a mixture of error and warnings. Same I did not consider a reall error. Then a bunch of warnings for printf(%d, unsigned int) and vice versa, which I have not even bothered to check even.

[PATCH 5/5] staging: lustre: lnet: socklnd: Clean up ksocknal_create_conn(...)

Remove prohibited space and fix indenting of following parameters of ksocknal_create_conn(...) to meet kernel coding style. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 3/5] staging: lustre: lnet: socklnd: Clean up CDEBUG(...)

Remove prohibited space and fix indenting of following parameters of CDEBUG(...) to meet kernel coding style. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 4/5] staging: lustre: lnet: socklnd: Clean up ksocknal_get_peer_info(...)

Remove prohibited space and fix indenting of following parameter of ksocknal_get_peer_info(...) to meet kernel coding style. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 1/5] staging: lustre: lnet: socklnd: Remove prohibited space

Remove prohibited space between open parenthesis and function name to meet kernel coding style. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c| 226 ++-- 1 file changed, 113 insertions(+), 113 deletions(-) diff --git

[PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

Remove prohibited space and fix line over 80 characters of memset(...) to meet kernel coding style. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/1] staging/skein: rename files and clean up directory structure

On Sun, 18 May 2014 11:42:53 -0700 Joe Perches wrote: On Sun, 2014-05-18 at 12:36 -0600, Jake Edge wrote: Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused

[PATCH v2 1/1] staging/skein: rename files and clean up directory structure

Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge j...@lwn.net --- Against next-20140516 v2: use git

Re: [PATCH 1/1] staging/skein: rename files and clean up directory structure

On Sun, 2014-05-18 at 12:36 -0600, Jake Edge wrote: Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). [] Diff appears to be huge

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

- memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags etc */ + memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */ It looks like this memset is unnecessary as it's already zeroed by LIBCFS_ALLOC- LIBCFS_ALLOC_GFP-LIBCFS_ALLOC_POST-memset. It

Re: [PATCH 0/5] staging: lustre: lnet: klnds: Fix coding style in socklnd.c

On Sun, May 18, 2014 at 06:19:12PM +0100, Masaru Nomura wrote: These patches fix warnings below in socklnd.c to meet coding style. Also fix some indenting due to changes to keep readability. WARNING: space prohibited between function name and open parenthesis '(' WARNING: line over 80

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote: Remove prohibited space and fix line over 80 characters of memset(...) to meet kernel coding style. [] diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c [] @@ -113,7

Re: [PATCH 1/2] staging: slicoss: rewrite eeprom checksum code

On Sat, May 17, 2014 at 9:51 PM, David Matlack matlackda...@gmail.com wrote: On Sat, May 17, 2014 at 9:12 PM, Joe Perches j...@perches.com wrote: The if seems unnecessary. Perhaps declare a u16 return var or use return lower_16 + upper_16; I agree it's fishy... but using overflow

Re: [PATCH v2 1/1] staging/skein: rename files and clean up directory structure

Jake, Anton, On Sun, May 18, 2014 at 12:56:15PM -0600, Jake Edge wrote: Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?).

Re: [PATCH v2 1/1] staging/skein: rename files and clean up directory structure

On Sun, 18 May 2014 18:52:31 -0400 Jason Cooper wrote: Jake, would you mind dropping this patch and perhaps assisting me with reviewing Anton's series? I'll have him resend it as-is and we can go from there. No, that's fine. Guess I'll put my patches to clean up some other stuff (function

Re: [PATCH v2 1/1] staging/skein: rename files and clean up directory structure

On Sun, May 18, 2014 at 05:04:50PM -0600, Jake Edge wrote: On Sun, 18 May 2014 18:52:31 -0400 Jason Cooper wrote: Jake, would you mind dropping this patch and perhaps assisting me with reviewing Anton's series? I'll have him resend it as-is and we can go from there. No, that's fine.

[PATCH 0/2] Staging: speakup: Fix deadlock when pasting

These patches fix a deadlock that can occur when using speakup to paste a selection. I tested them against 3.12.9, but there don't appear to be any later changes in this area. Ben. Ben Hutchings (2): Staging: speakup: Move pasting into a work item Staging: speakup: Update

[PATCH 1/2] Staging: speakup: Move pasting into a work item

Input is handled in softirq context, but when pasting we may need to sleep. speakup_paste_selection() currently tries to bodge this by busy-waiting if in_atomic(), but that doesn't help because the ldisc may also sleep. For bonus breakage, speakup_paste_selection() changes the state of current,

[PATCH 2/2] Staging: speakup: Update __speakup_paste_selection() tty (ab)usage to match vt

This function is largely a duplicate of paste_selection() in drivers/tty/vt/selection.c, but with its own selection state. The speakup selection mechanism should really be merged with vt. For now, apply the changes from 'TTY: vt, fix paste_selection ldisc handling', 'tty: Make ldisc input flow

Re: [PATCH 0/2] Staging: speakup: Fix deadlock when pasting

On Mon, 2014-05-19 at 00:50 +0100, Ben Hutchings wrote: These patches fix a deadlock that can occur when using speakup to paste a selection. I tested them against 3.12.9, but there don't appear to be any later changes in this area. [...] Actually, these have also been tested on top of 3.14.2.

[PATCH V2] staging: dgap: implement error handling in dgap_tty_register()

From 3acdda98e73a153a5fb32c2cd401d2dde1653b0a Mon Sep 17 00:00:00 2001 From: Daeseok Youn daeseok.y...@gmail.com Date: Fri, 25 Apr 2014 16:04:59 +0900 Subject: [PATCH] staging: dgap: implement error handling in dgap_tty_register() - alloc_tty_driver() is deprecated so it is changed to

[PATCH V3] staging: dgap: implement error handling in dgap_tty_register()

- alloc_tty_driver() is deprecated so it is changed to tty_alloc_driver() - Pointers which are allocated by alloc_tty_driver() and kzalloc() can be NULL so it need to check NULL for them. - If one of those is failed, it need to add proper handler for avoiding memory leak. - If both of drivers are

[PATCH v2 01/06] staging: crypto: skein: rename camelcase functions

camelCase is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all functions to non-camelCase equivalents. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/skein/TODO | 1 - drivers/staging/skein/include/skein.h

[PATCH v2 06/06] staging: crypto: skein: rename files

camelCase is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all files to non-camelCase equivalents. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/skein/Makefile | 10 +-

[PATCH v2 03/06] staging: crypto: skein: rename skein1024_ctx to skein_1024_ctx

Code have skein_512_ctx and skein_256_ctx but skein1024_ctx. It would be logical to convert these names to a single form. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/skein/include/skein.h | 14 +++--- drivers/staging/skein/include/skeinApi.h| 2 +-

[PATCH 10/13] staging: rtl8192e: make return of 0 explicit

From: Julia Lawall julia.law...@lip6.fr Delete unnecessary use of a local variable to immediately return 0. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ local idexpression ret; expression e; position p; @@

[PATCH 7/13] staging: wlags49_h2: make return of 0 explicit

From: Julia Lawall julia.law...@lip6.fr Delete unnecessary local variable whose value is always 0 and that hides the fact that the result is always 0. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ local

[PATCH 0/13] make return of 0 explicit

Sometimes a local variable is used as a return value in a case where the return value is always 0. The result is more apparent if this variable is just replaced by 0. This is done by the following semantic patch, although some cleanups may be needed. (http://coccinelle.lip6.fr/) // smpl @r