Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Greg KH
On Fri, Jul 11, 2014 at 06:57:24PM -0700, Joe Perches wrote: On Fri, 2014-07-11 at 18:53 -0700, Greg KH wrote: On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote: A simple script to run checkpatch --fix for various types of of cleanups. [] Anyway, try running this script on

Re: [PATCH] staging: unisys: added virtpci info entry

2014-07-12 Thread Dan Carpenter
On Fri, Jul 11, 2014 at 07:11:45PM -0400, Erik Arfvidson wrote: +static int print_vbus(struct device *vbus, void *data) +{ + struct print_vbus_info *p = (struct print_vbus_info *)data; + + *p-length += sprintf(p-buf + *p-length, bus_id:%s\n, +

Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Greg KH
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote: A simple script to run checkpatch --fix for various types of of cleanups. This script is useful primarily for staging. This reformats code to a more CodingStyle conforming style, compiles it, verifies that the object code hasn't

Confirm Your Address

2014-07-12 Thread biblioteca . pub
I work with One Tracking limited, we are conducting a standard investigation involving a client who shares the same name with you. Kindly confirm if this address is valid so I can brief further. Contact My Private Email: one.tracking_limi...@outlook.com Thank you for accommodating our

Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Dan Carpenter
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote: On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote: On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote: A simple script to run checkpatch --fix for various types of of cleanups. This script is useful primarily for

[PATCH 0/3] drivers/staging/bcm/Transmit.c cleanup patches

2014-07-12 Thread Matthias Beyer
Hi, this is my next patch set, this time for the drivers/staging/bcm/Transmit.c file. If you want me to, I can send the Line length patch split up into one patch per function. Note: I'm not able to test these patches as I do not have the appropriate hardware, I compiled them at least.

[PATCH 2/3] Staging: bcm: Transmit.c: Line length / Whitespace cleanup

2014-07-12 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Transmit.c | 57 -- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c index 346c55d..3dd3603 100644 ---

[PATCH 3/3] Staging: bcm: Transmit.c: Removed obvious comment

2014-07-12 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Transmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c index 3dd3603..05fae92 100644 --- a/drivers/staging/bcm/Transmit.c +++

[PATCH 1/3] Staging: bcm: Transmit.c: Replaced member accessing with variable

2014-07-12 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Transmit.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c index cd27bd8..346c55d 100644 ---

Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Joe Perches
On Sat, 2014-07-12 at 01:18 -0700, Greg KH wrote: On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote: A simple script to run checkpatch --fix for various types of of cleanups. [] I did the following: $ scripts/reformat_with_checkpatch.sh drivers/base/bus.c Ignore the first set

[PATCH V3 0/7] Drivers: scsi: storvsc: Bug fixes and improvements

2014-07-12 Thread K. Y. Srinivasan
In this patch set I have fixed a few bugs and implemented some enhancements. In this version of the patch I have addressed comments from Christoph Hellwig h...@infradead.org K. Y. Srinivasan (7): Drivers: scsi: storvsc: Change the limits to reflect the values on the host Drivers: scsi:

[PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-12 Thread K. Y. Srinivasan
Hyper-V hosts can support multiple targets and multiple channels and larger number of LUNs per target. Update the code to reflect this. With this patch we can correctly enumerate all the paths in a multi-path storage environment. In this version of the patch I have addressed comments from

[PATCH 6/7] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-12 Thread K. Y. Srinivasan
Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the Windows host require this. The host validates the command and SRB flags prior to passing the command down to native driver stack. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc: sta...@vger.kernel.org ---

[PATCH 7/7] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

2014-07-12 Thread K. Y. Srinivasan
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR. Correctly handle this. Note that there is sufficient sense information to support scsi error handling even in this case. In this version of the patch I have addressed comments from Christoph Hellwig h...@infradead.org

[PATCH V3 2/7] Drivers: scsi: storvsc: Set cmd_per_lun to reflect value supported by the Host

2014-07-12 Thread K. Y. Srinivasan
Set cmd_per_lun to reflect value supported by the Host. In this version of the patch I have addressed comments from Christoph Hellwig h...@infradead.org Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |2 +- 1 files changed, 1

[PATCH 5/7] Drivers: scsi: storvsc: Implement a timedout handler

2014-07-12 Thread K. Y. Srinivasan
On Azure, we have seen instances of unbounded I/O latencies. To deal with this issue, implement handler that can reset the timeout. Note that the host gaurantees that it will respond to each command that has been issued. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Cc:

[PATCH V3 4/7] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-12 Thread K. Y. Srinivasan
Based on the negotiated VMBUS protocol version, we adjust the size of the storage protocol messages. The two sizes we currently handle are pre-win8 and post-win8. In WS2012 R2, we are negotiating higher VMBUS protocol version than the win8 version. Make adjustments to correctly handle this. In

[PATCH V3 3/7] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

2014-07-12 Thread K. Y. Srinivasan
Going forward it is possible that some of the commands that are not currently implemented will be implemented on future Windows hosts. Even if they are not implemented, we are told the host will corrrectly handle unsupported commands (by returning appropriate return code and sense information).

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread Richard Weinberger
On Thu, Jul 10, 2014 at 12:33 PM, Richard Weinberger richard.weinber...@gmail.com wrote: On Wed, Jul 9, 2014 at 8:51 PM, KY Srinivasan k...@microsoft.com wrote: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, July 9, 2014 1:44 AM To: KY

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread KY Srinivasan
-Original Message- From: Richard Weinberger [mailto:richard.weinber...@gmail.com] Sent: Saturday, July 12, 2014 9:17 AM To: KY Srinivasan Cc: Christoph Hellwig; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com;

Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Greg KH
On Sat, Jul 12, 2014 at 12:30:43PM +0300, Dan Carpenter wrote: On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote: On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote: On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote: A simple script to run checkpatch --fix for various

Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Joe Perches
On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote: Yes, the warnings are all due to line-length, but Joe, you shouldn't add a patch that causes more checkpatch warnings than before :) Yeah, that was intentional though. This script does a series of relatively discrete changes. Lindent would

[PATCH] staging: iio: adc: ad7192: fix coding style

2014-07-12 Thread Marcus Folkesson
Line over 80 characters. This is for Eudyptula Challenge. Signed-off-by: Marcus Folkesson marcus.folkes...@gmail.com --- drivers/staging/iio/adc/ad7192.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c

Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Greg KH
On Sat, Jul 12, 2014 at 11:29:37AM -0700, Joe Perches wrote: On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote: Yes, the warnings are all due to line-length, but Joe, you shouldn't add a patch that causes more checkpatch warnings than before :) Yeah, that was intentional though. This

[PATCH] staging: android: Cleanup style issues

2014-07-12 Thread Peter Senna Tschudin
This patch fixes the following checkpatch warnings: - Remove else after return - Add space after declaration Tested by compilation only. Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/staging/android/sync_debug.c | 11 --- 1 file changed, 8 insertions(+), 3

Re: [PATCH] staging: android: Cleanup style issues

2014-07-12 Thread Greg KH
On Sat, Jul 12, 2014 at 09:55:56PM +0200, Peter Senna Tschudin wrote: This patch fixes the following checkpatch warnings: - Remove else after return - Add space after declaration Tested by compilation only. Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com ---

Re: [PATCH] staging: android: Cleanup style issues

2014-07-12 Thread Greg KH
On Sat, Jul 12, 2014 at 01:23:10PM -0700, Greg KH wrote: On Sat, Jul 12, 2014 at 09:55:56PM +0200, Peter Senna Tschudin wrote: This patch fixes the following checkpatch warnings: - Remove else after return - Add space after declaration Tested by compilation only. Signed-off-by:

[GIT PULL] Staging driver fixes for 3.16-rc5

2014-07-12 Thread Greg KH
The following changes since commit cd3de83f147601356395b57a8673e9c5ff1e59d1: Linux 3.16-rc4 (2014-07-06 12:37:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.16-rc5 for you to fetch changes up to

[PATCH] staging: android: Coding style fix

2014-07-12 Thread Modestas Stankus
This patch fixes warnings of checkpatch.pl script: WARNING: void function return statements are not generally useful + return; +} Task of Eudyptula challenge. --- drivers/staging/android/ion/ion_carveout_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] Remove useless else after a return statement

2014-07-12 Thread Lucas Tanure
Run Checkpatch and fixed the first warning. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/staging/android/binder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index cfe4bc8..1a0966b 100644

[PATCH 1/2] staging: comedi: addi_apci_1564: driver no longer needs to include addi_common.h

2014-07-12 Thread Chase Southwood
This driver no longer depends on anything in addi_common.h, save for a few headers that it was including indirectly. Remove the include of addi_common.h and add the includes of linux/interrupt.h and linux/sched.h directly. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott

[PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

2014-07-12 Thread Chase Southwood
Use the addi_watchdog module to provide support for the watchdog subdevice. Also, rearrange the subdevice init blocks so that the order makes sense. Digital input/output subdevices and subdevices for DI/DO interrupt support, followed by timer/counter/watchdog subdevices is the new order.

[RESEND PATCH] staging: android: Clean up binder_buffer_size()

2014-07-12 Thread Lucas Tanure
Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/staging/android/binder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index

[PATCH] dgnc: DGNC_VERIFY_BOARD macro in do while block

2014-07-12 Thread Jeremiah Mahler
Enclose the body of the multi-statement DGNC_VERIFY_BOARD macro inside a do - while block as per Documentation/CodingStyle. Fixes 1 error found by checkpatch.pl. Signed-off-by: Jeremiah Mahler jmmah...@gmail.com --- drivers/staging/dgnc/dgnc_sysfs.c | 20 +++- 1 file changed, 11

Re: [RESEND PATCH] staging: android: Clean up binder_buffer_size()

2014-07-12 Thread Greg Kroah-Hartman
On Sat, Jul 12, 2014 at 09:50:09PM -0300, Lucas Tanure wrote: Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/staging/android/binder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) What tree are you making

[PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Chen Gang
Several drivers need 'devm_ioremap_resource' which need HAS_IOMEM enabled. So let them depend on HAS_IOMEM. The related error (with allmodconfig under score): MODPOST 1365 modules ERROR: devm_ioremap_resource [drivers/watchdog/tegra_wdt.ko] undefined! ERROR: devm_ioremap_resource

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Chen Gang
After this last patch, score architecture can pass allmodconfig. :-) And also find a compiler issue, I will try to fix it, but shall not notify kernel mailing list, again. The related issue is below (it seems a kernel issue, but in fact, it is a compiler's issue): CC [M]

Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch

2014-07-12 Thread Joe Perches
On Sat, 2014-07-12 at 12:28 -0700, Greg KH wrote: On Sat, Jul 12, 2014 at 11:29:37AM -0700, Joe Perches wrote: On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote: Yes, the warnings are all due to line-length, but Joe, you shouldn't add a patch that causes more checkpatch warnings than

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Marek Vasut
On Sunday, July 13, 2014 at 05:07:10 AM, Chen Gang wrote: Several drivers need 'devm_ioremap_resource' which need HAS_IOMEM enabled. So let them depend on HAS_IOMEM. The related error (with allmodconfig under score): MODPOST 1365 modules ERROR: devm_ioremap_resource