Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

2014-08-07 Thread Antoine Schweitzer-Chaput
On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote: Signed-off-by: A Raghavendra Rao ar...@cdac.in This looks very similar to what I submitted on July 31st. At this time Greg had additional comments which led to a quite different patchset (though its review is not completed yet),

[PATCH] staging:r819xU: coding style: Fixed commenting style

2014-08-07 Thread Sanjeev Sharma
This is a patch to the r819xU_phyreg.h file that fixes commenting style warning Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com --- drivers/staging/rtl8192u/r819xU_phyreg.h | 188 --- 1 file changed, 97 insertions(+), 91 deletions(-) diff --git

[PATCH v3] staging: comedi: add NI USB-6501 support

2014-08-07 Thread Luca Ellero
Enable support for the National Instruments USB-6501 module. The NI USB-6501 is a Full-Speed USB 2.0 (12 Mbit/s) device that provides 24 digital I/O lines channels and one 32-bit counter. This is a preliminary version: GPIO: works counter: doesn't work Signed-off-by: Luca Ellero

[PATCH] Staging: wlan-ng: fix sparse warning in prism2fw.c

2014-08-07 Thread A Raghavendra Rao
Fix the following sparse warning : In file included from drivers/staging/wlan-ng/prism2usb.c:5:0: drivers/staging/wlan-ng/prism2fw.c: In function ‘read_cardpda.constprop.43’: drivers/staging/wlan-ng/prism2fw.c:792:1: warning: the frame size of 1068 bytes is larger than 1024 bytes

Re: [PATCH v3 1/2] staging: iio: accel: Add blank lines between declarations and code

2014-08-07 Thread Jonathan Cameron
On 07/08/14 01:22, Murilo Opsfelder Araujo wrote: This patch adds missing blank lines between declarations and code and fixes lines starting by spaces, satisfying checkpatch.pl. Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com Applied to the togreg branch of iio.git. Initially

Re: [PATCH v3 2/2] staging: iio: accel: sca3000_core.c: Adjust code to fit 80-chars limit

2014-08-07 Thread Jonathan Cameron
On 07/08/14 01:22, Murilo Opsfelder Araujo wrote: Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com Applied to the togreg branch of iio.git. Thanks, Jonathan --- drivers/staging/iio/accel/sca3000_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] staging: comedi: fixing coding style problems

2014-08-07 Thread Ian Abbott
On 2014/08/06 06:55 PM, Niklas Svensson wrote: This patch fixes warnings of checkpatch.pl script: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around devpriv-timer +init_timer((devpriv-timer)); CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis +

Re: [PATCH v3] staging: comedi: add NI USB-6501 support

2014-08-07 Thread Ian Abbott
On 2014/08/07 08:10 AM, Luca Ellero wrote: Enable support for the National Instruments USB-6501 module. The NI USB-6501 is a Full-Speed USB 2.0 (12 Mbit/s) device that provides 24 digital I/O lines channels and one 32-bit counter. This is a preliminary version: GPIO: works

Re: [PATCH] staging: iio: adis16060: Fix coding style problem

2014-08-07 Thread Jonathan Cameron
On 06/08/14 18:06, Oussama Jabbari wrote: This patch fixes a warning from checkpatch.pl script : WARNING: Missing a blank line after declarations Signed-off-by: Oussama Jabbari oussama.jabb...@gmail.com Whilst I find it hard to care about this particular issue, I'm accepting this mainly to

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current-real_parent field

2014-08-07 Thread Evgeny Budilovsky
On Thu, Aug 7, 2014 at 12:42 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Aug 06, 2014 at 09:22:43PM +0300, Evgeny Budilovsky wrote: Signed-off-by: Evgeny Budilovsky bud...@gmail.com Why is this needed? Is the current code a bug? Where was the reference added? Is this

Re: [PATCH] staging: iio: ad9951: Use devm_iio_device_register

2014-08-07 Thread Jonathan Cameron
On 03/08/14 11:00, Himangi Saraogi wrote: This patch introduces the use of devm_iio_device_register and does away with the unregister in the remove function. The remove function is no longer required and is completely removed. Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by:

Re: [PATCH] staging:iio:ad9852: Use devm_iio_device_register

2014-08-07 Thread Jonathan Cameron
On 03/08/14 10:58, Himangi Saraogi wrote: This patch introduces the use of devm_iio_device_register and does away with the unregister in the remove function. Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr Applied to the togreg branch of

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-07 Thread Srikrishan Malik
On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote: diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c index c03d77c9c5b8..09209171b50c 100644 ---

Re: [PATCH] staging:r819xU: coding style: Fixed commenting style

2014-08-07 Thread Greg KH
On Thu, Aug 07, 2014 at 12:15:57PM +0530, Sanjeev Sharma wrote: This is a patch to the r819xU_phyreg.h file that fixes commenting style warning Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com --- drivers/staging/rtl8192u/r819xU_phyreg.h | 188 --- 1

URGENT BUSINESS REQUEST

2014-08-07 Thread Ahmed Zama
Dear Friend I am Mr. Ahmed Zama,I work for UBA bank Ouagadougou Burkina Faso. I have a business proposal which concerns the transfer of € 4.8 M Euros into a foreign account. Everything about this transaction shall be legally done without any problem. If you are interested to help me, I will

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

2014-08-07 Thread Joe Perches
On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote: On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote: On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: That looks silly before and after. Everything is indented in a funny way. Is this better:

[PATCHv2 1/2] Staging: rtl8188eu: Lines over 80 characters fixed.

2014-08-07 Thread Adrian Remonda
This is a patch to the hal/rtl8188eu_recv.c file that fixes up a line over 80 characters warning found by the checkpatch.pl tool. Signed-off-by: Adrian Remonda adrianremo...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 28 +- 1 file changed, 18

Re: [PATCH] Staging: rtl8188eu: Lines over 80 characters fixed.

2014-08-07 Thread AdrianRemonda
On Mon, Aug 04, 2014 at 03:52:17PM -0700, Joe Perches wrote: On Tue, 2014-08-05 at 00:45 +0200, Adrian Remonda wrote: This is a patch to the hal/rtl8188eu_recv.c file that fixes up a line over 80 characters warning found by the checkpatch.pl tool. [] diff --git

[PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

2014-08-07 Thread Martin Berglund
Add missing __user macro casting in the function wpa_set_keys. This is okay since the function handles the possibility of param-u.wpa_key.key and param-u.wpa_key.seq pointing to kernelspace using a flag, fcpfkernel. Signed-off-by: Martin Berglund mar...@rogsta.net --- This was submitted as part

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-07 Thread Richard Weinberger
On Mon, Jul 21, 2014 at 11:32 PM, David Miller da...@davemloft.net wrote: From: Olaf Hering o...@aepfle.de Date: Mon, 21 Jul 2014 11:18:51 +0200 On Mon, Jul 21, Richard Weinberger wrote: My concern is that 10 seconds is maybe not a the right choice. (As we cannot know all implementations)

Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

2014-08-07 Thread Greg Kroah-Hartman
On Thu, Aug 07, 2014 at 11:08:34PM +0100, Martin Berglund wrote: Add missing __user macro casting in the function wpa_set_keys. This is okay since the function handles the possibility of param-u.wpa_key.key and param-u.wpa_key.seq pointing to kernelspace using a flag, fcpfkernel.

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-07 Thread Dexuan Cui
-Original Message- From: Richard Weinberger [mailto:richard.weinber...@gmail.com] Sent: Friday, August 8, 2014 6:37 AM To: David Miller; Yue Zhang (OSTC DEV) Cc: o...@aepfle.de; net...@vger.kernel.org; driverdev- de...@linuxdriverproject.org; LKML; Greg KH; jasow...@redhat.com;

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-07 Thread Greg KH
On Fri, Aug 08, 2014 at 03:13:58AM +, Dexuan Cui wrote: -Original Message- From: Richard Weinberger [mailto:richard.weinber...@gmail.com] Sent: Friday, August 8, 2014 6:37 AM To: David Miller; Yue Zhang (OSTC DEV) Cc: o...@aepfle.de; net...@vger.kernel.org; driverdev-

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current-real_parent field

2014-08-07 Thread Greg Kroah-Hartman
On Thu, Aug 07, 2014 at 02:13:50PM +0300, Evgeny Budilovsky wrote: On Thu, Aug 7, 2014 at 12:42 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Aug 06, 2014 at 09:22:43PM +0300, Evgeny Budilovsky wrote: Signed-off-by: Evgeny Budilovsky bud...@gmail.com Why is this

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current-real_parent field

2014-08-07 Thread Oleg Drokin
Hello! On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote: This is not a critical bug and in the worst case the code here may cause miss of statistics counter increase. This is why I think it is not worth to backport the patch at all. You are right, and if this is just for some random

RE: [PATCH] staging:r819xU: coding style: Fixed commenting style

2014-08-07 Thread Sharma, Sanjeev
Opps, I forget. Let me correct and send V2 patch. Regards Sanjeev Sharma -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, August 07, 2014 9:33 PM To: Sharma, Sanjeev Cc: de...@driverdev.osuosl.org; oor...@gmail.com; linux-ker...@vger.kernel.org

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current-real_parent field

2014-08-07 Thread Greg Kroah-Hartman
On Fri, Aug 08, 2014 at 12:03:20AM -0400, Oleg Drokin wrote: Hello! On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote: This is not a critical bug and in the worst case the code here may cause miss of statistics counter increase. This is why I think it is not worth to backport the

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current-real_parent field

2014-08-07 Thread Oleg Drokin
On Aug 8, 2014, at 12:42 AM, Greg Kroah-Hartman wrote: On Fri, Aug 08, 2014 at 12:03:20AM -0400, Oleg Drokin wrote: Hello! On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote: This is not a critical bug and in the worst case the code here may cause miss of statistics counter increase.

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current-real_parent field

2014-08-07 Thread Greg Kroah-Hartman
On Fri, Aug 08, 2014 at 01:06:15AM -0400, Oleg Drokin wrote: On Aug 8, 2014, at 12:42 AM, Greg Kroah-Hartman wrote: On Fri, Aug 08, 2014 at 12:03:20AM -0400, Oleg Drokin wrote: Hello! On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote: This is not a critical bug and in the