Re: [PATCH] staging: xillybus: fix some coding style errors

2014-08-10 Thread Greg Kroah-Hartman
On Wed, Jul 16, 2014 at 03:19:42PM +0200, Vincent Bernat wrote: This includes: - keep else on the same line as the closing brace - don't use else after return - don't issue a message for an out-of-memory error - blank line after a declaration Signed-off-by: Vincent Bernat

Re: [PATCH 07/13] staging: comedi: amplc_dio200: tidy up comedi_driver declaration

2014-08-10 Thread Greg KH
On Fri, Aug 01, 2014 at 01:07:05PM -0700, H Hartley Sweeten wrote: For aesthetics, add some whitespace to the declaration. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk --- drivers/staging/comedi/drivers/amplc_dio200.c | 14

Re: [PATCH] staging: dgnc: remove some unused code

2014-08-10 Thread Greg KH
On Sat, Aug 02, 2014 at 08:06:38PM +0900, Seunghun Lee wrote: Remove some unused code. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c| 72 +-

Re: [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

2014-08-10 Thread Greg KH
On Wed, Aug 06, 2014 at 10:42:51PM +0530, Srikrishan Malik wrote: Fixes following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com Can you redo this whole series, based on the comments you

Re: [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning

2014-08-10 Thread Greg KH
On Tue, Aug 05, 2014 at 09:03:48PM +0100, Miguel Oliveira wrote: Fix sparse warning: drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static? by making it static since it's only used once. Signed-off-by:

Re: [PATCH] staging: rtl8192u: checkpatch: do not use C99 // comments

2014-08-10 Thread Greg KH
On Sun, Aug 03, 2014 at 09:28:20PM +0200, Martin Kepplinger wrote: Use the common kernel coding style, so don't use C99 // comments. If too long, where reasonable, they are shortened as well. Some old internal comments about date and author of changes are removed. This provides a more

Re: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.

2014-08-10 Thread Greg KH
On Fri, Aug 08, 2014 at 12:05:38PM +0300, Dan Carpenter wrote: On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote: This patch clear some code that was not doing any help. Pointed out by Larry.Finger The patch is fine but the changelog doesn't inpsire confidence. It should

Re: [PATCH 00/15] staging: comedi: 8255: tidy up the (*io) operations

2014-08-10 Thread Greg KH
On Mon, Aug 04, 2014 at 02:18:43PM +0100, Ian Abbott wrote: On 2014-08-01 22:18, H Hartley Sweeten wrote: Now that the comedi_device has a 'mmio' and a 'iobase' member, this module can detect if the (*io) operations need to use readb/writeb for memory mapped I/O or inb/outb for port I/O. This

Re: [PATCH 02/10] staging: ozwpan: Fix typo in typedef

2014-08-10 Thread Greg KH
On Mon, Aug 04, 2014 at 02:54:48PM +0200, Christoph Jaeger wrote: Signed-off-by: Christoph Jaeger em...@christophjaeger.info --- drivers/staging/ozwpan/ozproto.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.h

Re: [PATCH 1/3] Staging: Netlogic: Fix compilation error

2014-08-10 Thread Greg KH
On Tue, Aug 05, 2014 at 07:44:23PM +0530, ganes...@broadcom.com wrote: From: Ganesan Ramalingam ganes...@broadcom.com Cop2 save and restore function names are changed, added that change I can't understand this sentance, what does it mean? What compilation error? Where is it broken, in

Re: [PATCH] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread Greg KH
On Tue, Aug 05, 2014 at 11:57:06PM +0100, Mark Einon wrote: Fix two reported bugs, caused by et131x_adapter-phydev-addr being accessed before it is initialised, by: - letting et131x_mii_write() take a phydev address, instead of using the one stored in adapter by default. This is so

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

2014-08-10 Thread Greg KH
On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov artem...@acm.org --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 file changed, 3

Re: [PATCH] staging: xillybus: fix some coding style errors

2014-08-10 Thread Vincent Bernat
❦ 9 août 2014 20:34 -0700, Greg Kroah-Hartman gre...@linuxfoundation.org : This includes: - keep else on the same line as the closing brace - don't use else after return - don't issue a message for an out-of-memory error - blank line after a declaration Signed-off-by: Vincent

Re: [PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

2014-08-10 Thread Greg Kroah-Hartman
On Sat, Aug 09, 2014 at 08:22:48PM +, Junien Fridrick wrote: Sorry for the noise, this is part of task 10 of the Eudyptula Challenge. It's not noise at all, but it's not needed in the changelog comment, as was pointed out. Can you resend without this line, and actually say _what_ coding

Re: [PATCH] staging: xillybus: fix some coding style errors

2014-08-10 Thread Greg Kroah-Hartman
On Sun, Aug 10, 2014 at 02:16:04PM +0200, Vincent Bernat wrote: ❦ 9 août 2014 20:34 -0700, Greg Kroah-Hartman gre...@linuxfoundation.org : This includes: - keep else on the same line as the closing brace - don't use else after return - don't issue a message for an out-of-memory

[PATCH 00/17] staging/bcm/Bcmchar.c variable rename patches

2014-08-10 Thread Matthias Beyer
Hi, this is the requested resend of my patchset on the drivers/staging/bcm/Bcmchar.c file where I do rename variables. Please note, as always: As I do not have the appropriate hardware, I'm not able to test these patches. I compiled them at least. Kind regards, Matthias Beyer Matthias

[PATCH 01/17] Staging: bcm: Bcmchar.c: Fixed indentation of function arguments

2014-08-10 Thread Matthias Beyer
Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 56 --- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index c1e01f7..aff21d0 100644 ---

[PATCH 08/17] Staging: bcm: Bcmchar.c: Renamed variable PktLen - pkt_len

2014-08-10 Thread Matthias Beyer
Renamed variable PktLen - pkt_len in bcm_char_read(). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index

[PATCH 03/17] Staging: bcm: Bcmchar.c: Renamed variable pReadData - read_data

2014-08-10 Thread Matthias Beyer
Renamed variable pReadData - read_data in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 07/17] Staging: bcm: Bcmchar.c: Renamed variable pTarang - tarang

2014-08-10 Thread Matthias Beyer
Renamed variable pTarang - tarang in bcm_char_open() bcm_char_release() bcm_char_read() Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff

[PATCH 06/17] Staging: bcm: Bcmchar.c: Renamed variable ulDSDMagicNumInUsrBuff - dsd_magic_num_in_usr_buff

2014-08-10 Thread Matthias Beyer
Renamed variable ulDSDMagicNumInUsrBuff - dsd_magic_num_in_usr_buff in handle_flash2x_adapter(). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c

[PATCH 04/17] Staging: bcm: Bcmchar.c: Renamed variable stNVMReadWrite - nvm_rw

2014-08-10 Thread Matthias Beyer
Renamed variable stNVMReadWrite - nvm_rw in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git

[PATCH 09/17] Staging: bcm: Bcmchar.c: Renamed variable Packet - packet

2014-08-10 Thread Matthias Beyer
Renamed variable Packet - packet in bcm_char_read(). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index

[PATCH 05/17] Staging: bcm: Bcmchar.c: Renamed variable Status - status

2014-08-10 Thread Matthias Beyer
Renamed variable Status - status in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() bcm_char_ioctl_gpio_set_request()

[PATCH 02/17] Staging: bcm: Bcmchar.c: Renamed variable Adapter - ad

2014-08-10 Thread Matthias Beyer
Renamed variable Adapter - ad in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() bcm_char_open() bcm_char_release() bcm_char_read() bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_reg_write_private()

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Greg KH
On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via getter function and as a result the externing of globals is removed. The names of the variables

[PATCH 13/17] Staging: bcm: Bcmchar.c: Renamed variable sWrmBuffer - wrm_buff

2014-08-10 Thread Matthias Beyer
Renamed variable sWrmBuffer - wrm_buff in bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 32 1 file changed, 16 insertions(+), 16 deletions(-)

[PATCH 12/17] Staging: bcm: Bcmchar.c: Renamed variable Bufflen - buff_len

2014-08-10 Thread Matthias Beyer
Renamed variable Bufflen - buff_len in bcm_char_ioctl_reg_read_private(). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c

[PATCH 10/17] Staging: bcm: Bcmchar.c: Renamed variable sRdmBuffer - rdm_buff

2014-08-10 Thread Matthias Beyer
Renamed variable sRdmBuffer - rdm_buff in bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff

[PATCH 11/17] Staging: bcm: Bcmchar.c: Renamed variable IoBuffer - io_buff

2014-08-10 Thread Matthias Beyer
Renamed variable IoBuffer - io_buff in bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() bcm_char_ioctl_gpio_set_request() Signed-off-by: Matthias Beyer m...@beyermatthias.de ---

[PATCH 17/17] Staging: bcm: Bcmchar.c: Renamed variable uiOperation - operation

2014-08-10 Thread Matthias Beyer
Renamed variable uiOperation - operation in bcm_char_ioctl_gpio_set_request(). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c

[PATCH 15/17] Staging: bcm: Bcmchar.c: Renamed variable ucResetValue - reset_val

2014-08-10 Thread Matthias Beyer
Renamed variable ucResetValue - reset_val in bcm_char_ioctl_gpio_set_request(). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c

[PATCH 14/17] Staging: bcm: Bcmchar.c: Renamed variable uiTempVar - tmp

2014-08-10 Thread Matthias Beyer
Renamed variable uiTempVar - tmp in bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH 16/17] Staging: bcm: Bcmchar.c: Renamed variable uiBit - bit

2014-08-10 Thread Matthias Beyer
Renamed variable uiBit - bit in bcm_char_ioctl_gpio_set_request(). Signed-off-by: Matthias Beyer m...@beyermatthias.de --- drivers/staging/bcm/Bcmchar.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

2014-08-10 Thread Artemiy Volkov
On Sat, 9 Aug 2014, Greg KH wrote: On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov artem...@acm.org ---

[PATCHv2] staging: rtl8192u: checkpatch: do not use C99 // comments

2014-08-10 Thread Martin Kepplinger
Use the common kernel coding style, so don't use C99 // comments in r8192U_core.c If too long, where reasonable, they are shortened as well. Some old internal comments about date and author of changes are removed. This provides a more consistent view and hopefully encourages to look at it.

Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

2014-08-10 Thread Martin Berglund
On Sat, Aug 09, 2014 at 08:36:55PM -0700, Greg Kroah-Hartman wrote: On Sat, Aug 09, 2014 at 01:55:19AM +0200, Martin Berglund wrote: On Fri, Aug 08, 2014 at 06:47:25AM -0700, Greg Kroah-Hartman wrote: On Fri, Aug 08, 2014 at 09:07:55AM +0200, Martin Berglund wrote: On Thu, Aug 07, 2014

Re: [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

2014-08-10 Thread Srikrishan Malik
On Sat, Aug 09, 2014 at 09:32:22PM -0700, Greg KH wrote: On Wed, Aug 06, 2014 at 10:42:51PM +0530, Srikrishan Malik wrote: Fixes following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Srikrishan Malik

[PATCH 01/22] staging: rtl8188eu: Cleanup firmware initialization code

2014-08-10 Thread navin patidar
Using rtl8188ee's (drivers/net/wireless/rtlwifi/rtl8188ee/fw.c) neat and clean firmware initialization code to replace rtl8188eu's messy firmware initialization code. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/Makefile|1 +

[PATCH 05/22] staging: rtl8188eu: Remove unused function odm_ConfigRFReg_8188E()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 25 .../staging/rtl8188eu/include/odm_RegConfig8188E.h |3 --- 2 files changed, 28 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c

[PATCH 04/22] staging: rtl8188eu: Remove unused functions odm_ConfigRF_Radio[A, B]_8188E()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 19 --- .../staging/rtl8188eu/include/odm_RegConfig8188E.h |6 -- 2 files changed, 25 deletions(-) diff --git

[PATCH 06/22] staging: rtl8188eu: Remove unused function odm_ConfigMAC_8188E()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c |8 drivers/staging/rtl8188eu/include/odm_RegConfig8188E.h |2 -- 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c

[PATCH 03/22] staging: rtl8188eu: Cleanup and simplify RF configuration code

2014-08-10 Thread navin patidar
Cleanup and consolidate RF configuration related code in HalHWImg8188E_RF.c file. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 269 drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 14 -

[PATCH 02/22] staging: rtl8188eu: Cleanup and simplify MAC configuration code

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c | 120 ++-- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |7 -- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 37 --

[PATCH 11/22] staging: rtl8188eu: Remove unused function rtw_IOL_accquire_xmit_frame()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_iol.c| 36 --- drivers/staging/rtl8188eu/include/rtw_iol.h |1 - 2 files changed, 37 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c

[PATCH 08/22] staging: rtl8188eu: Remove odm_RegConfig8188E.[h, c] files

2014-08-10 Thread navin patidar
driver doesn't require these files anymore. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/Makefile |1 - drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 86 .../staging/rtl8188eu/include/odm_RegConfig8188E.h |

[PATCH 09/22] staging: rtl8188eu: Remove unused function storePwrIndexDiffRateOffset()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 44 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |2 - 2 files changed, 46 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c

[PATCH 10/22] staging: rtl8188eu: Hal8188EPhyCfg.h: Remove unused function declaration

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h b/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h index

[PATCH 12/22] staging: rtl8188eu: Remove unused function rtw_IOL_cmd_boundary_handle()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_iol.c| 13 - drivers/staging/rtl8188eu/include/rtw_iol.h |1 - 2 files changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c

[PATCH 14/22] staging: rtl8188eu: Remove unused function rtw_IOL_exec_cmds_sync()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_iol.c|5 - drivers/staging/rtl8188eu/include/rtw_iol.h |3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c

[PATCH 13/22] staging: rtl8188eu: Remove unused function rtw_IOL_append_WD_cmd()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_iol.c| 14 -- drivers/staging/rtl8188eu/include/rtw_iol.h |4 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c

[PATCH 17/22] staging: rtl8188eu: Remove unused function rtw_IOL_cmd_buf_dump()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_iol.c| 17 - drivers/staging/rtl8188eu/include/rtw_iol.h |2 -- 2 files changed, 19 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c

[PATCH 16/22] staging: rtl8188eu: Remove unused function rtw_IOL_cmd_tx_pkt_buf_dump()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 32 - drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 33 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c

[PATCH 15/22] staging: rtl8188eu: Remove unused functions rtw_IOL_append_DELAY_[US, MS]_cmd()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_iol.c| 16 drivers/staging/rtl8188eu/include/rtw_iol.h |2 -- 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c

[PATCH 18/22] staging:rtl8188eu: Remove rtl8188e_IOL_exec_cmds_sync() and its wrapper function

2014-08-10 Thread navin patidar
rtl8188e_IOL_exec_cmds_sync() is a unused function. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/hal_intf.c | 10 --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 32 -

[PATCH 22/22] staging: rtl8188eu: Declare Efuse_GetCurrentSize() as a static function

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_efuse.c|2 +- drivers/staging/rtl8188eu/include/rtw_efuse.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c

[PATCH 19/22] staging: rtl8188eu: Remove unused function iol_ioconfig()

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c index 16525b0..50b1332

[PATCH 21/22] staging: rtl8188eu: rtw_iol.h: Remove unused struct, enum and macro

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_iol.h | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_iol.h b/drivers/staging/rtl8188eu/include/rtw_iol.h index 8ebdddb..68aae7f

[PATCH 20/22] staging: rtl8188eu: rtw_iol.c: Remove unused functions

2014-08-10 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_iol.c| 63 --- drivers/staging/rtl8188eu/include/rtw_iol.h | 18 2 files changed, 81 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c

[PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

2014-08-10 Thread Avinash kumar
Cleaned all C99 comments related warnings Signed-off-by :Avinash Kumar avi.kp@gmail.com Signed-off-by: Avinash kumar avi.kp@gmail.com --- drivers/staging/vt6655/wpactl.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git

[PATCH] staging: wlan-ng: prism2mgmt.c Fix break not useful

2014-08-10 Thread Jeshwanth Kumar N K
This is the part of eudyptula task-10.This is a patch to the prism2mgmt.c file that fixes up warning break is not useful after a goto or return found in checkpatch.pl tool. Signed-off-by: Jeshwanth Kumar N K jeshkumar...@gmail.com --- drivers/staging/wlan-ng/prism2mgmt.c | 3 --- 1 file

[PATCHv3 1/2] Staging: rtl8188eu: Lines over 80 characters fixed.

2014-08-10 Thread Adrian Remonda
This is a patch to the hal/rtl8188eu_recv.c file that fixes up a line over 80 characters warning found by the checkpatch.pl tool. Signed-off-by: Adrian Remonda adrianremo...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 28 +- 1 file changed, 18

[PATCHv3 2/2] Staging: rtl8188eu: Removed unneeded code.

2014-08-10 Thread Adrian Remonda
This patch removes some unneeded code. 1) kzalloc() allocates 4 extra bytes so that we can align the return value. But actually the return value is already aligned so we can remove the + 4 and the call to N_BYTE_ALIGMENT(). 2) The memset() isn't needed because kzalloc() zeroes the

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Konrad Zapalowicz
On 08/10, Greg KH wrote: On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via getter function and as a result the externing of globals is removed.

[PATCH RESEND] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread Mark Einon
Fix two reported bugs, caused by et131x_adapter-phydev-addr being accessed before it is initialised, by: - letting et131x_mii_write() take a phydev address, instead of using the one stored in adapter by default. This is so et131x_mdio_write() can use it's own addr value. - removing

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread Anca Emanuel
Do you have this hardware ? And did you test this ? How can you cc stable without an Tested by somebody else ? On Mon, Aug 11, 2014 at 12:16 AM, Mark Einon mark.ei...@gmail.com wrote: Fix two reported bugs, caused by et131x_adapter-phydev-addr being accessed before it is initialised, by: -

[PATCH v2] staging: lustre: fix coding style issue: missing space after 'if'

2014-08-10 Thread Junien Fridrick
Coding style issue reported by checkpatch.pl Signed-off-by: Junien Fridrick linux.ker...@junien.fridrick.net --- This patch is part of task 10 of the eudyptula challenge Applies to next-20140808 v2 : fixed patch short summary and description drivers/staging/lustre/lustre/llite/remote_perm.c |

[PATCH] drivers: android: fix watermark when cma enabled

2014-08-10 Thread Zengtao (B)
From: Zeng Tao prime.z...@hisilicon.com Date: Tue, 5 Aug 2014 17:58:10 +0800 Subject: [PATCH] drivers: android: fix watermark when cma enabled when cma is enabled, the watermark caculation will include the cma pages, while it can't use cma pages. this will cause oom while lowmemory killer don't

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-10 Thread Dexuan Cui
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] IMO the most feasible and need-the-least-change solution may be: the hyperv network VSC driver passes the event RNDIS_STATUS_NETWORK_CHANGE to the udev daemon? No, don't do that, again, act like

Re: [PATCH 16/19] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-10 Thread Hans Wennborg
On 08/09/2014 09:23 PM, Greg KH wrote: On Sun, Aug 03, 2014 at 05:20:58PM -0700, Hans Wennborg wrote: Signed-off-by: Hans Wennborg h...@hanshq.net --- drivers/staging/rtl8192ee/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) This patch fails to apply to my tree :(

Re: staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-10 Thread Hans Wennborg
Re-sending patch based off of https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-10 Thread Hans Wennborg
Signed-off-by: Hans Wennborg h...@hanshq.net --- drivers/staging/rtl8192ee/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192ee/pci.c b/drivers/staging/rtl8192ee/pci.c index 0215aef..349e636 100644 --- a/drivers/staging/rtl8192ee/pci.c +++

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-10 Thread Dexuan Cui
-Original Message- From: Dexuan Cui Sent: Monday, August 11, 2014 11:24 AM Now I understand it's not good to pass the event to the udev daemon, and it's not good to use a SLEEP(10s) in the kernel space(even if it's in a work task here). Please let me know if it's the correct

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-10 Thread Florian Fainelli
Le 10/08/2014 20:23, Dexuan Cui a écrit : -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] IMO the most feasible and need-the-least-change solution may be: the hyperv network VSC driver passes the event RNDIS_STATUS_NETWORK_CHANGE to the udev daemon? No, don't do

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-10 Thread Bill Fink
On Sun, 10 Aug 2014, Florian Fainelli wrote: Le 10/08/2014 20:23, Dexuan Cui a écrit : -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] IMO the most feasible and need-the-least-change solution may be: the hyperv network VSC driver passes the event

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread gre...@linuxfoundation.org
On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: Do you have this hardware ? And did you test this ? Mark is the maintainer of this driver, I assume he has the hardware, if not, I don't care, I trust him :) How can you cc stable without an Tested by somebody else ? Since when is

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Greg KH
On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote: On 08/10, Greg KH wrote: On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via

Re: [PATCH] staging: wlan-ng: prism2mgmt.c Fix break not useful

2014-08-10 Thread Greg KH
On Mon, Aug 11, 2014 at 12:10:37AM +0530, Jeshwanth Kumar N K wrote: This is the part of eudyptula task-10.This is a patch to the prism2mgmt.c file that fixes up warning break is not useful after a goto or return found in checkpatch.pl tool. That's a really long single line, please fix it

Re: [PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

2014-08-10 Thread Greg KH
On Sun, Aug 10, 2014 at 11:28:55PM +0530, Avinash kumar wrote: Cleaned all C99 comments related warnings Signed-off-by :Avinash Kumar avi.kp@gmail.com Signed-off-by: Avinash kumar avi.kp@gmail.com Why is this line twice in here, the first one has the ':' in the wrong place. Please

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

2014-08-10 Thread Greg KH
On Sun, Aug 10, 2014 at 10:56:38PM +1000, Artemiy Volkov wrote: On Sat, 9 Aug 2014, Greg KH wrote: On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: