On Tue, Aug 12, 2014 at 05:51:28AM +, Dexuan Cui wrote:
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Decoupling the dependency between hyperv_keyboard and i8042 needs
non-trivial efforts and is hence a long term goal.
For now, let's make the
This commit fixes the following checkpatch warnings:
WARNING: externs should be avoided in .c files
#80: FILE: drivers/staging/dgnc/dgnc_driver.c:80:
+intdgnc_init_module(void);
#81: FILE: drivers/staging/dgnc/dgnc_driver.c:81:
+void
dgap_major_serial_registered and dgap_major_transparent_print_registered
could be checked whether a board is initialized.
But it doesn't need to check that variables becasue dgap_board
as global is managed for boards which are initialized completely.
So when it called dgap_cleanup_tty() function,
On Mon, 11 Aug 2014, Greg KH wrote:
On Sun, Aug 10, 2014 at 10:56:38PM +1000, Artemiy Volkov wrote:
On Sat, 9 Aug 2014, Greg KH wrote:
On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote:
This patch fixes the checkpatch.pl 'Missing a blank line after declarations'
warning in
A sparse warning is generated about 'ieee80211_debug_init' and
'ieee80211_debug_exit' not being declared.
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning:
symbol 'ieee80211_debug_init' was not declared. Should it be static?
-Original Message-
From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
ow...@vger.kernel.org] On Behalf Of Greg KH
What exactly needs to be done to fix this correctly that is going to
take too much work at the moment?
To decouple the dependency between the
On 08/11/2014 09:02 PM, Dan Carpenter wrote:
On Mon, Aug 11, 2014 at 04:32:16PM +0800, rogera...@realtek.com wrote:
From: Roger Tseng rogera...@realtek.com
Current code erroneously fill the last byte of R2 response with an undefined
value. In addition, it is impossible to obtain the real
-Original Message-
From: Florian Fainelli [mailto:f.faine...@gmail.com]
Sent: Monday, August 11, 2014 11:52 AM
I suppose you meant the below logic:
if (refresh) {
rtnl_lock();
netif_carrier_off(net);
netif_carrier_on(net);
rtnl_unlock();
-Original Message-
From: Bill Fink
In the case of ifplugd, it has parameters -u | --delay-up= which
defaults to 0 seconds, and -d | --delay-down= which defaults to
5 seconds. Maybe for hyperv you could specify --delay-down=0.
I don't know if other daemons such as systemd have
From: Tom Gundersen
Unluckily this logic doesn't work because the user-space daemons
like ifplugd, usually don't renew the DHCP immediately as long as they
receive a link-down message: they usually wait for some seconds and if
they find the link becomes up soon, they won't trigger renew
On 2014-08-11 at 18:15:58 +0200, Jeshwanth Kumar N K jeshkumar...@gmail.com
wrote:
Fixes up warning, break is not useful after a goto or return statement
Signed-off-by: Jeshwanth Kumar N K jeshkumar...@gmail.com
---
drivers/staging/wlan-ng/prism2mgmt.c | 3 ---
1 file changed, 3
On 2014-08-12 03:02, Chase Southwood wrote:
This patchset removes an uncorrect and unneeded insn_config operation,
strips out remaining in-driver watchdog subdevice code, and cleans up the
driver's register map defines.
Chase Southwood (3):
staging: comedi: addi_apci_1564: remove
In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing.
So remove them and related codes.
CC: Lidza Louina lidza.lou...@gmail.com
CC: Mark Hounschell ma...@compro.net
Signed-off-by: Seunghun Lee way...@gmail.com
---
drivers/staging/dgnc/dgnc_cls.c| 63 +
This patch fixes the coding style error :
WARNING: else is not generally useful after a break or return
reported by checkpatch.pl
Signed-off-by: Vibi Sreenivasan vibisreeniva...@linuxmail.org
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 26 --
1 file changed, 12
On Sat, Aug 9, 2014 at 4:46 PM, Rickard Strandqvist
rickard_strandqv...@spectrumdigital.se wrote:
Added a guaranteed null-terminate after call to strncpy.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/lustre/lustre/libcfs/workitem.c |1 +
This patch fix coding style
- Remove return of void function
Tested by compilation
Signed-off-by: Phong Tran tranmanph...@gmail.com
---
drivers/staging/android/ion/ion_chunk_heap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_chunk_heap.c
This patch fix the coding style
- Add a new line after variable declaration
- Remove return of void fuction
Tested by compilation
Signed-off-by: Phong Tran tranmanph...@gmail.com
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This patch fix coding style
- Remove return of void function
Tested by compilation
Signed-off-by: Phong Tran tranmanph...@gmail.com
---
drivers/staging/android/ion/ion_carveout_heap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_carveout_heap.c
This patch fix coding style
- Replace kzalloc() by kcalloc()
- Remove return of void function
Tested by compilation
Signed-off-by: Phong Tran tranmanph...@gmail.com
---
drivers/staging/android/ion/ion_dummy_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
Hi Greg,
These patches fix checkpatch warning.
Apply for staging-next branch.
Regards,
Phong.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Aug 12, 2014 at 02:17:07AM +, Drokin, Oleg wrote:
On Aug 11, 2014, at 2:27 PM, Srikrishan Malik wrote:
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c
-Original Message-
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
Sent: Tuesday, August 12, 2014 10:55 AM
To: Dexuan Cui
Cc: Greg KH; linux-in...@vger.kernel.org; linux-ker...@vger.kernel.org;
driverdev-devel@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com;
This member of the boardinfor is only set for the PCIE boards. For
aeshetics, rename it to 'is_pcie'.
For clarity, use this flag in the (*auto_attach) to determine if the
dio200_pcie_board_setup() function needs to be called instead of using
the switch (context_model).
Signed-off-by: H Hartley
This exported function just does a free_irq() to release the interrupt
handler for the legacy and PCI dio200 drivers.
The legacy driver also calls comedi_legacy_detach() which would also
do the free_irq(). For that driver the just use comedi_legacy_detach()
directly for the (*detach).
For the
For aesthetics, add some whitespace to the declaration.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_dio200.c | 14 +++---
1 file changed,
This function is only called by amplc_dio200_common_attach() and it
can never fail. For aesthetics, absorb it into that function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This struct is used to provide part of the boardinfo data. Using the extra
indirection does not provide any additional clarity to the driver.
Absorb the members from dio200_layout into dio200_board and remove the
extra 'layout' indirection.
For aesthetics, rename all the local variables used for
The function names provide enough description. The extra comments are not
necessary. Remove them.
Also, tidy up some of the function declarations.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
The 8255 driver (*io) callback now includes the comedi_device pointer.
Instead of passing the (cast) pointer to subdev_8255_init(), pass the
'iobase' of the 8255 registers (DIO_BASE_REG).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc:
The 8255 driver (*io) callback now includes the comedi_device pointer.
Instead of passing the (cast) pointer to subdev_8255_init(), pass the
'iobase' of the 8255 registers (Port_A).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Now that the comedi_device has a 'mmio' and a 'iobase' member, this module
can updated to readb/writeb for memory mapped I/O or inb/outb for port I/O.
With this a lot of the code duplication can be removed in the drivers that
use the 8255 module.
1) Modify a couple comedi drivers that use port
The async command support in this module is incomplete and nothing
has ever used it. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/8255.c | 95
The drivers that use this module with memory mapped io all have the
ioremap'ed base address stored in the comedi_device 'mmio' member.
Introduce a default (*io) function that does 8-bit memory mapped io.
Modify subdev_8255_init() so that it takes a flag parameter indicating
if the io is port or
This driver uses two iobase addresses, found in PCI bars 2 and 3.
Currently, the address in PCI bar 2 is saved in the private data as
'iobase1' and the address in PCI bar 3 is saved in the comedi_device
as the 'iobase'. The 'iobase' is the base address of the daq
registers (ai/ao) of the board.
The 8255 driver (*io) callback now includes the comedi_device pointer.
Using this we can get the ioremap'ed base address.
Instead of passing the (cast) mmio address to subdev_8255_init(), pass
the 'iobase' of the 8255 registers (DIO_8255_OFFSET).
Signed-off-by: H Hartley Sweeten
This driver uses three iobase addresses, found in PCI bars 2, 3, and 4.
Currently, the address in PCI bar 2 is saved in the comedi_device as
the 'iobase', the PCI bar 3 address is saved in the private data as
'BADR3' and the one in PCI bar 4 is just passed to subdev_8255_init()
as the 'iobase'
The 8255 driver (*io) callback now includes the comedi_device pointer.
Using this we can get the ioremap'ed base address.
Instead of passing the (cast) mmio address to subdev_8255_init(), pass
the 'iobase' of the 8255 registers (i * 4).
Signed-off-by: H Hartley Sweeten
Currently the base address of the 8254 and 8255 devices, found in
PCI bar 3, is saved in the private data as 'pacer_counter_dio'.
The 'iobase' in the comedi_device is currently unused.
Save the address from PCI bar 3 in the comedi_device and remove
the unnecessary member from the private data.
The 8255 driver uses an (*io) callback to read/write the registers
of the 8255 device. The default callback provided by the driver uses
inb()/outb() calls to access to registers based on an 'iobase' that
was initialized during the subdev_8255_init() and a 'port' value.
The users of this module
The 8255 driver (*io) callback now includes the comedi_device pointer.
Using this we can get the ioremap'ed base address.
Instead of passing the (cast) mmio address to subdev_8255_init(), pass
the 'iobase' of the 8255 registers (I8255_4020_REG).
Signed-off-by: H Hartley Sweeten
This driver uses two iobase addresses, found in PCI bars 2 and 3.
Currently, the address in PCI bar 3 is saved in the comedi_device as
the 'iobase' and the one in PCI bar 2 is just passed to subdev_8255_init()
as the 'iobase' parameter.
Save the PCI bar 3 address in the private data as 'daqio'
There are a couple comedi drivers that duplicate some of the register
defines used by the 8255 module. Move these defines into the header
so the duplication can be removed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Currently, all users of is module that use the default (*io) function
pass an 'iobase' to subdev_8255_init() of the form:
dev-iobase + OFFSET_TO_8255_BASE_REG
Now that the (*io) callback includes the comedi_device 'dev' pointer
the 'dev-iobase' does not need to be included.
Modify the default
removed goto label, and directly returning 0 not through goto.
Signed-off-by: Jeshwanth Kumar N K jeshkumar...@gmail.com
---
drivers/staging/wlan-ng/prism2mgmt.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
On 8/10/2014 7:06 PM, Zengtao (B) wrote:
From: Zeng Tao prime.z...@hisilicon.com
Date: Tue, 5 Aug 2014 17:58:10 +0800
Subject: [PATCH] drivers: android: fix watermark when cma enabled
when cma is enabled, the watermark caculation will include the cma pages,
while it can't use cma pages.
On Wed, Aug 13, 2014 at 01:06:16AM +0530, Himangi Saraogi wrote:
Hi,
In the file, I see the code:
void rtl8821ae_dm_set_tx_ant_by_tx_
info(...) {
...
if ((rtlefuse-antenna_div_type == CG_TRX_HW_ANTDIV) ||
(rtlefuse-antenna_div_type == CG_TRX_HW_ANTDIV)){
-Original Message-
From: Dmitry Torokhov
Sent: Wednesday, August 13, 2014 1:55 AM
To decouple the dependency between the hyperv-keyboard and i8042
modules, I suppose we probably have to re-implement hyperv-
keyboard by
using input_allocate_device(), input_register_device(),
-Original Message-
From: KY Srinivasan
The Arch users can simply select to build i8042 into the kernel as a
workaround.
The proper solution is to allow loading libps2 module even if i8042 did not
find
its device. I wish I could simply drop this i8042_lock_chip and stuff, but
Adds a blank line after declaration to comply with coding style.
Signed-off-by: Ragnar B. Johannsson rag...@igo.is
---
drivers/staging/vt6656/rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 08ce18d..852ebe8 100644
---
This patchset fixes a few small coding style problems as reported by checkpatch.
Ragnar B. Johannsson (3):
staging: vt6656: remove unnecessary braces
staging: vt6656: fix incorrect indentation
staging: vt6656: add blank line after declaration
drivers/staging/vt6656/rxtx.c| 3 ++-
Use tabs, not spaces.
Signed-off-by: Ragnar B. Johannsson rag...@igo.is
---
drivers/staging/vt6656/rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 2d1ef88..08ce18d 100644
---
Removes unnecessary braces to comply with coding style.
Signed-off-by: Ragnar B. Johannsson rag...@igo.is
---
drivers/staging/vt6656/usbpipe.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index
52 matches
Mail list logo
