Re: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

2014-10-03 Thread Ian Abbott
On 02/10/2014 15:41, Chen Gang wrote: COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error ( with allmodconfig under um): CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:

[PATCH v3] staging: rts5208: Clean up coding style in rtsx_chip.c

2014-10-03 Thread Giedrius Statkevicius
Make the second line of a divided line match the opening paranthesis. Combine two if's in form of 'if (a) if (b) { [...] }' into one to lower the indentation level. To further lower indentation level and make the code more concise use the ternary operator where possible and sensible. Make the

Re: [PATCH v3] staging: rts5208: Clean up coding style in rtsx_chip.c

2014-10-03 Thread Greg KH
On Fri, Oct 03, 2014 at 07:16:13PM +0300, Giedrius Statkevicius wrote: Make the second line of a divided line match the opening paranthesis. Combine two if's in form of 'if (a) if (b) { [...] }' into one to lower the indentation level. To further lower indentation level and make the code more

[PATCH] staging:gs_fpgaboot: Remove KERN_INFO in pr_info()

2014-10-03 Thread Masanari Iida
This patch remove unnecessary KERN_INFO in pr_info() Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c

Re: [PATCH] staging:gs_fpgaboot: Remove KERN_INFO in pr_info()

2014-10-03 Thread Joe Perches
On Fri, 2014-10-03 at 10:18 -0700, Joe Perches wrote: On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote: This patch remove unnecessary KERN_INFO in pr_info() [] diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c [] @@ -58,7 +58,7 @@

[PATCH 07/41] staging: unisys: get rid of MACARRAY typedef

2014-10-03 Thread Benjamin Romer
Remove the MACARRAY typedef entirely and switch over to u8*[ETH_ALEN], like everybody else seems to use. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 02/41] staging: unisys: clean up GUESTPART_MSG_TYPE typedef

2014-10-03 Thread Benjamin Romer
Switch GUESTPART_MSG_TYPE over to enum guestpart_msg_type. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisqueue.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/include/uisqueue.h

[PATCH 00/41] staging: unisys: more checkpatch.pl cleanup

2014-10-03 Thread Benjamin Romer
This series includes patches that were not able to be applied from the prior series of cleanup patches, and additional patches to remove unused code and doxygen comments from timskmod.h. When this work is complete the include directory should be clean of all checkpatch.pl warnings, and all strict

[PATCH 13/41] staging: unisys: fix indentation in req_handler_info

2014-10-03 Thread Benjamin Romer
Fix the indentation around server_channel_init, so the parameters line up nicely. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 04/41] staging: unisys: fix CamelCase in struct add_vbus_guestpart

2014-10-03 Thread Benjamin Romer
Clean up CamelCase names: busNo = bus_no deviceCount = dev_count busTypeGuid = bus_uuid busInstGuid = instance_guid Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisqueue.h | 8 drivers/staging/unisys/uislib/uislib.c| 8

[PATCH 32/41] staging: unisys: Fix VMCALL_IO_DIAG_ADDR_PARAMS

2014-10-03 Thread Benjamin Romer
Remove the typedef from VMCALL_IO_DIAG_ADDR_PARAMS and use the name struct vmcall_io_diag_addr_params instead. Fix CamelCase member names: ChannelAddress = address Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/common-spar/include/vmcallinterface.h | 6 +++---

[PATCH 23/41] staging: unisys: Fix CamelCase in uislib_client_inject_add_vnic()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no devNo = dev_no instGuid = inst_uuid Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 4 ++-- drivers/staging/unisys/uislib/uislib.c| 18 +- 2 files changed, 11 insertions(+), 11

[PATCH 12/41] staging: unisys: fix CamelCase in ReqHandlerDel

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: ReqHandlerDel = req_handler_del switchTypeGuid = switch_uuid Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uisutils.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 01/41] staging: unisys: clean up enums in uisqueue.h

2014-10-03 Thread Benjamin Romer
Get rid of typedefs in enums SWITCH_TYPE and IOPART_MSG_TYPE, and use the enum names directly instead. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisqueue.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[PATCH 31/41] staging: unisys: Fix VMCALL_IO_CONTROLVM_ADDR_PARAMS structure

2014-10-03 Thread Benjamin Romer
Remove the typedef from VMCALL_IO_CONTROLVM_ADDR_PARAMS and switch to use struct vmcall_io_controlvm_addr_params. Fix the CamelCase names: ChannelAddress = address ChannelBytes = channel_bytes Unused = unused Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 09/41] staging: unisys: fix CamelCase in struct req_handler_info

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: switchTypeGuid = switch_uuid Server_Channel_Ok = server_channel_ok channelBytes = channel_bytes Server_Channel_Init = server_channel_init clientStr = client_str clientStrLen = client_str_len Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 21/41] staging: unisys: Fix CamelCase in uislib_client_inject_resume_vhba()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no devNo = dev_no Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 11/41] staging: unisys: fix CamelCase in ReqHandlerFind()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: ReqHandlerFind = req_handler_find switchTypeGuid = switch_uuid Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 2 +- drivers/staging/unisys/uislib/uisutils.c | 4 ++--

[PATCH 37/41] staging: unisys: remove old doxygen comments from timskmod.h

2014-10-03 Thread Benjamin Romer
Remove doxygen comments and fix what's left so it's still useful. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/timskmod.h | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/unisys/include/timskmod.h

[PATCH 20/41] staging: unisys: Fix CamelCase in uislib_client_inject_pause_vhba()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no devNo = dev_no Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 14/41] staging: unisys: fix CamelCase in uisctrl_register_req_handler_ex

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: switchTypeGuid = switch_uuid clientStr = client_str clientStrLent = client_str_len chipset_driverInfo = chipset_driver_info Server_Channel_Ok = server_channel_ok Server_Channel_Init = server_channel_init Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 25/41] staging: unisys: Fix CamelCase in uislib_client_inject_resume_vnic()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no devNo = dev_no Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 30/41] staging: unisys: fix typedef of ULTRA_VBUS_CHANNEL_PROTOCOL

2014-10-03 Thread Benjamin Romer
Get rid of the typedef ULTRA_VBUS_CHANNEL_PROTOCOL, in favor of the name struct ultra_vbus_channel_protocol. This change finishes the warnings clean up for include/uisqueue.h. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 22/41] staging: unisys: Fix CamelCase in uislib_client_inject_del_vhba()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no devNo = dev_no Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 03/41] staging: unisys: Clean up CamelCase in struct bus_info

2014-10-03 Thread Benjamin Romer
Clean up CamelCase names: busNo = bus_no deviceCount = device_count guestHandle = guest_handle recvBusInterruptHandle = recv_bus_irq_handle busInstGuid = inst_uuid pBusChannel = bus_channel busChannelBytes = bus_channel_bytes partitionName = partition_name localVnic = local_vnic Signed-off-by:

[PATCH 36/41] staging: unisys: Fix ULTRA_VBUS_DEVICEINFO

2014-10-03 Thread Benjamin Romer
Remove the typedef from ULTRA_VBUS_DEVICEINFO and use struct ultra_vbus_deviceinfo instead. Fix CamelCase member names: devType = devtype drvName = drvname infoStrings = infostrs Fix indentation on function definitions that were affected by the structure's name change. Signed-off-by: Benjamin

[PATCH 10/41] staging: unisys: fix CamelCase names in ReqHandlerAdd()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: ReqHandlerAdd = req_handler_add Server_Channel_Ok = svr_channel_ok channelBytes = channel_bytes Server_Channel_Init = svr_channel_init clientStr = client_str ClientStrLen = client_str_len Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 16/41] staging: unisys: remove uislib_server_inject_add/del_vnic() prototypes

2014-10-03 Thread Benjamin Romer
These functions contain CamelCase names but are not used. Delete the prototypes from uisutils.h. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/unisys/include/uisutils.h

[PATCH 29/41] staging: unisys: remove DEDICATED_SWITCH macro

2014-10-03 Thread Benjamin Romer
Nobody is using this macro anymore so remove it. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisqueue.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/include/uisqueue.h b/drivers/staging/unisys/include/uisqueue.h

[PATCH 17/41] staging: unisys: Fix CamelCase in uislib_client_inject_add_bus()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no instGuid = inst_uuid channelAddr = channel_addr nChannelBytes = n_channel_bytes Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 4 ++-- drivers/staging/unisys/uislib/uislib.c| 23

[PATCH 24/41] staging: unisys: Fix CamelCase in uislib_client_inject_pause_vnic()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no devNo = dev_no Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 35/41] staging: unisys: Fix VMCALL_CHANNEL_VERSION_MISMATCH_PARAMS

2014-10-03 Thread Benjamin Romer
Get rid of the typedef for VMCALL_CHANNEL_VERSION_MISMATCH_PARAMS, and use the name struct vmcall_channel_version_mismatch_params instead. Fix CamelCase member names: ChannelName = chname ItemName = item_name SourceFileName = file_name SourceLineNumber = line_no And get rid of the lengthof macro

[PATCH 41/41] staging: unisys: remove unused vmcall functions from uisutils.h

2014-10-03 Thread Benjamin Romer
Delete the issue_vmcall_measurement_do_nothing() and issue_vmcall_fatal() functions, because they are unused. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 19 --- 1 file changed, 19 deletions(-) diff --git

[PATCH 15/41] staging: unisys: fix CamelCase in uisctrl_unregister_req_handler_ex

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: switchTypeGuid = switch_uuid Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uisutils.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 05/41] staging: unisys: Fix CamelCase function pointers in uisutils

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: UisnicControlChanFunc = uisnic_control_chan_func UissdControlChanFunc = uissd_control_chan_func VirtControlChanFunc = virt_control_chan_func Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 6 +++---

[PATCH 27/41] staging: unisys: fix CamelCase struct name PciId

2014-10-03 Thread Benjamin Romer
Fix CamelCase name: PciId = pci_id Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/common-spar/include/channels/controlvmchannel.h | 2 +- drivers/staging/unisys/include/uisqueue.h | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 39/41] staging: unisys: remove unused struct network_policy

2014-10-03 Thread Benjamin Romer
Nobody is using this structure, so remove it. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisqueue.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/unisys/include/uisqueue.h

[PATCH 40/41] staging: unisys: remove unused fields from iopart structures

2014-10-03 Thread Benjamin Romer
The bus_no and dev_no fields in several of the iopart command parameter structures are unused. Remove them. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisqueue.h | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 34/41] staging: unisys: remove volatile from struct log_info_t

2014-10-03 Thread Benjamin Romer
There's no need for last_cycles to be declared volatile. Take that out. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/include/uisutils.h

[PATCH 28/41] staging: unisys: fix CamelCase name for struct InterruptInfo

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: InterruptInfo = irq_info Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- .../unisys/common-spar/include/channels/controlvmchannel.h | 4 ++-- drivers/staging/unisys/include/uisqueue.h | 6 +++---

[PATCH 19/41] staging: unisys: Fix CamelCase in uislib_client_inject_add_vhba()

2014-10-03 Thread Benjamin Romer
Clean up CamelCase names: busNo = bus_no devNo = dev_no instGuid = inst_uuid Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 4 ++-- drivers/staging/unisys/uislib/uislib.c| 18 +- 2 files changed, 11 insertions(+), 11

[PATCH 06/41] staging: unisys: fix CamelCase name for registered services variable

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: UisUtils_Registered_Services = uisutils_registered_services Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 2 +- drivers/staging/unisys/uislib/uisutils.c | 10

[PATCH 26/41] staging: unisys: fix CamelCase in uislib_client_inject_del_vnic()

2014-10-03 Thread Benjamin Romer
Fix CamelCase names: busNo = bus_no devNo = dev_no Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 2 +- drivers/staging/unisys/uislib/uislib.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 38/41] staging: unisys: remove redundant max macro

2014-10-03 Thread Benjamin Romer
No need to have another max macro when the kernel has one already. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/timskmod.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/include/timskmod.h

Re: [PATCH] staging:gs_fpgaboot: Remove KERN_INFO in pr_info()

2014-10-03 Thread Insop Song
That should clean up. Thank you. Reviewed-by: Insop Song insop.s...@gainspeed.com ISS On Fri, Oct 03, 2014 at 10:37:46AM -0700, Joe Perches wrote: On Fri, 2014-10-03 at 10:18 -0700, Joe Perches wrote: On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote: This patch remove unnecessary

[PATCH v2] Staging: slicoss: slicoss: replaced memcpy with ether_addr_copy

2014-10-03 Thread Abel Moyo
Replaced memcpy with ether_addr_copy in slic_mcast_add_list. Addresses are _aligned(2) as the struct mcast_address has only single field of type unsigned char. Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- Changes in v2: - Indicate how ether_addr_copy is safe in changelog

Re: [PATCH v2] Staging: slicoss: slicoss: replaced memcpy with ether_addr_copy

2014-10-03 Thread Dan Carpenter
On Fri, Oct 03, 2014 at 10:19:44PM +0200, Abel Moyo wrote: Replaced memcpy with ether_addr_copy in slic_mcast_add_list. Addresses are _aligned(2) as the struct mcast_address has only single field of type unsigned char. You have to consider the source address as well, but fair enough, that one

[PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Join together chained if's where possible to lower the indentation level. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/rts5208/rtsx_chip.c | 100 1 file

[PATCH 4/5] Divide lines to make them less than 80 characters long, align to the opening paranthesis where possible

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Make a couple of lines shorter than the max limit by diving them and also make sure to align them properly where possible. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/rts5208/rtsx_chip.c |

[PATCH 0/5] staging: rts5208: clean up coding style in rtsx_chip.c

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Align divided lines to the first line's opening paranthesis Where two or more if's are in form 'if (a) if (b) { [...] }' convert them into one to lower the indentation level. Use the ternary operator in places where there is code in

[PATCH 2/5] Convert Camel Case labels to lower case, remove unnecessary parantheses after a dereference operator and remove empty lines before }

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Convert labels from Camel Case to lower case, remove unnecessary parantheses around operands of dereference operators and remove unneeded empty lines before }. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com ---

[PATCH 3/5] Align lines of divided lines to the opening paranthesis where possible

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Make all divided lines aligned to the opening paranthesis Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/rts5208/rtsx_chip.c | 87 +++-- 1 file changed, 45

[PATCH 5/5] Use ternary operators where possible and sensible to avoid unnecessary increase of indentation level

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Convert code in format of if (a) if(b) { [...] } to one line with a simple ternary operation to avoid unnecesary increase of indentation level. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com ---

Re: [PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase

2014-10-03 Thread Greg KH
On Fri, Oct 03, 2014 at 11:27:04PM +0300, Giedrius Statkevicius wrote: From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Join together chained if's where possible to lower the indentation level. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com Your subject is

Re: [PATCH] staging:gs_fpgaboot: Remove KERN_INFO in pr_info()

2014-10-03 Thread Joe Perches
On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote: This patch remove unnecessary KERN_INFO in pr_info() [] diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c [] @@ -58,7 +58,7 @@ static void datadump(char *msg, void *m, int n) for

Re: [PATCH] staging: et131x: Remove et131x driver from drivers/staging

2014-10-03 Thread Greg KH
On Fri, Oct 03, 2014 at 09:45:53PM +0100, Mark Einon wrote: The current version of the et131x driver has been accepted into the main tree at /drivers/net/ethernet, so it can now be removed from staging. The MAINTAINERS entry has not been touched here, as the patch to add the driver to

[PATCH 5/5] staging: rts5208: use ternary operators to reduce indentation level

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Convert code in format of if (a) if(b) { [...] } to one line with a simple ternary operation to avoid unnecesary increase of indentation level. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com ---

[PATCH 4/5] staging: rts5208: divide lines to make them less than 80 characters long

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Make a couple of lines shorter than the max limit by diving them and also make sure to align them properly where possible. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/rts5208/rtsx_chip.c |

[PATCH 1/5] staging: rts5208: combine ifs where possible

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Join together chained if's where possible to lower the indentation level. In a lot of places of this code the indentation level is already very high. As a result, this patch increases the code flow and readability. Signed-off-by:

[PATCH 2/5] staging: rts5208: get rid of Camel Case, remove unneeded lines and parantheses

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Convert labels from Camel Case to lower case, remove unnecessary parantheses around operands of dereference operators and remove unneeded empty lines before }. Gets rid of a checkpatch.pl check that code should avoid Camel Case, also

[PATCH 3/5] staging: rts5208: align divided lines to opening paranthesis

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com Make all divided lines aligned to the opening paranthesis. Basically makes all lines aligned to the opening paranthesis to make the code more readable and it also gets rid of a lot of checkpatch.pl checks. Signed-off-by: Giedrius

[PATCH 0/5] staging: rts5208: clean up coding style in rtsx_chip.c

2014-10-03 Thread Giedrius Statkevicius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com This patch set is a general code style clean up for rtsx_chip.c. After this patch set checkpatch.pl without --strict doesn't complain anything about at all and with --strict it only complains about unmatched parantheses in those few

Re: [PATCH] staging: et131x: Remove et131x driver from drivers/staging

2014-10-03 Thread Dan Carpenter
Congrats. :) regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] drivers: staging: wlan-ng: fix sparse warnings

2014-10-03 Thread Cheng-wei Lee
This patch fix the sparse warnings in wlan-ng/cfg80211.c The following functions were only used in this file, so done by declaring them into static. drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static?