On 02/10/2014 15:41, Chen Gang wrote:
COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
with allmodconfig under um):
CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o
drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
Make the second line of a divided line match the opening paranthesis.
Combine two if's in form of 'if (a) if (b) { [...] }' into one to lower the
indentation level.
To further lower indentation level and make the code more concise use the
ternary operator where possible and sensible.
Make the
On Fri, Oct 03, 2014 at 07:16:13PM +0300, Giedrius Statkevicius wrote:
Make the second line of a divided line match the opening paranthesis.
Combine two if's in form of 'if (a) if (b) { [...] }' into one to lower the
indentation level.
To further lower indentation level and make the code more
This patch remove unnecessary KERN_INFO in pr_info()
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
On Fri, 2014-10-03 at 10:18 -0700, Joe Perches wrote:
On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote:
This patch remove unnecessary KERN_INFO in pr_info()
[]
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
[]
@@ -58,7 +58,7 @@
Remove the MACARRAY typedef entirely and switch over to u8*[ETH_ALEN],
like everybody else seems to use.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Switch GUESTPART_MSG_TYPE over to enum guestpart_msg_type.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisqueue.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/include/uisqueue.h
This series includes patches that were not able to be applied from the prior
series of cleanup patches, and additional patches to remove unused code and
doxygen comments from timskmod.h. When this work is complete the include
directory should be clean of all checkpatch.pl warnings, and all strict
Fix the indentation around server_channel_init, so the parameters line
up nicely.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Clean up CamelCase names:
busNo = bus_no
deviceCount = dev_count
busTypeGuid = bus_uuid
busInstGuid = instance_guid
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisqueue.h | 8
drivers/staging/unisys/uislib/uislib.c| 8
Remove the typedef from VMCALL_IO_DIAG_ADDR_PARAMS and use the name
struct vmcall_io_diag_addr_params instead. Fix CamelCase member names:
ChannelAddress = address
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/common-spar/include/vmcallinterface.h | 6 +++---
Fix CamelCase names:
busNo = bus_no
devNo = dev_no
instGuid = inst_uuid
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 4 ++--
drivers/staging/unisys/uislib/uislib.c| 18 +-
2 files changed, 11 insertions(+), 11
Fix CamelCase names:
ReqHandlerDel = req_handler_del
switchTypeGuid = switch_uuid
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uisutils.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
Get rid of typedefs in enums SWITCH_TYPE and IOPART_MSG_TYPE, and use the enum
names directly instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisqueue.h | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git
Remove the typedef from VMCALL_IO_CONTROLVM_ADDR_PARAMS and switch to
use struct vmcall_io_controlvm_addr_params. Fix the CamelCase names:
ChannelAddress = address
ChannelBytes = channel_bytes
Unused = unused
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
Fix CamelCase names:
switchTypeGuid = switch_uuid
Server_Channel_Ok = server_channel_ok
channelBytes = channel_bytes
Server_Channel_Init = server_channel_init
clientStr = client_str
clientStrLen = client_str_len
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
Fix CamelCase names:
busNo = bus_no
devNo = dev_no
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Fix CamelCase names:
ReqHandlerFind = req_handler_find
switchTypeGuid = switch_uuid
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 2 +-
drivers/staging/unisys/uislib/uisutils.c | 4 ++--
Remove doxygen comments and fix what's left so it's still useful.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/timskmod.h | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/unisys/include/timskmod.h
Fix CamelCase names:
busNo = bus_no
devNo = dev_no
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Fix CamelCase names:
switchTypeGuid = switch_uuid
clientStr = client_str
clientStrLent = client_str_len
chipset_driverInfo = chipset_driver_info
Server_Channel_Ok = server_channel_ok
Server_Channel_Init = server_channel_init
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
Fix CamelCase names:
busNo = bus_no
devNo = dev_no
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Get rid of the typedef ULTRA_VBUS_CHANNEL_PROTOCOL, in favor of the name
struct ultra_vbus_channel_protocol. This change finishes the warnings
clean up for include/uisqueue.h.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
Fix CamelCase names:
busNo = bus_no
devNo = dev_no
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Clean up CamelCase names:
busNo = bus_no
deviceCount = device_count
guestHandle = guest_handle
recvBusInterruptHandle = recv_bus_irq_handle
busInstGuid = inst_uuid
pBusChannel = bus_channel
busChannelBytes = bus_channel_bytes
partitionName = partition_name
localVnic = local_vnic
Signed-off-by:
Remove the typedef from ULTRA_VBUS_DEVICEINFO and use struct
ultra_vbus_deviceinfo instead. Fix CamelCase member names:
devType = devtype
drvName = drvname
infoStrings = infostrs
Fix indentation on function definitions that were affected by the
structure's name change.
Signed-off-by: Benjamin
Fix CamelCase names:
ReqHandlerAdd = req_handler_add
Server_Channel_Ok = svr_channel_ok
channelBytes = channel_bytes
Server_Channel_Init = svr_channel_init
clientStr = client_str
ClientStrLen = client_str_len
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
These functions contain CamelCase names but are not used. Delete the
prototypes from uisutils.h.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/unisys/include/uisutils.h
Nobody is using this macro anymore so remove it.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisqueue.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys/include/uisqueue.h
b/drivers/staging/unisys/include/uisqueue.h
Fix CamelCase names:
busNo = bus_no
instGuid = inst_uuid
channelAddr = channel_addr
nChannelBytes = n_channel_bytes
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 4 ++--
drivers/staging/unisys/uislib/uislib.c| 23
Fix CamelCase names:
busNo = bus_no
devNo = dev_no
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Get rid of the typedef for VMCALL_CHANNEL_VERSION_MISMATCH_PARAMS, and
use the name struct vmcall_channel_version_mismatch_params instead. Fix
CamelCase member names:
ChannelName = chname
ItemName = item_name
SourceFileName = file_name
SourceLineNumber = line_no
And get rid of the lengthof macro
Delete the issue_vmcall_measurement_do_nothing() and
issue_vmcall_fatal() functions, because they are unused.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 19 ---
1 file changed, 19 deletions(-)
diff --git
Fix CamelCase names:
switchTypeGuid = switch_uuid
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uisutils.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
Fix CamelCase names:
UisnicControlChanFunc = uisnic_control_chan_func
UissdControlChanFunc = uissd_control_chan_func
VirtControlChanFunc = virt_control_chan_func
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 6 +++---
Fix CamelCase name:
PciId = pci_id
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/common-spar/include/channels/controlvmchannel.h | 2 +-
drivers/staging/unisys/include/uisqueue.h | 2 +-
2 files changed, 2 insertions(+), 2
Nobody is using this structure, so remove it.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisqueue.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/unisys/include/uisqueue.h
The bus_no and dev_no fields in several of the iopart command parameter
structures are unused. Remove them.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisqueue.h | 6 --
1 file changed, 6 deletions(-)
diff --git
There's no need for last_cycles to be declared volatile. Take that out.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/include/uisutils.h
Fix CamelCase names:
InterruptInfo = irq_info
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
.../unisys/common-spar/include/channels/controlvmchannel.h | 4 ++--
drivers/staging/unisys/include/uisqueue.h | 6 +++---
Clean up CamelCase names:
busNo = bus_no
devNo = dev_no
instGuid = inst_uuid
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 4 ++--
drivers/staging/unisys/uislib/uislib.c| 18 +-
2 files changed, 11 insertions(+), 11
Fix CamelCase names:
UisUtils_Registered_Services = uisutils_registered_services
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 2 +-
drivers/staging/unisys/uislib/uisutils.c | 10
Fix CamelCase names:
busNo = bus_no
devNo = dev_no
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisutils.h | 2 +-
drivers/staging/unisys/uislib/uislib.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
No need to have another max macro when the kernel has one already.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/timskmod.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys/include/timskmod.h
That should clean up. Thank you.
Reviewed-by: Insop Song insop.s...@gainspeed.com
ISS
On Fri, Oct 03, 2014 at 10:37:46AM -0700, Joe Perches wrote:
On Fri, 2014-10-03 at 10:18 -0700, Joe Perches wrote:
On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote:
This patch remove unnecessary
Replaced memcpy with ether_addr_copy in slic_mcast_add_list.
Addresses are _aligned(2) as the struct mcast_address has only
single field of type unsigned char.
Signed-off-by: Abel Moyo abelmoyo...@gmail.com
---
Changes in v2:
- Indicate how ether_addr_copy is safe in changelog
On Fri, Oct 03, 2014 at 10:19:44PM +0200, Abel Moyo wrote:
Replaced memcpy with ether_addr_copy in slic_mcast_add_list.
Addresses are _aligned(2) as the struct mcast_address has only
single field of type unsigned char.
You have to consider the source address as well, but fair enough, that
one
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Join together chained if's where possible to lower the indentation level.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 100
1 file
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Make a couple of lines shorter than the max limit by diving them and also make
sure to align them properly where possible.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c |
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Align divided lines to the first line's opening paranthesis
Where two or more if's are in form 'if (a) if (b) { [...] }' convert them into
one to lower the indentation level.
Use the ternary operator in places where there is code in
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Convert labels from Camel Case to lower case, remove unnecessary parantheses
around operands of dereference operators and remove unneeded empty lines before
}.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Make all divided lines aligned to the opening paranthesis
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 87 +++--
1 file changed, 45
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Convert code in format of if (a) if(b) { [...] } to one line with a simple
ternary operation to avoid unnecesary increase of indentation level.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
On Fri, Oct 03, 2014 at 11:27:04PM +0300, Giedrius Statkevicius wrote:
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Join together chained if's where possible to lower the indentation level.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Your subject is
On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote:
This patch remove unnecessary KERN_INFO in pr_info()
[]
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
[]
@@ -58,7 +58,7 @@ static void datadump(char *msg, void *m, int n)
for
On Fri, Oct 03, 2014 at 09:45:53PM +0100, Mark Einon wrote:
The current version of the et131x driver has been accepted into the
main tree at /drivers/net/ethernet, so it can now be removed from
staging.
The MAINTAINERS entry has not been touched here, as the patch to
add the driver to
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Convert code in format of if (a) if(b) { [...] } to one line with a
simple ternary operation to avoid unnecesary increase of indentation
level.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Make a couple of lines shorter than the max limit by diving them and
also make sure to align them properly where possible.
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c |
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Join together chained if's where possible to lower the indentation
level.
In a lot of places of this code the indentation level is already very
high.
As a result, this patch increases the code flow and readability.
Signed-off-by:
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Convert labels from Camel Case to lower case, remove unnecessary
parantheses around operands of dereference operators and remove unneeded
empty lines before }.
Gets rid of a checkpatch.pl check that code should avoid Camel Case,
also
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Make all divided lines aligned to the opening paranthesis.
Basically makes all lines aligned to the opening paranthesis to make the
code more readable and it also gets rid of a lot of checkpatch.pl
checks.
Signed-off-by: Giedrius
From: Giedrius Statkevičius giedrius.statkevic...@gmail.com
This patch set is a general code style clean up for rtsx_chip.c. After
this patch set checkpatch.pl without --strict doesn't complain anything
about at all and with --strict it only complains about unmatched
parantheses in those few
Congrats. :)
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch fix the sparse warnings in wlan-ng/cfg80211.c
The following functions were only used in this file, so done by
declaring them into static.
drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol
'prism2_connect_result' was not declared. Should it be static?
64 matches
Mail list logo