Re: [PATCH] Fix the issue that lowmemkiller fell into a cycle that try to kill a task

2014-10-14 Thread 朱辉
2014 09 24 23:36, Rik van Riel: On 09/22/2014 10:57 PM, Hui Zhu wrote: The cause of this issue is when free memroy size is low and a lot of task is trying to shrink the memory, the task that is killed by lowmemkiller cannot get CPU to exit itself. Fix this issue with change the scheduling

[PATCH] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
In current hyper-v time sync service,it only gets the initial clock time from the host. It didn't process the following time samples. This change introduced a module parameter called host_time_sync. If it is set to true, the guest will periodically sychronize it's time with the host clock using

Re: [PATCH] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Greg KH
On Tue, Oct 14, 2014 at 01:23:46AM -0700, Thomas Shao wrote: --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -1786,6 +1786,7 @@ int do_adjtimex(struct timex *txc) return ret; } +EXPORT_SYMBOL(do_adjtimex); EXPORT_SYMBOL_GPL()?

RE: [PATCH] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Tuesday, October 14, 2014 3:35 PM To: Thomas Shao Cc: t...@linutronix.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; KY Srinivasan

Re: [PATCH 0/2] staging: comedi: tidy up the async event defines

2014-10-14 Thread Ian Abbott
On 13/10/14 17:56, H Hartley Sweeten wrote: The async event defines, COMEDI_CB_*, are only used in the kernel. They should not be exposed to userspace in the comedi.h uapi header. Move the defines to the comedidev.h kernel header and tidy up the documentation. Also, introduce some mask defines

[PATCH] staging, unisys: remove leftover function kmalloc_kernel()

2014-10-14 Thread WANG Chao
kmalloc_kernel() previously declared in timskmodutils.h which recently got removed. Now also remove kmalloc_kernel(), because it's not used anywhere. Signed-off-by: WANG Chao wangchao19890...@gmail.com --- drivers/staging/unisys/visorutil/visorkmodutils.c | 10 -- 1 file changed, 10

RE: [PATCH] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Gleixner
On Tue, 14 Oct 2014, Thomas Shao wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Tuesday, October 14, 2014 3:35 PM To: Thomas Shao Cc: t...@linutronix.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;

RE: [PATCH] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
-Original Message- From: Thomas Gleixner [mailto:t...@linutronix.de] Sent: Tuesday, October 14, 2014 5:14 PM To: Thomas Shao Cc: Greg KH; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; KY Srinivasan Subject: RE:

[PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
In current hyper-v time sync service,it only gets the initial clock time from the host. It didn't process the following time samples. This change introduced a module parameter called host_time_sync. If it is set to true, the guest will periodically sychronize it's time with the host clock using

[PATCH 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-14 Thread Thomas Shao
Export do_adjtimex function for hyper-v Time Synchronization component Signed-off-by: Thomas Shao huis...@microsoft.com --- kernel/time/timekeeping.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index

[PATCH 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-14 Thread Thomas Shao
Export do_adjtimex function for hyper-v Time Synchronization component Signed-off-by: Thomas Shao huis...@microsoft.com --- kernel/time/timekeeping.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-14 Thread DaeSeok Youn
Hi, 2014-10-14 11:19 GMT+09:00 Joe Perches j...@perches.com: On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org:

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Dan Carpenter
I had a couple small style nits. On Tue, Oct 14, 2014 at 04:11:18AM -0700, Thomas Shao wrote: diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c index 3b9c9ef..1d8390c 100644 --- a/drivers/hv/hv_util.c +++ b/drivers/hv/hv_util.c @@ -51,11 +51,30 @@ #define HB_WS2008_MAJOR 1

Caro usuário

2014-10-14 Thread ADMINISTRATOR
Caro usuário Seu e-mail ultrapassou 2 GB criadas pelo webmaster, você está executando em 2.30GB, o que não é possível enviar ou receber nova mensagem no próximo 24 horas até que você verificar e-mails conta. Por favor, informe seus dados abaixo para verificar a sua conta: (1) E-mail:

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
On Tue, Oct 14, 2014 at 04:11:18AM -0700, Thomas Shao wrote: In current hyper-v time sync service,it only gets the initial clock time from the host. It didn't process the following time samples. This change introduced a module parameter called host_time_sync. If it is set to true, the guest

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-14 Thread Mark Hounschell
On 10/13/2014 10:04 PM, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:

RE: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, October 14, 2014 7:19 PM To: Thomas Shao Cc: t...@linutronix.de; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-14 Thread Dan Carpenter
On Mon, Oct 13, 2014 at 07:19:38PM -0700, Joe Perches wrote: I don't know of a way to compare objects when functions are rearranged in the source file. Anyone else? I have a perl script that I use to review function movement. It barfed on the DaeSeok's original patch so I re-wrote it, but

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Dan Carpenter
On Tue, Oct 14, 2014 at 12:50:23PM +, Thomas Shao wrote: -static inline void do_adj_guesttime(u64 hosttime) +static inline void do_adj_guesttime(u64 hosttime, bool forceSync) I'm surprise checkpatch.pl does't complain about this CamelCase. I've run the scripts/checkpatch.pl, it

RE: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, October 14, 2014 9:10 PM To: Thomas Shao Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; linux-ker...@vger.kernel.org; a...@canonical.com; de...@linuxdriverproject.org;

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Mike Surcouf
What is your expected value for TICK_USEC? I cant make the arithmetic work. You double the check time if you are close but you never reduce the check time if you are not. Adjusting the tick count is a coarse adjustment of the clock. You will end up chasing the host time but never stabilizing it.

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
On Tue, Oct 14, 2014 at 01:04:35PM +, Thomas Shao wrote: + /* + * Use the Hyper-V time sample to adjust the guest time. The + * algorithm is: If the sample offsets exceeds 1 second, we + * directly set the clock to the server time. If the offset is

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
On Tue, Oct 14, 2014 at 01:04:35PM +, Thomas Shao wrote: I really don't see the need for this. We have NTP. If the guests want to, they may use it. Otherwise, they have a free running clock, just like real machines. Sometimes the user can't setup NTP. For example the guest OS

RE: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
-Original Message- From: Mike Surcouf [mailto:mps.surcouf.l...@gmail.com] Sent: Tuesday, October 14, 2014 9:17 PM To: Thomas Shao Cc: Dan Carpenter; t...@linutronix.de; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;

RE: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
-Original Message- From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Tuesday, October 14, 2014 9:20 PM To: Thomas Shao Cc: t...@linutronix.de; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

RE: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
-Original Message- From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Tuesday, October 14, 2014 9:26 PM To: Thomas Shao Cc: t...@linutronix.de; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
On Tue, Oct 14, 2014 at 02:16:34PM +0100, Mike Surcouf wrote: What is your expected value for TICK_USEC? I cant make the arithmetic work. You double the check time if you are close but you never reduce the check time if you are not. Adjusting the tick count is a coarse adjustment of the

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
Maybe John Stultz should also go onto CC. Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
On Tue, Oct 14, 2014 at 03:14:21PM +0100, Mike Surcouf wrote: Even with networking I think there are other senarios where this would be useful such as no access to an NTP server due to firewall rules or no internal NTP or simply an admin without much knowledge of NTP. Perhaps, but ...

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Victor Miasnikov
Hi! VMware has put a lot of effort into host - guest timesync so I think there is a case for some form of host based time sync on HyperV. . . . IMHO, you should let the guest steer its own clock. That gives the end user the most flexibility. No problem: Time Sync can be turn off in

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
On Tue, Oct 14, 2014 at 04:33:46PM +0200, Richard Cochran wrote: IMHO, you should let the guest steer its own clock. That gives the end user the most flexibility. Just provide the offset information, and let a dedicated service (like ntpd or linuxptp's phc2sys) do the rest. So if it really

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Mike Surcouf
The value for TICK_USEC is defined as ((100UL + USER_HZ/2) / USER_HZ). In my box, it's 1. OK got it thanks . Checked the algorithm OK by me. Of course you can only adjust clock by a tick (smallest resolution) so you could be flapping between 2 values so as you say NTP is preferred.

RE: [PATCH 1/3] staging: comedi: usbduxsigma: updated contact details and status

2014-10-14 Thread Hartley Sweeten
On Friday, October 10, 2014 12:33 PM, Bernd Porr wrote: I've updated my contact details of the driver. I've also tested it thoroughly and it works perfectly. I've changed the status to stable. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten

RE: [PATCH 2/3] staging: comedi: usbdux: updated contact details / comments

2014-10-14 Thread Hartley Sweeten
On Friday, October 10, 2014 12:34 PM, Bernd Porr wrote: I've updated my contact details and removed obsolete comments. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com ___ devel mailing list

RE: [PATCH 3/3] staging: comedi: usbduxfast: updated address details

2014-10-14 Thread Hartley Sweeten
On Friday, October 10, 2014 12:35 PM, Bernd Porr wrote: Updated the range of years, e-mail and added driver desription as usually done in comedi. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com

RE: [PATCH] staging: comedi: (regression) channel list must be set for COMEDI_CMD ioctl

2014-10-14 Thread Hartley Sweeten
On Thursday, October 09, 2014 2:03 AM, Ian Abbott wrote: On 09/10/14 00:13, Hartley Sweeten wrote: On Wednesday, October 08, 2014 8:09 AM, Ian Abbott wrote: `do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly call the Comedi subdevice's `do_cmd()` handler with a NULL

RE: [PATCH 3/3] staging: comedi: usbduxfast: updated address details

2014-10-14 Thread Hartley Sweeten
On Tuesday, October 14, 2014 9:51 AM, Hartley Sweeten wrote: On Friday, October 10, 2014 12:35 PM, Bernd Porr wrote: Updated the range of years, e-mail and added driver desription as usually done in comedi. Signed-off-by: Bernd Porr m...@berndporr.me.uk Reviewed-by: H Hartley Sweeten

RE: [PATCH 0/3] staging: comedi: cb_pcimdas: support PCIe-DAS1602/16

2014-10-14 Thread Hartley Sweeten
On Monday, October 13, 2014 5:41 AM, Ian Abbott wrote: Fix up the block comment style and add support for the PCIe-DAS1602/16. This is the PCI-Express version of the PCIM-DAS1602/16 and is software compatible with it, apart from a different PCI device ID. 1) staging: comedi: cb_pcimdas: use

RE: [PATCH] staging: comedi: drivers: comedi_bond.c: Changed from using strncat to strlcat

2014-10-14 Thread Hartley Sweeten
On Sunday, October 12, 2014 5:23 AM, Rickard Strandqvist wrote: Changed from using strncat to strlcat to simplify the code Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/comedi/drivers/comedi_bond.c |6 ++ 1 file changed, 2

Re: [PATCH] staging: comedi: addi_apci_3200: remove driver

2014-10-14 Thread Ian Abbott
On 14/10/14 18:11, H Hartley Sweeten wrote: This driver has some serious bitrot. In addition, it's not in the Kconfig or Makefile so it can't even be built. Just remove it. It would be easier to rewrite the driver than fix it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc:

[PATCH 22/34] staging: comedi: addi_common.h: remove boardinfo definition

2014-10-14 Thread H Hartley Sweeten
The addi_board definition is not only used by the addi_apci_3120 driver. Introduce a private definition in that driver and remove the global definition from addi_common.h. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 09/34] staging: comedi: addi_apci_035: remove unnecessary subdevice initialization

2014-10-14 Thread H Hartley Sweeten
The subdevices that don't initialize any of the callbacks don't really exist. Remove the unnecessary initialzation and just set the type to COMEDI_SUBD_UNUSED. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 13/34] staging: comedi: addi_common.h: rename boardinfo 'pc_DriverName'

2014-10-14 Thread H Hartley Sweeten
Rename this CamelCase member of the boardinfo. The comedi_device 'board_name' is set to this member during the (*auto_attach) of the addi-data that still use this boardinfo drivers. For aesthetics, use the dev-board_name instead of the boardinfo in the drivers. Signed-off-by: H Hartley Sweeten

[PATCH 21/34] staging: comedi: hwdrv_apci3120: remove need for boardinfo access

2014-10-14 Thread H Hartley Sweeten
The apci3120_ai_insn_config() function is broken in this driver. It does not follow the comedi API and will fail to work correctly. For now just remove the need for the boardinfo access to allow additional cleanup. The 'i_NbrAiChannel' is actually the subdevice 'n_chan' use that instead and

[PATCH 14/34] staging: comedi: addi_common.h: remove boardinfo 'i_IorangeBase1'

2014-10-14 Thread H Hartley Sweeten
This member of the boardinfo is used as a flag to determine what PCI BAR to use for the main 'iobase' used by the driver. Remove the boardinfo member and refactor the (*auto_attach) of the drivers to use the correct PCI BAR. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian

[PATCH 07/34] staging: comedi: addi_apci_1500: remove subdevice callbacks from boardinfo

2014-10-14 Thread H Hartley Sweeten
This driver only has one boardinfo entry so the subdevice callbacks are always the same. Remvoe the callbacks from the boardinfo and use them directly when initializing the subdevices. Remove all the subdevice callback initialization that would be set to NULL. Signed-off-by: H Hartley Sweeten

[PATCH 02/34] staging: comedi: addi_common.c: remove i_ADDI_Reset()

2014-10-14 Thread H Hartley Sweeten
The addi_apci_035 and addi_apci_1500 are the only drivers left that use this function in addi_common.c. The function simply calls the 'reset' function that is in the boardinfo of the driver. Both drivers use the same 'reset' function for all boardnfo entries. Remove the i_ADDI_Reset() function as

[PATCH 11/34] staging: comedi: addi_apci_1500: remove unnecessary subdevice initialization

2014-10-14 Thread H Hartley Sweeten
The subdevices that don't initialize any of the callbacks don't really exist. Remove the unnecessary initialzation and just set the type to COMEDI_SUBD_UNUSED. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 03/34] staging: comedi: addi_common.c: remove addi_auto_attach()

2014-10-14 Thread H Hartley Sweeten
The addi_apci_035 and addi_apci_1500 are the only drivers left that use this function in addi_common.c. The addi_common code adds a lot of bloat to the drivers. Copy the addi_auto_attach() code to the (*auto_attach) functions of the drivers and remove the function. This will help with removing

[PATCH 29/34] staging: comedi: addi_apci_3120: simplify analog output boardinfo

2014-10-14 Thread H Hartley Sweeten
There are two boards supported by this driver. One with eight 14-bit analog outputs and the other without analog outputs. Add a bit field flag, 'has_ao', to the boardinfo and remove the 'i_NbrAoChannel' and 'i_AoMaxdata' members. Use the new flag to determine if the analog output subdevice needs

[PATCH 18/34] staging: comedi: addi_apci_1500: remove boardinfo

2014-10-14 Thread H Hartley Sweeten
The hardware does not have an eeprom so the 's_EeParameters' use is not necessary. Remove it. Since the boardinfo only has one entry its not really necessary. Remove it and initialize the subdevices directly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 20/34] staging: comedi: addi_eeprom: remove source file

2014-10-14 Thread H Hartley Sweeten
This source file is no longer included by any of the addi-data drivers. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- .../staging/comedi/drivers/addi-data/addi_eeprom.c | 360

[PATCH 23/34] staging: comedi: addi_common.h: remove unused members from addi_private

2014-10-14 Thread H Hartley Sweeten
Remove all the unused members from the addi_private definition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/addi-data/addi_common.h | 16 1

[PATCH 05/34] staging: comedi: addi_common.c: remove included source file

2014-10-14 Thread H Hartley Sweeten
The addi_apci_035 and addi_apci_1500 are the only drivers left that include this source file. Copy the i_ADDIDATA_InsnReadEeprom() function from that file to those drivers and remove the addi_common.c file. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 08/34] staging: comedi: addi_common.h: remove subdevice callbacks from struct addi_board

2014-10-14 Thread H Hartley Sweeten
None of the drivers that still include this header use the subdevice callbacks. Remove all of them to reduce the bloat. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 04/34] staging: comedi: addi_common.c: remove v_ADDI_Interrupt()

2014-10-14 Thread H Hartley Sweeten
The addi_apci_035 and addi_apci_1500 are the only drivers left that use this function in addi_common.c. The function simply calls the 'interrupt' function that is in the boardinfo of the driver. Both drivers use the same 'interrupt' function for all boardnfo entries. Remove the i_ADDI_Reset()

[PATCH 06/34] staging: comedi: addi_apci_035: remove subdevice callbacks from boardinfo

2014-10-14 Thread H Hartley Sweeten
This driver only has one boardinfo entry so the subdevice callbacks are always the same. Remvoe the callbacks from the boardinfo and use them directly when initializing the subdevices. Remove all the subdevice callback initialization that would be set to NULL. Signed-off-by: H Hartley Sweeten

[PATCH 26/34] staging: comedi: addi_apci_3120: remove boardinfo 'i_NbrDiChannel'

2014-10-14 Thread H Hartley Sweeten
All boardinfo entries have this member set as '4'. Remove the member and initialize the Digial Input 'n_chan' with 4 directly. Also, remove the initialization of 'len_chanlist'. This member is only used with subdevices that support async commands. Signed-off-by: H Hartley Sweeten

[PATCH 15/34] staging: comedi: addi_apci_1500: remove eeprom support

2014-10-14 Thread H Hartley Sweeten
As indicated in the boardinfo, the hardware does not have an eeprom. Remove the subdevice and support code for it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 01/34] staging: comedi: addi_common.c: remove i_ADDI_Detach()

2014-10-14 Thread H Hartley Sweeten
The addi_apci_035 and addi_apci_1500 are the only drivers left that use this function in addi_common.c. Remove the function an add a private comedi_driver (*detach) function to those drivers. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 30/34] staging: comedi: addi_apci_3120: simplify analog input boardinfo

2014-10-14 Thread H Hartley Sweeten
There are two boards supported by this driver. One with 16-bit analog inputs and the other 12-bit analog inputs. Add a bit field flag, 'ai_is_16bit', to the boardinfo and remove the 'i_AiMaxdata' member. Use the new flag to initialize tne analog input subdevice maxdata correctly. For aesthetics,

[PATCH 19/34] staging: comedi: addi_apci_035: remove boardinfo

2014-10-14 Thread H Hartley Sweeten
The hardware has an eeprom but the boardinfo properly defines the subdevice support so reading the eeprom and setting the 's_EeParameters' use is not necessary. Since the boardinfo only has one entry its not really necessary. Also, providing a subdevice the read the eeprom is not really

[PATCH 17/34] staging: comedi: addi_common.h: remove boardinfo member 'i_PCIEeprom'

2014-10-14 Thread H Hartley Sweeten
This member of the boardinfo is not used by any of the drivers. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/addi-data/addi_common.h | 1 - 1 file

[PATCH 32/34] staging: comedi: addi_apci_1500: separate from addi_common.h

2014-10-14 Thread H Hartley Sweeten
Remove the need to include addi_common.h by introducing a new private data definition. Only include the members that are actually used by the driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 34/34] staging: comedi: addi_common.h: remove file

2014-10-14 Thread H Hartley Sweeten
This header is no longer included by any of the addi-data drivers. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- .../staging/comedi/drivers/addi-data/addi_common.h | 52

[PATCH 00/34] staging: comedi: addi-data: remove common code bloat

2014-10-14 Thread H Hartley Sweeten
The ADDI-DATA drivers all originally use some common code to provide the comedi driver attach/detach. This common code added a lot of bloat to the drivers due to the boardinfo and private data definitions. Most of the ADDI-DATA drivers have been separated from this commont code and now have

[PATCH 33/34] staging: comedi: addi_apci_3120: separate from addi_common.h

2014-10-14 Thread H Hartley Sweeten
Remove the need to include addi_common.h by introducing a new private data definition. Only include the members that are actually used by the driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 25/34] staging: comedi: addi_apci_3120: remove boardinfo 'i_NbrDoChannel'

2014-10-14 Thread H Hartley Sweeten
All boardinfo entries have this member set as '4'. Remove the member and initialize the Digial Output 'n_chan' with 4 directly. Also, remove the initialization of 'len_chanlist'. This member is only used with subdevices that support async commands. Signed-off-by: H Hartley Sweeten

[PATCH 27/34] staging: comedi: addi_apci_3120: remove boardinfo 'i_NbrAiChannel'

2014-10-14 Thread H Hartley Sweeten
All boardinfo entries have this member set as '16'. This will initialize the Analog Input 'n_chan' and cause the 'i_NbrAiChannelDiff' member to never get used. Remove both members and initialize the Analog Input 'n_chan' with 16 directly. Signed-off-by: H Hartley Sweeten

[PATCH 31/34] staging: comedi: addi_apci_035: separate from addi_common.h

2014-10-14 Thread H Hartley Sweeten
Remove the need to include addi_common.h by introducing a new private data definition. Only include the members that are actually used by the driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 12/34] staging: comedi: addi_apci_1500: remove unused subdevices

2014-10-14 Thread H Hartley Sweeten
Only allocate space for the subdevicess used by the driver. Remove all the COMEDI_SUBD_UNUSED subdevices. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 28/34] staging: comedi: addi_apci_3120: remove boardinfo 'i_AiChannelList'

2014-10-14 Thread H Hartley Sweeten
All boardinfo entries have this member set as '16'. This is also the Analog Input 'n_chan'. For aesthetics, initialize the Analog Input 'len_chanlist' with s-n_chan and remove the boardinfo member. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc:

[PATCH 10/34] staging: comedi: addi_apci_035: remove unused subdevices

2014-10-14 Thread H Hartley Sweeten
Only allocate space for the subdevicess used by the driver. Remove all the COMEDI_SUBD_UNUSED subdevices. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 24/34] staging: comedi: addi_apci_3120: remove boardinfo 'i_DoMaxdata'

2014-10-14 Thread H Hartley Sweeten
The maxdata for a Digital Output subdevice is always '1'. Remove this incorrect boardinfo. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/addi_apci_3120.c | 5

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Joe Perches
On Tue, 2014-10-14 at 14:19 +0300, Dan Carpenter wrote: I had a couple small style nits. On Tue, Oct 14, 2014 at 04:11:18AM -0700, Thomas Shao wrote: diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c index 3b9c9ef..1d8390c 100644 --- a/drivers/hv/hv_util.c +++

[PATCH 1/5] staging: comedi: usbdux: introduce usbduxsub_ao_handle_urb()

2014-10-14 Thread H Hartley Sweeten
Factor the urb handling and resubmit out of the analog output urb completion handler and tidy it up. This allows a common exit path to be used in the completion handler to stop the async command and handle the events. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 2/5] staging: comedi: usbdux: introduce usbduxsub_ai_handle_urb()

2014-10-14 Thread H Hartley Sweeten
Factor the urb handling and resubmit out of the analog input urb completion handler and tidy it up. This allows a common exit path to be used in the completion handler to stop the async command and handle the events. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 3/5] staging: comedi: usbduxfast: introduce usbduxfast_ai_handle_urb()

2014-10-14 Thread H Hartley Sweeten
Factor the urb handling and resubmit out of the completion handler and tidy it up. This allows a common exit path to be used in the completion handler to stop the async command and handle the events. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk

[PATCH 0/5] staging: comedi: usbdux drivers: tidy up urb completion

2014-10-14 Thread H Hartley Sweeten
Tidy up the usb completion functions in the usbdux drivers by introducing some helper functions to handle and resubmit the successful urbs. This allows a common exit path to be used in the completion handler to stop the async command, if necessary, and handle the events. This series applies

[PATCH 5/5] staging: comedi: usbduxsigma: introduce usbduxsigma_ai_handle_urb()

2014-10-14 Thread H Hartley Sweeten
Factor the urb handling and resubmit out of the analog input urb completion handler and tidy it up. This allows a common exit path to be used in the completion handler to stop the async command and handle the events. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 4/5] staging: comedi: usbduxsigma: introduce usbduxsigma_ao_handle_urb()

2014-10-14 Thread H Hartley Sweeten
Factor the urb handling and resubmit out of the analog output urb completion handler and tidy it up. This allows a common exit path to be used in the completion handler to stop the async command and handle the events. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

Re: [PATCH] staging: lustre: lustre: libcfs: debug.c: Cleaning up unnecessary use of memset in conjunction with strncpy

2014-10-14 Thread Rickard Strandqvist
2014-09-19 0:39 GMT+02:00 Dan Carpenter dan.carpen...@oracle.com: On Thu, Sep 18, 2014 at 09:57:17PM +0200, Rickard Strandqvist wrote: Should I add this as a patch in lib/string.c or email him first.. What is customary in these situations? Just write up a normal patch and try to merge it

Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Tue, 14 Oct 2014 15:16:28 -0700 In case that the IP header has optional field at the end, this patch will get the port numbers after that field, and compute the hash. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y.

Re: [PATCH 1/5] staging: comedi: usbdux: introduce usbduxsub_ao_handle_urb()

2014-10-14 Thread Bernd Porr
On 14/10/2014 20:14, H Hartley Sweeten wrote: Factor the urb handling and resubmit out of the analog output urb completion handler and tidy it up. This allows a common exit path to be used in the completion handler to stop the async command and handle the events. Signed-off-by: H Hartley

Re: [PATCH 2/5] staging: comedi: usbdux: introduce usbduxsub_ai_handle_urb()

2014-10-14 Thread Bernd Porr
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Bernd Porr m...@berndporr.me.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/5] staging: comedi: usbduxfast: introduce usbduxfast_ai_handle_urb()

2014-10-14 Thread Bernd Porr
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Bernd Porr m...@berndporr.me.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 5/5] staging: comedi: usbduxsigma: introduce usbduxsigma_ai_handle_urb()

2014-10-14 Thread Bernd Porr
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Bernd Porr m...@berndporr.me.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/5] staging: comedi: usbduxsigma: introduce usbduxsigma_ao_handle_urb()

2014-10-14 Thread Bernd Porr
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Bernd Porr m...@berndporr.me.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH net-next, v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread Haiyang Zhang
-Original Message- From: Haiyang Zhang [mailto:haiya...@microsoft.com] Sent: Tuesday, October 14, 2014 4:05 PM To: da...@davemloft.net; net...@vger.kernel.org Cc: Haiyang Zhang; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org;

Re: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-14 Thread Martin K. Petersen
Sitsofe == Sitsofe Wheeler sits...@gmail.com writes: Sitsofe A previous patch attempted to add a quirk to workaround this Sitsofe but the quirk was only enabled after the features had been Sitsofe scanned for, wouldn't work for small disks What does that mean, exactly? -- Martin K. Petersen

Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag

2014-10-14 Thread Martin K. Petersen
Sitsofe == Sitsofe Wheeler sits...@gmail.com writes: Sitsofe Microsoft Hyper-V virtual disks currently only claim SPC-2 Sitsofe compliance causing the kernel skip checks for features such as Sitsofe thin provisioning even though the virtual disk advertises them. Last time around we identified

RE: [PATCH net-next, v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread Haiyang Zhang
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Tuesday, October 14, 2014 5:37 PM To: Haiyang Zhang Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org

RE: [PATCH 2/3] scsi: add try_rc16 blacklist flag

2014-10-14 Thread KY Srinivasan
-Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Tuesday, October 14, 2014 6:08 PM To: Sitsofe Wheeler Cc: KY Srinivasan; Haiyang Zhang; Christoph Hellwig; Hannes Reinecke; linux- s...@vger.kernel.org; linux-ker...@vger.kernel.org;

RE: [PATCH] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Thomas Shao
These old duplicated patches are accidentally send by the mail server... Sorry for that. -Original Message- From: Thomas Shao [mailto:huis...@microsoft.com] Sent: Tuesday, October 14, 2014 1:49 PM To: t...@linutronix.de; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org;