[PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

2014-10-29 Thread Tristan Lelong
This patch removes tabs used to align variable names in declaration and assignation. It replaces them with exactly one space. Signed-off-by: Tristan Lelong tristan.lel...@blunderer.org --- drivers/staging/android/logger.c | 49 1 file changed, 24

RE: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-10-29 Thread Sharma, Sanjeev
-Original Message- From: Jes Sorensen [mailto:jes.soren...@redhat.com] Sent: Monday, October 27, 2014 2:13 PM To: Sharma, Sanjeev Cc: larry.fin...@lwfinger.net; gre...@linuxfoundation.org; linux-wirel...@vger.kernel.org; de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org Subject:

RE: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-10-29 Thread Sharma, Sanjeev
-Original Message- From: Joe Perches [mailto:j...@perches.com] Sent: Monday, October 27, 2014 8:23 PM To: Jes Sorensen Cc: Sharma, Sanjeev; larry.fin...@lwfinger.net; gre...@linuxfoundation.org; linux-wirel...@vger.kernel.org; de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org

Re: [PATCHv2 1/3] staging: ion: shrink page-pool by page unit

2014-10-29 Thread Gioh Kim
diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c index da2a63c..0ba8aaf 100644 --- a/drivers/staging/android/ion/ion_system_heap.c +++ b/drivers/staging/android/ion/ion_system_heap.c @@ -29,7 +29,7 @@ static gfp_t

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Mikael Svantesson
I'm saving the patch to my mail server using git-imap-send, then enter e-mail addresses using Thunderbird and send it. The problem seems to be that Thunderbird thrashes empty lines when double clicking the e-mail in Drafts or selecting Edit as new. When forwarding the e-mail it doesn't seem to

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Sudip Mukherjee
On Wed, Oct 29, 2014 at 08:15:43AM +0100, Mikael Svantesson wrote: I'm saving the patch to my mail server using git-imap-send, then enter e-mail addresses using Thunderbird and send it. any particular reason that you are not sending it using git send-email ? The problem seems to be that

Re: [PATCHv2 0/3] staging: ion: enable pool shrinking in page unit

2014-10-29 Thread Gioh Kim
2014-10-29 오후 2:35에 Gioh Kim 이(가) 쓴 글: Hello, Current pool shrinking is not page unit, block unit. But shrinker returns the pool size in page unit, so it is confused. And there is no way to control pool size and shrink pool directly. I have 3 patches like followings. 1. Patch 1/3:

[patch v2] Documentation/SubmittingPatches: Reported-by tags and permission

2014-10-29 Thread Dan Carpenter
The reported-by text says you have to ask for permission, but that should only be if the bug was reported in private. These days the standard is to always give reported-by credit or it's considered a bit rude. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

Re: [patch v2] Documentation/SubmittingPatches: Reported-by tags and permission

2014-10-29 Thread Jonathan Corbet
On Wed, 29 Oct 2014 13:01:36 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: The reported-by text says you have to ask for permission, but that should only be if the bug was reported in private. These days the standard is to always give reported-by credit or it's considered a bit rude.

Re: [PATCH v2 1/1] staging: skein: Removes skein_debug include

2014-10-29 Thread Jason Cooper
Eric, Much better. One small nit below: On Tue, Oct 28, 2014 at 06:44:31PM -0500, Eric Rost wrote: Removes skein_debug.h include since skein_debug.h is nonexistent. Removes unneeded debug empty macro defines and their uses. Signed-off-by: Eric Rost eric.r...@mybabylon.net ---

Re: [PATCH 3/3] staging: comedi: usbduxfast: updated address details

2014-10-29 Thread Greg Kroah-Hartman
On Tue, Oct 14, 2014 at 04:59:13PM +, Hartley Sweeten wrote: On Tuesday, October 14, 2014 9:51 AM, Hartley Sweeten wrote: On Friday, October 10, 2014 12:35 PM, Bernd Porr wrote: Updated the range of years, e-mail and added driver desription as usually done in comedi.

Re: [PATCH] staging: lustre: fix sparse warning for static declarations

2014-10-29 Thread Greg Kroah-Hartman
On Sat, Oct 25, 2014 at 07:09:34PM +, Junien Fridrick wrote: This patch fixes the following sparse warnings : drivers/staging/lustre/lnet/lnet/router_proc.c:167:5: warning: symbol 'proc_lnet_routes' was not declared. Should it be static?

Re: [PATCH v2 02/02] staging:lustre:lnet:selftest: remove unused function

2014-10-29 Thread Greg KH
On Tue, Oct 28, 2014 at 09:50:19PM +0400, Anton Saraev wrote: Function lnet_selftest_structure_assertion is never used and can be removed. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/lustre/lnet/selftest/module.c | 11 --- 1 file changed, 11 deletions(-)

Re: [PATCH v2 01/02] staging:lustre:lnet:selftest: fix sparse warnings

2014-10-29 Thread Greg KH
On Tue, Oct 28, 2014 at 09:50:18PM +0400, Anton Saraev wrote: Fix sparse warnings: symbol X was not declared. Should it be static? Some functions used only in files where they are declared. They can be static. Signed-off-by: Anton Saraev antonysar...@gmail.com ---

Re: [PATCH v6 0/7] staging: skein: CryptoAPI and Module Support

2014-10-29 Thread Greg KH
On Mon, Oct 27, 2014 at 09:20:31AM -0400, Jason Cooper wrote: Greg, On Fri, Oct 24, 2014 at 05:29:09PM -0500, Eric Rost wrote: Adds CryptoAPI and loadable module support to the Skein Hashing Algorithm. Collapses threefish module into skein module. Renames skein.c and skein.h to

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Greg Kroah-Hartman
On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote: Signed-off-by: Mikael Svantesson mik...@distopic.net --- drivers/staging/skein/skein_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_api.c

Re: [PATCH] staging: lustre: Fix coding style. Switch and case at the same indent.

2014-10-29 Thread Greg KH
On Tue, Oct 28, 2014 at 09:35:15PM +0200, Evaldas Palaima wrote: Fix a style issue reported by checkpatch.pl for the Eudyptula challenge. Signed-off-by: Evaldas Palaima evaldas.pala...@gmail.com --- drivers/staging/lustre/lustre/libcfs/fail.c | 24 1 file changed,

Re: [PATCH v2 1/2] staging: lustre: Reduce function visibility

2014-10-29 Thread Greg Kroah-Hartman
On Sat, Oct 25, 2014 at 03:30:37AM +0200, Mariusz Gorski wrote: This patch fixes the following sparse warnings: drivers/staging/lustre/lnet/lnet/module.c:47:1: warning: symbol 'lnet_configure' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/module.c:67:1: warning:

Re: [PATCH 1/1] Octeon: Staging Driver: Remove coding warnings

2014-10-29 Thread Greg KH
On Sun, Oct 12, 2014 at 01:13:51PM +0530, Akshay Sarode wrote: Checkpatch coding warnings of 'Missing a blank line after declaration' Signed-off-by: Akshay Sarode akshaysarod...@gmail.com --- drivers/staging/octeon/ethernet-tx.c | 11 +++ 1 file changed, 11 insertions(+) Someone

Re: [PATCH 1/1] staging - rtl8188eu: Deletion of unnecessary checks before three function calls

2014-10-29 Thread Greg Kroah-Hartman
On Thu, Oct 23, 2014 at 09:20:29PM +0200, SF Markus Elfring wrote: From 45970693cad6c12da2d5ac7da3d2bd7a566170d7 Mon Sep 17 00:00:00 2001 From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 23 Oct 2014 20:55:13 +0200 Subject: [PATCH] staging - rtl8188eu: Deletion of unnecessary

Re: [PATCH] drivers: staging: imx-drm Fix checkpatch warning

2014-10-29 Thread Greg KH
On Wed, Oct 15, 2014 at 11:37:24PM -0300, Gaston Gonzalez wrote: Fix line over 80 characters in imx-tve.c Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/imx-drm/imx-tve.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] Staging: vt6655: Fix a typo in card.c

2014-10-29 Thread Greg Kroah-Hartman
On Sun, Oct 26, 2014 at 06:57:37AM +, Nicky Chorley wrote: The word force was spelt incorrectly. Signed-off-by: Nicky Chorley ndchor...@gmail.com --- The C99 comments will be fixed in another patch, when I get round to it! drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1

Re: [PATCH] Staging: dgnc: fix macro coding style issue in digi.h

2014-10-29 Thread Greg KH
On Wed, Oct 29, 2014 at 02:12:38AM +0800, Cheng-Yi He wrote: This is a patch to the digi.h file that fixes up the following error found by the checkpatch tool. ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Cheng-Yi He chengyihetai...@gmail.com ---

Re: [PATCH] staging: rtl8192e: from bus specific dma api to dma api

2014-10-29 Thread Greg Kroah-Hartman
On Wed, Oct 22, 2014 at 02:24:46PM +0530, Sudip Mukherjee wrote: we should be using DMA API rather than using bus specific DMA API. Why? converted the occurrence of pci_map_*() to dma_map_*(), and at the same time used the dma_mapping_error(). Trailing whitespace :( What have you used

Re: [PATCH] Staging: rts5208: rtsx_scsi: Fixed a brace coding style issue

2014-10-29 Thread Greg KH
On Fri, Oct 17, 2014 at 12:30:51AM +0100, Mike Roocroft wrote: Fixed a coding style issue. Signed-off-by: Mike Roocroft mike.li...@btinternet.com --- drivers/staging/rts5208/rtsx_scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH][V2] Staging:rtl8723au: open/closed brace issue

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 03:10:22PM +, Paul McQuade wrote: ERROR: that open brace { should be on the previous line Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 130 ++-- 1 file changed, 40 insertions(+), 90

Re: [PATCH 2/2] staging: rtl8723au:core

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 04:18:52PM +, Paul McQuade wrote: ERROR: spaces required around that ':' (ctx:VxE) Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Your

Re: [PATCH] staging: rtl8723au pointer issue

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 03:59:56PM +, Paul McQuade wrote: ERROR: foo*bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) The subject does not make sense

Re: [PATCH 2/2] staging: rtl8723au: core style issue

2014-10-29 Thread Greg KH
On Mon, Oct 27, 2014 at 12:16:08AM +, Paul McQuade wrote: spaces required around % Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Your subject does not make sense :(

Re: [PATCH RESEND v2 1/2] Staging: rts5208: helper function to manage aspm during reset

2014-10-29 Thread Greg KH
On Tue, Oct 28, 2014 at 07:46:55PM +0100, Fabio Falzoi wrote: Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Reviewed-by: Dan Carpenter

Re: [PATCH 1/2] staging: rtl8723au: core: pointer issue

2014-10-29 Thread Greg KH
On Sun, Oct 26, 2014 at 04:17:46PM +, Paul McQuade wrote: ERROR: foo * bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Again with the odd subject

Re: [PATCH 01/10] staging: unisys: fix blank lines virthba

2014-10-29 Thread Greg KH
On Tue, Oct 28, 2014 at 06:42:37PM -0400, Erik Arfvidson wrote: This patch removes unnecessary blanks lines and adds necessary blank lines in virthba. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 7 +-- 1 file changed, 1

[PATCH 1/4] [media] solo6x10: free vb2 buffers on stop_streaming

2014-10-29 Thread Andrey Utkin
This fixes warning from drivers/media/v4l2-core/videobuf2-core.c:2144 Signed-off-by: Andrey Utkin andrey.krieger.ut...@gmail.com --- drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[PATCH 4/4] [media] solo6x10: don't turn off/on encoder interrupt in processing loop

2014-10-29 Thread Andrey Utkin
The used approach actually cannot prevent new encoder interrupt to appear, because interrupt handler can execute in different thread, and in current implementation there is still race condition regarding this. Also from practice the code with this change seems to work as stable as before.

[PATCH 2/4] [media] solo6x10: free DMA allocation when releasing encoder

2014-10-29 Thread Andrey Utkin
Fixes this warning: [ 956.730136] [ cut here ] [ 956.730143] WARNING: CPU: 1 PID: 10134 at lib/dma-debug.c:963 dma_debug_device_change+0x191/0x1f0() [ 956.730146] pci :07:05.0: DMA-API: device driver has pending DMA allocations while released from device [count=8]

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Greg Kroah-Hartman
On Wed, Oct 29, 2014 at 08:25:30AM +0100, Mikael Svantesson wrote: Signed-off-by: Mikael Svantesson mik...@distopic.net --- drivers/staging/skein/skein_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_api.c

Re: [PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

2014-10-29 Thread Greg KH
On Tue, Oct 28, 2014 at 11:09:10PM -0700, Tristan Lelong wrote: This patch removes tabs used to align variable names in declaration and assignation. It replaces them with exactly one space. Why? This seems like a totally unneeded change, sorry. greg k-h

[PATCH 06/10] staging: unisys: remove all unnecessary space after cast visorchannel_funcs

2014-10-29 Thread Erik Arfvidson
This patch removes all unnecessary spaces after cast for visorchannel_funcs Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- .../unisys/visorchannel/visorchannel_funcs.c | 25 +++--- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git

[PATCH 09/10] staging: unisys: remove unnecessary blank line in visorchannel_funcs

2014-10-29 Thread Erik Arfvidson
this patch removes unnecessary blank line in visorchannel_funcs Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visorchannel/visorchannel_funcs.c

[PATCH 08/10] staging: unisys: fixed aligment in visorchannel_funcs

2014-10-29 Thread Erik Arfvidson
this patch fixes aligment for visorchanne_funcs Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 10/10] staging: unisys: fixed braces check in visorchannel_funcs

2014-10-29 Thread Erik Arfvidson
this patch adds braces to an else statement to remove check in checkpatch.pl for visorchannel_funcs.c Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 05/10] staging: unisys: added spinlock comments visorchannel_funcs

2014-10-29 Thread Erik Arfvidson
This patch adds comment documentation to visorchannel_tag struct Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH 07/10] staging: unisys: fixed logical continuation visorchannel_funcs

2014-10-29 Thread Erik Arfvidson
this patch fixes a logical continuation check in visorchannel Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 01/10] staging: unisys: fix blank lines virthba

2014-10-29 Thread Erik Arfvidson
This patch removes unnecessary blanks lines and adds necessary blank lines in virthba. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH 04/10] staging: unisys: fix all logical continuation virthba

2014-10-29 Thread Erik Arfvidson
This patch fixes all logical continuations issues in virthba.c v2: fixed spacing around bitwise operator suggested by dan carpenter Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 44 1 file changed, 22

[PATCH 02/10] staging: unisys: virthba fix all spaces after cast

2014-10-29 Thread Erik Arfvidson
This patch fixes all spaces after cast for virthba Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 130 +++ 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

[PATCH 03/10] staging: unisys: virthba fix all alingment issues

2014-10-29 Thread Erik Arfvidson
this patch fixes all aligment issues in virthba.c Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 82 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Mikael Svantesson
On 2014-10-29 17:05, Greg Kroah-Hartman wrote: Please send this as a correct patch, not one with a whole bunch of other stuff in it that I would have to hand-edit in order to apply properly. Remember, you want to make it as easy as possible for me to accept your patches, so far, this isn't

RE: [PATCH 0/9] staging: comedi: addi_apci_1564: additional clean up

2014-10-29 Thread Hartley Sweeten
On Wednesday, October 22, 2014 4:09 AM, Ian Abbott wrote: On 21/10/14 18:15, Hartley Sweeten wrote: In addition, in apci1564_interrupt() the dev-iobase (BAR1) is used for: s-state = inl(dev-iobase + APCI1564_DI_INT_STATUS_REG) 0x; But is apci1564_reset() and

Re: [PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

2014-10-29 Thread Tristan Lelong
On Thu, Oct 30, 2014 at 12:08:12AM +0800, Greg KH wrote: On Tue, Oct 28, 2014 at 11:09:10PM -0700, Tristan Lelong wrote: This patch removes tabs used to align variable names in declaration and assignation. It replaces them with exactly one space. Why? This seems like a totally unneeded

Re: [RFC] stating: ion: use hot page first in pool

2014-10-29 Thread Laura Abbott
On 10/28/2014 9:57 PM, Gioh Kim wrote: Hello, I found that ion insert freed-page at the tail of list and extract at the head. I think it is good for cache to use the most recently used page but these pages in pool are not cached memory. So I'm not sure using hot page is better or not

[PATCH 2/2] staging: comedi: das16: use spin-lock when setting timer

2014-10-29 Thread Ian Abbott
das16 sets a timer running in `das16_cmd_exec()` and sets `devpriv-timer_running` to indicate that it is running. The timer expiration routine `das16_timer_interrupt()` checks `devpriv-timer_running` to check whether it needs to reschedule the timer, but this is not synchronized with

[PATCH 1/2] staging: comedi: das16: deschedule timer routine on detach

2014-10-29 Thread Ian Abbott
The das16 driver optionally uses a kernel timer and a DMA channel to support asynchronous data acquisition, but currently never calls `del_timer_sync()`. There is some possibility the timer routine could still be scheduled to run when the comedi detach handler is run to clean up the device and

[PATCH 0/2] staging: comedi: das16: fix some timer sync issues

2014-10-29 Thread Ian Abbott
das16 uses a kernel timer but never removes it from the queue synchronously at the moment. Patch 1 makes sure this is done before it is destroyed. Patch 2 uses the comedi device's main spin-lock to ensure some state shared with the timer routine is updated in an SMP-safe manner. 1) staging:

Dear Winner.

2014-10-29 Thread Mrs. Ana Paula Filipe
Dear winner, Your email address has won you One Million Euro, from Online Lotto, all the E-mail addresses were selected from a data base of internet e-mail users, from which your e-mail address came out as the winning coupon. Winning expiring date 30th of November , 2014. Contact our fiduciary

Re: [PATCH] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Jason Cooper
Mikael, On Wed, Oct 29, 2014 at 05:55:34PM +0100, Mikael Svantesson wrote: Signed-off-by: Mikael Svantesson mik...@distopic.net --- drivers/staging/skein/skein_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jason Cooper ja...@lakedaemon.net For future patches, please

[PATCH] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Mikael Svantesson
Signed-off-by: Mikael Svantesson mik...@distopic.net --- drivers/staging/skein/skein_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c index 6e700ee..5bfce07 100644 ---

[PATCH v2 02/02] staging:lustre:lnet:selftest: remove unused function

2014-10-29 Thread Anton Saraev
Function lnet_selftest_structure_assertion is never used and can be removed. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/lustre/lnet/selftest/module.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/module.c

[PATCH v2 00/02] staging:lustre:lnet:selftest: fix sparse warnings

2014-10-29 Thread Anton Saraev
As I can understand warning in previous series is about unused function (I don't see other differences in output of make with C=1, W=1 and W=2). I remove static for lnet_selftest_structure_assertion from first patch. Maybe I should merge patches in one but I think that addition of static

[PATCH v2 01/02] staging:lustre:lnet:selftest: fix sparse warnings

2014-10-29 Thread Anton Saraev
Fix sparse warnings: symbol X was not declared. Should it be static? Some functions used only in files where they are declared. They can be static. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/lustre/lnet/selftest/conctl.c| 34

Re: [PATCH] Staging: vt6655: Fix a typo in card.c

2014-10-29 Thread Nicky Chorley
On Wed, Oct 29, 2014 at 05:20:30PM +0800, Greg Kroah-Hartman wrote: On Sun, Oct 26, 2014 at 06:57:37AM +, Nicky Chorley wrote: The word force was spelt incorrectly. Signed-off-by: Nicky Chorley ndchor...@gmail.com --- The C99 comments will be fixed in another patch, when I get

[PATCH] Staging: vt6655: Fix typo in card.c

2014-10-29 Thread Nicky Chorley
The word force was spelt incorrectly. Signed-off-by: Nicky Chorley ndchor...@gmail.com --- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index eae6789..abb4710 100644 ---

Re: [PATCH RESEND] staging: dgap: re-arrange functions for removing forward declarations

2014-10-29 Thread Mark Hounschell
On 10/29/2014 05:22 AM, Greg KH wrote: On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Tested-by: Mark Hounschell ma...@compro.net Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: This patch is tested all

[PATCH v3 0/2] Staging: rts5208: rtsx_reset_chip style clean up

2014-10-29 Thread Fabio Falzoi
Clean up the code in rtsx_reset_chip function defining two new helper functions rtsx_reset_aspm and rtsx_enable_pcie_intr. Specifically, the following checkpatch warnings are corrected: * PARENTHESIS_ALIGNMENT at rows 295 and 313 This patch is inspired by the following post on LKML regarding

[PATCH v3 1/2] Staging: rts5208: helper function to manage aspm during reset

2014-10-29 Thread Fabio Falzoi
Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the PARENTHESIS_ALIGNMENT checkpatch warnings. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Reviewed-by: Dan Carpenter dan.carpe...@oracle.com --- drivers/staging/rts5208/rtsx_chip.c | 70

[PATCH v3 2/2] Staging: rts5208: helper function to enable interrupts

2014-10-29 Thread Fabio Falzoi
Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Reviewed-by: Dan Carpenter dan.carpe...@oracle.com --- drivers/staging/rts5208/rtsx_chip.c | 95 +++-- 1 file changed, 48

[PATCH] staging: panel: Use designated initializers

2014-10-29 Thread Mariusz Gorski
Fix warning: missing initializer [-Wmissing-field-initializers] by using designated struct initializers. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- drivers/staging/panel/panel.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] staging, rts5208, LLVMLinux: Change extern inline to static inline

2014-10-29 Thread Behan Webster
With compilers which follow the C99 standard (like modern versions of gcc and clang), extern inline does the opposite thing from older versions of gcc (emits code for an externally linkable version of the inline function). static inline does the intended behavior in both gcc and clang.

[PATCH 2/4] staging, rtl8192e, LLVMLinux: Remove unused inline prototype

2014-10-29 Thread Behan Webster
rtllib_probe_req is defined as static inline in rtllib_softmac.c however it is declared differently as extern inline in rtllib_softmac.h. Since it isn't used outside of the scope of rtllib_softmac, it makes sense to remove the incorrect declaration. Signed-off-by: Behan Webster

[PATCH 3/4] staging, rtl8192e, LLVMLinux: Remove unused prototype

2014-10-29 Thread Behan Webster
MgntQuery_MgntFrameTxRate is only used within rtllib_softmac.c, so it really should be static instead of extern. Since it is currently extern a warning is generated because a different function of the same name is defined staticlly in ieee80211_softmac.c Removing the incorrect extern declaration

[PATCH 4/4] staging, rtl8192e, LLVMLinux: Make static local in inline function const

2014-10-29 Thread Behan Webster
rtllib_association_req is a (large) inline function which defines 2 constant static arrays which aren't labelled as const. As a result clang complains with: non-constant static local variable in inline function may be different in different files [-Wstatic-local-in-inline] static u8

[PATCH 0/4] staging, rtl8192e, LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM

2014-10-29 Thread Behan Webster
Removing a number of warnings generated from compiling stl8192e with clang. The LLVMLinux project aims to fully build the Linux kernel using both gcc and clang (the C front end for the LLVM compiler infrastructure project). Behan Webster (4): staging, rtl8192e, LLVMLinux: Change extern inline

Re: [RFC] stating: ion: use hot page first in pool

2014-10-29 Thread Gioh Kim
2014-10-30 오전 2:00에 Laura Abbott 이(가) 쓴 글: On 10/28/2014 9:57 PM, Gioh Kim wrote: Hello, I found that ion insert freed-page at the tail of list and extract at the head. I think it is good for cache to use the most recently used page but these pages in pool are not cached memory. So I'm

Re: [PATCH 01/10] staging: unisys: fix blank lines virthba

2014-10-29 Thread Greg KH
On Wed, Oct 29, 2014 at 12:24:57PM -0400, Erik Arfvidson wrote: This patch removes unnecessary blanks lines and adds necessary blank lines in virthba. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 7 +-- 1 file changed, 1

Re: [PATCH] Staging: vt6655: Fix typo in card.c

2014-10-29 Thread Greg Kroah-Hartman
On Wed, Oct 29, 2014 at 08:00:37PM +, Nicky Chorley wrote: The word force was spelt incorrectly. Signed-off-by: Nicky Chorley ndchor...@gmail.com --- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/card.c

Re: [PATCH v3 0/2] Staging: rts5208: rtsx_reset_chip style clean up

2014-10-29 Thread Greg KH
On Wed, Oct 29, 2014 at 10:58:17PM +0100, Fabio Falzoi wrote: Clean up the code in rtsx_reset_chip function defining two new helper functions rtsx_reset_aspm and rtsx_enable_pcie_intr. Specifically, the following checkpatch warnings are corrected: * PARENTHESIS_ALIGNMENT at rows 295 and 313

Re: [PATCH RESEND] staging: dgap: re-arrange functions for removing forward declarations

2014-10-29 Thread DaeSeok Youn
Hi, 2014-10-29 18:22 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Tested-by: Mark Hounschell ma...@compro.net Signed-off-by: Daeseok Youn daeseok.y...@gmail.com ---

[PATCH v3 1/1] staging: skein: Removes skein_debug include

2014-10-29 Thread Eric Rost
Removes skein_debug.h include since skein_debug.h is nonexistent. Removes unneeded debug empty macro defines and their uses. Signed-off-by: Eric Rost eric.r...@mybabylon.net --- drivers/staging/skein/skein_base.c | 18 - drivers/staging/skein/skein_base.h | 17 -

Re: [PATCH v3 1/1] staging: skein: Removes skein_debug include

2014-10-29 Thread Eric Rost
On Wed, 2014-10-29 at 19:12 -0500, Eric Rost wrote: Removes skein_debug.h include since skein_debug.h is nonexistent. Removes unneeded debug empty macro defines and their uses. Signed-off-by: Eric Rost eric.r...@mybabylon.net --- Jason, I wanted you to take one last look at this before I

[PATCH] staging: android: logger: fix kuid/uid in logger_entry

2014-10-29 Thread Xiong Zhou
From: Xiong Zhou jencce.ker...@gmail.com struct logger_entry can be returned to userspace via ioctl, so it is wrong to have a kuid_t member, fixing it to uid_t. This was introduced by commit bd471258f2, to pass uidguid type checks : UIDGID_STRICT_TYPE_CHECKS, which has been removed from kernel

Re: [PATCH] staging: rtl8192e: from bus specific dma api to dma api

2014-10-29 Thread Sudip Mukherjee
On Wed, Oct 29, 2014 at 04:47:25PM +0800, Greg Kroah-Hartman wrote: On Wed, Oct 22, 2014 at 02:24:46PM +0530, Sudip Mukherjee wrote: we should be using DMA API rather than using bus specific DMA API. Why? as given in the DMA-API-HOWTO.txt : the DMA API works with any bus independent of