Hi Mariusz,
On Wed, Oct 29, 2014 at 11:32:30PM +0100, Mariusz Gorski wrote:
Fix warning: missing initializer [-Wmissing-field-initializers]
by using designated struct initializers.
Signed-off-by: Mariusz Gorski marius.gor...@gmail.com
Acked-by: Willy Tarreau w...@1wt.eu
Thanks,
Willy
On Thursday 30 October 2014 10:23:31 Xiong Zhou wrote:
From: Xiong Zhou jencce.ker...@gmail.com
struct logger_entry can be returned to userspace via ioctl,
so it is wrong to have a kuid_t member, fixing it to uid_t.
This was introduced by commit bd471258f2, to pass uidguid
type checks :
Joe Perches j...@perches.com writes:
On Mon, 2014-10-27 at 09:43 +0100, Jes Sorensen wrote:
Sanjeev Sharma sanjeev_sha...@mentor.com writes:
This is a patch to the rtw_cmd.c file that fixes
Error reported by checkpatch.
[]
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c
Please find attached your award notification document.
GPA TEAM
Notice2014.pdf
Description: Adobe PDF document
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Commit 240512474424 (staging: comedi: comedi_test: use
comedi_handle_events()) resulted in the timer routine
`waveform_ai_interrupt()` calling `comedi_handle_events()` instead of
`comedi_events()`. That had the advantage of automatically stopping the
acquisition on
Hey Andrew,
can we get this one applied already - I'm seeing this warning at least
since before my summer vacation started! :-P
Thanks.
On Mon, Sep 01, 2014 at 09:55:06AM -0700, Joe Perches wrote:
There's a useless + use that needs to be removed as perl 5.20
emits a Useless use of greediness
On Thu, Oct 30, 2014 at 12:12:04PM +0100, Borislav Petkov wrote:
Hey Andrew,
can we get this one applied already - I'm seeing this warning at least
since before my summer vacation started! :-P
Oh ok, so it did go in after 3.17 but when using checkpatch on a 3.17
tree, it fires of course.
Most comedi subdevices that support asynchronous data acquisition
commands only support data transfer in a single direction, as indicated
by the `SDF_CMD_READ` and `SDF_CMD_WRITE` subdevice flags. A few allow
data transfer in either direction, but only a single direction at a
time, as indicated
There is no need for `ni_ai_cmdtest()` or `ni_ao_cmdtest()` to set the
`CMDF_WRITE` flag to the correct state as it has already been done by
the core comedi module.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_mio_common.c | 6 --
1 file changed, 6
If a Comedi asynchronous command has been set up for data transfer in
the write direction on the current read subdevice (for those
subdevices that support both directions), don't allow the read file
operation as that would mess with the data in the comedi data buffer
that is read by the low-level
`comedi_poll()` handles the poll() file operation for comedi devices.
If no asynchronous command has been set up on the current read
subdevice, it sets the `POLLIN` and `POLLRDNORM` bits in the return
value to indicate that the read() file operation would not block as it
would return an error.
If a Comedi asynchronous command has been set up for data transfer in
the read direction on the current write subdevice (for those
subdevices that support both directions), don't allow the write file
operation as that would mess with the data in the comedi data buffer
that is written by the
Most comedi subdevices that support asynchronous commands only support
data transfer in either the read or write direction, as indicated by
the `SDF_CMD_READ` and `SDF_CMD_WRITE` subdevice flags, although a few
support both directions on the same subdevice (though not
simultaneously). The `struct
The low-level Comedi drivers shouldn't change the `flags` member of
`struct comedi_cmd` as the Comedi core also uses some of those flags.
They should just ignore the flags they don't understand.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/me4000.c | 3 ---
1
`do_bufinfo_ioctl()` handled the `COMEDI_BUFINFO` ioctl. It is supposed
to update the read or write positions in the buffer depending on the
direction of data transfer set up by the asynchronous command.
Currently it checks the `SDF_CMD_READ` and `SDF_CMD_WRITE` subdevice
flags. That's fine for
On Wed, Oct 29, 2014 at 07:12:08PM -0500, Eric Rost wrote:
Removes skein_debug.h include since skein_debug.h is nonexistent.
Removes unneeded debug empty macro defines and their uses.
Signed-off-by: Eric Rost eric.r...@mybabylon.net
---
drivers/staging/skein/skein_base.c | 18
Sharma, Sanjeev sanjeev_sha...@mentor.com writes:
-Original Message-
From: Jes Sorensen [mailto:jes.soren...@redhat.com]
Sent: Monday, October 27, 2014 2:13 PM
To: Sharma, Sanjeev
Cc: larry.fin...@lwfinger.net; gre...@linuxfoundation.org;
linux-wirel...@vger.kernel.org;
Sharma, Sanjeev sanjeev_sha...@mentor.com writes:
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: Monday, October 27, 2014 8:23 PM
To: Jes Sorensen
Cc: Sharma, Sanjeev; larry.fin...@lwfinger.net;
gre...@linuxfoundation.org; linux-wirel...@vger.kernel.org;
On Thursday, October 30, 2014 5:42 AM, Ian Abbott wrote:
If a Comedi asynchronous command has been set up for data transfer in
the write direction on the current read subdevice (for those
subdevices that support both directions), don't allow the read file
operation as that would mess with the
On Thursday, October 30, 2014 5:43 AM, Ian Abbott wrote:
If a Comedi asynchronous command has been set up for data transfer in
the read direction on the current write subdevice (for those
subdevices that support both directions), don't allow the write file
operation as that would mess with the
This function currently fails if the number of samples to add would
overflow the async buffer. Modify it to add the samples that fit so
at least some of the sample data is returned to the user.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The SDF_GROUND, SDF_COMMON, SDF_DIFF, and SDF_OTHER flags are only useful
with the analog input and output subdevices.
Remove these flags from the other subdevice types in the comedi drivers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
For consistency in the comedi drivers:
1) Replace all SDF_WRITEABLE uses with SDF_WRITABLE
2) Remove the analog reference flags from the non-analog subdevices
3) Remove the unnecessary SDF_READABLE flag from the digital output subdevices
H Hartley Sweeten (3):
staging: comedi: drivers:
As indicated in the comedi.h uapi header, SDF_WRITEABLE was a spelling
error in the API, SDF_WRITABLE is prefered.
For aesthetics, replace all the SDF_WRITEABLE uses with SDF_WRITABLE.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The SDF_READABLE flag is not necessary for digital output subdevices. For
consistency, remove this flag from the comedi drivers that set it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The comedi core calls comedi_buf_reset() before starting an async command
(*do_cmd) and after returning a subdevice to an idle state (*cancel).
The drivers do not need to reset the async-cur_chan in those functions.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Bipolar analog input samples need to be munged from two's-complement format
to the unsigned offset format that comedi expects. Currently this driver
uses a bitmap in the private data to determine if the sample being acquired
is bipolar.
The comedi_async 'cur_chan' is used to test the bit in the
This functions uses the async-cur_chan to determine if the current channel
is using a bipolar range and the sample needs to be munged. The cur_chan is
never incremented so all the samples are munged based on the fist channel
in the cmd-chanlist.
Bump the cur_chan after writing each sample. This
Currently this driver uses a bitmap in the private data to keep track of
the unipolar/bipolar range for each channel. This is needed to determine
if the data needs to be munged for bipolar samples.
Remove this member from the private data and use the comedi core helper
function
This member of the private data is replicating what the comedi_async
'cur_chan' member is used for. Use that instead and remove the private
data member.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Move the tracking of the comedi_async 'cur_chan' into the core.
H Hartley Sweeten (3):
staging: comedi: ni_mio_common: remove unused variable in ni_ao_fifo_load()
staging: comedi: drivers: move comedi_async 'cur_chan' tracking into the core
staging: comedi: amplc_pci230: remove private data
The commedi_async 'cur_chan' member is used to track the current position
in the chanlist for a scan. Currently only a couple comedi drivers use
this member.
For aeshtetics, move the 'cur_chan' tracking into the core for non-SDF_PACKED
subdevices. The 'cur_chan' will be updated after reading or
The local variable 'range' is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 3 ---
1 file changed, 3 deletions(-)
This will allow the workload spreading via vRSS for IPv6.
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/netvsc_drv.c |4 +++-
drivers/net/hyperv/rndis_filter.c |3 ++-
2 files changed, 5 insertions(+), 2
Remove one blank line of two between function variable declaration and
implementation in
virt_pci_mod_init().
Signed-off-by: Bryan Thompson bryan.thomp...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virtpci/virtpci.c |1 -
1 file changed, 1
Use the appropriate whitespace alignment for multiline statements in virtpci.c
Signed-off-by: Bryan Thompson bryan.thomp...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virtpci/virtpci.c | 28 ++--
1 file changed, 14
Insert a blank line between the definition of the driver_private structure and
the next statement.
Signed-off-by: Bryan Thompson bryan.thomp...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virtpci/virtpci.c |1 +
1 file changed, 1
Change two instances of using the sizeof a structure to the size of a specific
variable when
allocating memory in virtpci.c
Signed-off-by: Bryan Thompson bryan.thomp...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virtpci/virtpci.c |4 ++--
1
Update delete_all_virt function definition to two lines so each line is less
than 80
characters long.
Move comments on virtpci_device_add function parameters to a header block to
contain
each line to 80 characters.
Signed-off-by: Bryan Thompson bryan.thomp...@unisys.com
Signed-off-by: Benjamin
Removed unnecessary blank lines from virtpci.c
Signed-off-by: Bryan Thompson bryan.thomp...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virtpci/virtpci.c |3 ---
1 file changed, 3 deletions(-)
diff --git
Update if/else blocks with braces on both the if and the else blocks in
virtpci.c.
Signed-off-by: Bryan Thompson bryan.thomp...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virtpci/virtpci.c |7 ---
1 file changed, 4 insertions(+), 3
This series of patches cleans up some simple checkpatch.pl findings in virtpci.c
Bryan Thompson (9):
staging: unisys: virtpci: Add a blank line after the definition of
driver_private
staging: unisys: virtpci: Remove extraneous blank lines
staging: unisys: virtpci: Remove space between
On 30/10/14 18:05, Hartley Sweeten wrote:
On Thursday, October 30, 2014 5:42 AM, Ian Abbott wrote:
[snip]
add_wait_queue(async-wait_head, wait);
while (nbytes 0 !retval) {
@@ -2249,6 +2253,10 @@ static ssize_t comedi_read(struct file *file, char
__user *buf, size_t nbytes,
On 30/10/14 18:07, Hartley Sweeten wrote:
On Thursday, October 30, 2014 5:43 AM, Ian Abbott wrote:
[snip]
add_wait_queue(async-wait_head, wait);
on_wait_queue = true;
@@ -2146,6 +2150,10 @@ static ssize_t comedi_write(struct file *file, const
char __user *buf,
On Thu, Oct 30, 2014 at 10:03:53AM +, Ian Abbott wrote:
Commit 240512474424 (staging: comedi: comedi_test: use
comedi_handle_events()) resulted in the timer routine
`waveform_ai_interrupt()` calling `comedi_handle_events()` instead of
`comedi_events()`. That had the advantage of
On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell ma...@compro.net
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Tested-by: Mark Hounschell ma...@compro.net
---
V2: this patch is rebased
On 30/10/14 20:29, Greg Kroah-Hartman wrote:
On Thu, Oct 30, 2014 at 10:03:53AM +, Ian Abbott wrote:
Commit 240512474424 (staging: comedi: comedi_test: use
comedi_handle_events()) resulted in the timer routine
`waveform_ai_interrupt()` calling `comedi_handle_events()` instead of
On Thursday, October 30, 2014 1:28 PM, Ian Abbott wrote:
On 30/10/14 18:05, Hartley Sweeten wrote:
On Thursday, October 30, 2014 5:42 AM, Ian Abbott wrote:
[snip]
add_wait_queue(async-wait_head, wait);
while (nbytes 0 !retval) {
@@ -2249,6 +2253,10 @@ static ssize_t
On 30/10/14 20:45, Hartley Sweeten wrote:
On Thursday, October 30, 2014 1:28 PM, Ian Abbott wrote:
On 30/10/14 18:05, Hartley Sweeten wrote:
On Thursday, October 30, 2014 5:42 AM, Ian Abbott wrote:
[snip]
add_wait_queue(async-wait_head, wait);
while (nbytes 0 !retval) {
On Thursday, October 30, 2014 5:42 AM, Ian Abbott wrote:
Most comedi subdevices that support asynchronous data acquisition
commands only support data transfer in a single direction, as indicated
by the `SDF_CMD_READ` and `SDF_CMD_WRITE` subdevice flags. A few allow
data transfer in either
From: Haiyang Zhang haiya...@microsoft.com
Date: Thu, 30 Oct 2014 14:07:17 -0700
This will allow the workload spreading via vRSS for IPv6.
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
Applied.
Hi,
2014-10-31 5:33 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell ma...@compro.net
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
52 matches
Mail list logo
