Re: [PATCH] Staging:skein: Fix trailing whitespace error

2014-11-22 Thread Sudip Mukherjee
On Sat, Nov 22, 2014 at 01:20:13PM +0530, anjana s wrote: Just now I resend the same patch by making necessary changes. Kindly please go through it you replied only to me. You should always use reply to all unless there is some specific reason not to send the reply to all. thanks sudip

Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error

2014-11-22 Thread Sudip Mukherjee
On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote: This patch fixes the checkpatch.pl error: it still does not apply to next-20141121 ERROR: trailing whitespace and i am not seeing any trailing whitespace at line 191 of this file. if you base your patch on

Re: [PATCH] Revert staging: sm7xxfb: remove driver

2014-11-22 Thread Greg Kroah-Hartman
On Sat, Nov 22, 2014 at 12:32:02PM +0530, Sudip Mukherjee wrote: 2) most important - I do not have the hardware. So from the TODO list dual head and 2D acceleration support will be tough without actually checking on the hardware. For a driver like this, if you don't have the hardware, I

Re: [PATCH] Staging:skein: Fix trailing whitespace error

2014-11-22 Thread Greg KH
On Fri, Nov 21, 2014 at 05:37:04AM +0530, Anjana Sasindran wrote: This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/skein/skein_generic.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] Staging:skein: Fix trailing whitespace error

2014-11-22 Thread Greg KH
On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote: This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/skein/skein_generic.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error

2014-11-22 Thread Greg KH
On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote: This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/skein/skein_generic.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH v2] staging: lustre: Fix sparse warnings for static declarations

2014-11-22 Thread Greg KH
On Tue, Nov 11, 2014 at 12:15:28AM -0500, Adrian Nicoara wrote: All the changes are against variables/functions that are only accessed from within the same file. If the scope needs to change later on, the static keyword can be removed. Build tested. Signed-off-by: Adrian Nicoara

Re: [PATCH] staging:lustre:lnet:lnet Function must be static

2014-11-22 Thread Greg Kroah-Hartman
On Sun, Nov 16, 2014 at 09:24:44PM +0800, sunwxg wrote: From: Sun Wang sun@gmail.com Function must be static if function will not be used in other files. Signed-off-by: Sun Wang sun@gmail.com --- drivers/staging/lustre/lnet/lnet/{module.c.org = module.c} | 2 +- 1 file

Re: [PATCH] staging: lustre: Coalesce string fragments

2014-11-22 Thread Greg Kroah-Hartman
On Thu, Nov 20, 2014 at 03:43:39PM -0800, Joe Perches wrote: Join the string fragments to make it easier to grep. Ignored all the 80+ column lines. Added many missing spaces when coalescing formats. Signed-off-by: Joe Perches j...@perches.com --- I used this directory as a test for a

Re: net: Hyper-V: Deletion of an unnecessary check before the function call vfree

2014-11-22 Thread SF Markus Elfring
This has nothing to do with me asking you to frame your patches against the correct tree. I imagine than someone other can also pick up this update suggestion (a simple change of two lines) quicker before I might try another software build again from a different commit as a base. Regards,

Re: net: Hyper-V: Deletion of an unnecessary check before the function call vfree

2014-11-22 Thread SF Markus Elfring
Whereas if you learn how to base your changes cleanly on the correct base now, all of your future submissions will go quickly and smoothly into my tree. My reluctance to work with more Linux repositories will evolve over time. The faster affected software versions can be rebuilt the more it