From: Maarten Lankhorst maarten.lankho...@canonical.com
This allows users of dma fences to create a android fence.
v2: Added kerneldoc. (Tvrtko Ursulin).
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com
Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com
Cc: Maarten Lankhorst
From: Tvrtko Ursulin tvrtko.ursu...@intel.com
Debug output assumes all sync points are built on top of Android sync points
and when we start creating them from dma-fences will NULL ptr deref unless
taught about this.
Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com
Cc: Maarten Lankhorst
On 07/17/2015 03:31 PM, john.c.harri...@intel.com wrote:
From: Tvrtko Ursulin tvrtko.ursu...@intel.com
Debug output assumes all sync points are built on top of Android sync points
and when we start creating them from dma-fences will NULL ptr deref unless
taught about this.
This is Maarten's
On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote:
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote:
By checking for the success of kzalloc we were able to remove the goto
label thus making the
On Fri, Jul 17, 2015 at 02:47:55PM +0300, Dan Carpenter wrote:
On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote:
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote:
By checking for the success of
K. Y. Srinivasan k...@microsoft.com writes:
The current code returns from probe without waiting for the proper handling
of subchannels that may be requested. If the netvsc driver were to be rapidly
loaded/unloaded, we can trigger a panic as the unload will be tearing
down state that may not
Reformatting the code without introducing other warnings
like 'Avoid unnecessary line continuations' or breaking strings.
Signed-off-by: Joseph-Eugene Winzer m...@openmailbox.org
---
drivers/staging/rtl8192u/r8192U_core.c | 809 ++---
1 file changed, 536
kfree() can handle NULL pointers itself, so the check is unnecessary.
Signed-off-by: Joseph-Eugene Winzer m...@openmailbox.org
---
drivers/staging/rtl8192u/r8192U_core.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
Fixed a few lines that were longer than 80 chars.
Signed-off-by: Joseph-Eugene Winzer m...@openmailbox.org
---
drivers/staging/rtl8192u/r8192U_core.c | 61 +++---
1 file changed, 41 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
Fixing several coding style issues, like
C99 Comment Style
Trailing whitespaces
Inconsistent spacing of operators
Started to reformat comments/expressions for 80 character limit
Signed-off-by: Joseph-Eugene Winzer m...@openmailbox.org
---
drivers/staging/rtl8192u/r8192U_core.c |
Checkpatch didn't stop complaining about it and as linux/uaccess.h also
includes asm/uaccess.h, there shouldn't be a problem.
Signed-off-by: Joseph-Eugene Winzer m...@openmailbox.org
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/Kconfig| 2 --
drivers/staging/Makefile
Create the documentation for SM712. Mention all the supported modes and
how to use.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Documentation/fb/sm712fb.txt | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/fb/sm712fb.txt
diff
Now since sm712fb has moved out of staging update the maintainers list
accordingly.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8133cef..2c77c30 100644
Fix up return is not a function, parentheses are not required error found by
the checkpatch.pl script.
Signed-off-by: Antoine BLIN antoine.b...@lip6.fr
---
drivers/staging/sm750fb/ddk750_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix up line over 80 characters warning found by the checkpatch.pl script.
Signed-off-by: Antoine BLIN antoine.b...@lip6.fr
---
drivers/staging/sm750fb/ddk750_power.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_power.c
Hi Tixy,
On 17/07/15 12:01, Jon Medhurst (Tixy) wrote:
Use dma_get_sgtable rather than dma_common_get_sgtable so a device's
dma_ops aren't bypassed. This is essential in situations where a device
uses an IOMMU and the physical memory is not contiguous (as the common
function assumes).
On Thu, Jul 16, 2015 at 07:18:46PM +, Marciniszyn, Mike wrote:
Greg,
We are in the process of submitting an RDMA driver for the Intel OPA
architecture.
I have no idea what OPA is, sorry.
The current massive patch set is submitted to add the driver to the
infiniband tree.
I'm
On Fri, Jul 17, 2015 at 11:34:45AM +0530, Sudip Mukherjee wrote:
On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote:
Remove explicit true/false comparisons to bool variables.
Signed-off-by: Luis de Bethencourt l...@debethencourt.com
---
snip
diff --git
#if 0, but it's also obviously incorrect
It supposed to be some tag #ifdef CONFIG_** .
Could anybody in the loop can reply?
i was just checking on style checks.
Will skip this file , will take up later
On Thu, Jul 16, 2015 at 9:27 AM, Joe Perches j...@perches.com wrote:
On Thu, 2015-07-16 at
On Fri, 2015-07-17 at 12:58 +0530, Vinay Simha BN wrote:
scripts/checkpatch.pl kernel coding style fixes of WARNING
Please use checkpatch's --strict option until you know
kernel style much better.
diff --git a/drivers/staging/sm750fb/sm750_accel.h
b/drivers/staging/sm750fb/sm750_accel.h
[]
scripts/checkpatch.pl kernel coding style fixes of WARNING
WARNING: line over 80 characters
Signed-off-by: Vinay Simha BN simha...@gmail.com
---
drivers/staging/sm750fb/ddk750_display.h | 10 +-
drivers/staging/sm750fb/ddk750_hwi2c.h | 6 --
drivers/staging/sm750fb/ddk750_power.h
-Original Message-
From: Dexuan Cui
Sent: Friday, July 17, 2015 3:01 AM
To: KY Srinivasan; da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com; jasow...@redhat.com; vkuzn...@redhat.com
Cc: KY
On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
Stop using DBG_88E which is a custom macro for printing debugging
messages. Instead start using pr_debug and in the process define
pr_fmt.
In the end, don't we want to use netdev_dbg() everywhere where we
From: Alan Tull at...@opensource.altera.com
API to support programming FPGA.
The following functions are exported as GPL:
* fpga_mgr_buf_load
Load fpga from image in buffer
* fpga_mgr_firmware_load
Request firmware and load it to the FPGA.
* fpga_mgr_register
* fpga_mgr_unregister
From: Alan Tull at...@opensource.altera.com
New bindings document for simple fpga bus.
Signed-off-by: Alan Tull at...@opensource.altera.com
---
.../Documentation/bindings/simple-fpga-bus.txt | 61
1 file changed, 61 insertions(+)
create mode 100644
From: Alan Tull at...@opensource.altera.com
Add simple fpga bus. This is a bus that configures an fpga and its
bridges before populating the devices below it. This is intended
for use with device tree overlays.
Note that FPGA bridges are seen as reset controllers so no special
framework for
From: Alan Tull at...@opensource.altera.com
Add documentation under drivers/staging for new fpga manager's
sysfs interface.
Signed-off-by: Alan Tull at...@opensource.altera.com
---
v5 : (actually second version, but keeping version numbers
aligned with rest of patch series)
Move
On Fri, 2015-07-17 at 16:21 +0100, Robin Murphy wrote:
This also begs the question as to what happens if the memory region _is_
contiguous but is in highmem or an ioremapped region. Should a device
always provide dma_ops for that case? Because I believe the current
implementation of
-Original Message-
From: Dexuan Cui
Sent: Friday, July 17, 2015 3:07 AM
To: KY Srinivasan; da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com; jasow...@redhat.com; vkuzn...@redhat.com
Cc: KY
KY Srinivasan k...@microsoft.com writes:
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Friday, July 17, 2015 7:13 AM
To: KY Srinivasan
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org;
From: Alan Tull at...@opensource.altera.com
Add driver to fpga manager framework to allow configuration
of FPGA in Altera SoCFPGA parts.
Signed-off-by: Alan Tull at...@opensource.altera.com
Acked-by: Michal Simek michal.si...@xilinx.com
---
v2: fpga_manager struct now contains struct device
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Friday, July 17, 2015 9:10 AM
To: KY Srinivasan
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com;
The delba variable is a pointer to struct rtllib_hdr_3addr so this
pointer math bug means that we read nonsense data from beyond the end of
the buffer. It could result in a oops if the memory is not mapped.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
On Thu, Jul 16, 2015 at 11:13:43PM +0300, Dan Carpenter wrote:
On Fri, Jul 17, 2015 at 03:03:24AM +, Craig Inches wrote:
Fixed multiple instances of:
CHECK: Alignment should match open parenthesis
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't use
Use dma_get_sgtable rather than dma_common_get_sgtable so a device's
dma_ops aren't bypassed. This is essential in situations where a device
uses an IOMMU and the physical memory is not contiguous (as the common
function assumes).
Signed-off-by: Jon Medhurst t...@linaro.org
---
This also begs
Remove explicit true/false comparisons to bool variables.
Signed-off-by: Luis de Bethencourt l...@debethencourt.com
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
From: K. Y. Srinivasan
Sent: Friday, July 17, 2015 3:17
Subject: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed
during probe
The current code returns from probe without waiting for the proper handling
of subchannels that may be requested. If the netvsc driver were to
On Fri, Jul 17, 2015 at 01:05:55PM +0300, Dan Carpenter wrote:
On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
I don't think I like these at all. remove_one has always been buggy in
that it removes
On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote:
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote:
By checking for the success of kzalloc we were able to remove the goto
label thus making the code more readable.
No... You've just changed error handling to
I don't think I like these at all. remove_one has always been buggy in
that it removes everything. We should fix it to only remove one instead
of formalizing the currect terrible behavior.
regards,
dan carpenter
___
devel mailing list
bool Reval is set to match the value of bHalfWirelessN24GMode just to
this. The value can be returned directly. Removing uneeded bool.
Signed-off-by: Luis de Bethencourt l...@debethencourt.com
---
drivers/staging/rtl8192u/r8192U_core.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
I don't think I like these at all. remove_one has always been buggy in
that it removes everything. We should fix it to only remove one instead
of formalizing the currect terrible behavior.
Its already applied.
I thought after the
From: K. Y. Srinivasan
Sent: Friday, July 17, 2015 3:17
Subject: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed
during probe
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
...
@@ -1116,6 +1127,9 @@ int rndis_filter_device_add(struct
On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
I don't think I like these at all. remove_one has always been buggy in
that it removes everything. We should fix it to only remove one instead
of formalizing the
On Fri, Jul 17, 2015 at 03:57:21PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 01:05:55PM +0300, Dan Carpenter wrote:
On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
I don't think I like these at
The delba variable is a pointer to struct rtl_80211_hdr_3addr so this
addition here means we read nonsense data from beyond the end of the
buffer. It could result in an oops if the memory is not mapped.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote:
By checking for the success of kzalloc we were able to remove the goto
label thus making the code more readable.
No... You've just changed error handling to success handling and added
some new indent levels and made a tangled
On 07/17/2015 08:21 AM, Robin Murphy wrote:
Hi Tixy,
On 17/07/15 12:01, Jon Medhurst (Tixy) wrote:
Use dma_get_sgtable rather than dma_common_get_sgtable so a device's
dma_ops aren't bypassed. This is essential in situations where a device
uses an IOMMU and the physical memory is not
On Fri, Jul 17, 2015 at 06:51:18PM +0530, Sudip Mukherjee wrote:
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
This is really hard for the fbdev developers to review. Care to just
make up a single patch that adds the driver
On 07/17/15 08:51, at...@opensource.altera.com wrote:
From: Alan Tull at...@opensource.altera.com
---
drivers/staging/Kconfig |2 +
drivers/staging/Makefile|1 +
drivers/staging/fpga/Kconfig| 14 ++
drivers/staging/fpga/Makefile |8 +
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Friday, July 17, 2015 7:13 AM
To: KY Srinivasan
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com;
From: Alan Tull at...@opensource.altera.com
This patchset adds two chunks plus documentation:
* fpga manager core: exports ABI functions that write an image to a FPGA
* DT Overlay support: simple-fpga-bus to handle FPGA from a DT overlay
The core's ABI is minimal to start with: only 6
From: Alan Tull at...@opensource.altera.com
Add a document on the new FPGA manager core.
Signed-off-by: Alan Tull at...@opensource.altera.com
---
drivers/staging/fpga/Documentation/fpga-mgr.txt | 117 +++
1 file changed, 117 insertions(+)
create mode 100644
From: Alan Tull at...@opensource.altera.com
Add a document spelling out usage of the simple fpga bus.
Signed-off-by: Alan Tull at...@opensource.altera.com
---
.../staging/fpga/Documentation/simple-fpga-bus.txt | 48
1 file changed, 48 insertions(+)
create mode 100644
On Fri, Jul 17, 2015 at 10:51:10AM -0500, at...@opensource.altera.com wrote:
From: Alan Tull at...@opensource.altera.com
This patchset adds two chunks plus documentation:
* fpga manager core: exports ABI functions that write an image to a FPGA
* DT Overlay support: simple-fpga-bus to
The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754:
Linux 4.2-rc1 (2015-07-05 11:01:52 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.2-rc3
for you to fetch changes up to
On Fri, 17 Jul 2015, Jason Gunthorpe wrote:
On Fri, Jul 17, 2015 at 10:51:10AM -0500, at...@opensource.altera.com wrote:
From: Alan Tull at...@opensource.altera.com
This patchset adds two chunks plus documentation:
* fpga manager core: exports ABI functions that write an image to a
On 16.07.2015 11:58, Dan Carpenter wrote:
On Tue, Jul 14, 2015 at 10:04:03PM +0200, Mateusz Kulikowski wrote:
This series does some more cleanup for driver.
Changes in V2:
- Added patch 6/23 (Remove rtllib_stats structure as suggested by Dan)
- Updated patch 22/23 (remove whitespace - hint
On Fri, Jul 17, 2015 at 09:49:13PM +0200, Steffen Trumtrar wrote:
What you are describing here is a virtual bus, that is not existing on
at least the Socfpga, right?
I wouldn't get too hung up on bus or not bus, the HW these days
doesn't even use busses.
For AXI systems, which is all the ARM
On Fri, Jul 17, 2015 at 05:33:55PM +0200, Jakub Sitnicki wrote:
On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
Stop using DBG_88E which is a custom macro for printing debugging
messages. Instead start using pr_debug and in the process define
Signed-off-by: Adi Ratiu a...@adirat.com
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_sasem.c
b/drivers/staging/media/lirc/lirc_sasem.c index 8ebee96..c14ca7e 100644
---
Create the documentation for SM712. Mention all the supported modes and
how to use.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Documentation/fb/sm712fb.txt | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/fb/sm712fb.txt
diff
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/Kconfig |2 -
drivers/staging/Makefile |1 -
drivers/staging/sm7xxfb/Kconfig |
Now since sm712fb has moved out of staging update the maintainers list
accordingly.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8133cef..2c77c30 100644
On Fri, Jul 17, 2015 at 09:52:35AM -0700, Greg Kroah-Hartman wrote:
On Fri, Jul 17, 2015 at 06:51:18PM +0530, Sudip Mukherjee wrote:
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
This is really hard for the fbdev
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote:
Fixed a few lines that were longer than 80 chars.
[]
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
[]
@@ -212,7 +212,9 @@ static void rtl819x_set_channel_map(u8 channel_plan,
struct
Replace custom debug macro dprintk() with pr_debug() or
dev_dbg(). Remove unused module param `debug`.
This removes the following checkpatch warning:
WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then
dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
+
Remove unnecessary brakes where appropriate.
This removes the following checkpatch warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Maciek Borzecki maciek.borze...@gmail.com
---
drivers/staging/media/lirc/lirc_imon.c | 8
A tiny patch series that addresses warnings identified by
checkpatch. The first patch fixes minor warning with unnecessary
brakes around single statement block.
The second patch does away with a custom dprintk() in favor of dev_dbg
and pr_debug(). The patch is sent separately as the change is
n 17.07.2015 11:24, Dan Carpenter wrote:
The delba variable is a pointer to struct rtllib_hdr_3addr so this
pointer math bug means that we read nonsense data from beyond the end of
the buffer. It could result in a oops if the memory is not mapped.
Signed-off-by: Dan Carpenter
Alan,
it looks pretty good so far. I have worked with Michal and developed a
Zynq equivalent against your last
patchset which can be found in the Xilinx tree now.
I just briefly glanced the changes below just two nits that caught my eye.
I'll take a closer look while trying to update the
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote:
Reformatting the code without introducing other warnings
like 'Avoid unnecessary line continuations' or breaking strings.
Very few of these seem to be improvements and many
of them should likely be in separate patches.
diff --git
Hi!
On Fri, Jul 17, 2015 at 10:51:13AM -0500, at...@opensource.altera.com wrote:
From: Alan Tull at...@opensource.altera.com
New bindings document for simple fpga bus.
Signed-off-by: Alan Tull at...@opensource.altera.com
---
.../Documentation/bindings/simple-fpga-bus.txt | 61
On Fri, 17 Jul 2015, Steffen Trumtrar wrote:
Hi!
On Fri, Jul 17, 2015 at 10:51:13AM -0500, at...@opensource.altera.com wrote:
From: Alan Tull at...@opensource.altera.com
New bindings document for simple fpga bus.
Signed-off-by: Alan Tull at...@opensource.altera.com
---
On Fri, 17 Jul 2015, Moritz Fischer wrote:
Hi Moritz,
Alan,
it looks pretty good so far. I have worked with Michal and developed a
Zynq equivalent against your last
patchset which can be found in the Xilinx tree now.
I just briefly glanced the changes below just two nits that caught my
76 matches
Mail list logo
