Re: [PATCHv5] staging: vme_user: provide DMA functionality

> On 2015/10/17, at 23:52, Greg Kroah-Hartman > wrote: > > On Sun, Oct 11, 2015 at 03:13:25AM +0300, Dmitry Kalinkin wrote: >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write functionality to the user space. >>

Re: [PATCHv5] staging: vme_user: provide DMA functionality

On Sun, Oct 11, 2015 at 03:13:25AM +0300, Dmitry Kalinkin wrote: > This introduces a new dma device that provides a single ioctl call that > provides DMA read and write functionality to the user space. > > Signed-off-by: Dmitry Kalinkin > Cc: Igor Alekseev

Re: [PATCH] staging: IB/ipath: use TASK_COMM_LEN in ipath_portdata

On Thu, Oct 08, 2015 at 10:04:27PM -0700, Geliang Tang wrote: > Use comm[TASK_COMM_LEN] instead of comm[16]. Add linux/sched.h > header in ipath_kernel.h, and remove linux/sched.h header from > ipath_*.c which have included ipath_kernel.h. That's a lot of different things to be doing all in one

Re: [PATCH] staging: comedi: fixed few coding style warnings

On Wed, Oct 14, 2015 at 07:33:00PM +0530, Sakshi Bansal wrote: > Fixed block comments usage of * on subsequent lines > > Signed-off-by: Sakshi Bansal > --- > drivers/staging/comedi/comedi.h| 181 > +++-- >

Re: [PATCH 39/45] staging: comedi: cb_pcidas: split ai code out of interrupt handler

On Tue, Oct 13, 2015 at 05:48:03PM -0700, H Hartley Sweeten wrote: > Clarify the interrupt handler by splitting the analog input handling > into a new function. > > Signed-off-by: H Hartley Sweeten > Reviewed-by: Ian Abbott > --- >

Re: [PATCH 0/4] staging: fsl-mc: MC command serialization

On Wed, Oct 14, 2015 at 03:11:41PM -0500, J. German Rivera wrote: > This patch series depends on the patch series posted > at http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg996780.html I didn't take that series for obvious reasons :( ___

Re: [PATCH v2 01/12] staging: fsl-mc: Naming cleanup in fsl_mc-portal_allocate

On Wed, Oct 14, 2015 at 02:51:40PM -0500, J. German Rivera wrote: > mc_adev is a local variable for the allocated dpmcp object. > Renamed mc_adev as dpmcp_dev for clarity. > --- > CHANGE HISTORY > > Changes in v2: none None of the patches in this series has a signed-off-by: line, as required by

Re: [PATCH 0/4] staging: fsl-mc: MC command serialization

On Sat, Oct 17, 2015 at 04:36:44PM +, Jose Rivera wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Saturday, October 17, 2015 1:16 AM > > To: Rivera Jose-B46482 > > Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux- > >

Re: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

On Sat, Oct 17, 2015 at 04:34:28PM +, Sell, Timothy C wrote: > > How can you guarantee it? Please document that somehow, I don't see it > > here in this patch how that can be true, but maybe I'm not looking close > > enough... > > Sure; I'll add some code comments. Basically they will

RE: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, October 17, 2015 12:51 PM > To: Sell, Timothy C > Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par- > Maintainer > Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref

Re: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

On Sat, Oct 17, 2015 at 05:04:43PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Saturday, October 17, 2015 12:51 PM > > To: Sell, Timothy C > > Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par- > >

Re: [PATCH 16/16] staging: wilc1000: assign pointer of wl to sdio device data

Hi Glen, [auto build test ERROR on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Tony-Cho/staging-wilc1000-remove-extern-declarations-of-g_linux_wlan/20151014-195239 config:

Re: [PATCH 2/4] staging: lustre: hash.c: replace IS_PO2 by is_power_of_2

On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote: > On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote: > > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug > > macros. In this case, it is CDEBUG. Note that the replacement changes > > the types involved, because

Re: [PATCH 2/4] staging: lustre: hash.c: replace IS_PO2 by is_power_of_2

On Sat, 17 Oct 2015, Aya Mahfouz wrote: > On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote: > > On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote: > > > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug > > > macros. In this case, it is CDEBUG. Note that the

Re: [PATCH 1/4] staging: lustre: ldlm_extent.c: replace IS_PO2 by is_power_of_2

On Fri, Oct 16, 2015 at 10:41:09PM -0700, Greg KH wrote: > On Sat, Oct 17, 2015 at 12:05:44AM +0200, Aya Mahfouz wrote: > > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug > > macros. In this case, it is LASSERT. Note that the replacement changes > > the types involved, because

Re: [PATCH 4/4] staging: lustre: remove IS_PO2 and __is_po2

On Fri, Oct 16, 2015 at 10:21:05PM -0700, Greg KH wrote: > On Sat, Oct 17, 2015 at 12:07:28AM +0200, Aya Mahfouz wrote: > > Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have > > been replaced by is_power_of_2 > > > > Signed-off-by: Aya Mahfouz > > --- > >

[PATCH v3] staging: rtl8192u: simplify conditional

The code can be much cleaner and readable by simplifying the conditional statement. Signed-off-by: Luis de Bethencourt --- Hi, Dan Carpenter pointed out that the check needs to be >= and not just > because ieee->state can change between the two if statements. Thanks

Re: [PATCH 2/4] staging: lustre: hash.c: replace IS_PO2 by is_power_of_2

On Sat, Oct 17, 2015 at 12:47:13PM +0200, Julia Lawall wrote: > On Sat, 17 Oct 2015, Aya Mahfouz wrote: > > > On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote: > > > On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote: > > > > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with

RE: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, October 17, 2015 1:41 PM > To: Sell, Timothy C > Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par- > Maintainer > Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref

[PATCH 2/3] staging: octeon-ethernet: drop poll_now parameter from cvm_oct_common_open

Drop redundant poll_now parameter from cvm_oct_common_open. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rgmii.c | 2 +- drivers/staging/octeon/ethernet-sgmii.c | 2 +- drivers/staging/octeon/ethernet-xaui.c | 2 +- drivers/staging/octeon/ethernet.c

[PATCH 1/3] staging: octeon-ethernet: rgmii: poll link status on open

Get the initial link status already on open instead of postponing it to the periodic poll task. This unifies the behaviour with other interfaces types. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rgmii.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/3] staging: octeon-ethernet: move cvm_oct_xaui_open()

cvm_oct_xaui_open() is trivial and does not need a dedicated file. Move it to the main file. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/Makefile | 2 -- drivers/staging/octeon/ethernet-xaui.c | 31 ---

[PATCH v2 2/4] staging: fsl-mc: refactored mc_send_command()

Moved wait logic in mc_send_command() to its own function Signed-off-by: J. German Rivera --- Changes in v2: - Added missing Signed-off-by entry drivers/staging/fsl-mc/bus/mc-sys.c | 50 - 1 file changed, 38 insertions(+), 12

[PATCH v2 4/4] staging: fsl-mc: Added serialization to mc_send_command()

When the same portal is used to call mc_send_command() from two different threads or a thread and an interrupt handler, serialization is required, as the MC only supports one outstanding command per MC portal. Thus, a new command should not be sent to the MC until the last command sent has been

[PATCH v2 0/4] staging: fsl-mc: MC command serialization

This patch series depends on the patch series posted at http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg999081.html This patch series addresses the following item from the TODO list for the MC bus driver to exit staging: * Management Complex (MC) command serialization. Locking

[PATCH v2 3/4] staging: fsl-mc:Added support for atomic portals

Refactored mc_send_command() to support two flavors of polling: - preemptible (for non-atomic portals), which was already supported. It calls usleep_range() between polling iterations. - non-preemptible (for atomic portals), which is needed when mc_send_command() is called with interrupts

[PATCH v2 1/4] staging: fsl-mc: changed timeout units for MC cmd completion

Changed units for the timeout to wait for completion of MC command, from jiffies to milliseconds. Signed-off-by: J. German Rivera --- Changes in v2: - Added missing Signed-off-by entry drivers/staging/fsl-mc/bus/mc-sys.c | 6 +++--- 1 file changed, 3 insertions(+),

RE: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, October 17, 2015 1:59 AM > To: Romer, Benjamin M > Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org; Sell, > Timothy C > Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref

RE: [PATCH v2 01/12] staging: fsl-mc: Naming cleanup in fsl_mc-portal_allocate

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, October 17, 2015 1:16 AM > To: Rivera Jose-B46482 > Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; Hamciuc Bogdan-BHAMCIU1; Sharma Bhupesh-B45370; > ag...@suse.de;

Re: [lustre-devel] [PATCH 3/4] staging: lustre: workitem.c: replace IS_PO2 with is_power_of_2

On Oct 16, 2015, at 23:40, Greg KH wrote: > >> On Sat, Oct 17, 2015 at 12:06:59AM +0200, Aya Mahfouz wrote: >> Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug >> macros. In this case, it is CDEBUG. Note that the replacement changes >> the types

[PATCH v3 0/12] staging: fsl-mc: Cleanup and bug fixes

This patch series includes the following code cleanup and bug fixes for the fsl-mc bus driver: Patch 1: Naming cleanup in fsl_mc-portal_allocate Patch 2: fsl_mc_io object refactoring Patch 3: dpmcp opening/closing refactoring Patch 4: Changed dev_info() calls to dev_dbg() Patch 5: Changed types

[PATCH v3 03/12] staging: fsl-mc: dpmcp opening/closing refactoring

Before, we were opening and closing a mc_io's dpmcp object in fsl_mc_portal_reset(), since that was the only function that was calling dpmcp MC operations. However, it is better for maintainability to open the dpmcp object when it gets associated with an mc_io object, and close it when this

[PATCH v3 11/12] staging: fsl-mc: fixed bug in uninitialized root dprc irq count

When initializing the object attributes for the root dprc, the irq_count was uninitialized. Initialize it to 1. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/bus/mc-bus.c

[PATCH v3 06/12] staging: fsl-mc: Removed unused DPMCP macros

The macros were a left-over from a previous implementation of the dpmcp APIs and are no longer used. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 79

[PATCH v3 05/12] staging_fsl-mc: Changed types of flags, portal size in

Changed these two fields from 32-bit integers to 16-bit integers in struct fsl_mc_io, as 32 bits is too much for these fields. This change does not affect other components since fsl_mc_io is an opaque type. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes

[PATCH v3 02/12] staging: fsl-mc: fsl_mc_io object refactoring

Each fsl_mc_io object is associated with an fsl_mc_device object of type "dpmcp" representing the MC portal associated with the fsl_mc_io object. Before, we were representing this association with an fsl_mc_resource pointer. To enhance code clarity, it is more straight forward to use an

[PATCH v3 01/12] staging: fsl-mc: Naming cleanup in fsl_mc-portal_allocate

mc_adev is a local variable for the allocated dpmcp object. Renamed mc_adev as dpmcp_dev for clarity. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/bus/mc-allocator.c |

[PATCH v3 04/12] staging: fsl-mc: Changed dev_info() calls to dev_dbg()

Changed dev_info() calls to dev_dbg() in fsl_mc_allocator_probe/fsl_mc_allocator_remove, as they are useful only for debugging. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none

[PATCH v3 10/12] staging: fsl-mc: Fixed WARN_ON() in fsl_mc_resource_pool_remove_device

Check that resource is not NULL before de-referencing it. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +- 1 file changed, 1 insertion(+), 1

RE: [PATCH 0/4] staging: fsl-mc: MC command serialization

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, October 17, 2015 1:16 AM > To: Rivera Jose-B46482 > Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; Hamciuc Bogdan-BHAMCIU1; Sharma Bhupesh-B45370; > ag...@suse.de;

Re: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

On Sat, Oct 17, 2015 at 03:04:37PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Saturday, October 17, 2015 1:59 AM > > To: Romer, Benjamin M > > Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org; Sell, > >

Re: [PATCH 2/4] staging: lustre: hash.c: replace IS_PO2 by is_power_of_2

On Oct 17, 2015, at 07:23, Aya Mahfouz wrote: > >> On Sat, Oct 17, 2015 at 12:47:13PM +0200, Julia Lawall wrote: >>> On Sat, 17 Oct 2015, Aya Mahfouz wrote: >>> On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote: > On Sat, Oct 17, 2015 at 12:06:28AM

[PATCH v3 07/12] staging: fsl-mc: Fixed alignment of copyright comment

Whitespace cleanup-- add missing spaces in column 1 of copyright Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/include/dpcon-cmd.h | 60 +++--- 1

[PATCH v3 09/12] staging: fsl-mc: refactored error exit in allocator probe/remove

Replaced error gotos with direct returns in fsl_mc_allocator_probe() and fsl_mc_allocator_remove(), since the only error handling done in those functions is to exit. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: none Changes in v2: none

[PATCH v3 08/12] staging: fsl-mc: Fixed bug in fsl_mc_allocator_remove

Call fsl_mc_resource_pool_remove_device() only if mc_dev->resource is not NULL. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/bus/mc-allocator.c | 8 +--- 1 file

[PATCH v3 12/12] staging: fsl-mc: Added missing initializer in fsl_mc_bus_driver

owner needs to be initialized as THIS_MOUDLE. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Added missing signed-off-by Changes in v2: none drivers/staging/fsl-mc/bus/mc-bus.c | 1 + 1 file changed, 1 insertion(+) diff --git

RE: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, October 17, 2015 11:42 AM > To: Sell, Timothy C > Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par- > Maintainer > Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref

[PATCH v2] staging: r8188eu: Add _enter_critical_mutex() error handling

_enter_critical_mutex() is a simple call to mutex_lock_interruptible(), but there is no error handling code for it. The patch removes wrapper _enter_critical_mutex() and adds error handling for mutex_lock_interruptible(). Found by Linux Driver Verification project (linuxtesting.org).