Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-22 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 02:28:21PM +0900, Glen Lee wrote: > This patch add new argument wilc to wilc_handle_isr and pass wilc to > the function. It's not important enough to redo the patch but why are we sometimes using "wl" and sometimes "wilc"? regards, dan carpenter __

Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-22 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 08:00:09AM +0300, Dan Carpenter wrote: > On Fri, Oct 23, 2015 at 10:00:03AM +0530, Nilesh Kokane wrote: > > Fixed- Return of an errno should typically be negative (ie: return -EAGAIN) > > > > The changelog needs to describe the use visible effects of this change. > I was

[PATCH] Staging: media: lirc Braces not needed for single statement

2015-10-22 Thread Nilesh Kokane
Fixed the braces issue for single statement. Signed-off-by: Nilesh Kokane --- drivers/staging/media/lirc/lirc_imon.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c index 62ec9f7..a6cae49 1

[PATCH] staging: lustre: lnet :socklnd Braces not necessary

2015-10-22 Thread Nilesh Kokane
Braces not needed for single statement block Signed-off-by: Nilesh Kokane --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd

[PATCH] Staging: lustre: lnet :socklnd return statement in void function not useful

2015-10-22 Thread Nilesh Kokane
Return function in void function is not needed. Signed-off-by: Nilesh Kokane --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c index

[PATCH 28/28] staging: wilc1000: tcp_process: add argument dev and get private from it

2015-10-22 Thread Glen Lee
This patch adds new argument net_device *dev and use netdev private data member wilc instead of g_linux_wlan. Pass argument dev to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --gi

[PATCH 25/28] staging: wilc1000: wilc_wlan_txq_get_next: add argument wilc

2015-10-22 Thread Glen Lee
This patch adds new argument struct wilc and use wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.

[PATCH 24/28] staging: wilc1000: wilc_wlan_rxq_add: add argument wilc and use it

2015-10-22 Thread Glen Lee
This patch adds new argument struct wilc and use it instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c i

[PATCH 23/28] staging: wilc1000: Set_machw_change_vir_if: add argument dev

2015-10-22 Thread Glen Lee
Add new argument net_device *dev and use netdev private data member wilc instead of g_linux_wlan. Pass argument dev to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++ dri

[PATCH 22/28] staging: wilc1000: GetIfHandler: add argument struct wilc and use it

2015-10-22 Thread Glen Lee
This patch adds new argument struct wilc and use it instead of g_linux_wlan. And also pass wilc to the function. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/l

[PATCH 27/28] staging: wilc1000: wilc_wlan_txq_add_net_pkt: add argument struct net_device

2015-10-22 Thread Glen Lee
This patch add new argument struct net_device *dev and pass net_device to wilc_wlan_txq_add_net_pkt. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.h | 4 ++-- 3 files changed, 6 inse

[PATCH 20/28] staging: wilc1000: wilc_wlan_rxq_remove: add argument wilc and use it

2015-10-22 Thread Glen Lee
This patch adds new argument struct wilc and use it instead of g_linux_wlan. Pass struct wilc to wilc_wlan_rxq_remove. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wi

[PATCH 26/28] staging: wilc1000: mac_xmit: use netdev private wilc instead of g_linux_wlan

2015-10-22 Thread Glen Lee
This patch uses netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c in

[PATCH 15/28] staging: wilc1000: wlan_deinit_locks: rename argument name and use it

2015-10-22 Thread Glen Lee
This patch renames nic to wilc and use it instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 4f

[PATCH 19/28] staging: wilc1000: wilc_wlan_cleanup: add parameter net_device *dev

2015-10-22 Thread Glen Lee
This patch adds new function parameter net_device *dev and pass dev to the functions. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.h | 2 +- 3 files changed, 4 insertions(+), 4 deleti

[PATCH 21/28] staging: wilc1000: frmw_to_linux: add argument struct wilc

2015-10-22 Thread Glen Lee
This patch adds new argument struct wilc and use it instead of g_linux_wlan. Pass argument wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.

[PATCH 18/28] staging: wilc1000: mac_ioctl: use private data instead of g_linux_wlan

2015-10-22 Thread Glen Lee
Use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 75dad3e..05cb

[PATCH 14/28] staging: wilc1000: host_int_init: add argument net_device

2015-10-22 Thread Glen Lee
This patch add argument net_device *dev and pass it to kthread_run. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 3 files changed, 4 inser

[PATCH 17/28] staging: wilc1000: wlan_deinitialize_threads: change argument and use wilc

2015-10-22 Thread Glen Lee
This patch changes function parameter type struct wilc with struct net_device and use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff

[PATCH 13/28] staging: wilc1000: wilc_wlan_txq_filter_dup_tcp_ack: add argument and use wilc

2015-10-22 Thread Glen Lee
This patch add argument net_device dev and use netdev private data member wilc instead of g_linux_wlan. Pass argument dev to the function. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH 11/28] staging: wilc1000: linux_wlan_txq_task: use wilc instead of g_linux_wlan

2015-10-22 Thread Glen Lee
Pass argument dev instead of wilc from kthread_run and use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/staging/

[PATCH 16/28] staging: wilc1000: WILC_WFI_mgmt_rx: add argument wilc and use it

2015-10-22 Thread Glen Lee
This patch add new argument wilc and use wilc instead of g_wlan_linux. Declare the function in wilc_wfi_netdevice.h. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 10 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + drivers/staging/wilc1000/wilc_wlan

[PATCH 12/28] staging: wilc1000: wilc_wlan_handle_txq: add argument and use wilc

2015-10-22 Thread Glen Lee
This patch adds argument net_device dev and use netdev private data memeber wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 11 --- drivers/staging/wilc1000/wilc_wlan.h | 2 +- 3 files ch

[PATCH 10/28] staging: wilc1000: wlan_initialize_threads: change argument with net_device

2015-10-22 Thread Glen Lee
This patch changes function argument with net_device dev and use netdev private data member wilc instead of g_linux_wlan. And there are assignment code with different value continuously. Take last code. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 21 -

[PATCH 09/28] staging: wilc1000: linux_wlan_set_bssid: use wilc instead of g_linux_wlan

2015-10-22 Thread Glen Lee
This patch use netdev private data memeber wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.

[PATCH 08/28] staging: wilc1000: linux_wlan_mac_indicate: add argument and use wilc

2015-10-22 Thread Glen Lee
This patch adds argument wilc and pass the function wilc. Use wilc instead of g_linux_wlan and pd. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 13 ++--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.c |

[PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

2015-10-22 Thread Glen Lee
Use netdev private member wilc instead of g_linux_wlan and Change argument wilc with dev in the function request_threaded_irq to pass back to handler the function isr_uh_routine. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 9 +++-- 1 file changed, 7 insertions(+), 2 d

[PATCH 06/28] staging: wilc1000: wilc_wlan_handle_isr_ext: add argument struct wilc

2015-10-22 Thread Glen Lee
This patch adds argument struct wilc and pass wilc to the function. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index be6f631.

[PATCH 07/28] staging: wilc1000: wilc_wlan_handle_rxq: add new argument and use wilc

2015-10-22 Thread Glen Lee
This patch adds new argument struct *wilc and use it instead of g_linux_wlan. Pass wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/dr

[PATCH 04/28] staging: wilc1000: deinit_irq: use wilc instead of g_linux_wlan

2015-10-22 Thread Glen Lee
This patch changes function parameter linux_wlan_t nic with net_dev dev and use wilc instead of nic and g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/l

[PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-22 Thread Glen Lee
This patch add new argument wilc to wilc_handle_isr and pass wilc to the function. It is void type for now because wilc_wlan.c was implemented platform independently at the beginning (linux_wlan.c is implementation of LINUX part) so the struct wilc header file cannot be included at this moment, but

[PATCH 03/28] staging: wilc1000: isr_bh_routine: use wilc instead of g_linux_wlan

2015-10-22 Thread Glen Lee
Use netdev private member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 7b0614d..e3176

[PATCH 01/28] staging: wilc1000: isr_bh_routine: remove unused variable nic

2015-10-22 Thread Glen Lee
This patch removes unused variable nic. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index ce2bd53..b036b96 100644 --- a/drivers/staging/wilc

Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-22 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 10:00:03AM +0530, Nilesh Kokane wrote: > Fixed- Return of an errno should typically be negative (ie: return -EAGAIN) > The changelog needs to describe the use visible effects of this change. regards, dan carpenter ___ devel mai

[PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-22 Thread Nilesh Kokane
Fixed- Return of an errno should typically be negative (ie: return -EAGAIN) Signed-off-by: Nilesh Kokane --- drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/dri

Re: [PATCH v2 14/22] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-22 Thread Dan Carpenter
On Thu, Oct 22, 2015 at 07:18:19PM -0400, ira.weiny wrote: > This follows the rest of the style of the case statement in this function. We > prefer to leave this as is for a number of reasons. > > 1) This is consistent with the coding style elsewhere in this driver. Don't try to match existing s

Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-22 Thread glen lee
On 2015년 10월 22일 21:23, Arnd Bergmann wrote: On Wednesday 21 October 2015 19:06:52 glen lee wrote: Hi arnd, Thanks for the all the patches. About the patch ( use proper naming for global symbols ), We are planning to use this driver not only for wilc1000 but also for other atmel wireless drive

Re: [PATCH V2 03/12] staging: wilc1000: rename strInterfaceInfo in the sturct wilc

2015-10-22 Thread Tony Cho
Thanks for your review. I will do it later as you mentioned. Tony. On 2015년 10월 22일 20:19, Dan Carpenter wrote: Don't resend the series though. Please fix it in a later patch. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.o

Re: [PATCH v2 14/22] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-22 Thread ira.weiny
On Thu, Oct 22, 2015 at 01:41:58PM +0300, Dan Carpenter wrote: > On Mon, Oct 19, 2015 at 10:11:29PM -0400, ira.we...@intel.com wrote: > > + case HFI1_CMD_TID_INVAL_READ: > > + ret = hfi1_user_exp_rcv_invalid(fp, &tinfo); > > + if (!ret) { > > + addr = (unsign

Re: [PATCH v2 15/22] staging/rdma/hfi1: Allow tuning of SDMA interrupt rate

2015-10-22 Thread ira.weiny
On Thu, Oct 22, 2015 at 01:54:21PM +0300, Dan Carpenter wrote: > What values work well for this parameter? 64. For v3, I've squashed a change which was farther down my list of changes which set this after some testing. Thanks, Ira > > regards, > dan carpenter > ___

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-22 Thread Dan Carpenter
First fetch the changes, then check them out. $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next $ git checkout FETCH_HEAD regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverd

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-22 Thread punit vara
On Fri, Oct 23, 2015 at 12:52 AM, Dan Carpenter wrote: > On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: >> I am working on linux-next .I have tried to rebase my local branch on >> your staging tree but I am getting too many conflict .and I have tried >> to clone your staging tree sepa

Re: [PATCH] staging: lustre: o2iblnd: fix misleading indentation

2015-10-22 Thread Dan Carpenter
On Wed, Oct 21, 2015 at 06:40:40PM +0100, Luis de Bethencourt wrote: > The code is correct, the indentation is misleading. Only the the return rc > is part of the conditional statement if rc != 0. > > Fix a smatch warning: > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157 > kiblnd_hdev_se

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-22 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: > I am working on linux-next .I have tried to rebase my local branch on > your staging tree but I am getting too many conflict .and I have tried > to clone your staging tree separately but due slow internet I am > unable to clone it fully

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-22 Thread Greg KH
On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: > On Mon, Oct 19, 2015 at 8:51 PM, punit vara wrote: > > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger > > wrote: > >> On 10/18/2015 09:00 PM, Greg KH wrote: > >>> > >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: >

Re: [PATCH v2 1/3] staging: rtl8712: Remove boolean comparisons

2015-10-22 Thread Dan Carpenter
On Mon, Oct 19, 2015 at 06:14:29PM +0100, Luis de Bethencourt wrote: > Boolean tests do not need explicit comparison to true or false. > > Signed-off-by: Luis de Bethencourt > --- > diff --git a/drivers/staging/rtl8712/usb_ops_linux.c > b/drivers/staging/rtl8712/usb_ops_linux.c > index c940722..

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-22 Thread punit vara
On Mon, Oct 19, 2015 at 8:51 PM, punit vara wrote: > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger > wrote: >> On 10/18/2015 09:00 PM, Greg KH wrote: >>> >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: One more thing I would like suggestion how can start switching this

Re: [RFC][PATCH 1/2] WIP: Devicetree bindings for Ion

2015-10-22 Thread Laura Abbott
On 10/22/15 3:36 AM, and...@ncrmnt.org wrote: 20 октября 2015 г., 19:34, "Mitchel Humpherys" написал: On Tue, Oct 13 2015 at 11:14:23 AM, Andrew wrote: On 2015-10-12 21:39, Mitchel Humpherys wrote: On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring wrote: On Tue, Oct 6, 2015 at 3:47 PM, Lau

[PATCH] Staging: lustre: lov_obd: fixed a brace coding style issue

2015-10-22 Thread Nilesh Kokane
Fixed a coding style issue. Signed-off-by: Nilesh kokane --- drivers/staging/lustre/lustre/lov/lov_obd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lov/lov_obd.c index 96c55ac..8e1729e 1006

Re: [PATCH 3/3] locks: cleanup posix_lock_inode_wait and flock_lock_inode_wait

2015-10-22 Thread kbuild test robot
Hi Benjamin, [auto build test WARNING on jlayton/linux-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Benjamin-Coddington/locks-introduce-locks_lock_inode_wait/20151022-233848 repr

[RFC PATCH] locks: posix_lock_inode_wait() can be static

2015-10-22 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- locks.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index daf4664..0d2b326 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -1173,7 +1173,7 @@ EXPORT_SYMBOL(posix_lock_file); * * Apply a POSIX style lock reques

Re: [PATCH 1/3] locks: introduce locks_lock_inode_wait()

2015-10-22 Thread kbuild test robot
Hi Benjamin, [auto build test ERROR on jlayton/linux-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Benjamin-Coddington/locks-introduce-locks_lock_inode_wait/20151022-233848 config: x

Re: [PATCH 1/3] locks: introduce locks_lock_inode_wait()

2015-10-22 Thread Benjamin Coddington
On Thu, 22 Oct 2015, Benjamin Coddington wrote: > Users of the locks API commonly call either posix_lock_file_wait() or > flock_lock_file_wait() depending upon the lock type. Add a new function > locks_lock_inode_wait() which will check and call the correct function for > the type of lock passed

[PATCH 2/3] Move locks API users to locks_lock_inode_wait()

2015-10-22 Thread Benjamin Coddington
Instead of having users check for FL_POSIX or FL_FLOCK to call the correct locks API function, use the check within locks_lock_inode_wait(). This allows for some later cleanup. Signed-off-by: Benjamin Coddington --- drivers/staging/lustre/lustre/llite/file.c |8 ++-- fs/9p/vfs_file.c

[PATCH 3/3] locks: cleanup posix_lock_inode_wait and flock_lock_inode_wait

2015-10-22 Thread Benjamin Coddington
All callers use locks_lock_inode_wait() instead. Signed-off-by: Benjamin Coddington --- fs/locks.c |5 + include/linux/fs.h | 24 2 files changed, 1 insertions(+), 28 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 94d50d3..b6f3c92 100644 --- a

[PATCH 0/3] Minor cleanup for locks API

2015-10-22 Thread Benjamin Coddington
NFS has recently been moving things around to cope with the situation where a struct file may not be available during an unlock. That work has presented an opportunity to do a minor cleanup on the locks API. Users of posix_lock_file_wait() (for FL_POSIX style locks) and flock_lock_file_wait() (fo

[PATCH 1/3] locks: introduce locks_lock_inode_wait()

2015-10-22 Thread Benjamin Coddington
Users of the locks API commonly call either posix_lock_file_wait() or flock_lock_file_wait() depending upon the lock type. Add a new function locks_lock_inode_wait() which will check and call the correct function for the type of lock passed in. Signed-off-by: Benjamin Coddington --- fs/locks.c

[PATCH] Staging: lustre: lnet: Remove typedef srpc_server_rpc_t

2015-10-22 Thread Shraddha Barke
The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for srpc_server_rpc_t. Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lnet/selftest/brw_test.c | 4 ++-- drivers/staging/lustre/lnet/selftest/console.c | 2 +

[PATCH] Staging: lustre: lprocfs_status: Remove unused declaration

2015-10-22 Thread Shraddha Barke
Remove declaration of function lprocfs_wr_timeouts from header file since it is not used Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lprocfs_status.h b/drivers

Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-22 Thread Arnd Bergmann
On Wednesday 21 October 2015 19:06:52 glen lee wrote: > Hi arnd, > > Thanks for the all the patches. > About the patch ( use proper naming for global symbols ), > We are planning to use this driver not only for wilc1000 but also for > other atmel wireless driver. I'd appreciate if you could use w

Re: [Outreachy kernel] [PATCH 0/2] Staging: lustre: Remove unused functions

2015-10-22 Thread Shraddha Barke
On Thu, 22 Oct 2015, Arnd Bergmann wrote: On Thursday 22 October 2015 16:59:01 Shraddha Barke wrote: On Thu, 22 Oct 2015, Arnd Bergmann wrote: On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote: On Thu, 22 Oct 2015, Arnd Bergmann wrote: On Thursday 22 October 2015 14:50:18 Shraddh

Re: [Outreachy kernel] [PATCH 0/2] Staging: lustre: Remove unused functions

2015-10-22 Thread Arnd Bergmann
On Thursday 22 October 2015 16:59:01 Shraddha Barke wrote: > On Thu, 22 Oct 2015, Arnd Bergmann wrote: > > > On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote: > >> On Thu, 22 Oct 2015, Arnd Bergmann wrote: > >> > >>> On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote: > These

Re: [Outreachy kernel] [PATCH 0/2] Staging: lustre: Remove unused functions

2015-10-22 Thread Shraddha Barke
On Thu, 22 Oct 2015, Arnd Bergmann wrote: On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote: On Thu, 22 Oct 2015, Arnd Bergmann wrote: On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote: These patches remove the definitions of functions which are not used. Shraddha Barke (2

Re: [PATCH V2 03/12] staging: wilc1000: rename strInterfaceInfo in the sturct wilc

2015-10-22 Thread Dan Carpenter
Don't resend the series though. Please fix it in a later patch. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2 03/12] staging: wilc1000: rename strInterfaceInfo in the sturct wilc

2015-10-22 Thread Dan Carpenter
On Tue, Oct 20, 2015 at 02:26:47PM +0900, Tony Cho wrote: > This patch renames strInterfaceInfo in the struct wilc to the vif. In > addition, unnecessary print statements around it are removed in this patch. > > Signed-off-by: Tony Cho > --- > drivers/staging/wilc1000/linux_wlan.c |

Re: [PATCH v2 15/22] staging/rdma/hfi1: Allow tuning of SDMA interrupt rate

2015-10-22 Thread Dan Carpenter
What values work well for this parameter? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 14/22] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-22 Thread Dan Carpenter
On Mon, Oct 19, 2015 at 10:11:29PM -0400, ira.we...@intel.com wrote: > + case HFI1_CMD_TID_INVAL_READ: > + ret = hfi1_user_exp_rcv_invalid(fp, &tinfo); > + if (!ret) { > + addr = (unsigned long)cmd.addr + > + offsetof(struc

Re: [RFC][PATCH 1/2] WIP: Devicetree bindings for Ion

2015-10-22 Thread andrew
20 октября 2015 г., 19:34, "Mitchel Humpherys" написал: > On Tue, Oct 13 2015 at 11:14:23 AM, Andrew wrote: > >> On 2015-10-12 21:39, Mitchel Humpherys wrote: >>> On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring >>> wrote: On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott wrote: >>> >>>

Re: [Outreachy kernel] [PATCH 0/2] Staging: lustre: Remove unused functions

2015-10-22 Thread Arnd Bergmann
On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote: > On Thu, 22 Oct 2015, Arnd Bergmann wrote: > > > On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote: > >> These patches remove the definitions of functions which are not used. > >> > >> Shraddha Barke (2): > >> Staging: lustre: p

Re: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

2015-10-22 Thread Dan Carpenter
On Wed, Oct 21, 2015 at 04:29:35PM +, Weiny, Ira wrote: > > > > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote: > > > From: Niranjana Vishwanathapura > > > > > > Use NULL instead of 0 for pointer argument to fix the sparse error. > > > > > > Reviewed-by: Mike Marciniszyn

Re: [Outreachy kernel] [PATCH 0/2] Staging: lustre: Remove unused functions

2015-10-22 Thread Shraddha Barke
On Thu, 22 Oct 2015, Arnd Bergmann wrote: On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote: These patches remove the definitions of functions which are not used. Shraddha Barke (2): Staging: lustre: ptlrpc: Remove unused functions Staging: lustre: obdclass: Remove unused functio

Re: [Outreachy kernel] [PATCH 0/2] Staging: lustre: Remove unused functions

2015-10-22 Thread Arnd Bergmann
On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote: > These patches remove the definitions of functions which are not used. > > Shraddha Barke (2): > Staging: lustre: ptlrpc: Remove unused functions > Staging: lustre: obdclass: Remove unused functions > > .../lustre/lustre/obdclass/lp

[PATCH 1/2] Staging: lustre: ptlrpc: Remove unused functions

2015-10-22 Thread Shraddha Barke
Remove the functions which are not used anywhere throughout the kernel Signed-off-by: Shraddha Barke --- .../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 63 -- 1 file changed, 63 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/st

[PATCH 2/2] Staging: lustre: obdclass: Remove unused functions

2015-10-22 Thread Shraddha Barke
Remove the functions since they are not used anywhere throughout the kernel Signed-off-by: Shraddha Barke --- .../lustre/lustre/obdclass/lprocfs_status.c| 139 - 1 file changed, 139 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/

[PATCH 0/2] Staging: lustre: Remove unused functions

2015-10-22 Thread Shraddha Barke
These patches remove the definitions of functions which are not used. Shraddha Barke (2): Staging: lustre: ptlrpc: Remove unused functions Staging: lustre: obdclass: Remove unused functions .../lustre/lustre/obdclass/lprocfs_status.c| 139 - .../staging/lustre/lus