Re: [PATCH] staging/rdma/hfi1: Disable thermal polling before sensor initialization

On Wed, Nov 04, 2015 at 11:44:17PM -0500, jubin.j...@intel.com wrote: > From: jareer.h.abdel-qader This should be "Jareer Abdel-Qader ". regards, dan carpenter ___ devel mailing list

Re: [PATCH] staging/rdma/hfi1: Delete unnecessary checks before two function calls

On Thu, Nov 05, 2015 at 09:10:47AM +0100, SF Markus Elfring wrote: > diff --git a/drivers/staging/rdma/hfi1/file_ops.c > b/drivers/staging/rdma/hfi1/file_ops.c > index aae9826..204d1d0 100644 > --- a/drivers/staging/rdma/hfi1/file_ops.c > +++ b/drivers/staging/rdma/hfi1/file_ops.c > @@ -313,7

[PATCH V3] Revert "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

The source and destination pointers are misplaced. This will be like, ether_addr_copy(data, bssid + ADDR2); -> ether_addr_copy(bssid, data + ADDR2); and also to use ether_addr_copy, it has to be proved that src/dst address are properly aligned(2). I revert this as author agree to drop this patch.

[PATCH v2 2/2] staging: rtl8188eu: unused macros removed

IS_* and GET_CVID_* macros have not been used. Signed-off-by: Ivan Safonov --- Changes in v2: - All e-mail addresses of get_mainterner.pl script for this patch placed to the cc header. - Patch description corrected. drivers/staging/rtl8188eu/core/rtw_ioctl_set.c |

[PATCH v2 1/2] staging: rtl8188eu: rarely used macros replaced by their definitions

IS_* macros (except one) occur only once. Signed-off-by: Ivan Safonov --- Changes in v2: - All e-mail addresses of get_mainterner.pl script for this patch placed to the cc header. drivers/staging/rtl8188eu/hal/hal_com.c | 14 +++---

[PATCH] staging/rdma/hfi1: Delete unnecessary checks before two function calls

From: Markus Elfring Date: Thu, 5 Nov 2015 08:41:00 +0100 The functions "sc_return_credits" and "vfree" perform also input parameter validation. Thus the tests around their calls are not needed. This issue was detected by using the Coccinelle software.

RE: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

> Subject: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro > > This patch replaces bit shifting on 1 with the BIT(x) macro > > Signed-off-by: Sunny Kumar > --- Nak. The patch leaves the shift in. Mike ___ devel mailing

Re: [PATCH 2/3] staging: lustre: Delete an unnecessary variable initialisation in class_register_type()

Looks good. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] staging: lustre: Delete unnecessary checks before two function calls

I don't like these patches because relying on hidden sanity checks makes the code harder to read. I am CC'd on all these patches because of kernel-janitors and normally I ignore them but this is drivers/staging so I am invested in this code. Feel free to send them to other subsystems though.

Re: [PATCH 19/22] staging: comedi: adv_pci1710: fix counter 0 internal clock source

On 04/11/15 16:55, H Hartley Sweeten wrote: Counters 1 and 2 of the 8254 are cascaeded to create the 32-bit timer used for the analog input pacer trigger. The base clock to these counters is 10 MHz. Counter 0 is available to the user for general purpose use. This counter can use either an

[PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

This patch replaces bit shifting on 1 with the BIT(x) macro Signed-off-by: Sunny Kumar --- drivers/staging/rdma/hfi1/user_sdma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rdma/hfi1/user_sdma.c

[PATCH 2/3] staging: lustre: Delete an unnecessary variable initialisation in class_register_type()

From: Markus Elfring Date: Thu, 5 Nov 2015 10:55:16 +0100 The variable "rc" will be eventually set to an error return code in the class_register_type() function. Thus let us omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring

Re: [PATCH 14/22] staging: comedi: adv_pci1710: support external analog output reference

On 04/11/15 16:55, H Hartley Sweeten wrote: The analog outputs can use an external reference to create the D/A output range. Add an entry to the comedi_lrange table for it and modify the (*insn_write) to support it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

Re: [PATCH 15/22] staging: comedi: adv_pci1710: tidy up analog output subdev_flags

On 04/11/15 16:55, H Hartley Sweeten wrote: The SDF_GROUND and SDF_COMMON flags are not needed for the analog output subdevice. Just remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 3/3] staging: lustre: Less function calls in class_register_type() after error detection

From: Markus Elfring Date: Thu, 5 Nov 2015 12:48:58 +0100 The functions "kfree" and "kobject_put" were called in a few cases by the function "class_register_type" during error handling even if the passed variable contained a null pointer. This implementation

[PATCH 1/3] staging: lustre: Delete unnecessary checks before two function calls

From: Markus Elfring Date: Thu, 5 Nov 2015 10:18:45 +0100 The functions kobject_put() and kset_unregister() test whether their argument is NULL and then return immediately. Thus the tests around their calls are not needed. This issue was detected by using the

[PATCH 0/3] staging: lustre: Deletion of some unnecessary checks

From: Markus Elfring Date: Thu, 5 Nov 2015 13:03:33 +0100 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Delete unnecessary checks before two function calls Delete an

Re: [PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

On Thu, Nov 05, 2015 at 10:34:48AM +0300, Dan Carpenter wrote: > On Wed, Nov 04, 2015 at 09:06:08PM -0500, ira.we...@intel.com wrote: > > > +#define CCE_PCIE_CTRL_XMT_MARGIN_GEN1_GEN2_OVERWRITE_ENABLE_MASK 0x1ull > > There is absolutely no point to having a variable name which is nine >

Re: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

On Thu, Nov 05, 2015 at 05:28:03PM +0530, Sunny Kumar wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > > Signed-off-by: Sunny Kumar Also, NAK as has been covered in other responses. However, I wanted to add, similar to the hfi1_ioctl fix, we have follow on

RE: [PATCH 19/22] staging: comedi: adv_pci1710: fix counter 0 internal clock source

On Thursday, November 05, 2015 6:17 AM, Ian Abbott wrote: > On 04/11/15 16:55, H Hartley Sweeten wrote: >> Counters 1 and 2 of the 8254 are cascaeded to create the 32-bit timer >> used for the analog input pacer trigger. The base clock to these counters >> is 10 MHz. >> >> Counter 0 is available

Re: [PATCH 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

On Thu, Nov 05, 2015 at 10:56:27AM +0300, Dan Carpenter wrote: > On Wed, Nov 04, 2015 at 09:10:11PM -0500, ira.we...@intel.com wrote: > > From: Vennila Megavannan > > > > Add a module paramter to toggle prescan/Fast ECN Detection. > > > > In addition change the

RE: [PATCH 15/22] staging: comedi: adv_pci1710: tidy up analog output subdev_flags

On Thursday, November 05, 2015 6:01 AM, Ian Abbott wrote: > On 04/11/15 16:55, H Hartley Sweeten wrote: >> The SDF_GROUND and SDF_COMMON flags are not needed for the analog output >> subdevice. Just remove them. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Ian

RE: [PATCH 14/22] staging: comedi: adv_pci1710: support external analog output reference

On Thursday, November 05, 2015 5:43 AM, Ian Abbott wrote: > On 04/11/15 16:55, H Hartley Sweeten wrote: >> The analog outputs can use an external reference to create the D/A output >> range. Add an entry to the comedi_lrange table for it and modify the >> (*insn_write) to support it. >> >>

Re: [PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

On Thu, Nov 05, 2015 at 11:41:23AM -0500, ira.weiny wrote: > Is this an example where we should ignore the line lengths of checkpatch to > preserve the readability of the code? Honestly, you can't fight checkpatch, especially in staging. Rejecting patches is a drain on your emotions and your

Re: [PATCH] staging/rdma/hfi1: Disable thermal polling before sensor initialization

> This should be "Jareer Abdel-Qader ". ok. Will fix in V2. Thanks, Jubin John ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging/rdma/hfi1: Disable thermal polling before sensor initialization

From: Jareer Abdel-Qader During driver load the thermal sensor needs to be reset prior to initialization of the sensor. This prevents a possible sensor lock up which can cause the wrong temperature value to be reported. This fix leads to remove disabling thermal

[PATCH] staging/rdma/hfi1: Fix for opaportconfig ledon by not checking for portNum

From: Sebastian Sanchez opaportconfig ledon fails with error message due to port number being checked in the attr modifier. This change removes the check for the port number in AttrMod, so the P field is ignored. Reviewed-by: Easwar Hariharan

[PATCH] staging/rdma/hfi1: Remove spurious error messages

From: Ignacio Hernandez Changed the order in which diagnostics messages are printed, taking into account the cases where the errors are handled in rcv_hdrerr() and no further message is needed to report. Reviewed-by: Mark Debbage

[PATCH] staging/rdma/hfi1: Workaround to prevent corruption during packet delivery

From: Mark F. Brown Disabling one receive context when RX_DMA is receiving a packet can cause incorrect packet delivery for a subsequent packet on another receive context. This is resolved by doing the following: 1. Programming dummy tail address for every receive

[PATCH] staging/rdma/hfi1: Select only devices with active links

From: Dean Luick When looking for or validating a user device, only use devices that are currently active. Reviewed-by: Mitko Haralanov Signed-off-by: Dean Luick Signed-off-by: Jubin John ---

[PATCH] staging/rdma/hfi1: use one-shot LCB write

From: Dean Luick Use the one-shot LCB write implemented in the 8051 firmware. This speeds up 8051 LCB writes by 2x. Use old method for older firmwares. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick

[PATCH] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

From: Ira Weiny sdma_select_engine_vl only needs to protect itself from an invalid VL. Something higher up the stack should be warning the user when they try to use an SL which maps to an invalid VL. Reviewed-by: Dean Luick Reviewed-by: Mike Marciniszyn

[PATCH] staging: lustre: lnet: selftest: Move extern declarations to headers

This patch moves extern declarations to respective header files. This patch also removes extern keyword from function declarations since functions have the extern specifier by default. Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/lustre/lnet/selftest/console.c

Re: [PATCH] goldfish: add goldfish match node for dt driver probe

Hi yalin, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/yalin-wang/goldfish-add-goldfish-match-node-for-dt-driver-probe/20151106-132647 config: x86_64-allyesconfig (attached as .config) reproduce

[PATCH 33/73] staging: wilc1000: remove warnings line over 80 characters

From: Leo Kim This patch removes the warnings reported by checkpatch.pl for line over 80 characters. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH 27/73] staging: wilc1000: rename Ack member variable

From: Leo Kim This patch rename the Ack member variable to ack to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 10 +- 1 file changed, 5

[PATCH 34/73] staging: wilc1000: rename Dropped variable

From: Leo Kim This patch rename the Dropped variable to dropped to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 8 1 file changed, 4

[PATCH 29/73] staging: wilc1000: remove do-nothing else condition case.

From: Leo Kim This patch removes do-nothing else condition case. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 36/73] staging: wilc1000: rename Enable_TCP_ACK_Filter function

From: Leo Kim This patch rename the Enable_TCP_ACK_Filter function to enable_tcp_ack_filter to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4

[PATCH 32/73] staging: wilc1000: rename Ack_no variable

From: Leo Kim This patch rename the Ack_no variable to ack_no to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 11 +++ 1 file changed, 7

[PATCH 28/73] staging: wilc1000: rename Session_index member variable

From: Leo Kim This patch rename the Ack Session_index variable to session_index to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file changed, 2

[PATCH 35/73] staging: wilc1000: rename EnableTCPAckFilter variable

From: Leo Kim This patch rename the EnableTCPAckFilter variable to enabled to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 6 +++--- 1 file changed, 3

[PATCH 30/73] staging: wilc1000: rename Total_Length variable

From: Leo Kim This patch rename the Total_Length variable to total_length to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 7 --- 1 file changed, 4

[PATCH 41/73] staging: wilc1000: fixes else should follow close brace '}'

From: Leo Kim This patch fixes the error reported by checkpatch.pl for else should follow close brace '}' Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 10 +++--- 1 file changed, 3

[PATCH 40/73] staging: wilc1000: rename pu32TxqCount in wilc_wlan_handle_txq function

From: Leo Kim This patch rename pu32TxqCount to txq_count that is second argument of wilc_wlan_handle_txq function to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++--

[PATCH 44/73] staging: wilc1000: rename bValue in set_machw_change_vir_if function

From: Leo Kim This patch rename bValue to value that is second argument of set_machw_change_vir_if function to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-

[PATCH 31/73] staging: wilc1000: rename Data_offset variable

From: Leo Kim This patch rename the Data_offset variable to data_offset to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 6 +++--- 1 file changed, 3

[PATCH 37/73] staging: wilc1000: rename is_TCP_ACK_Filter_Enabled function

From: Leo Kim This patch rename the is_TCP_ACK_Filter_Enabled function to is_tcp_ack_filter_enabled to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++--

[PATCH 73/73] staging: wilc1000: rename u8WidCnt of handle_cfg_param function

From: Leo Kim This patch renames u8WidCnt variable of handle_cfg_param function to wid_cnt to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 184

[PATCH v2 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

This patch replaces bit shifting on 1 with the BIT(x) macro Signed-off-by: Sunny Kumar --- drivers/staging/rdma/hfi1/user_sdma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rdma/hfi1/user_sdma.c

[PATCH] Staging: gdm72xx: Fix sparse warning

Fix following sparse warnings by adding new structure for user-space data (struct data_us) in wm_ioctl.h: drivers/staging/gdm72xx/gdm_wimax.c:381:37: warning: incorrect type in argument 1 (different address spaces) drivers/staging/gdm72xx/gdm_wimax.c:381:37:expected void [noderef] *to

Re: [PATCH v2 02/11] fsl-mc: msi: Added FSL-MC-specific member to the msi_desc's union

On 2015/10/31 3:43, J. German Rivera wrote: > FSL-MC is a bus type different from PCI and platform, so it needs > its own member in the msi_desc's union. > > Signed-off-by: J. German Rivera > --- > Changes in v2: > - Addressed comment from Jiang Liu > * Added a

[PATCH 24/73] staging: wilc1000: rename add_TCP_track_session function

From: Leo Kim This patch rename the add_TCP_track_session function to add_tcp_session to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file

[PATCH 23/73] staging: wilc1000: rename Init_TCP_tracking function

From: Leo Kim This patch rename the Init_TCP_tracking function to init_tcp_tracking to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file

[PATCH 26/73] staging: wilc1000: rename add_TCP_Pending_Ack function

From: Leo Kim This patch rename the add_TCP_Pending_Ack function to add_tcp_pending_ack to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- 1 file

[PATCH 25/73] staging: wilc1000: rename Update_TCP_track_session function

From: Leo Kim This patch rename the Update_TCP_track_session function to update_tcp_session to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file

[PATCH 22/73] staging: wilc1000: rename Pending_Acks variable

From: Leo Kim This patch rename the Pending_Acks variable to pending_acks to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 18 +- 1 file

[PATCH 18/73] staging: wilc1000: rename Acks_keep_track_info variable

From: Leo Kim This patch rename the Acks_keep_track_info variable to ack_session_info to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 18

[PATCH 19/73] staging: wilc1000: rename Pending_Acks_info variable

From: Leo Kim This patch rename the Pending_Acks_info variable to pending_acks_info to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 17 +

[PATCH 21/73] staging: wilc1000: rename Opened_TCP_session variable

From: Leo Kim This patch rename the Opened_TCP_session variable to tcp_session to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 20 ++-- 1

[PATCH 13/73] staging: wilc1000: rename Ack_session_info struct variable

From: Leo Kim This patch rename Ack_session_info struct variable to ack_session_info to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 10 +- 1 file

[PATCH 14/73] staging: wilc1000: rename Ack_seq_num of struct ack_session_info

From: Leo Kim This patch rename Ack_seq_num of struct ack_session_info to seq_num to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 6 +++--- 1 file

[PATCH 12/73] staging: wilc1000: rename Statisitcs_DroppedAcks variable

From: Leo Kim This patch rename Statisitcs_DroppedAcks variable to dropped_acks to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file changed, 2

[PATCH 20/73] staging: wilc1000: rename PendingAcks_arrBase variable

From: Leo Kim This patch rename the PendingAcks_arrBase variable to pending_base to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 18 +- 1

[PATCH 15/73] staging: wilc1000: rename Bigger_Ack_num of struct ack_session_info

From: Leo Kim This patch rename Bigger_Ack_num of struct ack_session_info to bigger_ack_num to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 10 +-

[PATCH 17/73] staging: wilc1000: rename Session_index of struct pending_acks_info

From: Leo Kim This patch rename Session_index of struct pending_acks_info to session_index to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 6 +++--- 1

[PATCH 16/73] staging: wilc1000: remove typedef of struct Pending_Acks_info_t

From: Leo Kim This patch remove typedef of struct Pending_Acks_info_t. And, rename the Pending_Acks_info_t to pending_acks_info. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 6 +++--- 1

Re: [PATCH v2 01/11] irqdomain: Added domain bus token DOMAIN_BUS_FSL_MC_MSI

On 2015/10/31 3:43, J. German Rivera wrote: > Since an FSL-MC bus is a new bus type that is neither PCI nor > PLATFORM, we need a new domain bus token to disambiguate the > IRQ domain for FSL-MC MSIs. > > Signed-off-by: J. German Rivera > --- > Changes in v2: none >

[PATCH 10/73] staging: wilc1000: replace explicit NULL comparisons with !

From: Leo Kim This patch replace explicit NULL comparison with ! operator to simplify code. Reported by checkpatch.pl for Comparison to NULL could be written "!XXX" or "XXX". Signed-off-by: Leo Kim Signed-off-by: Glen Lee ---

[PATCH 07/73] staging: wilc1000: fixes add blank line after function declaration

From: Leo Kim This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c |

[PATCH 05/73] staging: wilc1000: fixes please don't use multiple blank lines

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for Please don't use multiple blank lines. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 48

[PATCH 06/73] staging: wilc1000: fixes blank lines aren't necessary brace

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for Blank lines aren't necessary after an open brace '{' and Blank lines aren't necessary before a close brace '}'. Signed-off-by: Leo Kim Signed-off-by: Glen Lee ---

[PATCH 09/73] staging: wilc1000: rename genuChipPSstate variable

From: Leo Kim This patch rename genuChipPSstate variable to chip_ps_state to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 20 ++-- 1 file

[PATCH 04/73] staging: wilc1000: wilc_wlan.c: remove over-commenting

From: Leo Kim There are over-commenting in the wilc_wlan.c file and most of them are not helpful to explain what the code does and generate 80 ending line over warnings. So, all of comments are removed in this patch and the comments will later be added if necessary with the

[PATCH 03/73] staging: wilc1000: fixes that open brace { should be on the previous line

From: Leo Kim This patch fixes the error reported by checkpatch.pl for that open brace { should be on the previous line. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 3 +-- 1 file changed,

[PATCH 02/73] staging: wilc1000: fixes a struct allocation to match coding standards

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for prefer kmalloc(sizeof(*tx_data)...) over kmalloc(sizeof(struct tx_complete_data)...) Signed-off-by: Leo Kim Signed-off-by: Glen Lee ---

[PATCH 11/73] staging: wilc1000: rename Statisitcs_totalAcks variable

From: Leo Kim This patch rename Statisitcs_totalAcks variable to total_acks to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file changed, 2

[PATCH 08/73] staging: wilc1000: fixes missing a blank line after declarations

From: Leo Kim This patch fixes the warnings reported by checkpatch.pl for Missing a blank line after declarations. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 2 ++ 1 file changed, 2

[PATCH 01/73] staging: wilc1000: fixes alignment should match open parenthesis

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for alignment should match open parenthesis Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 11 ++- 1 file changed,

[PATCH 52/73] staging: wilc1000: rename tcp_PendingAck_index of struct txq_entry_t

From: Leo Kim This patch renames tcp_PendingAck_index of struct txq_entry_t to index to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 12 ++--

[PATCH 56/73] staging: wilc1000: replace numeric type to kernel error type

From: Leo Kim This patch replaces numeric type to generic type by kernel style. -5 -> -EIO -105 -> -ENOBUFS Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 24 1

[PATCH 55/73] staging: wilc1000: remove warnings line over 80 characters

From: Leo Kim This patch removes the warnings reported by checkpatch.pl for line over 80 characters. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 50 1

[PATCH 57/73] staging: wilc1000: wilc_wlan.h: alignment defines

From: Leo Kim This patch fixes alignment of defines. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.h | 292 ++- 1 file changed, 148 insertions(+), 144

[PATCH 54/73] staging: wilc1000: fixes possible unnecessary 'out of memory' message

From: Leo Kim This patch fixes the warning reported by checkpatch.pl for possible unnecessary 'out of memory' message Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 1 - 1 file changed, 1

[PATCH 58/73] staging: wilc1000: fixes prefer using the BIT macro

From: Leo Kim This patch fixes the warning reported by checkpatch.pl for prefer using the BIT macro. And, removes unnecessary bit increase defines. Signed-off-by: Leo Kim Signed-off-by: Glen Lee ---

[PATCH 51/73] staging: wilc1000: fixes alignment should match open parenthesis

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for alignment should match open parenthesis. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1 file changed, 1

[PATCH 50/73] staging: wilc1000: wilc_wlan.c: remove unused pointer variables

From: Leo Kim This patch removes unused two pointer variable. - Free_head - Alloc_head It's pointer variables unused inside code. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 3 --- 1

[PATCH 53/73] staging: wilc1000: fixes space prohibited between function name and open parenthesis

From: Leo Kim This patch fixes the warning reported by checkpatch.pl for space prohibited between function name and open parenthesis '(' Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1

[PATCH 48/73] staging: wilc1000: rename drvHandler in wilc_wlan_cfg_set function

From: Leo Kim This patch rename drvHandler to drv_handler that is seventh argument of wilc_wlan_cfg_set function to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++--

[PATCH 47/73] staging: wilc1000: rename drvHandler in wilc_wlan_cfg_commit function

From: Leo Kim This patch rename drvHandler to drv_handler that is third argument of wilc_wlan_cfg_commit function to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1

[PATCH 39/73] staging: wilc1000: remove unused argument of chip_sleep_manually function

From: Leo Kim This patch removes u32SleepTime that is second argument of chip_sleep_manually function because it is not used in this function. Remove argument in the function call also. Signed-off-by: Leo Kim Signed-off-by: Glen Lee

[PATCH 38/73] staging: wilc1000: fixes a struct allocation to match coding standards

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for prefer kmalloc(sizeof(*tqe)...) over kmalloc(sizeof(struct txq_entry_t)...) Signed-off-by: Leo Kim Signed-off-by: Glen Lee ---

[PATCH 42/73] staging: wilc1000: rename pBSSID variable

From: Leo Kim This patch rename the pBSSID variable to bssid to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 43/73] staging: wilc1000: fixes a struct allocation to match coding standards

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for prefer kmalloc(sizeof(*rqe)...) over kmalloc(sizeof(struct rxq_entry_t)...) Signed-off-by: Leo Kim Signed-off-by: Glen Lee ---

[PATCH 49/73] staging: wilc1000: rename drvHandler in wilc_wlan_cfg_get function

From: Leo Kim This patch rename drvHandler to drv_handler that is fifth argument of wilc_wlan_cfg_get function to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++--

[PATCH 46/73] staging: wilc1000: fixes braces {} are not necessary for any arm of this statement

From: Leo Kim This patch fixes the warning reported by checkpatch.pl for braces {} are not necessary for any arm of this statement Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 5 ++--- 1

[PATCH 45/73] staging: wilc1000: fixes braces {} should be used on all arms of this statement

From: Leo Kim This patch fixes the error reported by checkpatch.pl for braces {} should be used on all arms of this statement Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file

[PATCH 60/73] staging: wilc1000: remove typedef from wilc_cfg_frame_t

From: Leo Kim This patch removes typedef from the struct wilc_cfg_frame_t and renames it to wilc_cfg_frame. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++--

[PATCH 70/73] staging: wilc1000: rename Handle_GetMacAddress function

From: Leo Kim This patch renames Handle_GetMacAddress function to handle_get_mac_address to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 7 --- 1 file changed, 4

[PATCH 69/73] staging: wilc1000: rename Handle_SetMacAddress function

From: Leo Kim This patch renames Handle_SetMacAddress function to handle_set_mac_address to avoid camelcase. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 7 --- 1 file changed, 4

  1   2   >