Re: [PATCH] Staging: comedi: comedi.h Fixed multiple coding style issues

On 18/11/15 19:23, Daniel H. Hemmingsen wrote: Fixed multiple comments and spacing coding style issues. Signed-off-by: Daniel H. Hemmingsen --- drivers/staging/comedi/comedi.h | 307 +++- 1 file changed, 177 insertions(+), 130

[PATCH] staging: goldfish: (coding style) Add spaces around the "+" to conform to checkpatch

Added a space around the "+" at: "reg_base+addr2" to clear up a checkpatch check. Signed-off-by: Christian Colic --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: goldfish: (coding style) Rewrite comparisons to NULL as "!data->reg_base"

Rewrite comparisons to NULL "data->reg_base == NULL" as "!data->reg_base" to conform to checkpatch. Signed-off-by: Christian Colic --- drivers/staging/goldfish/goldfish_audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 06/28] staging: most: fix mbo leak

On Thu, 19 Nov 2015 10:41:24 +0530 Sudip Mukherjee wrote: > On Wed, Nov 18, 2015 at 01:43:30PM +0100, Christian Gromm wrote: > > This patch fixes a potential MBO leak in case function aim_read() > > exits right after the MBO has been fetched from kfifo and before > >

Re: [PATCH 1/2] Drivers: hv: vmbus: Fix a Host signaling bug

"K. Y. Srinivasan" writes: > Currently we have two policies for deciding when to signal the host: > One based on the ring buffer state and the other based on what the > VMBUS client driver wants to do. Consider the case when the client > wants to explicitly control when to

Re: [PATCH 01/27] mtd: nand: fix drivers abusing mtd->priv

On Mon, Nov 16, 2015 at 02:37:34PM +0100, Boris Brezillon wrote: > The ->priv field of the mtd_info object attached to a nand_chip device > should point to the nand_chip device. The pxa and cafe drivers are > assigning this field their own private structure, which works fine as long > as the

RE: [PATCH] Staging: comedi: comedi.h Fixed multiple coding style issues

On Thursday, November 19, 2015 3:21 AM, Ian Abbott wrote: > On 18/11/15 19:23, Daniel H. Hemmingsen wrote: >> Fixed multiple comments and spacing coding style issues. >> >> Signed-off-by: Daniel H. Hemmingsen >> --- >> drivers/staging/comedi/comedi.h | 307 >>

Re: [PATCH 02/27] mtd: nand: add an mtd_to_nand() helper

On Mon, Nov 16, 2015 at 02:37:35PM +0100, Boris Brezillon wrote: > Some drivers are retrieving the nand_chip pointer using the container_of > macro on a struct wrapping both the nand_chip and the mtd_info struct while > the standard way of retrieving this pointer is through mtd->priv. > Provide an

Re: [PATCH 5/9] staging/rdma/hfi1: Add function stubs for TID caching

On Thu, Nov 12, 2015 at 07:58:54AM +0200, Or Gerlitz wrote: > On Sat, Oct 31, 2015 at 12:41 AM, wrote: > > From: Mitko Haralanov > > > > Add mmu notify helper functions and TID caching function stubs in > > preparation > > for the TID caching

Re: [PATCH 18/18] staging/rdma/hfi1: Workaround CONFIG_SDMA_VERBOSITY timing issue

On Fri, Nov 13, 2015 at 07:37:16PM -0800, Jubin John wrote: > Enabling CONFIG_SDMA_VERBOSITY exposes a timing issue in the > driver/DC firmware. Removing the CCE_INT_* CSR reads from > sdma_dumpstate and a sdma_dumpstate call from the sdma_sendctrl() > works around the issue That sounds like a

Re: [PATCH 07/18] staging/rdma/hfi1: Extend quiet timeout

On Fri, Nov 13, 2015 at 07:37:05PM -0800, Jubin John wrote: > From: Dean Luick > > The longest quiet timeout is now 6s. Extend the driver wait. To what? And why? What does this fix? ___ devel mailing list

Re: [PATCH 3/4] staging: wilc1000: rename index to tcp_pending_ack_idx

On 2015년 11월 20일 00:45, Greg KH wrote: On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote: On 2015년 11월 19일 15:23, Dan Carpenter wrote: On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote: This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since this name

Re: [PATCH 01/18] staging/rdma/hfi1: Support alternate firmware names

On Fri, Nov 13, 2015 at 07:36:59PM -0800, Jubin John wrote: > From: Dean Luick > > Add support for an automatic fallback for firmware names. Why? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 02/18] staging/rdma/hfi1: Decode CNP opcode

On Fri, Nov 13, 2015 at 07:37:00PM -0800, Jubin John wrote: > From: Dean Luick > > Add CNP opcode decode Why? ___ devel mailing list de...@linuxdriverproject.org

[PATCH V2 0/2] Drivers: hv: vmbus: Fix a couple of bugs

Fix a couple of bugs. In this version I have addressed review comments from Vitaly. Andrey Smetanin (1): drivers/hv: correct tsc page sequence invalid value K. Y. Srinivasan (1): Drivers: hv: vmbus: Fix a Host signaling bug drivers/hv/channel.c | 18 ++ drivers/hv/hv.c

[PATCH V2 1/2] Drivers: hv: vmbus: Fix a Host signaling bug

Currently we have two policies for deciding when to signal the host: One based on the ring buffer state and the other based on what the VMBUS client driver wants to do. Consider the case when the client wants to explicitly control when to signal the host. In this case, if the client were to defer

[PATCH V2 2/2] drivers/hv: correct tsc page sequence invalid value

From: Andrey Smetanin Hypervisor Top Level Functional Specification v3/4 says that TSC page sequence value = -1(0x) is used to indicate that TSC page no longer reliable source of reference timer. Unfortunately, we found that Windows Hyper-V guest side

Re: [PATCH v3 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

On Mon, Nov 09, 2015 at 06:34:44PM -0500, ira.we...@intel.com wrote: > From: Vennila Megavannan > > Add a module paramter to toggle prescan/Fast ECN Detection and remove the > Kconfig option which used to control this. Ick, no, not a module parameter, that's horrid

Re: [PATCH 06/18] staging/rdma/hfi: Add one-time LCB reset

On Fri, Nov 13, 2015 at 07:37:04PM -0800, Jubin John wrote: > From: Dean Luick > > Add one-time LCB reset on driver load to pre-emptively work > around any LCB power cycle issues. You dropped a character in your Subject line :(

Re: [PATCH 09/18] staging/rdma/hfi1: Correctly limit VLs against SDMA engines

On Fri, Nov 13, 2015 at 07:37:07PM -0800, Jubin John wrote: > From: Dean Luick > > Correctly reduce the number of VLs when limited by the number > of SDMA engines. why? What does this "solve"? ___ devel mailing list

Re: [PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode

On Fri, Nov 13, 2015 at 07:37:01PM -0800, Jubin John wrote: > From: Dean Luick > > Add aeth name syndrome decode Again, why? Come on, be more descriptive about why you are making the change, not what the change is, we can all read code. Please fix this whole series up

Re: [PATCH 05/18] staging/rdma/hfi1: Clean up comments

On Fri, Nov 13, 2015 at 07:37:03PM -0800, Jubin John wrote: > From: Edward Mascarenhas > > Clean up comments In what way? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v3] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

On Mon, Nov 16, 2015 at 05:03:49PM -0500, ira.we...@intel.com wrote: > From: Dean Luick > > Correctly set half-swing for integrated devices. A0 needs all fields set for > CcePcieCtrl. B0 and later only need a few fields set. > > Reviewed-by: Stuart Summers

Re: [PATCH] staging: speakup: (coding sytle) remove unnecessary space after a cast

Hi Christian, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.4-rc1 next-20151119] url: https://github.com/0day-ci/linux/commits/Christian-Colic/staging-speakup-coding-sytle-remove-unnecessary-space-after-a-cast/20151120-012835 config: i386-randconfig-a0

Re: [PATCH 03/27] mtd: nand: update examples in the documentation to use mtd_to_nand()

On Mon, Nov 16, 2015 at 02:37:36PM +0100, Boris Brezillon wrote: > mtd_to_nand() has been introduced to hide accesses to mtd->priv. > All NAND controller drivers should use it instead of directly accessing > the ->priv field. > > Signed-off-by: Boris Brezillon

Re: HFI1 code duplication todo

On Thu, Nov 12, 2015 at 04:13:18PM -0500, Dennis Dalessandro wrote: The major todo for the hfi1 driver in staging is getting rid of the verbs code duplication between ipath, qib, and now hfi1. The ipath driver has been deprecated and is going to be deleted soon. So that leaves qib and hfi. To

[PATCH] staging: speakup: (coding style) Rewrite comparisons to NULL

linux-ker...@vger.kernel.org Bcc: Subject: [PATCH] staging: speakup: (coding style) Rewrite comparisons to NULL Reply-To: Rewrite comparisons to NULL so they dont show any checkpatch errors anymore. "vc_cons[i].d != NULL" => "vc_cons[i].d" Signed-off-by: Christian Colic

[PATCH] staging: speakup: (coding style) use braces {} on all arms of if-statement

linux-ker...@vger.kernel.org Bcc: Subject: [PATCH] staging: speakup: (coding style) use braces {} on all arms of if-statement Reply-To: Fix checkpatch error: "braces {} should be used on all arms of this statement" by adding the necessary braces around the "if". Signed-off-by: Christian Colic

[PATCH] staging: speakup: (coding sytle) remove unnecessary space after a cast

Fix checkpatch check. Remove an unnecessary space after a cast. Signed-off-by: Christian Colic --- drivers/staging/speakup/devsynth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/devsynth.c

[PATCH] staging: lustre: lustre: fld: Removed a blank line

Removed a blank line after the open brace to remove the check detected by the checkpatch.pl. CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Anjali Menon --- drivers/staging/lustre/lustre/fld/fld_cache.c | 1 - 1 file changed, 1 deletion(-)

[PATCH] staging: speakup: (coding style) Rewrite comparisons to NULL

Rewrite comparisons to NULL so they dont show any checkpatch errors anymore. "vc_cons[i].d != NULL" => "vc_cons[i].d" Signed-off-by: Christian Colic --- drivers/staging/speakup/buffers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Dead or Alive

FROM THE DESK OF MR. WALI IBRAHIM INTERNATIONAL MONETARY FUND AGENCY INTERNATIONAL OPERATION DEPT VICTORIA ISLAND LAGOS-NIGERIA. RE-OUTSTANDING PAYMENT This is to inform you of your long overdue Payment outstanding our Banking records. I saw your name in the Central Computer among list of

[PATCH 2/6] staging: wilc1000: return linux error value

Return proper linux error value -ETIMEDOUT instead of -1. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c

[PATCH 3/6] staging: wilc1000: wilc_wlan.c: remove hif_func of wilc_wlan_dev_t

hif_func of wilc_wlan_dev_t is duplicate because we have same struct wilc_hif_func ops of struct wilc which is available in wilc_wlan.c. Rename ops of struct wilc with hif_func and remove hif_func of wilc_wlan_dev_t, and use wilc->hif_func instead of g_wlan.hif_func in all functions.

[PATCH 4/6] staging: wilc1000: remove io_type of wilc_wlan_dev_t

io_type of wilc_wlan_dev_t is unneeded, we can use io_type of struct wilc. Remove io_type of wilc_wlan_dev_t and use io_type of wilc. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-)

[PATCH 5/6] staging: wilc1000: remove unused varialbe tx_buffer_offset

This patch removes unused variable tx_buffer_offset of wilc_wlan_dev_t. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index

[PATCH 1/6] staging: wilc1000: remove unused variable

wilc_sdio_func is not used anymore so just delete it. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan_sdio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_sdio.c b/drivers/staging/wilc1000/linux_wlan_sdio.c index

[PATCH 6/6] staging: wilc1000: move all of wilc_wlan_dev_t to struct wilc

linux_wlan.c and wilc_wlan.c was separated into two part at the beginning to support various platforms. They are in charge of send/receive control and packet data, so they will be merged into one file wlan.c later. First of all, wilc_wlan_dev_t which is used as global variable of wilc_wlan.c will

[PATCH v2 12/28] staging: most: move initialization of pointer

This patch makes function store_add_link initialize the pointer to an AIM right before the channel is probed. It is needed, the AIM may already call most_start_channel while probe_channel is still running. At this point the pointer to the AIM must not be NULL. Signed-off-by: Christian Gromm

[PATCH] staging: speakup: (coding style) Add braces around all arms of if-statement

Fix checkpatch error: "braces {} should be used on all arms of this statement" by adding the necessary braces around the "if". Signed-off-by: Christian Colic --- drivers/staging/speakup/devsynth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 27/28] staging: most: add statistics for dropped packets

This patch adds a counter for dropped packets. It needed for statistical analysis. Signed-off-by: Christian Gromm --- v2: change type of skb_len to unsigned int. This has been demanded by Dan Carpenter. drivers/staging/most/aim-network/networking.c | 11

[PATCH v2 26/28] staging: most: rearrange function aim_write

This patch straightens and rearranges the code of function aim_write() of module aim-cdev. Signed-off-by: Christian Gromm --- v2: Implemented and followed advice of Dan Carpenter to keep common error handling at the end of the function.

Re: [PATCH] staging: speakup: (coding style) use braces {} on all arms of if-statement

On Thu, Nov 19, 2015 at 01:13:50PM +0100, Christian Colic wrote: > linux-ker...@vger.kernel.org > Bcc: > Subject: [PATCH] staging: speakup: (coding style) use braces {} on all arms > of if-statement > Reply-To: Why are these lines in the body of your patch? Please fix up and resend these

Re: [PATCH 3/4] staging: wilc1000: rename index to tcp_pending_ack_idx

On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote: > > > On 2015년 11월 19일 15:23, Dan Carpenter wrote: > >On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote: > >>This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx > >>since > >>this name could be confused index

[PATCH] staging: speakup: (coding style) Add spaces around operands (checkpatch checks)

Fix checkpatch check: CHECK: spaces preferred around that '-' (ctx:VxV) Add spaces around operands to fix these warnings. Signed-off-by: Christian Colic --- drivers/staging/speakup/keyhelp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[PATCH 0/2] staging: comedi: s526: add counter register macros

Add macros to describe the counter mode and counter control/status registers. In patch 1, the macros for the counter mode register replace the use of bitfield structure and union types. 1) staging: comedi: s526: replace counter mode bitfield struct 2) staging: comedi: s526: add macros for

[PATCH 2/2] staging: comedi: s526: add macros for counter control reg values

The driver writes a couple of literal values to the counter control/status register, 0x8000 to reset the counter, and 0x4000 to load the counter from preload register 0. Add a bunch of macros to define these values and other values for the register, based on the Sensoray 526 manual.

[PATCH 1/2] staging: comedi: s526: replace counter mode bitfield struct

The driver uses `struct counter_mode_register_t` to describe the 16-bit counter mode register as a sequence of bitfield members. The struct appears as the type of one of the members of `union cmReg`, the other member of which is of type `unsigned short`, so the driver can manipulate the register

RE: [PATCH 1/8] staging: comedi: rearrange comedi_write() code

On Wednesday, November 18, 2015 10:55 AM, Ian Abbott wrote: > Rearrange the code in `comedi_write()` to reduce the amount of > indentation. The code never reiterates the `while` loop once `count` > has become non-zero, so we can check that in the `while` condition to > save an indentation level.

[PATCH] staging: android: ion: Fixing NULL comparison style

Using checkpatch.pl fixed the check. CHECK: Comparison to NULL could be written "!data" Signed-off-by: Anjali Menon --- drivers/staging/android/ion/compat_ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] staging: speakup: (coding sytle) remove unnecessary space after a cast

On Thu, Nov 19, 2015 at 01:20:09PM +0100, Christian Colic wrote: > Fix checkpatch check. > Remove an unnecessary space after a cast. > > Signed-off-by: Christian Colic > --- > drivers/staging/speakup/devsynth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] staging: speakup: (coding style) Add spaces around operands (checkpatch checks)

Hi al, Looks good and silences the checkpatch warnings. Christian, There are more checkpatch warnings in this file. Could you fix them as well? Reviewed-by: Luis de Bethencourt On Thu, Nov 19, 2015 at 02:40:59PM +0100, Christian Colic wrote: > Fix checkpatch check:

RE: [PATCH 0/8] staging: comedi: some comedi_write() changes

On Wednesday, November 18, 2015 10:55 AM, Ian Abbott wrote: > Tidy up the "write" file operation handler, `comedi_write()` a bit and > improve the error handling. > > 1) staging: comedi: rearrange comedi_write() code > 2) staging: comedi: do extra checks for becoming non-busy for "write" > 3)

RE: [PATCH 0/2] staging: comedi: s526: add counter register macros

On Thursday, November 19, 2015 7:49 AM, Ian Abbott wrote: > Add macros to describe the counter mode and counter control/status > registers. In patch 1, the macros for the counter mode register replace > the use of bitfield structure and union types. > > 1) staging: comedi: s526: replace counter

Re: [PATCH] staging: android: ion: Fixing NULL comparison style

On Thu, Nov 19, 2015 at 10:29:53PM +0530, Anjali Menon wrote: > Using checkpatch.pl fixed the check. > > CHECK: Comparison to NULL could be written "!data" > > Signed-off-by: Anjali Menon > --- > drivers/staging/android/ion/compat_ion.c | 6 +++--- > 1 file changed,