[PATCH] Staging: vt6656: Fixed multiple commenting codig style issues.

2015-12-30 Thread maomao xu
Fixed multiple comment blocks that didn't comply with the kernels coding style. Signed-off-by: maomao xu --- drivers/staging/vt6656/main_usb.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb

Re: [PATCH v2 1/2] staging: wilc1000: fix always return 0 error

2015-12-30 Thread Souptick Joarder
HI Glen, On Thu, Dec 24, 2015 at 11:32 AM, Glen Lee wrote: > This patch fixes a bug that return always 0 so it fails every time. > > Fixes: c1af9db78950 ("staging: wilc1000: call linux_sdio_init instead of > io_init") > Signed-off-by: Glen Lee > --- > Changes in v2: separate v1 patch into two p

Re: [PATCH] staging: rtl8192e: Fix line over 80 Characters.

2015-12-30 Thread Greg KH
On Wed, Dec 30, 2015 at 11:38:09PM +0530, Vignesh D wrote: > Fix the comment in line 35, having more than 80 characters in single > line > > Signed-off-by: Vignesh D I need a "real" name here please. > --- > drivers/staging/rtl8192e/dot11d.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 delet

[PATCH] staging: rtl8192e: Fix line over 80 Characters.

2015-12-30 Thread Vignesh D
Fix the comment in line 35, having more than 80 characters in single line Signed-off-by: Vignesh D --- drivers/staging/rtl8192e/dot11d.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h index 2c19054..c

Re: rtlwifi: rtl_pci: Fix kernel panic

2015-12-30 Thread Kalle Valo
> In commit 38506ecefab9 (rtlwifi: rtl_pci: Start modification for new > drivers), a bug was introduced that causes a NULL pointer dereference. > As this bug only affects the infrequently used RTL8192EE and only under > low-memory conditions, it has taken a long time for the bug to show up. > > T

Re: [1/8] rtlwifi: rtl8723be: Fix module parameter initialization

2015-12-30 Thread Kalle Valo
> This driver has a number of errors in the module initialization. These > include the following: > > Parameter msi_support is stored in two places - one is removed. > Paramters sw_crypto and disable_watchdog were never stored in the final > locations, nor were they initialized properly. > > Sig

Re: [PATCH 17/20] staging: wilc1000: fix return type of host_int_get_ipaddress

2015-12-30 Thread Souptick Joarder
Hi Lim, On Wed, Dec 30, 2015 at 5:45 PM, Chaehyun Lim wrote: > This patch changes return type of host_int_get_ipaddress from s32 to > int. The result variable gets return value from wilc_mq_send that has > data type of int. It should be changed return type of this function as > well as data type

[PATCH 20/20] staging: wilc1000: move static declaration of host_int_get_ipaddress

2015-12-30 Thread Chaehyun Lim
This patch moves static function declaration to front part of host_interface.c file. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc10

[PATCH 18/20] staging: wilc1000: remove argument hif_drv in host_int_get_ipaddress

2015-12-30 Thread Chaehyun Lim
This patch removes hif_drv argument of host_int_get_ipaddress. There is no need to pass hif_drv in this function because hif_drv is a member of vif. It is removed struct host_if_drv and use hif_drv of vif. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 12 ---

[PATCH 16/20] staging: wilc1000: remove return statement

2015-12-30 Thread Chaehyun Lim
This patch removes return statement that is always returned 0. wilc_setup_ipaddress can not run to the end due to return statement. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interfa

[PATCH 09/20] staging: wilc1000: rename pstrPowerMgmtParam in wilc_set_power_mgmt

2015-12-30 Thread Chaehyun Lim
This patch renames pstrPowerMgmtParam to pwr_mgmt_info to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/hos

[PATCH 10/20] staging: wilc1000: fix return type of wilc_setup_multicast_filter

2015-12-30 Thread Chaehyun Lim
This patch changes return type of wilc_setup_multicast_filter from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/s

[PATCH 17/20] staging: wilc1000: fix return type of host_int_get_ipaddress

2015-12-30 Thread Chaehyun Lim
This patch changes return type of host_int_get_ipaddress from s32 to int. The result variable gets return value from wilc_mq_send that has data type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/

[PATCH 11/20] staging: wilc1000: rename bIsEnabled in wilc_setup_multicast_filter

2015-12-30 Thread Chaehyun Lim
This patch renames bIsEnabled to enabled to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interfac

[PATCH 19/20] staging: wilc1000: rename u16ipadd in host_int_get_ipaddress

2015-12-30 Thread Chaehyun Lim
This patch renames u16ipadd to ip_addr to remove u16 prefix. There is no need to use this prefix to show data type of this argument. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 05/20] staging: wilc1000: rename u32SessionID in wilc_listen_state_expired

2015-12-30 Thread Chaehyun Lim
This patch renames u32SessionID to session_id to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_int

[PATCH 13/20] staging: wilc1000: rename pstrMulticastFilterParam in wilc_setup_multicast_filter

2015-12-30 Thread Chaehyun Lim
This patch renames pstrMulticastFilterParam to multicast_filter_param to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagi

[PATCH 15/20] staging: wilc1000: rename u16ipadd in wilc_setup_ipaddress

2015-12-30 Thread Chaehyun Lim
This patch renames u16ipadd to ip_addr to remove u16 prefix. There is no need to use prefix to show data type of this argument. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+),

[PATCH 14/20] staging: wilc1000: fix return type of wilc_setup_ipaddress

2015-12-30 Thread Chaehyun Lim
This patch changes return type of wilc_setup_ipaddress from s32 to int. The result variable gets return value from wilc_mq_send that has data type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/wi

[PATCH 12/20] staging: wilc1000: rename u32count in wilc_setup_multicast_filter

2015-12-30 Thread Chaehyun Lim
This patch renames u32count to count to remove u32 prefix. There is no need to use this prefix to show data type of this argument. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+

[PATCH 08/20] staging: wilc1000: rename u32Timeout in wilc_set_power_mgmt

2015-12-30 Thread Chaehyun Lim
This patch renames u32Timeout to timeout to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interfac

[PATCH 07/20] staging: wilc1000: rename bIsEnabled in wilc_set_power_mgmt

2015-12-30 Thread Chaehyun Lim
This patch renames bIsEnabled to enabled to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interf

[PATCH 04/20] staging: wilc1000: fix return type of wilc_listen_state_expired

2015-12-30 Thread Chaehyun Lim
This patch changes return type of wilc_listen_state_expired from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/sta

[PATCH 06/20] staging: wilc1000: fix return type of wilc_set_power_mgmt

2015-12-30 Thread Chaehyun Lim
This patch changes return type of wilc_set_power_mgmt from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/w

[PATCH 02/20] staging: wilc1000: rename u16FrameType in wilc_frame_register

2015-12-30 Thread Chaehyun Lim
This patch renames u16FrameType to frame_type to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_i

[PATCH 03/20] staging: wilc1000: rename bReg in wilc_frame_register

2015-12-30 Thread Chaehyun Lim
This patch renames bReg to reg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/dri

[PATCH 01/20] staging: wilc1000: fix return type of wilc_frame_register

2015-12-30 Thread Chaehyun Lim
This patch changes return type of wilc_frame_register from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/w

Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

2015-12-30 Thread Sudip Mukherjee
On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote: > On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee > wrote: > > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: > >> Split comment in order to fit into 80 characters per line. > >> Found by checkpatch.pl > >> >

[PATCH] staging: lustre: remove useless check

2015-12-30 Thread Andrzej Hajda
Variable reserved is unsigned so the check is always true. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/staging/lustr

[PATCH] Staging: ste_rmi4: constify synaptics_rmi4_platform_data structures

2015-12-30 Thread Julia Lawall
This synaptics_rmi4_platform_data structure is never modified, so declare it as const. Others are already const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: most: replace multiple if..else with table lookup

2015-12-30 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, Dec 24, 2015 at 08:06:26AM -0800, Joe Perches wrote: > On Thu, 2015-12-24 at 10:49 +, Gujulan Elango, Hari Prasath (H.) wrote: > > From: Hari Prasath Gujulan Elango > > > > Replace multiple if..else if..statements with simple table lookup in two > > functions. > > > > Signed-off-by:

Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

2015-12-30 Thread Ksenija Stanojević
On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee wrote: > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: >> Split comment in order to fit into 80 characters per line. >> Found by checkpatch.pl >> >> Signed-off-by: Ksenija Stanojevic >> --- > > Instead of multiline maybe this