[PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

The macro startget_to_rport() can return NULL; handle that case properly. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/scsi_transport_fc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

On Thu, 2016-01-07 at 16:40 -0800, K. Y. Srinivasan wrote: > The macro startget_to_rport() can return NULL; handle that case > properly. OK, can we unwind why you think you could possibly need this? It would mean that fc_timed_out was called for a non-FC device, which was thought to be an

Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

On 16-01-07 05:28 AM, Vitaly Kuznetsov wrote: > Eric Dumazet writes: > >> On Thu, 2016-01-07 at 10:33 +0100, Vitaly Kuznetsov wrote: >>> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add >>> VLAN ID to flow_keys")) introduced a performance

[patch] staging: unisys: remove some dead code

queue_delayed_work() returns bool, not negative error codes. It returns false if the work has already been queued or true otherwise. Since we don't care about that, we can just remove the test. Signed-off-by: Dan Carpenter diff --git

Re: [PATCH] Staging: wlan-ng: p80211conv.c: Coding style fixes General coding style checks have been fixed. Warnings not fixed.

You're going to have to split this into multiple patches that fix one type of bug at a time. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

On Thu, 2016-01-07 at 10:33 +0100, Vitaly Kuznetsov wrote: > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that

Re: [PATCHv2 1/1] staging/ion: Add support to get ion handle from dma buf

Hi Rohit, On 6 January 2016 at 12:41, Rohit kumar wrote: > Currently we can only import dma buf fd's to get ion_handle. > Adding support to import dma buf handles to support kernel > specific use cases. > > An example use case is in linux platforms such as Tizen, in which >

RE: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

> -Original Message- > From: John Fastabend [mailto:john.fastab...@gmail.com] > Sent: Thursday, January 7, 2016 5:02 PM > To: Vitaly Kuznetsov ; Simon Xiao > ; Eric Dumazet > Cc: Tom Herbert ;

Re: [patch] staging: unisys: remove some dead code

On Thu, Jan 07, 2016 at 12:34:13PM +0300, Dan Carpenter wrote: > queue_delayed_work() returns bool, not negative error codes. It returns > false if the work has already been queued or true otherwise. Since > we don't care about that, we can just remove the test. > > Signed-off-by: Dan Carpenter

[PATCH v2 1/2] Staging: goldfish: Add space around +

Fix checkpatch warning of adding space around + in accordance with kernel coding style. Signed-off-by: Shraddha Barke --- Changes in v2- No change. Added lkml and other maintainers. drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 0/2] Staging: goldfish: Checkpatch cleanups

These patches remove the last few checkpatch warnings in staging/goldfish directory Shraddha Barke (2): Staging: goldfish: Add space around + Staging: goldfish: Remove explicit NULL comparison drivers/staging/goldfish/goldfish_audio.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

On 16-01-07 07:49 PM, KY Srinivasan wrote: > > >> -Original Message- >> From: John Fastabend [mailto:john.fastab...@gmail.com] >> Sent: Thursday, January 7, 2016 5:02 PM >> To: Vitaly Kuznetsov ; Simon Xiao >> ; Eric Dumazet

Re: [PATCHv2 1/1] staging/ion: Add support to get ion handle from dma buf

Hi Sumit, On Thu, 07 Jan 2016 19:43:09 +0530 Sumit Semwal wrote: > Hi Rohit, > > On 6 January 2016 at 12:41, Rohit kumar wrote: > > Currently we can only import dma buf fd's to get ion_handle. > > Adding support to import dma buf handles to

[PATCH 06/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Logical continuation is fixed Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index c9bbf89..44bf164

[PATCH 08/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Removed blank line after open braces Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index 2c251e3..27342f8 100644 ---

[PATCH 10/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Logical continuation fixing for 'if' block Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index

[PATCH 11/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Logical continuation fix for 'if' block Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index

[PATCH 05/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Removed blank line after braces Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index d799701..c9bbf89 100644 ---

[PATCH 07/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Alignment matched with open parenthesis Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index

[PATCH 03/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Fixed a logical continuation Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index 4bcc444..ff5a2cc

[PATCH 02/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Removed space after casting Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index 7e3d4b5..4bcc444 100644

[PATCH 14/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Removed space after casting operator Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index

[PATCH 15/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Removed space after casting operator Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index

[PATCH 12/40] drivers/staging/wlan-ng/p80211conv.c: Fixed coding style

Logical continuation fix for 'if' block Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index

Re: [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style

You can't have 40 patches with the same subject. Also that is too generic a subject. Also don't break it up into one line per patch, break it up so it's patch 1: remove blank lines patch 2: no spaces after a cast patch 3: fix all NULL compares etc... regards, dan carpenter