Re: [PATCH] staging: android: ion: Set the length of the DMA sg entries in buffer

On Thu, 2016-01-21 at 16:58 -0800, Laura Abbott wrote: > On 01/21/2016 12:19 PM, Jon Medhurst (Tixy) wrote: [...] > > If sg_dma_len() is correct or acceptable then it seems to me that the > > ION code should set that length. Especially as the comment in the code > > implies it's faking a call to

Re: [PATCH 21/26] staging: wilc1000: increase link speed

Btw, even though I don't always comment, I see all the places where checkpatch would have complained. It's like that TV show "Person of Interest". https://www.youtube.com/watch?v=WOnQ8CD3v4g#t=16s regards, dan carpenter ___ devel mailing list

Re: [PATCH 24/26] staging: wilc1000: add ops tx power in cfg80211

On Tue, Jan 12, 2016 at 04:39:53PM +0900, Glen Lee wrote: > +static void handle_set_tx_pwr(struct wilc_vif *vif, u8 tx_pwr) > +{ > + s32 ret = 0; s32 should almost always be changed to int. Don't initialize variables with bogus values. GCC has a helper warning for uninitialized variables

Re: [PATCH 04/26] staging: wilc1000: add sdio resume/suspend

On 2016년 01월 22일 16:44, Dan Carpenter wrote: You should be running checkpatch.pl on your patches. It's my mistake. I will run checkpatch.pl on the patch series. Thank you your advise. glen lee. regards, dan carpenter ___ devel mailing list

[PATCH] Staging: xgifb: vb_init.c: Coding style warning fix block comments

This patch is to vb_init.c file that fixes up following warnings reported by checkpatch.pl: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2

[PATCH] Staging: xgifb: vb_init: Coding style warning fix block comments

This is a patch to the vb_init.c file that fixes up a warning reported by checkpatch.pl: WARNING: Block comments use a trailing */ on a separate line Singed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH] Staging: xgifb: vb_init.c: Coding style warning fix block comment

This is a patch to the vb_init.c file that fixes up a warning reported by checkpatch.pl: WARNING: Block comments use * on subsequent lines Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff