Hello1

2016-05-12 Thread HH
I hope you and your family are fine. I have a selling proposal that I would love to share with you.. Have a nice day as I await to hear your response. Thanks and regards XI ___ devel mailing list de...@linuxdriverproject.org

[PATCH] staging/lustre/ptlrpc: Removes potential null dereference

2016-05-12 Thread Lidza Louina
The lustre_msg_buf method could return NULL. Subsequent code didn't check if it's null before using it. This patch adds two checks. Signed-off-by: Lidza Louina diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c b/drivers/staging/lustre/lustre/ptlrpc/sec.c

Treat As Urgent

2016-05-12 Thread Mrs Mary Chalmers
Dear Beloved. Please forgive my intrusion into your privacy; I am a Australia sick widow admitted in a private hospital here in Spain due to long time cancer and reference to the doctor’s confirmation that I have less than three months to live because the cancer has reached a critical stage. Now

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-12 Thread Doug Ledford
On 05/03/2016 10:33 AM, Florian Westphal wrote: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc:

Aw: Re: [PATCH 0/6] hv_netvsc: avoid races on mtu change/set channels

2016-05-12 Thread Lino Sanfilippo
> It's worse: before the patch series we get 'struct hv_device' (as it is > called from core VMBus code and we simply cannot get to 'struct > net_device' we need without traveling through 'struct > netvsc_device'. This structure is removed and re-created by both > netvsc_set_channels() and

Re: [PATCH] MAINTAINERS: add entry for the Sync File Framework

2016-05-12 Thread Emil Velikov
Hi Gustavo, On 11 May 2016 at 14:45, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add Gustavo as maintainer for the Sync File Framework. Sumit is > co-maintainer as he maintains drivers/dma-buf/. It also uses Sumit's > tree as base. >

Re: Aw: [PATCH 0/6] hv_netvsc: avoid races on mtu change/set channels

2016-05-12 Thread Vitaly Kuznetsov
"Lino Sanfilippo" writes: > Hi, > >> >> MTU change and set channels operations are implemented as netvsc device >> re-creation destroying internal structures (struct net_device stays). This >> is really unfortunate but there is no support from Hyper-V host to do it >> in a

Aw: [PATCH 0/6] hv_netvsc: avoid races on mtu change/set channels

2016-05-12 Thread Lino Sanfilippo
Hi, > > MTU change and set channels operations are implemented as netvsc device > re-creation destroying internal structures (struct net_device stays). This > is really unfortunate but there is no support from Hyper-V host to do it > in a different way. Such re-creation is unsurprisingly racy,

[PATCH 8/9] staging: unisys: visorhba: return 0 literal

2016-05-12 Thread David Kershner
From: David Binder Returns 0 instead of variable rc in visorhba_init(). Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1

[PATCH 4/9] staging: unisys: visorhba: simplify and enhance debugfs interface

2016-05-12 Thread David Kershner
From: Tim Sell debugfs info for each visorhba device is now presented by a file named of the following form within the debugfs tree: visorhba/vbus:dev/info where is the vbus number, and is the relative device number. Also, the debugfs presentation function was

[PATCH 2/9] staging: unisys: visorhba: correct scsi task mgmt completion handling

2016-05-12 Thread David Kershner
From: Tim Sell This patch is necessary to enable ANY task mgmt command to complete successfully via visorhba. When issuing a task mgmt command (CMD_SCSITASKMGMT_TYPE) to the IO partition (back-end), forward_taskmgmt_command() includes pointers within the command area

[PATCH 3/9] staging: unisys: visorhba: remove unused (and broken) logic

2016-05-12 Thread David Kershner
From: Tim Sell The handling of CMD_NOTIFYGUEST_TYPE messages from the IO partition appears to be only partially implemented, but fortunately it is never used in our current environment. This patch deletes the unused code. Signed-off-by: Tim Sell

[PATCH 7/9] staging: unisys: visornic: cleanup error handling

2016-05-12 Thread David Kershner
From: David Binder Adjusts goto labels to prevent attempts to free unallocated resources. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 6 +++--- 1

[PATCH 6/9] staging: unisys: visornic: simplify visornic if statements

2016-05-12 Thread David Kershner
From: David Binder Changes the conditional logic by looking for the absence of work to do, instead of the opposite. Signed-off-by: David Binder Reviewed-by: Tim Sell Signed-off-by: David Kershner

[PATCH 1/9] staging: unisys: visorhba: delete processing of vdiskmgmt commands

2016-05-12 Thread David Kershner
From: Tim Sell We never issue SCSI commands of type CMD_VDISKMGMT_TYPE, so there is no need to have code that processes their completions. Signed-off-by: Tim Sell Signed-off-by: David Kershner ---

[PATCH 5/9] staging: unisys: visorhba: visorhbas_open[] no longer used, so deleted

2016-05-12 Thread David Kershner
From: Tim Sell The prior patch which simplified the visorhba debugfs interface made it so visorhbas_open[] and VISORHBA_OPEN_MAX were no longer needed, so they have now been deleted. Signed-off-by: Tim Sell Signed-off-by: David Kershner

[PATCH 9/9] staging: unisys: visornic: check for error instead of success

2016-05-12 Thread David Kershner
From: David Binder Changes the conditional logic to check for an error code instead of a success code. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c |

[PATCH 0/9] staging: unisys: visorhba: fix scsi task mgmt completion handling and other cleanups

2016-05-12 Thread David Kershner
On 5/2 Dan Carpenter pointed out some sloppy u64 <--> pointer casting we were doing in visorhba, but this turned out to be the tip of an iceberg. Our handling of scsi task mgmt completions turned out to be buggy. This patchset switches visorhba to use idr_alloc() / idr_find() so that we can

[PATCH 6/6] hv_netvsc: set nvdev link after populating chn_table

2016-05-12 Thread Vitaly Kuznetsov
Crash in netvsc_send() is observed when netvsc device is re-created on mtu change/set channels. The crash is caused by dereferencing of NULL channel pointer which comes from chn_table. The root cause is a mixture of two facts: - we set nvdev pointer in net_device_context in alloc_net_device()

[PATCH 3/6] hv_netvsc: untangle the pointer mess

2016-05-12 Thread Vitaly Kuznetsov
We have the following structures keeping netvsc adapter state: - struct net_device - struct net_device_context - struct netvsc_device - struct rndis_device - struct hv_device and there are pointers/dependencies between them: - struct net_device_context is contained in struct net_device - struct

[PATCH 2/6] hv_netvsc: use start_remove flag to protect netvsc_link_change()

2016-05-12 Thread Vitaly Kuznetsov
netvsc_link_change() can race with netvsc_change_mtu() or netvsc_set_channels() as these functions destroy struct netvsc_device and rndis filter. Use start_remove flag for syncronization. As netvsc_change_mtu()/netvsc_set_channels() are called with rtnl lock held we need to take it before checking

[PATCH 5/6] hv_netvsc: synchronize netvsc_change_mtu()/netvsc_set_channels() with netvsc_remove()

2016-05-12 Thread Vitaly Kuznetsov
When netvsc device is removed during mtu change or channels setup we get into troubles as both paths are trying to remove the device. Synchronize them with start_remove flag and rtnl lock. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/netvsc_drv.c | 9 +++-- 1

[PATCH 4/6] hv_netvsc: get rid of struct net_device pointer in struct netvsc_device

2016-05-12 Thread Vitaly Kuznetsov
Simplify netvsvc pointer graph by getting rid of the redundant ndev pointer. We can always get a pointer to struct net_device from somewhere else. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/hyperv_net.h | 2 -- drivers/net/hyperv/netvsc.c | 30

[PATCH 0/6] hv_netvsc: avoid races on mtu change/set channels

2016-05-12 Thread Vitaly Kuznetsov
MTU change and set channels operations are implemented as netvsc device re-creation destroying internal structures (struct net_device stays). This is really unfortunate but there is no support from Hyper-V host to do it in a different way. Such re-creation is unsurprisingly racy, Haiyang reported

[PATCH 1/6] hv_netvsc: move start_remove flag to net_device_context

2016-05-12 Thread Vitaly Kuznetsov
struct netvsc_device is destroyed on mtu change so keeping the protection flag there is not a good idea. Move it to struct net_device_context which is preserved. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/hyperv_net.h | 4 +++- drivers/net/hyperv/netvsc.c |

Re: [PATCH] MAINTAINERS: add entry for the Sync File Framework

2016-05-12 Thread Maarten Lankhorst
Op 11-05-16 om 15:45 schreef Gustavo Padovan: > From: Gustavo Padovan > > Add Gustavo as maintainer for the Sync File Framework. Sumit is > co-maintainer as he maintains drivers/dma-buf/. It also uses Sumit's > tree as base. > > Cc: Sumit Semwal

[PATCH 3/3] staging: dgnc: removes redundant null check and change

2016-05-12 Thread Daeseok Youn
The dgnc_set_modem_info() used only channel_t variable. Any other variables were used only for checking NULL. So fist parameter changed from "tty_struct" to "channel_t" and useless NULL checks and variables are removed. Signed-off-by: Daeseok Youn ---

[PATCH 2/3] staging: dgnc: remove redundant variable null check

2016-05-12 Thread Daeseok Youn
The unit struct(un_t) was not used in dgnc_tty_hangup(). Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_tty.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 52a1613..5119bcb

[PATCH 1/3] staging: dgnc: remove redundant local variable for

2016-05-12 Thread Daeseok Youn
The local variable "bd" was not used in dgnc_carrier() function. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_tty.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-12 Thread Dr. Greg Wettstein
On Mon, May 09, 2016 at 08:27:04AM +0200, Thomas Gleixner wrote: Good morning. > > On Fri, 6 May 2016, Jarkko Sakkinen wrote: > > I fully understand if you (and others) want to keep this standpoint but > > what if we could get it to staging after I've revised it with suggested > > > This should

[PATCH 3/4] Staging: comedi: fix type issue in s626.c

2016-05-12 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a type issues found by the checkpatch.pl tool. i.e Prefer kernel type 'u8' over 'uint8_t' Prefer kernel type 'u16' over 'uint16_t' Prefer kernel type 'u32' over 'uint32_t' Prefer kernel type 's16' over 'int16_t' Prefer kernel type

[PATCH 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

2016-05-12 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a line over 80 characters issues found by the checkpatch.pl tool. Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 1/4] Staging: comedi: Fix WARNING issue in s626.c

2016-05-12 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a Block comments issues found by the checkpatch.pl tool. i.e. Block comments use a trailing */ on a separate line Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 30

[PATCH 2/4] Staging: comedi:Fix checkpatch issue in s626.c

2016-05-12 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a WARNING: Prefer 'unsigned int' to bare use of 'unsigned' found by the checkpatch.pl tool Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 8 1 file changed, 4