Re: [PATCH] staging: android ion/hisi: fix dependencies

On 16 September 2016 at 07:40, Laura Abbott wrote: > On 09/15/2016 08:57 AM, Arnd Bergmann wrote: >> >> The newly added Hi6220 Ion code fails to build when the ION_OF helpers >> are not present: >> >> drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function >>

Re: [PATCH -next] staging: android: ion: Fix return value check in hi6220_ion_probe()

On 16 September 2016 at 07:40, Laura Abbott wrote: > On 09/14/2016 07:20 PM, Wei Yongjun wrote: >> >> From: Wei Yongjun >> >> In case of error, the function ion_device_create() returns ERR_PTR() and >> never returns NULL. The NULL test in the return

Re: [PATCH] staging: android ion/hisi: fix dependencies

On 09/15/2016 08:57 AM, Arnd Bergmann wrote: The newly added Hi6220 Ion code fails to build when the ION_OF helpers are not present: drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove': hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to

Re: [PATCH -next] staging: android: ion: Fix return value check in hi6220_ion_probe()

On 09/14/2016 07:20 PM, Wei Yongjun wrote: From: Wei Yongjun In case of error, the function ion_device_create() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Acked-by: Laura Abbott

[PATCH 2/2] staging: sm750fb: fix block comment style and spelling issues in ddk750_chip.c

Fix the following warning types: - line length - block comment line * prefix - trailing */ on a separate line found by the checkpatch.pl tool in multiple block comments. Fix a single spelling error in a comment. Signed-off-by: Moshe Green ---

[PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c

Fix multiple line length warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git

Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

On Thu, 2016-09-15 at 19:22 +0200, Sergio Paracuellos wrote: > That's true. It seems that checkpatch script is getting a false > positive. Just trying to do checkpatch happy. Sorry for inconvenience. Keeping the style consistent instead of taking the simplest path to quiet the checkpatch

[PATCH] Staging: wlan-ng: if statement style cleanup

Signed-off-by: Jon Eyolfson --- drivers/staging/wlan-ng/cfg80211.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index a36e40d..457f176 100644 ---

Re: [PATCH 2/2] staging: sm750fb: fix block comment style and spelling issues in ddk750_chip.c

On Mon, Sep 12, 2016 at 01:17:25PM +0200, Greg KH wrote: > On Sun, Sep 04, 2016 at 09:04:10PM +0300, Moshe Green wrote: > > Fix the following warning types: > > - line length > > - block comment line * prefix > > - trailing */ on a separate line > > found by the checkpatch.pl tool in multiple

Re: [PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c

On Mon, Sep 12, 2016 at 01:16:35PM +0200, Greg KH wrote: > On Sun, Sep 04, 2016 at 09:03:27PM +0300, Moshe Green wrote: > > Fix multiple line length warnings found by the checkpatch.pl tool > > in ddk750_chip.c. > > > > Signed-off-by: Moshe Green > > --- > >

[PATCH] staging: rts5208: make some vars to lower case to keep the style consistent

This patch fixes the checkpatch.pl warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx_card.c | 18 +- 1 file changed, 9 insertions(+), 9

Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings

On Wednesday 14 September 2016 10:44 AM, Dilger, Andreas wrote: On Sep 12, 2016, at 04:27, Greg KH wrote: On Fri, Sep 09, 2016 at 08:50:35PM +0530, Nayeemahmed Badebade wrote: Added __acquires / __releases sparse locking annotations to lock_res_and_lock and

Re: [PATCH V2] staging: lustre: include/lustre_net.h: Remove unnecessary space before function pointer arguments.

On Thu, Sep 15, 2016 at 12:18:56PM +0200, Richard Groux wrote: > Minor warnings spotted by checkpatch.pl in lustre > Remove unnecessary space before function pointer arguments. > > Signed-off-by: Richard Groux > --- > drivers/staging/lustre/lustre/include/lustre_net.h

Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

That's true. It seems that checkpatch script is getting a false positive. Just trying to do checkpatch happy. Sorry for inconvenience. I'll be careful with Changelog stuff from now. Thanks for advice. Cheers, Sergio Paracuellos El 2016年09月15日 a las 16:51, Greg KH escribió: On Thu,

[PATCH] staging: android ion/hisi: fix dependencies

The newly added Hi6220 Ion code fails to build when the ION_OF helpers are not present: drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove': hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to `ion_destroy_platform_data'

[PATCH v2] staging: lustre: clean function declarations in class_obd.c up

We get 2 warnings when building kernel with W=1: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes] drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for

RE: [PATCH -next] staging: fsl-mc: use list_del_init instead of list_del/INIT_LIST_HEAD

> -Original Message- > From: Wei Yongjun [mailto:weiyj...@gmail.com] > Sent: Wednesday, September 14, 2016 9:27 PM > To: J . German Rivera ; Stuart Yoder > ; Greg Kroah- > Hartman ; German Rivera

RE: [PATCH -next] staging: fsl-mc: remove .owner field for driver

> -Original Message- > From: Wei Yongjun [mailto:weiyj...@gmail.com] > Sent: Wednesday, September 14, 2016 9:27 PM > To: J . German Rivera ; Stuart Yoder > ; Greg Kroah- > Hartman ; German Rivera

Re: [PATCH] staging: lustre: clean function declarations in class_obd.c up

On Thu, Sep 15, 2016 at 09:51:27PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: Don't do that! :) > > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: > no previous prototype for 'class_procfs_init' [-Wmissing-prototypes] >

Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

On Thu, Sep 15, 2016 at 04:29:54PM +0200, Sergio Paracuellos wrote: > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/rts5208/rtsx_card.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_card.c >

[PATCH 11/11] staging: most: hdm-dim2: monitor atx DBR space

From: Andrey Shvetsov This patch implements a workaround for a DIM2 issue where the device macro, in case the asynchronous channel sends data (to MOST), sporadically duplicates the synchronous blocks with a size of half the synchronous DBR buffer. The patch monitors the

[PATCH 01/11] staging: most: hdm-dim2: fix channel configuration

From: Andrey Shvetsov The DIM2 HDM checks the parameters passed to the function configure_channel() and adapts the buffer sizes of the configuration according to the hardware limitation. This patch is needed to init the HAL layer with the correct values. Signed-off-by:

[PATCH 02/11] staging: most: hdm-dim2: remove macro ENABLE_HDM_TEST

From: Andrey Shvetsov This patch removes the macro ENABLE_HDM_TEST, which was needed while doing DIM2-HAL simulations. But these are not conducted anymore. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm

[PATCH 07/11] staging: most: hdm-dim2: rename function

From: Andrey Shvetsov This patch renames the function dim_service_irq. It subsitutes the name with the more suitable identifier dim_service_ahb_int_irq. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm

[PATCH 10/11] staging: most: hdm-dim2: fix dim2-ip interrupt names

From: Andrey Shvetsov This patch fixes the DIM2 IP interrupt names. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-dim2/dim2_hdm.c | 6 +++--- 1 file changed, 3

[PATCH 05/11] staging: most: hdm-dim2: round up DBR memory for async/ctrl

From: Andrey Shvetsov As the DBR memory is allocated in units of DBR_BLOCK_SIZE, it is more efficient to configure the DIM2 IP to use whole blocks of the DBR memory. This patch ceils the DBR memory size used by the DIM2 IP for async/ctrl channels. Signed-off-by: Andrey

[PATCH 04/11] staging: most: hdm-dim2: double size of DBR buffer

From: Andrey Shvetsov This patch increases the size of the asynchronous and control DBR buffers in the Tx path to twice the max. message size. This patch is needed to increase the throughput for big messages. Signed-off-by: Andrey Shvetsov

[PATCH 00/11] staging: most: fix issues of HDM DIM2

This patch set is needed to fix the issues of the DIM2 module of the MOST driver. Andrey Shvetsov (11): staging: most: hdm-dim2: fix channel configuration staging: most: hdm-dim2: remove macro ENABLE_HDM_TEST staging: most: hdm-dim2: relocate variable declarations staging: most: hdm-dim2:

[PATCH 03/11] staging: most: hdm-dim2: relocate variable declarations

From: Andrey Shvetsov This patch eliminates nested variable declarations by putting them at the beginning of the function in order to flatten the code. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm

[PATCH 09/11] staging: most: hdm-dim2: remove clearance of pending MLB interrupt

From: Andrey Shvetsov This patch removes unnecessary clearing of a pending mlb_int from the service routine for ahb interrupt. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

[PATCH 06/11] staging: most: hdm-dim2: remove structure member

From: Andrey Shvetsov This patch removes the member irq_ahb0 of the structure dim2_hdm, since its job is suitably done by a simple auto variable. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

[PATCH 08/11] staging: most: hdm-dim2: delete error code from logging message

From: Andrey Shvetsov This patch removes the logging of the returned error code of function dim2_probe as it is done by the calling function. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

[PATCH] staging: lustre: clean function declarations in class_obd.c up

We get 2 warnings when building kernel with W=1: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes] drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for

Re: [PATCH V2] staging: lustre: include/lustre_net.h: Remove unnecessary space before function pointer arguments.

Minor warnings spotted by checkpatch.pl in lustre Remove unnecessary space before function pointer arguments. Signed-off-by: Richard Groux --- drivers/staging/lustre/lustre/include/lustre_net.h | 46 +++--- 1 file changed, 23 insertions(+), 23

[PATCH -next] staging: ks7010: remove unused including

From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/staging/ks7010/ks_wlan_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c

[PATCH -next] staging: rtl8712: fix double lock bug in SetPSModeWorkItemCallback()

From: Wei Yongjun Fix a double lock bug in SetPSModeWorkItemCallback(). Fixes: 5c2ba8b85e35 ("rtl8712: pwrctrl_priv: Replace semaphore lock with mutex") Signed-off-by: Wei Yongjun --- drivers/staging/rtl8712/rtl871x_pwrctrl.c | 2 +- 1 file

Re: [PATCH] drivers: wilc1000: remove references to semaphores

On Tuesday 02 August 2016 12:04 AM, Joshua Houghton wrote: > * Update the comments that refer to semaphores > * Remove redundant includes to semphore.h > > Signed-off-by: Joshua Houghton > --- > drivers/staging/wilc1000/TODO | 1 - >