[PATCH] staging: wlan-ng: avoid to introduce new typedefs

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/cfg80211.c | 12 +- drivers/staging/wlan-ng/p80211metastruct.h | 248

[PATCH 09/11 V2] staging: dgnc: rename dgnc_tty_uninit() to dgnc_cleanup_tty()

The dgnc_tty_uninit() doesn't match with dgnc_tty_init() at all. And also the dgnc_cleanup_tty() is only called for exiting the module. Signed-off-by: Daeseok Youn --- V2: the subject line was cut off, I put it completely. drivers/staging/dgnc/dgnc_driver.c | 2 +-

[PATCH 07/11 V2] staging: dgnc: rename dgnc_finalize_board_init() to dgnc_request_irq()

The dgnc_finalize_board_init() function has only job for requesting the IRQ. It should be renamed to dgnc_request_irq() Signed-off-by: Daeseok Youn --- V2: the subject line was cut off, I put it completely. drivers/staging/dgnc/dgnc_driver.c | 6 +++--- 1 file changed,

[PATCH 05/11 V2] staging: dgnc: move functions unrelated with dgnc_found_board()

The functions related with tty device initialization are needed to be moved from dgnc_found_board() to dgnc_init_one(). Signed-off-by: Daeseok Youn --- V2: the subject line was cut off, I put it completely. drivers/staging/dgnc/dgnc_driver.c | 81

[PATCH 04/11 V2] staging: dgnc: kfree for board structure in dgnc_found_board()

The board structure should be freed when any function was failed in dgnc_found_board(). And the board strucure will be stored into dgnc_board array when the dgnc_found_board() function has no error. Signed-off-by: Daeseok Youn --- V2: the subject line was cut off, I put

[PATCH 03/11 V2] staging: dgnc: missing NULL check for ioremap in dgnc_do_remap()

The ioremap() function can be failed, so it need to have error handling in dgnc_do_remap(). And also the return type of dgnc_do_remap() should be changed from "void" to "int" Signed-off-by: Daeseok Youn --- V2: the subject line was cut off, I put it completely.

[PATCH 01/11 V2] staging: dgnc: remove redundant initialization for channel array

The channel array in board_t was initialized in dgnc_found_board() with NULL. But the channel is going to initialize in dgnc_tty_init() again. So the channel array doesn't need to set NULL for initailization in dgnc_found_board(). Signed-off-by: Daeseok Youn --- V2: The

Re: [PATCH 04/11] staging: dgnc: kfree for board structure in

2016-09-22 16:21 GMT+09:00 Greg KH : > On Thu, Sep 22, 2016 at 02:22:03PM +0900, Daeseok Youn wrote: >> The board structure should be freed when any function was failed >> in dgnc_found_board(). And the board strucure will be stored >> into dgnc_board array when the

[PATCH V2] staging: wlan-ng: remove unnecessary spaces before casts

Fixed a coding style issue by removing unnecessary spaces before casts. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/p80211netdev.c | 12 ++-- drivers/staging/wlan-ng/p80211req.c| 16

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Fri, 2016-09-23 at 00:39 +0200, becher.jan...@gmail.com wrote: > On Thu, Sep 22, 2016 at 03:05:02PM -0700, Joe Perches wrote: > > On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > > >r emoved a space after a cast to obtain the coding style. > > Better would be to change the subject to

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 03:05:02PM -0700, Joe Perches wrote: > On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > > removed a space after a cast to obtain the coding style. > > Better would be to change the subject to something like: > > [PATCH] staging: wlan-ng: Remove unnecessary spaces

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. Better would be to change the subject to something like: [PATCH] staging: wlan-ng: Remove unnecessary spaces before casts ___ devel

[PATCH] drivers: wlan-ng: fixed a coding style issue

removed a space after a cast to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/p80211netdev.c | 12 ++-- drivers/staging/wlan-ng/p80211req.c| 16

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > So you think I should make one "big" patch and resend it?

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 22:52 +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > > So you think I should make one "big" patch and resend it? Make

[PATCH] staging: ion: Align cases with switch

The preferred indentation for cases and switches has the cases at the same level as the switch. Signed-off-by: Christopher H. Pezley --- drivers/staging/android/ion/ion_of.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 11:32:02PM +0300, Andrey Utkin wrote: > On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > > removed a space after a cast to obtain the coding style. > > > > Signed-off-by: Jannik Becher > > --- > >

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. > > Signed-off-by: Jannik Becher > --- > drivers/staging/wlan-ng/p80211req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v3 2/2] staging: ion: Fix a coding style issue

On 09/22/2016 08:59 AM, Antti Keränen wrote: Correctly align an unaligned block comment Signed-off-by: Antti Keränen --- drivers/staging/android/uapi/ion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/uapi/ion.h

Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue

On 09/22/2016 08:59 AM, Antti Keränen wrote: Remove unnecessary braces surrounding a single statement block In the future, when sending different versions of a patch please give a short summary of what's changed. I think this is just a resend from v2 with more reviewers added but I'm not 100%

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Thu, Sep 22, 2016 at 02:49:22PM -0500, Tom Lendacky wrote: > > I thought that reduction is the reservation of bits for the SME mask. > > > > What other reduction is there? > > There is a reduction in physical address space for the SME mask and the > bits used to aid in identifying the ASID

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 09/22/2016 02:11 PM, Borislav Petkov wrote: > On Thu, Sep 22, 2016 at 02:04:27PM -0500, Tom Lendacky wrote: >> That's not what I mean here. If the BIOS sets the SMEE bit in the >> SYS_CFG msr then, even if the encryption bit is never used, there is >> still a reduction in physical address

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 09/22/2016 09:45 AM, Paolo Bonzini wrote: > > > On 22/09/2016 16:35, Borislav Petkov wrote: @@ -230,6 +230,10 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages) efi_scratch.efi_pgt = (pgd_t *)__sme_pa(efi_pgd); pgd = efi_pgd;

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 09/22/2016 09:59 AM, Borislav Petkov wrote: > On Thu, Sep 22, 2016 at 04:45:51PM +0200, Paolo Bonzini wrote: >> The main difference between the SME and SEV encryption, from the point >> of view of the kernel, is that real-mode always writes unencrypted in >> SME and always writes encrypted in

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Thu, Sep 22, 2016 at 02:04:27PM -0500, Tom Lendacky wrote: > That's not what I mean here. If the BIOS sets the SMEE bit in the > SYS_CFG msr then, even if the encryption bit is never used, there is > still a reduction in physical address space. I thought that reduction is the reservation of

[PATCH] drivers: wlan-ng: fixed a coding style issue

removed a space after a cast to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/p80211req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c

Re: [PATCH] rtl871x: use tabs with indentation instead of spaces

On 09/22/2016 09:17 AM, Greg KH wrote: > On Wed, Sep 21, 2016 at 11:12:05PM +0200, Christopher Pezley wrote: >> There is a line with space indentation instead of tabs. I've changed it to >> use tabs for indentation. >> >> Signed-off-by: Christopher H. Pezley >> --- >>

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 09/22/2016 12:07 PM, Borislav Petkov wrote: > On Thu, Sep 22, 2016 at 05:05:54PM +0200, Paolo Bonzini wrote: >> Which paragraph? > > "Linux relies on BIOS to set this bit if BIOS has determined that the > reduction in the physical address space as a result of enabling memory > encryption..." >

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 22/09/2016 20:47, Tom Lendacky wrote: > > Because the firmware volume is written to high memory in encrypted form, > > and because the PEI phase runs in 32-bit mode, the firmware code will be > > encrypted; on the other hand, data that is placed in low memory for the > > kernel can be

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 22/09/2016 20:37, Borislav Petkov wrote: >> > Unless this is part of some spec, it's easier if things are the same in >> > SME and SEV. > Yeah, I was pondering over how sprinkling sev_active checks might not be > so clean. > > I'm wondering if we could make the EFI regions presented to the

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Thu, Sep 22, 2016 at 08:23:36PM +0200, Paolo Bonzini wrote: > Unless this is part of some spec, it's easier if things are the same in > SME and SEV. Yeah, I was pondering over how sprinkling sev_active checks might not be so clean. I'm wondering if we could make the EFI regions presented to

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 22/09/2016 19:46, Tom Lendacky wrote: >> > Do you mean, it is encrypted here because we're in the guest kernel? > Yes, the idea is that the SEV guest will be running encrypted from the > start, including the BIOS/UEFI, and so all of the EFI related data will > be encrypted. Unless this is

Re: [PATCH] staging:android:io: Fix multiple styling issues

Hello Yannis! There is a typo in your one-line description/subject ("ion"). On 09/22/2016 07:55 PM, Yannis Damigos wrote: > This patch fixes 1 error, 1 warning and 14 checks found by > checkpatch. Please be more specific in your commit message and mention what exactly you are doing to the code

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 09/22/2016 09:35 AM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 07:25:25PM -0400, Brijesh Singh wrote: >> From: Tom Lendacky >> >> EFI data is encrypted when the kernel is run under SEV. Update the >> page table references to be sure the EFI memory areas are

[PATCH 6/8] staging: rts5208: fix style warnings in spi.c

This patch fixes the following checkpatch.pl warning in spi.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/spi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/spi.c

[PATCH 1/8] staging: rts5208: fix style warnings in rtsx.h

This patch fixes the following checkpatch.pl warning in rtsx.h: WARNING: do not add new typedefs Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx.h | 4 drivers/staging/rts5208/rtsx_chip.h | 2 +- 2 files changed, 1 insertion(+), 5

[PATCH 7/8] staging: rts5208: fix style warnings in sd.c

This patch fixes the following checkpatch.pl warning in sd.c: WARNING: else is not generally useful after a break or return It also makes code more uniform with the new changes Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/sd.c | 173

[PATCH 8/8] staging: rts5208: fix style warnings in xd.c

This patch fixes the following checkpatch.pl warning in xd.c: WARNING: else is not generally useful after a break or return It also makes code more uniform with the new changes Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/xd.c | 38

[PATCH 0/8] staging: rts5208: Fix several style warnings

This patchset fix several style warnings reported by checkpatch.pl script. Sergio Paracuellos (8): staging: rts5208: fix style warnings in rtsx.h staging: rts5208: fix style warnings in rtsx.c staging: rts5208: fix style warnings in rtsx_chip.h staging: rts5208: fix style warnings in

[PATCH 5/8] staging: rts5208: fix style warnings in rtsx_sys.h

This patch fixes the following checkpatch.pl warning in rtsx_sys.h: WARNING: do not add new typedefs Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx_sys.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_sys.h

[PATCH 4/8] staging: rts5208: fix style warnings in rtsx.h

This patch fixes the following checkpatch.pl warning in rtsx.h: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 3/8] staging: rts5208: fix style warnings in rtsx_chip.h

This patch fixes the following checkpatch.pl warning in rtsx_chip.h: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx_chip.h | 52 +++-- 1 file changed,

[PATCH 2/8] staging: rts5208: fix style warnings in rtsx.c

This patch fixes the following checkpatch.pl warning in rtsx.c: WARNING: Symbolic permissions are not preferred. Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] staging: sm750fb: rename getChipType to get_chip_type

Rename CamelCased function getChipType to get_chip_type. This issue was found by checkpatch.pl Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 16 drivers/staging/sm750fb/ddk750_chip.h | 2 +- drivers/staging/sm750fb/ddk750_mode.c

[PATCH] staging: ks7010: add blank line after variable declarations

Fixes warnings found by checkpatch Missing a blank line after declarations Signed-off-by: Johan Svensson --- drivers/staging/ks7010/ks_hostif.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/ks7010/ks_hostif.c

[PATCH] drivers: wlan-ng: fixed a coding style issue

changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c

[PATCH] staging:android:io: Fix multiple styling issues

This patch fixes 1 error, 1 warning and 14 checks found by checkpatch. Signed-off-by: Yannis Damigos --- drivers/staging/android/ion/ion_of.c | 49 ++-- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git

Re: [PATCH] iio: accel: sca3000_core: avoid potentially uninitialized variable

On 22/09/16 10:43, Arnd Bergmann wrote: > The newly added __sca3000_get_base_freq function handles all valid > modes of the SCA3000_REG_ADDR_MODE register, but gcc notices > that any other value (i.e. 0x00) causes the base_freq variable to > not get initialized: > >

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Thu, Sep 22, 2016 at 07:08:50PM +0200, Paolo Bonzini wrote: > That's not how I read it. I just figured that the BIOS has some magic > things high in the physical address space and if you reduce the physical > address space the BIOS (which is called from e.g. EFI runtime services) > would have

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 22/09/2016 19:07, Borislav Petkov wrote: >> Which paragraph? > "Linux relies on BIOS to set this bit if BIOS has determined that the > reduction in the physical address space as a result of enabling memory > encryption..." > > Basically, you can enable SME in the BIOS and you're all set.

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Thu, Sep 22, 2016 at 05:05:54PM +0200, Paolo Bonzini wrote: > Which paragraph? "Linux relies on BIOS to set this bit if BIOS has determined that the reduction in the physical address space as a result of enabling memory encryption..." Basically, you can enable SME in the BIOS and you're all

[PATCH v3 2/2] staging: ion: Fix a coding style issue

Correctly align an unaligned block comment Signed-off-by: Antti Keränen --- drivers/staging/android/uapi/ion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h index 647f130..e629394

[PATCH v3 1/2] staging: ion: Fix a coding style issue

Remove unnecessary braces surrounding a single statement block Signed-off-by: Antti Keränen --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c

Re: [PATCH v2 0/2] staging: ion: Fix checkpatch.pl coding style issues

On Thu, Sep 22, 2016 at 05:13:07PM +0300, Antti Keränen wrote: > This set of patches fix two coding style warnings found with checkpatch.pl > I hope I got this correctly this time around :) > > Antti Keränen (2): > staging: ion: Fix a coding style issue > staging: ion: Fix a coding style

Re: [RFC PATCH v1 04/28] x86: Secure Encrypted Virtualization (SEV) support

On Mon, Aug 22, 2016 at 07:24:19PM -0400, Brijesh Singh wrote: > From: Tom Lendacky Subject: [RFC PATCH v1 04/28] x86: Secure Encrypted Virtualization (SEV) support Please start patch commit heading with a verb, i.e.: "x86: Add AMD Secure Encrypted Virtualization (SEV)

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Thu, Sep 22, 2016 at 04:45:51PM +0200, Paolo Bonzini wrote: > The main difference between the SME and SEV encryption, from the point > of view of the kernel, is that real-mode always writes unencrypted in > SME and always writes encrypted in SEV. But UEFI can run in 64-bit mode > and learn

[PATCH 2/2] staging: r8188eu: remove RFType member of odm_dm_struct structure

rf_type is always equal to ODM_1T1R. So, only RF PATH A exists for r8188eu device... Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/odm.c | 35 - drivers/staging/rtl8188eu/hal/phy.c | 16 +++--

[PATCH 1/2] staging: r8188eu: remove rf_type member of hal_data_8188e structure

rf_type is always equal to RF_1T1R. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c| 5 + drivers/staging/rtl8188eu/hal/phy.c | 5 + drivers/staging/rtl8188eu/hal/rf_cfg.c| 5 +

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 22/09/2016 16:35, Borislav Petkov wrote: >> > @@ -230,6 +230,10 @@ int __init efi_setup_page_tables(unsigned long >> > pa_memmap, unsigned num_pages) >> >efi_scratch.efi_pgt = (pgd_t *)__sme_pa(efi_pgd); >> >pgd = efi_pgd; >> > >> > + flags = _PAGE_NX | _PAGE_RW; >> > + if

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Mon, Aug 22, 2016 at 07:25:25PM -0400, Brijesh Singh wrote: > From: Tom Lendacky > > EFI data is encrypted when the kernel is run under SEV. Update the > page table references to be sure the EFI memory areas are accessed > encrypted. > > Signed-off-by: Tom Lendacky

Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

Hi Michael, El 22/09/16 a las 06:43, Michael Ellerman escribió: Emilio López writes: +CFLAGS += -I../../../../include/uapi/ Please don't include the unprocessed uapi headers, they are not meant to be directly included in userspace programs. They even say so:

[PATCH v2 0/2] staging: ion: Fix checkpatch.pl coding style issues

This set of patches fix two coding style warnings found with checkpatch.pl I hope I got this correctly this time around :) Antti Keränen (2): staging: ion: Fix a coding style issue staging: ion: Fix a coding style issue drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--

Re: [RFC PATCH v1 05/28] KVM: SVM: prepare for new bit definition in nested_ctl

On Mon, Aug 22, 2016 at 07:24:32PM -0400, Brijesh Singh wrote: > From: Tom Lendacky > > Currently the nested_ctl variable in the vmcb_control_area structure is > used to indicate nested paging support. The nested paging support field > is actually defined as bit 0 of the

[PATCH v2 1/2] staging: ion: Fix a coding style issue

Remove unnecessary braces surrounding a single statement block Signed-off-by: Antti Keränen --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c

[PATCH v2 2/2] staging: ion: Fix a coding style issue

Correctly align an unaligned block comment Signed-off-by: Antti Keränen --- drivers/staging/android/uapi/ion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h index 647f130..e629394

[staging:staging-testing 1000/1004] drivers/staging/i4l/act2000/act2000_isa.c:385:3: error: implicit declaration of function 'netdev_dbg'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 2a38ef60ef4ffe135566d1b8acc197b803c48ec1 commit: bce83de2578b37f1be039977278e8691a597ea7d [1000/1004] staging: i4l: act2000: Replace printk(KERN_DEBUG..) with netdev_dbg(dev, ..) config:

Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

Emilio López writes: > These tests are based on the libsync test suite from Android. > This commit lays the ground for future tests, as well as includes > tests for a variety of basic allocation commands. Hi Emilio, Just a few comments on the Makefile. > diff

Re: [staging:staging-testing 998/1004] drivers/staging/i4l/act2000/act2000_isa.c:81:3: error: implicit declaration of function 'netdev_warn'

On Thu, Sep 22, 2016 at 05:38:27PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 2a38ef60ef4ffe135566d1b8acc197b803c48ec1 > commit: 94b9eba50e3ad6fafe88d71da4a7345ebe87cdfb [998/1004] staging: i4l: >

[PATCH] iio: accel: sca3000_core: avoid potentially uninitialized variable

The newly added __sca3000_get_base_freq function handles all valid modes of the SCA3000_REG_ADDR_MODE register, but gcc notices that any other value (i.e. 0x00) causes the base_freq variable to not get initialized: drivers/staging/iio/accel/sca3000_core.c: In function 'sca3000_write_raw':

[staging:staging-testing 998/1004] drivers/staging/i4l/act2000/act2000_isa.c:81:3: error: implicit declaration of function 'netdev_warn'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 2a38ef60ef4ffe135566d1b8acc197b803c48ec1 commit: 94b9eba50e3ad6fafe88d71da4a7345ebe87cdfb [998/1004] staging: i4l: act2000: Replace printk(KERN_WARNING..) with netdev_warn(dev, ..) config:

[PATCH v2 3/6] staging: most: aim-cdev: make syscall write accept buffers of arbitrary size

This patch allows to call the write() function for synchronous and isochronous channels with buffers of any size. The AIM simply waits for data to fill up the MOST buffer object according to the network interface controller specification for streaming channels, before it submits the buffer to the

Re: [PATCH 04/11] staging: dgnc: kfree for board structure in

On Thu, Sep 22, 2016 at 02:22:03PM +0900, Daeseok Youn wrote: > The board structure should be freed when any function was failed > in dgnc_found_board(). And the board strucure will be stored > into dgnc_board array when the dgnc_found_board() function has no error. > > Signed-off-by: Daeseok

Re: [PATCH 03/11] staging: dgnc: missing NULL check for ioremap in

On Thu, Sep 22, 2016 at 02:21:38PM +0900, Daeseok Youn wrote: > The ioremap() function can be failed, so it need to have error > handling in dgnc_do_remap(). And also the return type of > dgnc_do_remap() should be changed from "void" to "int" > > Signed-off-by: Daeseok Youn

Re: [PATCH 01/11] staging: dgnc: remove redundant initialization for

On Thu, Sep 22, 2016 at 02:20:51PM +0900, Daeseok Youn wrote: > The channel array in board_t was initialized in dgnc_found_board() > with NULL. But the channel is going to initialize in dgnc_tty_init(). > So the channel array doesn't need to set NULL for initailization. > > Signed-off-by: Daeseok

Re: [PATCH] rtl871x: use tabs with indentation instead of spaces

On Wed, Sep 21, 2016 at 11:12:05PM +0200, Christopher Pezley wrote: > There is a line with space indentation instead of tabs. I've changed it to > use tabs for indentation. > > Signed-off-by: Christopher H. Pezley > --- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- >

Re: [PATCH] staging: ion: Fix checkpatch.pl coding style issues

On Thu, Sep 22, 2016 at 09:57:16AM +0300, Antti Keränen wrote: > This patch fixes two coding style issues found with checkpatch.pl. Both > of them are warnings. Ah, then this should be two separate patches :) Also, always use scripts/get_maintainer.pl to determine who to cc: on a patch. > >

Re: [PATCH 3/6] staging: most: aim-cdev: make syscall write accept buffers of arbitrary size

On Wed, Sep 21, 2016 at 02:49:07PM +0200, Christian Gromm wrote: > From: Andrey Shvetsov > > This patch allows to call the write() function for synchronous and > isochronous channels with buffers of any size. The AIM simply waits for > data to fill up the MOST buffer

Re: [PATCH 2/6] staging: most: aim-cdev: remove labels

On Wed, Sep 21, 2016 at 02:49:06PM +0200, Christian Gromm wrote: > From: Andrey Shvetsov > > This patch removes the labels 'put_mbo' and 'unlock' and relocates the > code accordingly making the code look simpler. But this is the opposite of what you should normally do.

[PATCH] staging: ion: Fix checkpatch.pl coding style issues

This patch fixes two coding style issues found with checkpatch.pl. Both of them are warnings. uapi/ion.h had an unaligned block comment. ion/hisilicon/hi6220_ion.c had unnecessary braces around a single statement block. One warning in uapi/ion.h was left in place that wanted a typedef

Re: [PATCH] staging: ion: Fix checkpatch.pl coding style issues

On Thu, Sep 22, 2016 at 09:08:01AM +0300, Antti Keränen wrote: > One warning was left in place that wanted a typedef (ion_user_handle_t) to be > removed. > I think the typedef makes sense so I left it intact. This does not describe at all what type of changes you made, or why you made them, only

[PATCH] staging: ion: Fix checkpatch.pl coding style issues

One warning was left in place that wanted a typedef (ion_user_handle_t) to be removed. I think the typedef makes sense so I left it intact. Signed-off-by: Antti Keränen --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++-- drivers/staging/android/uapi/ion.h