[PATCH] staging: lustre: ldlm: Fix extern variable declaration

From: Imre Deak Move the extern declaration to a header file common to all users of the variable. This fixes the following sparse warning: symbol 'ldlm_cancel_unused_locks_before_replay' was not declared. Should it be static? Signed-off-by: Imre Deak

Re: [PATCH] staging: ion: Align cases with switch

On 09/23/2016 01:40 PM, Christopher Pezley wrote: The preferred indentation for cases and switches has the cases at the same level as the switch. Please remember to tag your patches with v2 when sending the next version to tell them apart (e.g. [PATCHv2]) Acked-by: Laura Abbott

[PATCH] staging: ion: Align cases with switch

The preferred indentation for cases and switches has the cases at the same level as the switch. Signed-off-by: Christopher H. Pezley --- drivers/staging/android/ion/ion_of.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v4] staging: ion: Fix a coding style issue

On 09/23/2016 11:03 AM, Antti Keränen wrote: This patch fixes the alignment of an allocation flag block comment and moves the comments before each #define. Acked-by: Laura Abbott Signed-off-by: Antti Keränen --- In addition to fixing the alignment

Re: [PATCH] vme: fake: mark symbols static where possible

On 23 September 2016 at 14:38, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/vme/bridges/vme_fake.c:384:6: warning: no previous prototype for > 'fake_lm_check' [-Wmissing-prototypes] > drivers/vme/bridges/vme_fake.c:619:6: warning: no

Re: [PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

On 23/09/16 19:20, Vaibhav Agarwal wrote: > On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman > wrote: >> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently, if info is null, the dev_err

Re: [PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman wrote: > On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently, if info is null, the dev_err message is dereferencing an >> uninitialized

[PATCH v4] staging: ion: Fix a coding style issue

This patch fixes the alignment of an allocation flag block comment and moves the comments before each #define. Signed-off-by: Antti Keränen --- In addition to fixing the alignment issue, this version of the patch moves the comments from after the define lines to before the

Re: [PATCH] staging: wlan-ng: avoid to introduce new typedefs

Drop it, please. It seems I wrongly included the original patch too. Sorry for inconvenience. Thanks, Sergio Paracuellos El 2016年09月23日 a las 18:59, Greg KH escribió: On Fri, Sep 23, 2016 at 03:45:18PM +0200, Sergio Paracuellos wrote: This patch fixes the following checkpatch.pl

Re: [PATCH] staging: android: ion: mark symbols static where possible

On 09/23/2016 06:13 AM, Baoyou Xie wrote: We get 4 warnings when building kernel with W=1: drivers/staging/android/ion/ion_carveout_heap.c:36:17: warning: no previous prototype for 'ion_carveout_allocate' [-Wmissing-prototypes] drivers/staging/android/ion/ion_carveout_heap.c:50:6: warning: no

Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible

On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote: > We get 3 warnings when building kernel with W=1: > drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for > 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] > drivers/staging/ks7010/ks7010_sdio.c:120:6:

Re: [PATCH] staging: wlan-ng: avoid to introduce new typedefs

On Fri, Sep 23, 2016 at 03:45:18PM +0200, Sergio Paracuellos wrote: > This patch fixes the following checkpatch.pl warning in p80211types.h: > WARNING: do not add new typedefs > > Signed-off-by: Sergio Paracuellos > --- Was this patch part of this series? It

Re: [PATCH v2] staging: greybus: Fix a commit coding style issue.

On Fri, Sep 23, 2016 at 07:58:13PM +0530, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue found by > checkpatch. > Please wrap your changelog text at 72 columns like git is trying to get you to do... thanks, greg k-h

Re: [PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote: > From: Colin Ian King > > Currently, if info is null, the dev_err message is dereferencing an > uninitialized module pointer. Instead, initialize module before the > dev_err call to fix this issue. > > Found

Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues

On Fri, Sep 23, 2016 at 04:26:28PM +0300, Yannis Damigos wrote: > On Fri, Sep 23, 2016 at 3:17 PM, Greg KH wrote: > > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.dami...@gmail.com wrote: > >> From: Yannis Damigos > >> > >> This patch

Re: Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards

On Fri, Sep 23, 2016 at 04:28:11PM +0200, Marcel Xubuntu wrote: > Mostly code formatting, unapologetically a stepping stone for a potential > refactoring with a knowledge seeking, following complete disclosure, > ultimate goal. > In case this fails, my backup plan is to have the world's record for

Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards

Mostly code formatting, unapologetically a stepping stone for a potential refactoring with a knowledge seeking, following complete disclosure, ultimate goal. In case this fails, my backup plan is to have the world's record for the quickest kernel patch dismissal, either way it's a win. diff

[PATCH v2] staging: greybus: Fix a commit coding style issue.

Fixes a comment coding style warning by adding 2 blank lines. Issue found by checkpatch. Signed-off-by: Sidhant Gupta --- Changes since v1: * Corrected name in `From: ` and `Signed-off-by: ` sections. * Cc-ed mailing list. * Made commit message more clear.

[PATCH 3/8 V2] staging: rts5208: fix comment blocks style in rtsx_chip.h

This patch fixes the following checkpatch.pl warning in rtsx_chip.h: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx_chip.h | 52 +++-- 1 file changed,

[PATCH 7/8 V2] staging: rts5208: fix style warnings in sd.c

This patch fixes the following checkpatch.pl warning in sd.c: WARNING: else is not generally useful after a break or return It also makes code more uniform with the new changes Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/sd.c | 173

[PATCH 2/8 V2] staging: rts5208: avoid symbolic permissions in rtsx.c

This patch fixes the following checkpatch.pl warning in rtsx.c: WARNING: Symbolic permissions are not preferred. Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 8/8 V2] staging: rts5208: fix style warnings in xd.c

This patch fixes the following checkpatch.pl warning in xd.c: WARNING: else is not generally useful after a break or return It also makes code more uniform with the new changes Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/xd.c | 38

[PATCH 4/8 V2] staging: rts5208: fix comment blocks style in rtsx.h

This patch fixes the following checkpatch.pl warning in rtsx.h: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 6/8 V2] staging: rts5208: fix line style warnings in spi.c

This patch fixes the following checkpatch.pl warning in spi.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/spi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/spi.c

[PATCH 5/8 V2] staging: rts5208: remove not used typedef in rtsx_sys.h

This patch fixes the following checkpatch.pl warning in rtsx_sys.h: WARNING: do not add new typedefs Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx_sys.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_sys.h

[PATCH 1/8 V2] staging: rts5208: avoid new typedef in rtsx.h: rtsx_dev_t

This patch fixes the following checkpatch.pl warning in rtsx.h: WARNING: do not add new typedefs It also remove DELAY_PARA_T because code is not using it. Signed-off-by: Sergio Paracuellos --- drivers/staging/rts5208/rtsx.h | 4

[PATCH 0/8 V2] staging: rts5208: Fix several style warnings

This patchset fix several style warnings reported by checkpatch.pl script. Changes V2: * Fix commit subject names to be more specific Sergio Paracuellos (8): staging: rts5208: avoid new typedef in rtsx.h: rtsx_dev_t staging: rts5208: avoid symbolic permissions in rtsx.c staging: rts5208:

Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

I believed I tested it but I found out that the CONFIG_OF_RESERVED_MEM was not enabled in my config. So it was not properly tested. I will try to test it again. Sorry, Yannis On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote: > On Fri, Sep 23, 2016 at 12:50:15PM +0300,

[PATCH 18/20] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_unk1024_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 2 +-

[PATCH 16/20] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr255_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 1 file changed, 2

[PATCH 19/20] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_unk4096_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 4 ++--

[PATCH 20/20] staging: wlan-ng: fix block comments style errors

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 135 +- 1 file changed, 68

[PATCH 10/20] staging: wlan-ng: avoid new typedef: p80211item_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 08/20] staging: wlan-ng: avoid new typedef: p80211pstr32_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr32_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.h | 2 +- drivers/staging/wlan-ng/p80211types.h

[PATCH 17/20] staging: wlan-ng: avoid new typedef: p80211item_unk392_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_unk392_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 4 ++--

[PATCH 13/20] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr6_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 4 ++--

[PATCH 09/20] staging: wlan-ng: avoid new typedef: p80211macarray_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211macarray_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 15/20] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr32_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/cfg80211.c | 4 ++--

[PATCH 14/20] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr14_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 2 +-

[PATCH 12/20] staging: wlan-ng: avoid new typedef: p80211item_uint32_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_uint32_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/cfg80211.c | 8 +-

[PATCH 11/20] staging: wlan-ng: avoid new typedef: p80211itemd_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211itemd_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 3 ++- drivers/staging/wlan-ng/p80211types.h

[PATCH 07/20] staging: wlan-ng: avoid new typedef: p80211pstr14_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr14_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstrd_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 4 ++--

[PATCH 05/20] staging: wlan-ng: avoid new typedef: p80211pstr255_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr255_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 1 file changed, 3 insertions(+),

[PATCH 06/20] staging: wlan-ng: avoid new typedef: p80211pstr6_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr6_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 01/20] staging: wlan-ng: avoid new typedef: p80211enumpair_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211enumpair_t. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 1 file changed, 3

[PATCH 02/20] staging: wlan-ng: avoid new typedef: p80211enum_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211enum_t. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 44 +-- 1

[PATCH] staging: wlan-ng: avoid to introduce new typedefs

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/cfg80211.c | 12 +- drivers/staging/wlan-ng/p80211metastruct.h | 248

[PATCH 03/20] staging: wlan-ng: avoid new typedef: p80211pstr_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 00/20] staging: wlan-ng: fix some style issues in p80211types.h

This patchset fix some style issues reported by checkpatch.pl script. Sergio Paracuellos (20): staging: wlan-ng: avoid new typedef: p80211enumpair_t staging: wlan-ng: avoid new typedef: p80211enum_t staging: wlan-ng: avoid new typedef: p80211pstr_t staging: wlan-ng: avoid new typedef:

[PATCH] vme: fake: mark symbols static where possible

We get 4 warnings when building kernel with W=1: drivers/vme/bridges/vme_fake.c:384:6: warning: no previous prototype for 'fake_lm_check' [-Wmissing-prototypes] drivers/vme/bridges/vme_fake.c:619:6: warning: no previous prototype for 'fake_vmewrite8' [-Wmissing-prototypes]

Re: [PATCH v2 3/6] staging: most: aim-cdev: make syscall write accept buffers of arbitrary size

On Fri, 23 Sep 2016 15:20:33 +0200 Greg KH wrote: > On Fri, Sep 23, 2016 at 02:49:28PM +0200, Christian Gromm wrote: > > On Fri, 23 Sep 2016 14:08:51 +0200 > > Greg KH wrote: > > > > > On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian

[PATCH] staging: rtl8192u: remove unused functions in r8192U_core.c

We get 2 warnings when building kernel with W=1: drivers/staging/rtl8192u/r8192U_core.c:925:12: warning: no previous declaration for 'ieeerate2rtlrate' [-Wmissing-declarations] drivers/staging/rtl8192u/r8192U_core.c:958:12: warning: no previous declaration for 'rtl8192_rate2rate'

[PATCH] staging: rtl8192u: ieee80211: ieee80211_softmac: mark symbols static where possible

We get 5 warnings when building kernel with W=1: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:287:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:323:24: warning: no previous declaration for

Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues

On Fri, Sep 23, 2016 at 3:17 PM, Greg KH wrote: > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.dami...@gmail.com wrote: >> From: Yannis Damigos >> >> This patch fixes the following blank line issues: >> >> CHECK: Please don't use

[PATCH 1/2] Staging: ks7010: mark symbols static where possible

We get 3 warnings when building kernel with W=1: drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request'

[PATCH 2/2] Staging: ks7010: remove unused function in ks_wlan_net.c

We get 1 warning when building kernel with W=1: drivers/staging/ks7010/ks_wlan_net.c:3520:5: warning: no previous prototype for 'ks_wlan_reset' [-Wmissing-prototypes] In fact, these functions are unused in ks_wlan_net.c, but should be removed. So this patch removes the unused function.

[PATCH v2] staging: most: aim-cdev: make syscall write accept buffers of arbitrary size

This patch allows to call the write() function for synchronous and isochronous channels with buffers of any size. The AIM simply waits for data to fill up the MOST buffer object according to the network interface controller specification for streaming channels, before it submits the buffer to the

Re: [PATCH v2 3/6] staging: most: aim-cdev: make syscall write accept buffers of arbitrary size

On Fri, Sep 23, 2016 at 02:49:28PM +0200, Christian Gromm wrote: > On Fri, 23 Sep 2016 14:08:51 +0200 > Greg KH wrote: > > > On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian Gromm wrote: > > > This patch allows to call the write() function for synchronous and > > >

[PATCH] staging: android: ion: mark symbols static where possible

We get 4 warnings when building kernel with W=1: drivers/staging/android/ion/ion_carveout_heap.c:36:17: warning: no previous prototype for 'ion_carveout_allocate' [-Wmissing-prototypes] drivers/staging/android/ion/ion_carveout_heap.c:50:6: warning: no previous prototype for 'ion_carveout_free'

Re: [PATCH v2 3/6] staging: most: aim-cdev: make syscall write accept buffers of arbitrary size

On Fri, 23 Sep 2016 14:08:51 +0200 Greg KH wrote: > On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian Gromm wrote: > > This patch allows to call the write() function for synchronous and > > isochronous channels with buffers of any size. The AIM simply waits > > for

Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote: > This patch removes the empty function rmem_ion_device_release > > Signed-off-by: Yannis Damigos > --- > drivers/staging/android/ion/ion_of.c | 7 --- > 1 file changed, 7 deletions(-) Please just

Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues

On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.dami...@gmail.com wrote: > From: Yannis Damigos > > This patch fixes the following blank line issues: > > CHECK: Please don't use multiple blank lines > + > + What does that mean with the + + lines? > > CHECK:

Re: [PATCHv2 2/5] staging:android:ion: Fix whitespace issues

On Fri, Sep 23, 2016 at 11:05:14AM +0300, giannis.dami...@gmail.com wrote: > From: Yannis Damigos > > This patch fixes the following whitespace issues: > > CHECK: Alignment should match open parenthesis > +int ion_parse_dt_heap_common(struct device_node *heap_node, >

Re: [PATCH] staging: ion: Align cases with switch

On Thu, Sep 22, 2016 at 10:38:13PM +0200, Christopher Pezley wrote: > The preferred indentation for cases and switches has the cases at the same > level as the switch. Please wrap your changelog text at 72 columns like git tried to get you to do :) thanks, greg k-h

Re: [PATCH 01/11 V2] staging: dgnc: remove redundant initialization for channel array

On Fri, Sep 23, 2016 at 10:25:02AM +0900, Daeseok Youn wrote: > The channel array in board_t was initialized in dgnc_found_board() > with NULL. But the channel is going to initialize in dgnc_tty_init() > again. So the channel array doesn't need to set NULL > for initailization in

Re: [PATCH 0/8] staging: rts5208: Fix several style warnings

On Thu, Sep 22, 2016 at 08:18:53PM +0200, Sergio Paracuellos wrote: > This patchset fix several style warnings reported by checkpatch.pl script. > > Sergio Paracuellos (8): > staging: rts5208: fix style warnings in rtsx.h > staging: rts5208: fix style warnings in rtsx.c > staging: rts5208:

Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type

On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote: > Rename CamelCased function getChipType to get_chip_type. > This issue was found by checkpatch.pl As this is a global function, can you rename it to something like "sm750_get_chip_type()"? Having a driver-specific function called

Re: [PATCH v2 3/6] staging: most: aim-cdev: make syscall write accept buffers of arbitrary size

On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian Gromm wrote: > This patch allows to call the write() function for synchronous and > isochronous channels with buffers of any size. The AIM simply waits for > data to fill up the MOST buffer object according to the network interface > controller

Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote: > This patch removes the empty function rmem_ion_device_release > > Signed-off-by: Yannis Damigos > --- > drivers/staging/android/ion/ion_of.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git

Re: [PATCH 1/2 v2] pci-hyperv: properly handle pci bus remove

Hi, You seem to be missing the Reported-by tag. That's xiaof...@redhat.com. Cathy On 09/14/2016 10:10 PM, Long Li wrote: From: Long Li hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device from host (e.g. by disabling SRIOV on a device). In

[PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

From: Colin Ian King Currently, if info is null, the dev_err message is dereferencing an uninitialized module pointer. Instead, initialize module before the dev_err call to fix this issue. Found using static analysis with cppcheck:

[PATCHv3 5/5] staging:android:ion: Remove empty release function

This patch removes the empty function rmem_ion_device_release Signed-off-by: Yannis Damigos --- drivers/staging/android/ion/ion_of.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On Fri, Sep 23, 2016 at 09:33:00PM +1200, Kai Huang wrote: > How is this even possible? The spec clearly says under SEV only in long mode > or PAE mode guest can control whether memory is encrypted via c-bit, and in > other modes guest will be always in encrypted mode. I was suggesting the

Re: [RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

On 23/09/16 06:37, Borislav Petkov wrote: On Thu, Sep 22, 2016 at 08:23:36PM +0200, Paolo Bonzini wrote: Unless this is part of some spec, it's easier if things are the same in SME and SEV. Yeah, I was pondering over how sprinkling sev_active checks might not be so clean. I'm wondering if

Re: [PATCHv2 5/5] staging:android:ion: Fix void function return

On Fri, Sep 23, 2016 at 11:05:17AM +0300, giannis.dami...@gmail.com wrote: > From: Yannis Damigos > > This patch removes the return statement of void function > > WARNING: void function return statements are not generally useful > + return; > +} > >

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 20:01 +0200, Jannik Becher wrote: > changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding > style. Hello. Please always use Greg KH's latest staging-next branch (or -next) to make these sorts of changes.  This one has already been done.

[PATCHv2 2/5] staging:android:ion: Fix whitespace issues

From: Yannis Damigos This patch fixes the following whitespace issues: CHECK: Alignment should match open parenthesis +int ion_parse_dt_heap_common(struct device_node *heap_node, + struct ion_platform_heap *heap, CHECK: Alignment should match

[PATCHv2 3/5] staging:android:ion: Fix blank line issues

From: Yannis Damigos This patch fixes the following blank line issues: CHECK: Please don't use multiple blank lines + + CHECK: Please use a blank line after function/struct/union/enum declarations +} +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup);

[PATCHv2 4/5] staging:android:ion: Fix switch case indentation

From: Yannis Damigos This patch fixes the following switch statement indentation issue: ERROR: switch and case should be at the same indent + switch (heap->type) { + case ION_HEAP_TYPE_CARVEOUT: + case ION_HEAP_TYPE_CHUNK: [...] +

[PATCHv2 5/5] staging:android:ion: Fix void function return

From: Yannis Damigos This patch removes the return statement of void function WARNING: void function return statements are not generally useful + return; +} Signed-off-by: Yannis Damigos --- drivers/staging/android/ion/ion_of.c | 1

[PATCHv2 1/5] staging:android:ion: Fix comparison with NULL

From: Yannis Damigos This patch fixes the following comparison with NULL issues: CHECK: Comparison to NULL could be written "compatible[i].name" + for (i = 0; compatible[i].name != NULL; i++) { CHECK: Comparison to NULL could be written "!compatible[i].name" +

Re: [PATCH] staging: wlan-ng: avoid to introduce new typedefs

On Fri, Sep 23, 2016 at 06:46:55AM +0200, Sergio Paracuellos wrote: > This patch fixes the following checkpatch.pl warning in p80211types.h: > WARNING: do not add new typedefs > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/wlan-ng/cfg80211.c